* [PATCH] dmaengine: dmatest: split struct dmatest_info from variable declaration
@ 2026-05-30 20:03 Rosen Penev
2026-06-08 12:13 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-05-30 20:03 UTC (permalink / raw)
To: dmaengine; +Cc: Vinod Koul, Frank Li, open list
Combining the struct definition with its variable initializer confuses the
kernel-doc parser because __MUTEX_INITIALIZER() expands to contain braces,
breaking brace counting and causing:
Warning: drivers/dma/dmatest.c:152 struct member '' not described in 'dmatest_info'
Split into separate struct definition and variable declaration, which is
the standard kernel pattern.
Assisted-by: Opencode:Big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/dma/dmatest.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index df38681a1ff4..2ae3469397f3 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -137,7 +137,7 @@ struct dmatest_params {
* @did_init: module has been initialized completely
* @last_error: test has faced configuration issues
*/
-static struct dmatest_info {
+struct dmatest_info {
/* Test parameters */
struct dmatest_params params;
@@ -147,7 +147,9 @@ static struct dmatest_info {
int last_error;
struct mutex lock;
bool did_init;
-} test_info = {
+};
+
+static struct dmatest_info test_info = {
.channels = LIST_HEAD_INIT(test_info.channels),
.lock = __MUTEX_INITIALIZER(test_info.lock),
};
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dmaengine: dmatest: split struct dmatest_info from variable declaration
2026-05-30 20:03 [PATCH] dmaengine: dmatest: split struct dmatest_info from variable declaration Rosen Penev
@ 2026-06-08 12:13 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2026-06-08 12:13 UTC (permalink / raw)
To: dmaengine, Rosen Penev; +Cc: Frank Li, linux-kernel
On Sat, 30 May 2026 13:03:22 -0700, Rosen Penev wrote:
> Combining the struct definition with its variable initializer confuses the
> kernel-doc parser because __MUTEX_INITIALIZER() expands to contain braces,
> breaking brace counting and causing:
>
> Warning: drivers/dma/dmatest.c:152 struct member '' not described in 'dmatest_info'
>
> Split into separate struct definition and variable declaration, which is
> the standard kernel pattern.
>
> [...]
Applied, thanks!
[1/1] dmaengine: dmatest: split struct dmatest_info from variable declaration
commit: 87aab0781cb35baa2214d0a95ff01e786e428226
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-08 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-30 20:03 [PATCH] dmaengine: dmatest: split struct dmatest_info from variable declaration Rosen Penev
2026-06-08 12:13 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox