* [PATCHv3] dmaengine: tegra210-adma: use
@ 2026-06-08 4:53 Rosen Penev
2026-06-08 10:30 ` Jon Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-06-08 4:53 UTC (permalink / raw)
To: dmaengine
Cc: Laxman Dewangan, Jon Hunter, Vinod Koul, Frank Li, Thierry Reding,
open list:TEGRA ARCHITECTURE SUPPORT, open list
Simpler to call the proper function.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v3: change subject
v2: reword commit message
drivers/dma/tegra210-adma.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
index 14e0c408ed1e..be2ad6e28618 100644
--- a/drivers/dma/tegra210-adma.c
+++ b/drivers/dma/tegra210-adma.c
@@ -1073,14 +1073,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
}
} else {
/* If no 'page' property found, then reg DT binding would be legacy */
- res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (res_base) {
- tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
- if (IS_ERR(tdma->base_addr))
- return PTR_ERR(tdma->base_addr);
- } else {
- return -ENODEV;
- }
+ tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(tdma->base_addr))
+ return PTR_ERR(tdma->base_addr);
tdma->ch_base_addr = tdma->base_addr + cdata->ch_base_offset;
}
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv3] dmaengine: tegra210-adma: use
2026-06-08 4:53 [PATCHv3] dmaengine: tegra210-adma: use Rosen Penev
@ 2026-06-08 10:30 ` Jon Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Jon Hunter @ 2026-06-08 10:30 UTC (permalink / raw)
To: Rosen Penev, dmaengine
Cc: Laxman Dewangan, Vinod Koul, Frank Li, Thierry Reding,
open list:TEGRA ARCHITECTURE SUPPORT, open list
On 08/06/2026 05:53, Rosen Penev wrote:
> Simpler to call the proper function.
The existing functions are also proper, this is just a simplification.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> v3: change subject
Subject looks incorrect.
> v2: reword commit message
> drivers/dma/tegra210-adma.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index 14e0c408ed1e..be2ad6e28618 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -1073,14 +1073,9 @@ static int tegra_adma_probe(struct platform_device *pdev)
> }
> } else {
> /* If no 'page' property found, then reg DT binding would be legacy */
> - res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (res_base) {
> - tdma->base_addr = devm_ioremap_resource(&pdev->dev, res_base);
> - if (IS_ERR(tdma->base_addr))
> - return PTR_ERR(tdma->base_addr);
> - } else {
> - return -ENODEV;
> - }
> + tdma->base_addr = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(tdma->base_addr))
> + return PTR_ERR(tdma->base_addr);
This no longer applies cleanly on top of Sheetal's change [0] and so
will need to be rebased.
Jon
[0]
https://lore.kernel.org/linux-tegra/20260512092508.1406119-1-sheetal@nvidia.com/
--
nvpublic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-08 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-08 4:53 [PATCHv3] dmaengine: tegra210-adma: use Rosen Penev
2026-06-08 10:30 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox