Re: [PATCH v5 12/14] dmaengine: dw-edma-pcie: Handle optional data blocks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] IRQ vectors allocated by pci_alloc_irq_vectors() are leaked in multiple error paths within dw_edma_pcie_probe().
--

--- Patch [12]: [PATCH v5 12/14] dmaengine: dw-edma-pcie: Handle optional data blocks ---
commit 668bf3e5a48eceeac33c0a1fc5620f41d4cdbd7d
Author: Koichiro Den <den@valinux.co.jp>

dmaengine: dw-edma-pcie: Handle optional data blocks

This commit skips data block BAR mapping and debug output when a channel has
no data block size. This allows future providers to describe channels that
only need descriptor memory exposed, with no functional change intended for
existing devices.

> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index a5d65cc9706c2..8c4d1359a5456 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
[ ... ]
> @@ -497,6 +499,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  							  ll_block);
>  		ll_region->sz = ll_block->sz;
>  
> +		if (!dt_block->sz)
> +			continue;
> +
>  		dt_region->vaddr.io = pcim_iomap_table(pdev)[dt_block->bar];
>  		if (!dt_region->vaddr.io)
>  			return -ENOMEM;

[Severity: High]
This is a pre-existing issue, but does this error path in
dw_edma_pcie_probe() leak IRQ resources?

The probe function successfully allocates vectors via pci_alloc_irq_vectors()
earlier in the execution, but if this dt_region mapping fails, the function
returns -ENOMEM directly without calling pci_free_irq_vectors(). 

Failing to free IRQ resources can exhaust system IRQ capacity and prevent
future allocations. The same pattern appears to exist in the read channel
mapping loop and the final dw_edma_probe() error paths. Should there be a
common error handling label to properly clean up the allocated IRQ vectors?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717050308.2144108-1-den@valinux.co.jp?part=12