* [PATCH v3 01/24] dmaengine: dw-edma: Add dw_edma_core_ll_cur_idx() to get current LL entry index
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:17 ` sashiko-bot
2026-07-27 17:03 ` [PATCH v3 02/24] dmaengine: dw-edma: Add dw_edma_core_ll_clear() to clear LL control-word Koichiro Den
` (22 subsequent siblings)
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
From: Frank Li <Frank.Li@nxp.com>
Add dw_edma_core_ll_cur_idx() to get the current LL entry index and
prepare for dynamic addition of DMA requests while the DMA engine is
running.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Co-developed-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- No changes.
drivers/dma/dw-edma/dw-edma-core.h | 10 ++++++++++
drivers/dma/dw-edma/dw-edma-v0-core.c | 19 +++++++++++++++++++
drivers/dma/dw-edma/dw-hdma-v0-core.c | 19 +++++++++++++++++++
3 files changed, 48 insertions(+)
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index f6a5ad317567..e50fa7965778 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -138,6 +138,7 @@ struct dw_edma_core_ops {
void (*ll_data)(struct dw_edma_chan *chan, struct dw_edma_burst *burst,
u32 idx, bool cb, bool irq);
void (*ll_link)(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr);
+ int (*ll_cur_idx)(struct dw_edma_chan *chan);
void (*ch_doorbell)(struct dw_edma_chan *chan);
void (*ch_enable)(struct dw_edma_chan *chan);
void (*ch_config)(struct dw_edma_chan *chan);
@@ -181,6 +182,15 @@ struct dw_edma_chan *dchan2dw_edma_chan(struct dma_chan *dchan)
return vc2dw_edma_chan(to_virt_chan(dchan));
}
+/*
+ * Return the current LL entry index. A negative value means that the channel
+ * context is not initialized or was lost after a link reset.
+ */
+static inline int dw_edma_core_ll_cur_idx(struct dw_edma_chan *chan)
+{
+ return chan->dw->core->ll_cur_idx(chan);
+}
+
static inline u64 dw_edma_core_get_ll_paddr(struct dw_edma_chan *chan)
{
if (chan->dir == EDMA_DIR_WRITE)
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index abc1bd4c0be2..ba84811234e1 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -616,6 +616,24 @@ static void dw_edma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
FIELD_PREP(EDMA_V0_DOORBELL_CH_MASK, chan->id));
}
+static int dw_edma_v0_core_ll_cur_idx(struct dw_edma_chan *chan)
+{
+ u32 base, val;
+
+ val = GET_CH_32(chan->dw, chan->dir, chan->id, llp.lsb);
+ base = lower_32_bits(dw_edma_core_get_ll_paddr(chan));
+
+ /*
+ * An all-zero pointer means that the channel context is unavailable,
+ * so an LL region starting at DMA address zero is not supported.
+ */
+ if (!val && !GET_CH_32(chan->dw, chan->dir, chan->id, llp.msb))
+ return -EINVAL;
+
+ /* u32 subtraction handles a low-word wrap at a 4 GiB boundary. */
+ return (val - base) / EDMA_LL_SZ;
+}
+
/* eDMA debugfs callbacks */
static void dw_edma_v0_core_debugfs_on(struct dw_edma *dw)
{
@@ -650,6 +668,7 @@ static const struct dw_edma_core_ops dw_edma_v0_core = {
.handle_int = dw_edma_v0_core_handle_int,
.ll_data = dw_edma_v0_core_ll_data,
.ll_link = dw_edma_v0_core_ll_link,
+ .ll_cur_idx = dw_edma_v0_core_ll_cur_idx,
.ch_doorbell = dw_edma_v0_core_ch_doorbell,
.ch_enable = dw_edma_v0_core_ch_enable,
.ch_config = dw_edma_v0_core_ch_config,
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index 36ee72efcd31..2fc7f8e85b43 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -384,6 +384,24 @@ static void dw_hdma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
SET_CH_32(dw, chan->dir, chan->id, doorbell, HDMA_V0_DOORBELL_START);
}
+static int dw_hdma_v0_core_ll_cur_idx(struct dw_edma_chan *chan)
+{
+ u32 base, val;
+
+ val = GET_CH_32(chan->dw, chan->dir, chan->id, llp.lsb);
+ base = lower_32_bits(dw_edma_core_get_ll_paddr(chan));
+
+ /*
+ * An all-zero pointer means that the channel context is unavailable,
+ * so an LL region starting at DMA address zero is not supported.
+ */
+ if (!val && !GET_CH_32(chan->dw, chan->dir, chan->id, llp.msb))
+ return -EINVAL;
+
+ /* u32 subtraction handles a low-word wrap at a 4 GiB boundary. */
+ return (val - base) / EDMA_LL_SZ;
+}
+
/* HDMA debugfs callbacks */
static void dw_hdma_v0_core_debugfs_on(struct dw_edma *dw)
{
@@ -406,6 +424,7 @@ static const struct dw_edma_core_ops dw_hdma_v0_core = {
.non_ll_start = dw_hdma_v0_core_non_ll_start,
.ll_data = dw_hdma_v0_core_ll_data,
.ll_link = dw_hdma_v0_core_ll_link,
+ .ll_cur_idx = dw_hdma_v0_core_ll_cur_idx,
.ch_doorbell = dw_hdma_v0_core_ch_doorbell,
.ch_enable = dw_hdma_v0_core_ch_enable,
.ch_config = dw_hdma_v0_core_ch_config,
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 01/24] dmaengine: dw-edma: Add dw_edma_core_ll_cur_idx() to get current LL entry index
2026-07-27 17:03 ` [PATCH v3 01/24] dmaengine: dw-edma: Add dw_edma_core_ll_cur_idx() to get current LL entry index Koichiro Den
@ 2026-07-27 17:17 ` sashiko-bot
0 siblings, 0 replies; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:17 UTC (permalink / raw)
To: Koichiro Den; +Cc: Frank.Li, dmaengine, vkoul
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Torn read of 64-bit hardware register 'llp' leads to false -EINVAL when the DMA is running.
--
--- Patch [1]: [PATCH v3 01/24] dmaengine: dw-edma: Add dw_edma_core_ll_cur_idx() to get current LL entry index ---
commit 8302239cbe55e73285af81992cde8e677977d567
Author: Frank Li <Frank.Li@nxp.com>
dmaengine: dw-edma: Add dw_edma_core_ll_cur_idx() to get current LL entry index
Add dw_edma_core_ll_cur_idx() to get the current LL entry index. This
prepares the driver for dynamically adding DMA requests while the engine
is running.
> diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
> --- a/drivers/dma/dw-edma/dw-edma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
> @@ -616,6 +616,24 @@ static void dw_edma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
[ ... ]
> +static int dw_edma_v0_core_ll_cur_idx(struct dw_edma_chan *chan)
> +{
> + u32 base, val;
> +
> + val = GET_CH_32(chan->dw, chan->dir, chan->id, llp.lsb);
> + base = lower_32_bits(dw_edma_core_get_ll_paddr(chan));
> +
> + /*
> + * An all-zero pointer means that the channel context is unavailable,
> + * so an LL region starting at DMA address zero is not supported.
> + */
> + if (!val && !GET_CH_32(chan->dw, chan->dir, chan->id, llp.msb))
[Severity: Medium]
Does this conditional read of llp.msb risk a torn read if the DMA engine
is actively running?
If the linked list ring crosses a 4 GiB boundary, a valid descriptor can reside
at a physical address with a zero LSB (e.g., 0x00000001_00000000).
Could the following sequence occur:
CPU reads llp.lsb as 0.
CPU is interrupted.
DMA engine advances the ring to an address below 4 GiB (e.g. 0x00000000_FFFFD000).
CPU resumes and reads llp.msb as 0.
Will this cause the function to falsely evaluate the pointer as all-zeros
and incorrectly return -EINVAL?
> + return -EINVAL;
> +
> + /* u32 subtraction handles a low-word wrap at a 4 GiB boundary. */
> + return (val - base) / EDMA_LL_SZ;
> +}
[ ... ]
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> @@ -384,6 +384,24 @@ static void dw_hdma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
[ ... ]
> +static int dw_hdma_v0_core_ll_cur_idx(struct dw_edma_chan *chan)
> +{
> + u32 base, val;
> +
> + val = GET_CH_32(chan->dw, chan->dir, chan->id, llp.lsb);
> + base = lower_32_bits(dw_edma_core_get_ll_paddr(chan));
> +
> + /*
> + * An all-zero pointer means that the channel context is unavailable,
> + * so an LL region starting at DMA address zero is not supported.
> + */
> + if (!val && !GET_CH_32(chan->dw, chan->dir, chan->id, llp.msb))
[Severity: Medium]
This shares the same logic as dw_edma_v0_core_ll_cur_idx(). Can this also
suffer from the identical torn read scenario described above, leading to a
false -EINVAL?
> + return -EINVAL;
> +
> + /* u32 subtraction handles a low-word wrap at a 4 GiB boundary. */
> + return (val - base) / EDMA_LL_SZ;
> +}
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=1
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 02/24] dmaengine: dw-edma: Add dw_edma_core_ll_clear() to clear LL control-word
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
2026-07-27 17:03 ` [PATCH v3 01/24] dmaengine: dw-edma: Add dw_edma_core_ll_cur_idx() to get current LL entry index Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 03/24] dmaengine: dw-edma: Factor out linked-list transfer start Koichiro Den
` (21 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
Add a core operation for clearing the control word of one linked-list
entry. A later patch uses the operation to invalidate stale CB when
resetting a circular LL ring.
No functional change.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- No changes.
drivers/dma/dw-edma/dw-edma-core.h | 6 ++++++
drivers/dma/dw-edma/dw-edma-v0-core.c | 16 ++++++++++++++++
drivers/dma/dw-edma/dw-hdma-v0-core.c | 16 ++++++++++++++++
3 files changed, 38 insertions(+)
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index e50fa7965778..089f913fd247 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -138,6 +138,7 @@ struct dw_edma_core_ops {
void (*ll_data)(struct dw_edma_chan *chan, struct dw_edma_burst *burst,
u32 idx, bool cb, bool irq);
void (*ll_link)(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr);
+ void (*ll_clear)(struct dw_edma_chan *chan, u32 idx);
int (*ll_cur_idx)(struct dw_edma_chan *chan);
void (*ch_doorbell)(struct dw_edma_chan *chan);
void (*ch_enable)(struct dw_edma_chan *chan);
@@ -255,6 +256,11 @@ dw_edma_core_ll_link(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr)
chan->dw->core->ll_link(chan, idx, cb, addr);
}
+static inline void dw_edma_core_ll_clear(struct dw_edma_chan *chan, u32 idx)
+{
+ chan->dw->core->ll_clear(chan, idx);
+}
+
static inline void dw_edma_core_ch_doorbell(struct dw_edma_chan *chan)
{
chan->dw->core->ch_doorbell(chan);
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index ba84811234e1..c31fff095b4f 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -605,6 +605,21 @@ dw_edma_v0_core_ll_link(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr)
dw_edma_v0_write_ll_link(chan, idx, control, addr);
}
+static void dw_edma_v0_core_ll_clear(struct dw_edma_chan *chan, u32 idx)
+{
+ ptrdiff_t ofs = idx * sizeof(struct dw_edma_v0_lli);
+
+ if (chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL) {
+ struct dw_edma_v0_lli *lli = chan->ll_region.vaddr.mem + ofs;
+
+ lli->control = 0;
+ } else {
+ struct dw_edma_v0_lli __iomem *lli = chan->ll_region.vaddr.io + ofs;
+
+ writel(0, &lli->control);
+ }
+}
+
static void dw_edma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
{
struct dw_edma *dw = chan->dw;
@@ -668,6 +683,7 @@ static const struct dw_edma_core_ops dw_edma_v0_core = {
.handle_int = dw_edma_v0_core_handle_int,
.ll_data = dw_edma_v0_core_ll_data,
.ll_link = dw_edma_v0_core_ll_link,
+ .ll_clear = dw_edma_v0_core_ll_clear,
.ll_cur_idx = dw_edma_v0_core_ll_cur_idx,
.ch_doorbell = dw_edma_v0_core_ch_doorbell,
.ch_enable = dw_edma_v0_core_ch_enable,
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index 2fc7f8e85b43..b2d35f0b7b6d 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -374,6 +374,21 @@ dw_hdma_v0_core_ll_link(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr)
dw_hdma_v0_write_ll_link(chan, idx, control, addr);
}
+static void dw_hdma_v0_core_ll_clear(struct dw_edma_chan *chan, u32 idx)
+{
+ ptrdiff_t ofs = idx * sizeof(struct dw_hdma_v0_lli);
+
+ if (chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL) {
+ struct dw_hdma_v0_lli *lli = chan->ll_region.vaddr.mem + ofs;
+
+ lli->control = 0;
+ } else {
+ struct dw_hdma_v0_lli __iomem *lli = chan->ll_region.vaddr.io + ofs;
+
+ writel(0, &lli->control);
+ }
+}
+
static void dw_hdma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
{
struct dw_edma *dw = chan->dw;
@@ -424,6 +439,7 @@ static const struct dw_edma_core_ops dw_hdma_v0_core = {
.non_ll_start = dw_hdma_v0_core_non_ll_start,
.ll_data = dw_hdma_v0_core_ll_data,
.ll_link = dw_hdma_v0_core_ll_link,
+ .ll_clear = dw_hdma_v0_core_ll_clear,
.ll_cur_idx = dw_hdma_v0_core_ll_cur_idx,
.ch_doorbell = dw_hdma_v0_core_ch_doorbell,
.ch_enable = dw_hdma_v0_core_ch_enable,
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 03/24] dmaengine: dw-edma: Factor out linked-list transfer start
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
2026-07-27 17:03 ` [PATCH v3 01/24] dmaengine: dw-edma: Add dw_edma_core_ll_cur_idx() to get current LL entry index Koichiro Den
2026-07-27 17:03 ` [PATCH v3 02/24] dmaengine: dw-edma: Add dw_edma_core_ll_clear() to clear LL control-word Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 04/24] dmaengine: dw-edma: Make DMA link list work as a circular buffer Koichiro Den
` (20 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
Move linked-list programming into dw_edma_core_ll_start(). It can derive
the first-batch state from desc->start_burst, so dw_edma_core_start() no
longer needs a pass-through argument.
No functional change.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- No changes.
drivers/dma/dw-edma/dw-edma-core.c | 29 +++++++++++++++++++----------
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 1f893dc54c79..6a25a050b89c 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -67,17 +67,11 @@ static void vchan_free_desc(struct virt_dma_desc *vdesc)
kfree(vd2dw_edma_desc(vdesc));
}
-static void dw_edma_core_start(struct dw_edma_desc *desc, bool first)
+static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
{
struct dw_edma_chan *chan = desc->chan;
- size_t i = 0;
-
- if (chan->non_ll) {
- chan->dw->core->non_ll_start(chan, &desc->burst[desc->start_burst]);
- desc->done_burst = desc->start_burst;
- desc->start_burst += 1;
- return;
- }
+ size_t i;
+ bool first = !desc->start_burst;
for (i = 0; i + desc->start_burst < desc->nburst; i++) {
u32 idx = i + desc->start_burst;
@@ -101,6 +95,21 @@ static void dw_edma_core_start(struct dw_edma_desc *desc, bool first)
dw_edma_core_ch_doorbell(chan);
}
+static void dw_edma_core_start(struct dw_edma_desc *desc)
+{
+ struct dw_edma_chan *chan = desc->chan;
+
+ if (chan->non_ll) {
+ chan->dw->core->non_ll_start(chan,
+ &desc->burst[desc->start_burst]);
+ desc->done_burst = desc->start_burst;
+ desc->start_burst += 1;
+ return;
+ }
+
+ dw_edma_core_ll_start(desc);
+}
+
static int dw_edma_start_transfer(struct dw_edma_chan *chan)
{
struct dw_edma_desc *desc;
@@ -114,7 +123,7 @@ static int dw_edma_start_transfer(struct dw_edma_chan *chan)
if (!desc)
return 0;
- dw_edma_core_start(desc, !desc->start_burst);
+ dw_edma_core_start(desc);
desc->cb = !desc->cb;
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 04/24] dmaengine: dw-edma: Make DMA link list work as a circular buffer
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (2 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 03/24] dmaengine: dw-edma: Factor out linked-list transfer start Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:24 ` sashiko-bot
2026-07-27 17:03 ` [PATCH v3 05/24] dmaengine: dw-edma: Move callback result helper before LL helpers Koichiro Den
` (19 subsequent siblings)
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
From: Frank Li <Frank.Li@nxp.com>
The driver currently rebuilds the whole linked list for every transfer.
Use it as a circular ring instead. Append entries at ll_head with the
current cycle bit, and reserve the final entry for the link back to the
start.
Clear control words before first use so stale cycle bits cannot become
valid entries. Reject rings without usable data slots and, until reclaim
support lands, descriptors that exceed the usable ring capacity.
Termination and abort can discard descriptors while ll_done still trails
ll_head. Reset the ring after the channel has stopped so the next transfer
does not inherit occupied slots.
This prepares the driver for appending requests while the engine runs.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Co-developed-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Reset ring state after termination or abort. (Frank, Sashiko)
- Use ll_done as the consumer boundary from the beginning and move the
ring accounting helpers here, so the later progress-reclamation
patch can focus on consuming IRQ-paired progress.
- Calculate free space once per ring-fill pass.
drivers/dma/dw-edma/dw-edma-core.c | 125 +++++++++++++++++++++++------
drivers/dma/dw-edma/dw-edma-core.h | 27 ++++++-
2 files changed, 125 insertions(+), 27 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 6a25a050b89c..d7a8a43b71d6 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -51,13 +51,19 @@ dw_edma_alloc_desc(struct dw_edma_chan *chan, size_t nburst)
{
struct dw_edma_desc *desc;
+ /*
+ * For now, a descriptor that does not fit would stall the channel
+ * forever: reject it up front.
+ */
+ if (!chan->non_ll && nburst > chan->ll_max - 1)
+ return NULL;
+
desc = kzalloc_flex(*desc, burst, nburst, GFP_NOWAIT);
if (unlikely(!desc))
return NULL;
desc->chan = chan;
desc->nburst = nburst;
- desc->cb = true;
return desc;
}
@@ -67,30 +73,75 @@ static void vchan_free_desc(struct virt_dma_desc *vdesc)
kfree(vd2dw_edma_desc(vdesc));
}
+static void dw_edma_core_reset_ll(struct dw_edma_chan *chan)
+{
+ u32 i;
+
+ chan->ll_head = 0;
+ chan->ll_done = 0;
+ /* Drop stale CB bits before reusing the circular LL ring. */
+ for (i = 0; i < chan->ll_max; i++)
+ dw_edma_core_ll_clear(chan, i);
+ chan->cb = true;
+
+ dw_edma_core_ll_link(chan, chan->ll_max, chan->cb,
+ chan->ll_region.paddr);
+
+ dw_edma_core_ch_enable(chan);
+ chan->ll_valid = true;
+}
+
+static u32 dw_edma_core_get_ll_dist(struct dw_edma_chan *chan, u32 from, u32 to)
+{
+ return (to + chan->ll_max - from) % chan->ll_max;
+}
+
+static u32 dw_edma_core_get_used_num(struct dw_edma_chan *chan)
+{
+ return dw_edma_core_get_ll_dist(chan, chan->ll_done, chan->ll_head);
+}
+
+static u32 dw_edma_core_get_free_num(struct dw_edma_chan *chan)
+{
+ /* Keep one data entry free so equal indices mean an empty ring. */
+ return chan->ll_max - 1 - dw_edma_core_get_used_num(chan);
+}
+
+static bool dw_edma_ll_pending(struct dw_edma_chan *chan)
+{
+ return chan->ll_head != chan->ll_done;
+}
+
static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
{
struct dw_edma_chan *chan = desc->chan;
size_t i;
- bool first = !desc->start_burst;
+ u32 free;
+
+ free = dw_edma_core_get_free_num(chan);
+ for (i = desc->start_burst; i < desc->nburst && free; i++, free--) {
+ /*
+ * Refresh the link element before filling the last data slot so
+ * the next lap has the updated CB value.
+ */
+ if (chan->ll_head == chan->ll_max - 1)
+ dw_edma_core_ll_link(chan, chan->ll_max, chan->cb,
+ chan->ll_region.paddr);
- for (i = 0; i + desc->start_burst < desc->nburst; i++) {
- u32 idx = i + desc->start_burst;
+ dw_edma_core_ll_data(chan, &desc->burst[i],
+ chan->ll_head, chan->cb,
+ i == desc->nburst - 1 || free == 1);
- if (i == chan->ll_max)
- break;
+ chan->ll_head++;
- dw_edma_core_ll_data(chan, &desc->burst[idx],
- i, desc->cb,
- idx == desc->nburst - 1 || i == chan->ll_max - 1);
+ if (chan->ll_head == chan->ll_max) {
+ chan->cb = !chan->cb;
+ chan->ll_head = 0;
+ }
}
desc->done_burst = desc->start_burst;
- desc->start_burst += i;
-
- dw_edma_core_ll_link(chan, i, desc->cb, chan->ll_region.paddr);
-
- if (first)
- dw_edma_core_ch_enable(chan);
+ desc->start_burst = i;
dw_edma_core_ch_doorbell(chan);
}
@@ -123,9 +174,10 @@ static int dw_edma_start_transfer(struct dw_edma_chan *chan)
if (!desc)
return 0;
- dw_edma_core_start(desc);
+ if (!chan->non_ll && !chan->ll_valid)
+ dw_edma_core_reset_ll(chan);
- desc->cb = !desc->cb;
+ dw_edma_core_start(desc);
return 1;
}
@@ -159,6 +211,19 @@ static void dw_edma_terminate_all_descs(struct dw_edma_chan *chan)
dw_edma_terminate_vdesc_list(&chan->vc.desc_submitted);
}
+/* Must be called with vc.lock held after the channel has stopped. */
+static void dw_edma_finish_termination(struct dw_edma_chan *chan)
+{
+ dw_edma_terminate_all_descs(chan);
+
+ /* Preserve a clean ring; resync only if entries remain published. */
+ if (!chan->non_ll && dw_edma_ll_pending(chan))
+ dw_edma_core_reset_ll(chan);
+
+ chan->request = EDMA_REQ_NONE;
+ chan->status = EDMA_ST_IDLE;
+}
+
static void dw_edma_device_caps(struct dma_chan *dchan,
struct dma_slave_caps *caps)
{
@@ -299,17 +364,15 @@ static int dw_edma_device_terminate_all(struct dma_chan *dchan)
if (!chan->configured) {
dw_edma_terminate_all_descs(chan);
} else if (chan->status == EDMA_ST_PAUSE) {
- dw_edma_terminate_all_descs(chan);
- chan->status = EDMA_ST_IDLE;
+ dw_edma_finish_termination(chan);
} else if (chan->status == EDMA_ST_IDLE) {
- dw_edma_terminate_all_descs(chan);
+ dw_edma_finish_termination(chan);
} else if (dw_edma_core_ch_status(chan) == DMA_COMPLETE) {
/*
* The channel is in a false BUSY state, probably didn't
* receive or lost an interrupt
*/
- dw_edma_terminate_all_descs(chan);
- chan->status = EDMA_ST_IDLE;
+ dw_edma_finish_termination(chan);
} else if (chan->request > EDMA_REQ_PAUSE) {
err = -EPERM;
} else {
@@ -645,6 +708,8 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
DMA_TRANS_NOERROR);
list_del(&vd->node);
vchan_cookie_complete(vd);
+ if (!chan->non_ll)
+ chan->ll_done = chan->ll_head;
}
if (chan->request == EDMA_REQ_PAUSE) {
@@ -659,9 +724,7 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
break;
case EDMA_REQ_STOP:
- dw_edma_terminate_all_descs(chan);
- chan->request = EDMA_REQ_NONE;
- chan->status = EDMA_ST_IDLE;
+ dw_edma_finish_termination(chan);
break;
default:
@@ -685,6 +748,8 @@ static void dw_edma_abort_interrupt(struct dw_edma_chan *chan)
list_del(&vd->node);
vchan_cookie_complete(vd);
}
+ if (!chan->non_ll)
+ dw_edma_core_reset_ll(chan);
chan->request = EDMA_REQ_NONE;
chan->status = EDMA_ST_IDLE;
spin_unlock_irqrestore(&chan->vc.lock, flags);
@@ -871,6 +936,9 @@ static int dw_edma_alloc_chan_resources(struct dma_chan *dchan)
if (chan->status != EDMA_ST_IDLE)
return -EBUSY;
+ /* The hardware context may have been invalidated while unowned. */
+ chan->ll_valid = false;
+
return 0;
}
@@ -962,6 +1030,13 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u32 wr_alloc, u32 rd_alloc)
else
chan->ll_region = chip->ll_region_rd[chan->id];
+ if (!chip->cfg_non_ll && chan->ll_region.sz < 3 * EDMA_LL_SZ) {
+ dev_err(dev,
+ "channel %s[%u]: LL region has fewer than 2 data entries\n",
+ str_write_read(chan->dir == EDMA_DIR_WRITE),
+ chan->id);
+ return -EINVAL;
+ }
chan->ll_max = chan->ll_region.sz / EDMA_LL_SZ - 1;
dev_vdbg(dev, "L. List:\tChannel %s[%u] max_cnt=%u\n",
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index 089f913fd247..761a5ab4bbb5 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -60,7 +60,6 @@ struct dw_edma_desc {
size_t done_burst;
size_t start_burst;
- u8 cb;
size_t nburst;
struct dw_edma_burst burst[] __counted_by(nburst);
};
@@ -72,8 +71,32 @@ struct dw_edma_chan {
enum dw_edma_dir dir;
u8 func_no;
- u32 ll_max;
+ /*
+ * New LL entries are appended at ll_head. Entries between ll_done
+ * and ll_head, modulo the LL ring, are owned by DMA; the rest are
+ * owned by software.
+ *
+ * software-owned DMA-owned software-owned
+ * +---------------+-------------------+---------------+
+ * ^ ^ ^
+ * 0 ll_done ll_head
+ *
+ * The link entry points back to the region start. ll_head == ll_done
+ * means all entries are software-owned and previous DMA work is
+ * done.
+ *
+ * Software always keeps at least one free entry, so the ring is
+ * never completely DMA-owned. That keeps a hardware-reported physical
+ * LL index unique within the current ll_done..ll_head producer window.
+ */
+ u32 ll_head;
+ u32 ll_done;
+
+ u32 ll_max; /* Data entries */
struct dw_edma_region ll_region; /* Linked list */
+ bool ll_valid; /* LL context programmed */
+
+ bool cb;
struct msi_msg msi;
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 04/24] dmaengine: dw-edma: Make DMA link list work as a circular buffer
2026-07-27 17:03 ` [PATCH v3 04/24] dmaengine: dw-edma: Make DMA link list work as a circular buffer Koichiro Den
@ 2026-07-27 17:24 ` sashiko-bot
0 siblings, 0 replies; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:24 UTC (permalink / raw)
To: Koichiro Den; +Cc: Frank.Li, vkoul, dmaengine
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] DMA_CYCLIC transfers do not loop continuously in hardware and execute only once, failing to implement the cyclic DMA API contract.
--
--- Patch [4]: [PATCH v3 04/24] dmaengine: dw-edma: Make DMA link list work as a circular buffer ---
commit 23381b9c15312609c44ea3df9e57409eb0f1026d
Author: Frank Li <Frank.Li@nxp.com>
dmaengine: dw-edma: Make DMA link list work as a circular buffer
This commit modifies the driver to treat the DMA linked list as a circular
buffer rather than rebuilding it completely for every transfer. It
introduces helpers to manage ring space, resets the ring state upon
termination, and appends entries with alternating cycle bits.
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index 6a25a050b89c4..d7a8a43b71d64 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
> @@ -67,30 +73,75 @@ static void vchan_free_desc(struct virt_dma_desc *vdesc)
[ ... ]
> static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
> {
> struct dw_edma_chan *chan = desc->chan;
> size_t i;
> - bool first = !desc->start_burst;
> + u32 free;
> +
> + free = dw_edma_core_get_free_num(chan);
> + for (i = desc->start_burst; i < desc->nburst && free; i++, free--) {
[Severity: High]
This is a pre-existing issue, but since we are modifying the linked list to
act as a circular buffer, how does the driver handle DMA_CYCLIC transfers?
Looking at dw_edma_core_ll_start(), it programs the hardware ring linearly
for the requested bursts. Because the execution stops deterministically after
processing the appended bursts due to a cycle bit mismatch, won't the DMA
engine halt when it reaches the unwritten ring slots instead of looping
continuously?
Clients using dmaengine_prep_dma_cyclic() for continuous audio or circular
buffering might encounter unexpected halts after executing the requested
number of periods instead of continuous execution.
[ ... ]
> @@ -645,6 +708,8 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
> DMA_TRANS_NOERROR);
> list_del(&vd->node);
> vchan_cookie_complete(vd);
> + if (!chan->non_ll)
> + chan->ll_done = chan->ll_head;
> }
[Severity: High]
This is also a pre-existing issue, but does this interrupt completion path
break the cyclic DMA API contract?
When a client submits a cyclic transfer, the interrupt handler appears to
unconditionally complete and remove the descriptor once all bursts are
submitted.
Calling vchan_cookie_complete() and list_del() here terminates the cyclic
transfer completely, freeing the descriptor and preventing any continuous
hardware looping.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=4
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 05/24] dmaengine: dw-edma: Move callback result helper before LL helpers
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (3 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 04/24] dmaengine: dw-edma: Make DMA link list work as a circular buffer Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request Koichiro Den
` (18 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
From: Frank Li <Frank.Li@nxp.com>
Move dw_hdma_set_callback_result() next to the descriptor helpers so
linked-list completion and reset code can use it without a forward
declaration.
No functional change.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- No changes.
drivers/dma/dw-edma/dw-edma-core.c | 50 +++++++++++++++---------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index d7a8a43b71d6..6e7d1f7c20f9 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -73,6 +73,31 @@ static void vchan_free_desc(struct virt_dma_desc *vdesc)
kfree(vd2dw_edma_desc(vdesc));
}
+static void dw_hdma_set_callback_result(struct virt_dma_desc *vd,
+ enum dmaengine_tx_result result)
+{
+ u32 residue = 0;
+ struct dw_edma_desc *desc;
+ struct dmaengine_result *res;
+
+ if (!vd->tx.callback_result)
+ return;
+
+ desc = vd2dw_edma_desc(vd);
+ if (desc) {
+ residue = desc->alloc_sz;
+
+ if (result == DMA_TRANS_NOERROR)
+ residue -= desc->burst[desc->start_burst - 1].xfer_sz;
+ else if (desc->done_burst)
+ residue -= desc->burst[desc->done_burst - 1].xfer_sz;
+ }
+
+ res = &vd->tx_result;
+ res->result = result;
+ res->residue = residue;
+}
+
static void dw_edma_core_reset_ll(struct dw_edma_chan *chan)
{
u32 i;
@@ -660,31 +685,6 @@ dw_edma_device_prep_interleaved_dma(struct dma_chan *dchan,
return dw_edma_device_transfer(&xfer, dw_edma_device_get_config(dchan, NULL));
}
-static void dw_hdma_set_callback_result(struct virt_dma_desc *vd,
- enum dmaengine_tx_result result)
-{
- u32 residue = 0;
- struct dw_edma_desc *desc;
- struct dmaengine_result *res;
-
- if (!vd->tx.callback_result)
- return;
-
- desc = vd2dw_edma_desc(vd);
- if (desc) {
- residue = desc->alloc_sz;
-
- if (result == DMA_TRANS_NOERROR)
- residue -= desc->burst[desc->start_burst - 1].xfer_sz;
- else if (desc->done_burst)
- residue -= desc->burst[desc->done_burst - 1].xfer_sz;
- }
-
- res = &vd->tx_result;
- res->result = result;
- res->residue = residue;
-}
-
static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
{
struct dw_edma_desc *desc;
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (4 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 05/24] dmaengine: dw-edma: Move callback result helper before LL helpers Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:13 ` sashiko-bot
2026-07-27 19:11 ` Frank Li
2026-07-27 17:03 ` [PATCH v3 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions Koichiro Den
` (17 subsequent siblings)
23 siblings, 2 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
Prepare for LL progress reclamation, which can complete and remove the
last issued descriptor before DONE request handling runs. STOP and PAUSE
still have state to update even when no descriptor remains.
Move the request switch outside the descriptor check, and look up a
descriptor only in the cases that need one. Keep this non-functional
reordering separate from progress accounting.
No functional change.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Explain that this reordering prepares for LL progress reclamation.
(Frank)
drivers/dma/dw-edma/dw-edma-core.c | 56 ++++++++++++++++--------------
1 file changed, 29 insertions(+), 27 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 6e7d1f7c20f9..b419ff2becf9 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -697,39 +697,41 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
return;
}
- vd = vchan_next_desc(&chan->vc);
- if (vd) {
- switch (chan->request) {
- case EDMA_REQ_NONE:
- case EDMA_REQ_PAUSE:
- desc = vd2dw_edma_desc(vd);
- if (desc->start_burst >= desc->nburst) {
- dw_hdma_set_callback_result(vd,
- DMA_TRANS_NOERROR);
- list_del(&vd->node);
- vchan_cookie_complete(vd);
- if (!chan->non_ll)
- chan->ll_done = chan->ll_head;
- }
+ switch (chan->request) {
+ case EDMA_REQ_NONE:
+ case EDMA_REQ_PAUSE:
+ vd = vchan_next_desc(&chan->vc);
+ if (!vd)
+ break;
- if (chan->request == EDMA_REQ_PAUSE) {
- chan->request = EDMA_REQ_NONE;
- chan->status = EDMA_ST_PAUSE;
- break;
- }
+ desc = vd2dw_edma_desc(vd);
+ if (desc->start_burst >= desc->nburst) {
+ dw_hdma_set_callback_result(vd, DMA_TRANS_NOERROR);
+ list_del(&vd->node);
+ vchan_cookie_complete(vd);
+ if (!chan->non_ll)
+ chan->ll_done = chan->ll_head;
+ }
- /* Continue transferring if there are remaining chunks or issued requests.
- */
- chan->status = dw_edma_start_transfer(chan) ? EDMA_ST_BUSY : EDMA_ST_IDLE;
+ if (chan->request == EDMA_REQ_PAUSE) {
+ chan->request = EDMA_REQ_NONE;
+ chan->status = EDMA_ST_PAUSE;
break;
+ }
- case EDMA_REQ_STOP:
- dw_edma_finish_termination(chan);
- break;
+ chan->status = dw_edma_start_transfer(chan) ? EDMA_ST_BUSY : EDMA_ST_IDLE;
+ break;
- default:
+ case EDMA_REQ_STOP:
+ vd = vchan_next_desc(&chan->vc);
+ if (!vd)
break;
- }
+
+ dw_edma_finish_termination(chan);
+ break;
+
+ default:
+ break;
}
spin_unlock_irqrestore(&chan->vc.lock, flags);
}
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request
2026-07-27 17:03 ` [PATCH v3 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request Koichiro Den
@ 2026-07-27 17:13 ` sashiko-bot
2026-07-27 19:11 ` Frank Li
1 sibling, 0 replies; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:13 UTC (permalink / raw)
To: Koichiro Den; +Cc: vkoul, dmaengine, Frank.Li
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] The DMA subsystem is unregistered after the hardware is turned off, interrupts are freed, and the workqueue is destroyed, allowing active clients to access freed or stopped resources.
--
--- Patch [6]: [PATCH v3 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request ---
commit 9cc3e80742a029b2761081307fe945a794ab8be6
Author: Koichiro Den <den@valinux.co.jp>
dmaengine: dw-edma: Dispatch DONE interrupts by channel request
This commit prepares for LL progress reclamation by moving the request
switch outside the descriptor check. It separates this non-functional
reordering from progress accounting, ensuring STOP and PAUSE states
update correctly even when no descriptor remains.
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index 6e7d1f7c20f93..b419ff2becf9e 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
[Severity: High]
This isn't a bug introduced by this patch, but is it possible for a client
to access freed or stopped resources during driver unbind?
Looking at dw_edma_remove(), the DMA subsystem is unregistered after the
hardware is turned off, interrupts are freed, and the workqueue is
destroyed:
drivers/dma/dw-edma/dw-edma-core.c:dw_edma_remove() {
...
if (chip->flags & DW_EDMA_CHIP_PARTIAL)
err = dw_edma_core_quiesce(dw);
else
dw_edma_core_off(dw);
for (i = (dw->nr_irqs - 1); i >= 0; i--)
free_irq(chip->ops->irq_vector(dev, i), &dw->irq[i]);
dw_edma_emul_irq_free(dw);
...
destroy_workqueue(dw->wq);
/* Deregister eDMA device */
dma_async_device_unregister(&dw->dma);
...
}
If a user unbinds the DMA driver via sysfs or a PCI hot-remove occurs,
could a concurrent client attempt to issue a DMA request because the
device is still globally registered with the DMA engine subsystem?
Should dma_async_device_unregister() be called at the beginning of
dw_edma_remove() to prevent new subsystem interactions and avoid a
potential system crash like a PCIe UR fault or use-after-free on the
workqueue?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=6
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [PATCH v3 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request
2026-07-27 17:03 ` [PATCH v3 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request Koichiro Den
2026-07-27 17:13 ` sashiko-bot
@ 2026-07-27 19:11 ` Frank Li
1 sibling, 0 replies; 40+ messages in thread
From: Frank Li @ 2026-07-27 19:11 UTC (permalink / raw)
To: Koichiro Den
Cc: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel, Devendra K Verma, dmaengine, linux-kernel
On Tue, Jul 28, 2026 at 02:03:05AM +0900, Koichiro Den wrote:
> Prepare for LL progress reclamation, which can complete and remove the
> last issued descriptor before DONE request handling runs. STOP and PAUSE
> still have state to update even when no descriptor remains.
>
> Move the request switch outside the descriptor check, and look up a
> descriptor only in the cases that need one. Keep this non-functional
> reordering separate from progress accounting.
>
> No functional change.
>
> Signed-off-by: Koichiro Den <den@valinux.co.jp>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Changes in v3:
> - Explain that this reordering prepares for LL progress reclamation.
> (Frank)
>
> drivers/dma/dw-edma/dw-edma-core.c | 56 ++++++++++++++++--------------
> 1 file changed, 29 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index 6e7d1f7c20f9..b419ff2becf9 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
> @@ -697,39 +697,41 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
> return;
> }
>
> - vd = vchan_next_desc(&chan->vc);
> - if (vd) {
> - switch (chan->request) {
> - case EDMA_REQ_NONE:
> - case EDMA_REQ_PAUSE:
> - desc = vd2dw_edma_desc(vd);
> - if (desc->start_burst >= desc->nburst) {
> - dw_hdma_set_callback_result(vd,
> - DMA_TRANS_NOERROR);
> - list_del(&vd->node);
> - vchan_cookie_complete(vd);
> - if (!chan->non_ll)
> - chan->ll_done = chan->ll_head;
> - }
> + switch (chan->request) {
> + case EDMA_REQ_NONE:
> + case EDMA_REQ_PAUSE:
> + vd = vchan_next_desc(&chan->vc);
> + if (!vd)
> + break;
>
> - if (chan->request == EDMA_REQ_PAUSE) {
> - chan->request = EDMA_REQ_NONE;
> - chan->status = EDMA_ST_PAUSE;
> - break;
> - }
> + desc = vd2dw_edma_desc(vd);
> + if (desc->start_burst >= desc->nburst) {
> + dw_hdma_set_callback_result(vd, DMA_TRANS_NOERROR);
> + list_del(&vd->node);
> + vchan_cookie_complete(vd);
> + if (!chan->non_ll)
> + chan->ll_done = chan->ll_head;
> + }
>
> - /* Continue transferring if there are remaining chunks or issued requests.
> - */
> - chan->status = dw_edma_start_transfer(chan) ? EDMA_ST_BUSY : EDMA_ST_IDLE;
> + if (chan->request == EDMA_REQ_PAUSE) {
> + chan->request = EDMA_REQ_NONE;
> + chan->status = EDMA_ST_PAUSE;
> break;
> + }
>
> - case EDMA_REQ_STOP:
> - dw_edma_finish_termination(chan);
> - break;
> + chan->status = dw_edma_start_transfer(chan) ? EDMA_ST_BUSY : EDMA_ST_IDLE;
> + break;
>
> - default:
> + case EDMA_REQ_STOP:
> + vd = vchan_next_desc(&chan->vc);
> + if (!vd)
> break;
> - }
> +
> + dw_edma_finish_termination(chan);
> + break;
> +
> + default:
> + break;
> }
> spin_unlock_irqrestore(&chan->vc.lock, flags);
> }
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (5 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 06/24] dmaengine: dw-edma: Dispatch DONE interrupts by channel request Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:23 ` sashiko-bot
2026-07-27 17:03 ` [PATCH v3 08/24] dmaengine: dw-edma: Prepare LL progress event handling Koichiro Den
` (16 subsequent siblings)
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
LL fill currently rings the doorbell every time. A running eDMA or HDMA
channel follows entries whose CB matches CCS without another kick. A
channel stopped at a CB mismatch needs one.
Move that decision to dw_edma_core_ch_maybe_doorbell(). It rings only
for a BUSY LL channel with pending entries, no EDMA_REQ_STOP or
EDMA_REQ_PAUSE. The BUSY check prevents EDMA_REQ_STOP completion from
restarting terminated work.
issue_pending() still publishes LL entries only from IDLE. A later patch
allows live appends. Non-LL channels are unchanged.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Keep status gating out of this preparatory change. Add it together with
the stopped-tail recheck. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index b419ff2becf9..c036510dabcb 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -167,8 +167,6 @@ static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
desc->done_burst = desc->start_burst;
desc->start_burst = i;
-
- dw_edma_core_ch_doorbell(chan);
}
static void dw_edma_core_start(struct dw_edma_desc *desc)
@@ -249,6 +247,16 @@ static void dw_edma_finish_termination(struct dw_edma_chan *chan)
chan->status = EDMA_ST_IDLE;
}
+/* Must be called with vc.lock held. */
+static void dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
+{
+ if (chan->non_ll || chan->request != EDMA_REQ_NONE ||
+ chan->status != EDMA_ST_BUSY || !dw_edma_ll_pending(chan))
+ return;
+
+ dw_edma_core_ch_doorbell(chan);
+}
+
static void dw_edma_device_caps(struct dma_chan *dchan,
struct dma_slave_caps *caps)
{
@@ -374,6 +382,7 @@ static int dw_edma_device_resume(struct dma_chan *dchan)
chan->status = EDMA_ST_BUSY;
if (!dw_edma_start_transfer(chan))
chan->status = EDMA_ST_IDLE;
+ dw_edma_core_ch_maybe_doorbell(chan);
}
return err;
@@ -420,6 +429,7 @@ static void dw_edma_device_issue_pending(struct dma_chan *dchan)
chan->status == EDMA_ST_IDLE) {
chan->status = EDMA_ST_BUSY;
dw_edma_start_transfer(chan);
+ dw_edma_core_ch_maybe_doorbell(chan);
}
spin_unlock_irqrestore(&chan->vc.lock, flags);
}
@@ -733,6 +743,8 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
default:
break;
}
+ dw_edma_core_ch_maybe_doorbell(chan);
+
spin_unlock_irqrestore(&chan->vc.lock, flags);
}
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions
2026-07-27 17:03 ` [PATCH v3 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions Koichiro Den
@ 2026-07-27 17:23 ` sashiko-bot
2026-07-27 19:14 ` Frank Li
0 siblings, 1 reply; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:23 UTC (permalink / raw)
To: Koichiro Den; +Cc: vkoul, Frank.Li, dmaengine
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The DONE interrupt handler fails to clear EDMA_REQ_STOP and EDMA_REQ_PAUSE if the descriptor list is empty, contradicting the commit message's stated intent to prepare for LL progress reclamation.
--
--- Patch [7]: [PATCH v3 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions ---
commit ee61354242533ea66a01a91592b3314e404a95eb
Author: Koichiro Den <den@valinux.co.jp>
dmaengine: dw-edma: Centralize LL doorbell decisions
LL fill currently rings the doorbell every time. This patch moves that decision
to dw_edma_core_ch_maybe_doorbell(), which rings only for a BUSY LL channel with
pending entries. This centralization prevents EDMA_REQ_STOP completion from
restarting terminated work.
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index b419ff2becf9e..c036510dabcb3 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
> @@ -733,6 +743,8 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
> default:
> break;
> }
[Severity: Medium]
Will this lead to a permanent channel hang when LL progress reclamation is
introduced?
Looking at dw_edma_done_interrupt() just above this change, the DONE interrupt
handler fails to clear EDMA_REQ_STOP and EDMA_REQ_PAUSE if the descriptor list
is empty:
drivers/dma/dw-edma/dw-edma-core.c:dw_edma_done_interrupt()
case EDMA_REQ_STOP:
vd = vchan_next_desc(&chan->vc);
if (!vd)
break;
dw_edma_finish_termination(chan);
break;
The commit "Dispatch DONE interrupts by channel request" explicitly claims to
restructure the code so that STOP and PAUSE still have state to update even
when no descriptor remains.
However, the implementation adds if (!vd) break; which completely skips the
state updates when no descriptor remains.
If a future patch asynchronously removes the last descriptor before the DONE
interrupt handles an EDMA_REQ_STOP, won't the channel remain permanently
stuck in EDMA_REQ_STOP without completing termination, leading to an infinite
loop in dw_edma_wait_termination?
> + dw_edma_core_ch_maybe_doorbell(chan);
> +
> spin_unlock_irqrestore(&chan->vc.lock, flags);
> }
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=7
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [PATCH v3 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions
2026-07-27 17:23 ` sashiko-bot
@ 2026-07-27 19:14 ` Frank Li
0 siblings, 0 replies; 40+ messages in thread
From: Frank Li @ 2026-07-27 19:14 UTC (permalink / raw)
To: sashiko-reviews; +Cc: Koichiro Den, vkoul, Frank.Li, dmaengine
On Mon, Jul 27, 2026 at 05:23:25PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The DONE interrupt handler fails to clear EDMA_REQ_STOP and EDMA_REQ_PAUSE if the descriptor list is empty, contradicting the commit message's stated intent to prepare for LL progress reclamation.
> --
>
> --- Patch [7]: [PATCH v3 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions ---
> commit ee61354242533ea66a01a91592b3314e404a95eb
> Author: Koichiro Den <den@valinux.co.jp>
>
> dmaengine: dw-edma: Centralize LL doorbell decisions
>
> LL fill currently rings the doorbell every time. This patch moves that decision
> to dw_edma_core_ch_maybe_doorbell(), which rings only for a BUSY LL channel with
> pending entries. This centralization prevents EDMA_REQ_STOP completion from
> restarting terminated work.
>
> > diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> > index b419ff2becf9e..c036510dabcb3 100644
> > --- a/drivers/dma/dw-edma/dw-edma-core.c
> > +++ b/drivers/dma/dw-edma/dw-edma-core.c
>
> [ ... ]
>
> > @@ -733,6 +743,8 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
> > default:
> > break;
> > }
>
> [Severity: Medium]
> Will this lead to a permanent channel hang when LL progress reclamation is
> introduced?
>
> Looking at dw_edma_done_interrupt() just above this change, the DONE interrupt
> handler fails to clear EDMA_REQ_STOP and EDMA_REQ_PAUSE if the descriptor list
> is empty:
>
> drivers/dma/dw-edma/dw-edma-core.c:dw_edma_done_interrupt()
> case EDMA_REQ_STOP:
> vd = vchan_next_desc(&chan->vc);
> if (!vd)
> break;
>
> dw_edma_finish_termination(chan);
> break;
>
> The commit "Dispatch DONE interrupts by channel request" explicitly claims to
> restructure the code so that STOP and PAUSE still have state to update even
> when no descriptor remains.
>
> However, the implementation adds if (!vd) break; which completely skips the
> state updates when no descriptor remains.
>
> If a future patch asynchronously removes the last descriptor before the DONE
> interrupt handles an EDMA_REQ_STOP, won't the channel remain permanently
> stuck in EDMA_REQ_STOP without completing termination, leading to an infinite
> loop in dw_edma_wait_termination?
Is it true?
Frank
>
> > + dw_edma_core_ch_maybe_doorbell(chan);
> > +
> > spin_unlock_irqrestore(&chan->vc.lock, flags);
> > }
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=7
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 08/24] dmaengine: dw-edma: Prepare LL progress event handling
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (6 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 07/24] dmaengine: dw-edma: Centralize LL doorbell decisions Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 19:47 ` Frank Li
2026-07-27 20:09 ` Frank Li
2026-07-27 17:03 ` [PATCH v3 09/24] dmaengine: dw-edma: Prepare deferred IRQ reporting for LL events Koichiro Den
` (15 subsequent siblings)
23 siblings, 2 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
LL event pairing needs to know whether event registers are shared per
channel or per direction. It also needs a provider operation to clear
stale LL interrupt status before a channel restart. Add both.
Centralize runtime request updates in dw_edma_set_request(). A later
patch uses it to cancel a pending LL recheck when STOP or PAUSE changes
the channel policy. Rename the existing workqueue event bits to
distinguish them from provider IRQ events.
No functional change.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- New prep patch split from the event/restart serialization and
stopped-tail recheck changes. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 35 ++++++++++++++++-----------
drivers/dma/dw-edma/dw-edma-core.h | 12 +++++++++
drivers/dma/dw-edma/dw-edma-v0-core.c | 2 ++
drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 ++
4 files changed, 37 insertions(+), 14 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index c036510dabcb..b84aed59bf77 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -30,9 +30,9 @@ struct dw_edma_desc *vd2dw_edma_desc(struct virt_dma_desc *vd)
return container_of(vd, struct dw_edma_desc, vd);
}
-enum dw_edma_irq_event {
- DW_EDMA_IRQ_DONE = BIT(0),
- DW_EDMA_IRQ_ABORT = BIT(1),
+enum dw_edma_deferred_event {
+ DW_EDMA_DEFERRED_DONE = BIT(0),
+ DW_EDMA_DEFERRED_ABORT = BIT(1),
};
static inline
@@ -73,6 +73,13 @@ static void vchan_free_desc(struct virt_dma_desc *vdesc)
kfree(vd2dw_edma_desc(vdesc));
}
+/* Must be called with vc.lock held. */
+static void
+dw_edma_set_request(struct dw_edma_chan *chan, enum dw_edma_request request)
+{
+ chan->request = request;
+}
+
static void dw_hdma_set_callback_result(struct virt_dma_desc *vd,
enum dmaengine_tx_result result)
{
@@ -243,7 +250,7 @@ static void dw_edma_finish_termination(struct dw_edma_chan *chan)
if (!chan->non_ll && dw_edma_ll_pending(chan))
dw_edma_core_reset_ll(chan);
- chan->request = EDMA_REQ_NONE;
+ dw_edma_set_request(chan, EDMA_REQ_NONE);
chan->status = EDMA_ST_IDLE;
}
@@ -360,7 +367,7 @@ static int dw_edma_device_pause(struct dma_chan *dchan)
else if (chan->request != EDMA_REQ_NONE)
err = -EPERM;
else
- chan->request = EDMA_REQ_PAUSE;
+ dw_edma_set_request(chan, EDMA_REQ_PAUSE);
return err;
}
@@ -410,10 +417,10 @@ static int dw_edma_device_terminate_all(struct dma_chan *dchan)
} else if (chan->request > EDMA_REQ_PAUSE) {
err = -EPERM;
} else {
- chan->request = EDMA_REQ_STOP;
+ dw_edma_set_request(chan, EDMA_REQ_STOP);
}
if (chan->status == EDMA_ST_IDLE)
- chan->request = EDMA_REQ_NONE;
+ dw_edma_set_request(chan, EDMA_REQ_NONE);
return err;
}
@@ -724,7 +731,7 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
}
if (chan->request == EDMA_REQ_PAUSE) {
- chan->request = EDMA_REQ_NONE;
+ dw_edma_set_request(chan, EDMA_REQ_NONE);
chan->status = EDMA_ST_PAUSE;
break;
}
@@ -764,7 +771,7 @@ static void dw_edma_abort_interrupt(struct dw_edma_chan *chan)
}
if (!chan->non_ll)
dw_edma_core_reset_ll(chan);
- chan->request = EDMA_REQ_NONE;
+ dw_edma_set_request(chan, EDMA_REQ_NONE);
chan->status = EDMA_ST_IDLE;
spin_unlock_irqrestore(&chan->vc.lock, flags);
}
@@ -778,15 +785,15 @@ static void dw_edma_irq_work(struct work_struct *work)
do {
events = atomic_xchg(&chan->irq_pending, 0);
- if (events & DW_EDMA_IRQ_DONE)
+ if (events & DW_EDMA_DEFERRED_DONE)
dw_edma_done_interrupt(chan);
- if (events & DW_EDMA_IRQ_ABORT)
+ if (events & DW_EDMA_DEFERRED_ABORT)
dw_edma_abort_interrupt(chan);
} while (atomic_read(&chan->irq_pending));
}
static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
- enum dw_edma_irq_event event)
+ enum dw_edma_deferred_event event)
{
atomic_or(event, &chan->irq_pending);
queue_work(chan->dw->wq, &chan->irq_work);
@@ -794,12 +801,12 @@ static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
static void dw_edma_done_interrupt_deferred(struct dw_edma_chan *chan)
{
- dw_edma_queue_irq_work(chan, DW_EDMA_IRQ_DONE);
+ dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_DONE);
}
static void dw_edma_abort_interrupt_deferred(struct dw_edma_chan *chan)
{
- dw_edma_queue_irq_work(chan, DW_EDMA_IRQ_ABORT);
+ dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_ABORT);
}
static void dw_edma_emul_irq_ack(struct irq_data *d)
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index 761a5ab4bbb5..95bd4bf47ea2 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -41,6 +41,11 @@ enum dw_edma_xfer_type {
EDMA_XFER_INTERLEAVED
};
+enum dw_edma_event_scope {
+ DW_EDMA_EVENT_PER_CHAN,
+ DW_EDMA_EVENT_PER_DIR,
+};
+
struct dw_edma_chan;
struct dw_edma_chunk;
@@ -155,6 +160,7 @@ struct dw_edma_core_ops {
int (*ch_quiesce)(struct dw_edma_chan *chan);
u16 (*ch_count)(struct dw_edma *dw, enum dw_edma_dir dir);
enum dma_status (*ch_status)(struct dw_edma_chan *chan);
+ enum dw_edma_event_scope event_scope;
irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
dw_edma_handler_t done, dw_edma_handler_t abort);
void (*non_ll_start)(struct dw_edma_chan *chan, struct dw_edma_burst *child);
@@ -163,6 +169,7 @@ struct dw_edma_core_ops {
void (*ll_link)(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr);
void (*ll_clear)(struct dw_edma_chan *chan, u32 idx);
int (*ll_cur_idx)(struct dw_edma_chan *chan);
+ void (*ll_irq_clear)(struct dw_edma_chan *chan);
void (*ch_doorbell)(struct dw_edma_chan *chan);
void (*ch_enable)(struct dw_edma_chan *chan);
void (*ch_config)(struct dw_edma_chan *chan);
@@ -284,6 +291,11 @@ static inline void dw_edma_core_ll_clear(struct dw_edma_chan *chan, u32 idx)
chan->dw->core->ll_clear(chan, idx);
}
+static inline void dw_edma_core_ll_irq_clear(struct dw_edma_chan *chan)
+{
+ chan->dw->core->ll_irq_clear(chan);
+}
+
static inline void dw_edma_core_ch_doorbell(struct dw_edma_chan *chan)
{
chan->dw->core->ch_doorbell(chan);
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index c31fff095b4f..d497d36f5b28 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -680,11 +680,13 @@ static const struct dw_edma_core_ops dw_edma_v0_core = {
.ch_quiesce = dw_edma_v0_core_ch_quiesce,
.ch_count = dw_edma_v0_core_ch_count,
.ch_status = dw_edma_v0_core_ch_status,
+ .event_scope = DW_EDMA_EVENT_PER_DIR,
.handle_int = dw_edma_v0_core_handle_int,
.ll_data = dw_edma_v0_core_ll_data,
.ll_link = dw_edma_v0_core_ll_link,
.ll_clear = dw_edma_v0_core_ll_clear,
.ll_cur_idx = dw_edma_v0_core_ll_cur_idx,
+ .ll_irq_clear = dw_edma_v0_core_clear_done_int,
.ch_doorbell = dw_edma_v0_core_ch_doorbell,
.ch_enable = dw_edma_v0_core_ch_enable,
.ch_config = dw_edma_v0_core_ch_config,
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index b2d35f0b7b6d..b181603bf2c7 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -435,12 +435,14 @@ static const struct dw_edma_core_ops dw_hdma_v0_core = {
.ch_quiesce = dw_hdma_v0_core_ch_quiesce,
.ch_count = dw_hdma_v0_core_ch_count,
.ch_status = dw_hdma_v0_core_ch_status,
+ .event_scope = DW_EDMA_EVENT_PER_CHAN,
.handle_int = dw_hdma_v0_core_handle_int,
.non_ll_start = dw_hdma_v0_core_non_ll_start,
.ll_data = dw_hdma_v0_core_ll_data,
.ll_link = dw_hdma_v0_core_ll_link,
.ll_clear = dw_hdma_v0_core_ll_clear,
.ll_cur_idx = dw_hdma_v0_core_ll_cur_idx,
+ .ll_irq_clear = dw_hdma_v0_core_clear_done_int,
.ch_doorbell = dw_hdma_v0_core_ch_doorbell,
.ch_enable = dw_hdma_v0_core_ch_enable,
.ch_config = dw_hdma_v0_core_ch_config,
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 08/24] dmaengine: dw-edma: Prepare LL progress event handling
2026-07-27 17:03 ` [PATCH v3 08/24] dmaengine: dw-edma: Prepare LL progress event handling Koichiro Den
@ 2026-07-27 19:47 ` Frank Li
2026-07-27 20:09 ` Frank Li
1 sibling, 0 replies; 40+ messages in thread
From: Frank Li @ 2026-07-27 19:47 UTC (permalink / raw)
To: Koichiro Den
Cc: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel, Devendra K Verma, dmaengine, linux-kernel
On Tue, Jul 28, 2026 at 02:03:07AM +0900, Koichiro Den wrote:
> LL event pairing needs to know whether event registers are shared per
what's means pairing here?
Frank
> channel or per direction. It also needs a provider operation to clear
> stale LL interrupt status before a channel restart. Add both.
>
> Centralize runtime request updates in dw_edma_set_request(). A later
> patch uses it to cancel a pending LL recheck when STOP or PAUSE changes
> the channel policy. Rename the existing workqueue event bits to
> distinguish them from provider IRQ events.
>
> No functional change.
>
> Signed-off-by: Koichiro Den <den@valinux.co.jp>
> ---
> Changes in v3:
> - New prep patch split from the event/restart serialization and
> stopped-tail recheck changes. (Sashiko)
>
> drivers/dma/dw-edma/dw-edma-core.c | 35 ++++++++++++++++-----------
> drivers/dma/dw-edma/dw-edma-core.h | 12 +++++++++
> drivers/dma/dw-edma/dw-edma-v0-core.c | 2 ++
> drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 ++
> 4 files changed, 37 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index c036510dabcb..b84aed59bf77 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
> @@ -30,9 +30,9 @@ struct dw_edma_desc *vd2dw_edma_desc(struct virt_dma_desc *vd)
> return container_of(vd, struct dw_edma_desc, vd);
> }
>
> -enum dw_edma_irq_event {
> - DW_EDMA_IRQ_DONE = BIT(0),
> - DW_EDMA_IRQ_ABORT = BIT(1),
> +enum dw_edma_deferred_event {
> + DW_EDMA_DEFERRED_DONE = BIT(0),
> + DW_EDMA_DEFERRED_ABORT = BIT(1),
> };
>
> static inline
> @@ -73,6 +73,13 @@ static void vchan_free_desc(struct virt_dma_desc *vdesc)
> kfree(vd2dw_edma_desc(vdesc));
> }
>
> +/* Must be called with vc.lock held. */
> +static void
> +dw_edma_set_request(struct dw_edma_chan *chan, enum dw_edma_request request)
> +{
> + chan->request = request;
> +}
> +
> static void dw_hdma_set_callback_result(struct virt_dma_desc *vd,
> enum dmaengine_tx_result result)
> {
> @@ -243,7 +250,7 @@ static void dw_edma_finish_termination(struct dw_edma_chan *chan)
> if (!chan->non_ll && dw_edma_ll_pending(chan))
> dw_edma_core_reset_ll(chan);
>
> - chan->request = EDMA_REQ_NONE;
> + dw_edma_set_request(chan, EDMA_REQ_NONE);
> chan->status = EDMA_ST_IDLE;
> }
>
> @@ -360,7 +367,7 @@ static int dw_edma_device_pause(struct dma_chan *dchan)
> else if (chan->request != EDMA_REQ_NONE)
> err = -EPERM;
> else
> - chan->request = EDMA_REQ_PAUSE;
> + dw_edma_set_request(chan, EDMA_REQ_PAUSE);
>
> return err;
> }
> @@ -410,10 +417,10 @@ static int dw_edma_device_terminate_all(struct dma_chan *dchan)
> } else if (chan->request > EDMA_REQ_PAUSE) {
> err = -EPERM;
> } else {
> - chan->request = EDMA_REQ_STOP;
> + dw_edma_set_request(chan, EDMA_REQ_STOP);
> }
> if (chan->status == EDMA_ST_IDLE)
> - chan->request = EDMA_REQ_NONE;
> + dw_edma_set_request(chan, EDMA_REQ_NONE);
>
> return err;
> }
> @@ -724,7 +731,7 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
> }
>
> if (chan->request == EDMA_REQ_PAUSE) {
> - chan->request = EDMA_REQ_NONE;
> + dw_edma_set_request(chan, EDMA_REQ_NONE);
> chan->status = EDMA_ST_PAUSE;
> break;
> }
> @@ -764,7 +771,7 @@ static void dw_edma_abort_interrupt(struct dw_edma_chan *chan)
> }
> if (!chan->non_ll)
> dw_edma_core_reset_ll(chan);
> - chan->request = EDMA_REQ_NONE;
> + dw_edma_set_request(chan, EDMA_REQ_NONE);
> chan->status = EDMA_ST_IDLE;
> spin_unlock_irqrestore(&chan->vc.lock, flags);
> }
> @@ -778,15 +785,15 @@ static void dw_edma_irq_work(struct work_struct *work)
> do {
> events = atomic_xchg(&chan->irq_pending, 0);
>
> - if (events & DW_EDMA_IRQ_DONE)
> + if (events & DW_EDMA_DEFERRED_DONE)
> dw_edma_done_interrupt(chan);
> - if (events & DW_EDMA_IRQ_ABORT)
> + if (events & DW_EDMA_DEFERRED_ABORT)
> dw_edma_abort_interrupt(chan);
> } while (atomic_read(&chan->irq_pending));
> }
>
> static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
> - enum dw_edma_irq_event event)
> + enum dw_edma_deferred_event event)
> {
> atomic_or(event, &chan->irq_pending);
> queue_work(chan->dw->wq, &chan->irq_work);
> @@ -794,12 +801,12 @@ static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
>
> static void dw_edma_done_interrupt_deferred(struct dw_edma_chan *chan)
> {
> - dw_edma_queue_irq_work(chan, DW_EDMA_IRQ_DONE);
> + dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_DONE);
> }
>
> static void dw_edma_abort_interrupt_deferred(struct dw_edma_chan *chan)
> {
> - dw_edma_queue_irq_work(chan, DW_EDMA_IRQ_ABORT);
> + dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_ABORT);
> }
>
> static void dw_edma_emul_irq_ack(struct irq_data *d)
> diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
> index 761a5ab4bbb5..95bd4bf47ea2 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.h
> +++ b/drivers/dma/dw-edma/dw-edma-core.h
> @@ -41,6 +41,11 @@ enum dw_edma_xfer_type {
> EDMA_XFER_INTERLEAVED
> };
>
> +enum dw_edma_event_scope {
> + DW_EDMA_EVENT_PER_CHAN,
> + DW_EDMA_EVENT_PER_DIR,
> +};
> +
> struct dw_edma_chan;
> struct dw_edma_chunk;
>
> @@ -155,6 +160,7 @@ struct dw_edma_core_ops {
> int (*ch_quiesce)(struct dw_edma_chan *chan);
> u16 (*ch_count)(struct dw_edma *dw, enum dw_edma_dir dir);
> enum dma_status (*ch_status)(struct dw_edma_chan *chan);
> + enum dw_edma_event_scope event_scope;
> irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> dw_edma_handler_t done, dw_edma_handler_t abort);
> void (*non_ll_start)(struct dw_edma_chan *chan, struct dw_edma_burst *child);
> @@ -163,6 +169,7 @@ struct dw_edma_core_ops {
> void (*ll_link)(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr);
> void (*ll_clear)(struct dw_edma_chan *chan, u32 idx);
> int (*ll_cur_idx)(struct dw_edma_chan *chan);
> + void (*ll_irq_clear)(struct dw_edma_chan *chan);
> void (*ch_doorbell)(struct dw_edma_chan *chan);
> void (*ch_enable)(struct dw_edma_chan *chan);
> void (*ch_config)(struct dw_edma_chan *chan);
> @@ -284,6 +291,11 @@ static inline void dw_edma_core_ll_clear(struct dw_edma_chan *chan, u32 idx)
> chan->dw->core->ll_clear(chan, idx);
> }
>
> +static inline void dw_edma_core_ll_irq_clear(struct dw_edma_chan *chan)
> +{
> + chan->dw->core->ll_irq_clear(chan);
> +}
> +
> static inline void dw_edma_core_ch_doorbell(struct dw_edma_chan *chan)
> {
> chan->dw->core->ch_doorbell(chan);
> diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
> index c31fff095b4f..d497d36f5b28 100644
> --- a/drivers/dma/dw-edma/dw-edma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
> @@ -680,11 +680,13 @@ static const struct dw_edma_core_ops dw_edma_v0_core = {
> .ch_quiesce = dw_edma_v0_core_ch_quiesce,
> .ch_count = dw_edma_v0_core_ch_count,
> .ch_status = dw_edma_v0_core_ch_status,
> + .event_scope = DW_EDMA_EVENT_PER_DIR,
> .handle_int = dw_edma_v0_core_handle_int,
> .ll_data = dw_edma_v0_core_ll_data,
> .ll_link = dw_edma_v0_core_ll_link,
> .ll_clear = dw_edma_v0_core_ll_clear,
> .ll_cur_idx = dw_edma_v0_core_ll_cur_idx,
> + .ll_irq_clear = dw_edma_v0_core_clear_done_int,
> .ch_doorbell = dw_edma_v0_core_ch_doorbell,
> .ch_enable = dw_edma_v0_core_ch_enable,
> .ch_config = dw_edma_v0_core_ch_config,
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> index b2d35f0b7b6d..b181603bf2c7 100644
> --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> @@ -435,12 +435,14 @@ static const struct dw_edma_core_ops dw_hdma_v0_core = {
> .ch_quiesce = dw_hdma_v0_core_ch_quiesce,
> .ch_count = dw_hdma_v0_core_ch_count,
> .ch_status = dw_hdma_v0_core_ch_status,
> + .event_scope = DW_EDMA_EVENT_PER_CHAN,
> .handle_int = dw_hdma_v0_core_handle_int,
> .non_ll_start = dw_hdma_v0_core_non_ll_start,
> .ll_data = dw_hdma_v0_core_ll_data,
> .ll_link = dw_hdma_v0_core_ll_link,
> .ll_clear = dw_hdma_v0_core_ll_clear,
> .ll_cur_idx = dw_hdma_v0_core_ll_cur_idx,
> + .ll_irq_clear = dw_hdma_v0_core_clear_done_int,
> .ch_doorbell = dw_hdma_v0_core_ch_doorbell,
> .ch_enable = dw_hdma_v0_core_ch_enable,
> .ch_config = dw_hdma_v0_core_ch_config,
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 40+ messages in thread* Re: [PATCH v3 08/24] dmaengine: dw-edma: Prepare LL progress event handling
2026-07-27 17:03 ` [PATCH v3 08/24] dmaengine: dw-edma: Prepare LL progress event handling Koichiro Den
2026-07-27 19:47 ` Frank Li
@ 2026-07-27 20:09 ` Frank Li
1 sibling, 0 replies; 40+ messages in thread
From: Frank Li @ 2026-07-27 20:09 UTC (permalink / raw)
To: Koichiro Den
Cc: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel, Devendra K Verma, dmaengine, linux-kernel
On Tue, Jul 28, 2026 at 02:03:07AM +0900, Koichiro Den wrote:
> LL event pairing needs to know whether event registers are shared per
> channel or per direction. It also needs a provider operation to clear
> stale LL interrupt status before a channel restart. Add both.
>
> Centralize runtime request updates in dw_edma_set_request(). A later
> patch uses it to cancel a pending LL recheck when STOP or PAUSE changes
> the channel policy. Rename the existing workqueue event bits to
> distinguish them from provider IRQ events.
>
> No functional change.
>
> Signed-off-by: Koichiro Den <den@valinux.co.jp>
> ---
...
>
> +enum dw_edma_event_scope {
> + DW_EDMA_EVENT_PER_CHAN,
> + DW_EDMA_EVENT_PER_DIR,
> +};
> +
not why core need know this information?
Frank
> struct dw_edma_chan;
> struct dw_edma_chunk;
>
> @@ -155,6 +160,7 @@ struct dw_edma_core_ops {
> int (*ch_quiesce)(struct dw_edma_chan *chan);
> u16 (*ch_count)(struct dw_edma *dw, enum dw_edma_dir dir);
> enum dma_status (*ch_status)(struct dw_edma_chan *chan);
> + enum dw_edma_event_scope event_scope;
> irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> dw_edma_handler_t done, dw_edma_handler_t abort);
> void (*non_ll_start)(struct dw_edma_chan *chan, struct dw_edma_burst *child);
> @@ -163,6 +169,7 @@ struct dw_edma_core_ops {
> void (*ll_link)(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr);
> void (*ll_clear)(struct dw_edma_chan *chan, u32 idx);
> int (*ll_cur_idx)(struct dw_edma_chan *chan);
> + void (*ll_irq_clear)(struct dw_edma_chan *chan);
> void (*ch_doorbell)(struct dw_edma_chan *chan);
> void (*ch_enable)(struct dw_edma_chan *chan);
> void (*ch_config)(struct dw_edma_chan *chan);
> @@ -284,6 +291,11 @@ static inline void dw_edma_core_ll_clear(struct dw_edma_chan *chan, u32 idx)
> chan->dw->core->ll_clear(chan, idx);
> }
>
> +static inline void dw_edma_core_ll_irq_clear(struct dw_edma_chan *chan)
> +{
> + chan->dw->core->ll_irq_clear(chan);
> +}
> +
> static inline void dw_edma_core_ch_doorbell(struct dw_edma_chan *chan)
> {
> chan->dw->core->ch_doorbell(chan);
> diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
> index c31fff095b4f..d497d36f5b28 100644
> --- a/drivers/dma/dw-edma/dw-edma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
> @@ -680,11 +680,13 @@ static const struct dw_edma_core_ops dw_edma_v0_core = {
> .ch_quiesce = dw_edma_v0_core_ch_quiesce,
> .ch_count = dw_edma_v0_core_ch_count,
> .ch_status = dw_edma_v0_core_ch_status,
> + .event_scope = DW_EDMA_EVENT_PER_DIR,
> .handle_int = dw_edma_v0_core_handle_int,
> .ll_data = dw_edma_v0_core_ll_data,
> .ll_link = dw_edma_v0_core_ll_link,
> .ll_clear = dw_edma_v0_core_ll_clear,
> .ll_cur_idx = dw_edma_v0_core_ll_cur_idx,
> + .ll_irq_clear = dw_edma_v0_core_clear_done_int,
> .ch_doorbell = dw_edma_v0_core_ch_doorbell,
> .ch_enable = dw_edma_v0_core_ch_enable,
> .ch_config = dw_edma_v0_core_ch_config,
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> index b2d35f0b7b6d..b181603bf2c7 100644
> --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> @@ -435,12 +435,14 @@ static const struct dw_edma_core_ops dw_hdma_v0_core = {
> .ch_quiesce = dw_hdma_v0_core_ch_quiesce,
> .ch_count = dw_hdma_v0_core_ch_count,
> .ch_status = dw_hdma_v0_core_ch_status,
> + .event_scope = DW_EDMA_EVENT_PER_CHAN,
> .handle_int = dw_hdma_v0_core_handle_int,
> .non_ll_start = dw_hdma_v0_core_non_ll_start,
> .ll_data = dw_hdma_v0_core_ll_data,
> .ll_link = dw_hdma_v0_core_ll_link,
> .ll_clear = dw_hdma_v0_core_ll_clear,
> .ll_cur_idx = dw_hdma_v0_core_ll_cur_idx,
> + .ll_irq_clear = dw_hdma_v0_core_clear_done_int,
> .ch_doorbell = dw_hdma_v0_core_ch_doorbell,
> .ch_enable = dw_hdma_v0_core_ch_enable,
> .ch_config = dw_hdma_v0_core_ch_config,
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 09/24] dmaengine: dw-edma: Prepare deferred IRQ reporting for LL events
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (7 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 08/24] dmaengine: dw-edma: Prepare LL progress event handling Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 20:12 ` Frank Li
2026-07-27 17:03 ` [PATCH v3 10/24] dmaengine: dw-edma: Prepare LL kicks for event serialization Koichiro Den
` (14 subsequent siblings)
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
A later change serializes status capture, interrupt clear, and event
recording against channel restart. It must also publish all causes
observed for a channel in that critical section through one callback.
Otherwise, the deferred worker can consume one cause before another from
the same status pass is recorded.
Replace the DONE and ABORT callback pair with one callback carrying an
event bitmap. For now, map the bitmap back to the existing deferred DONE
and ABORT work, so behavior remains unchanged.
Also split DONE handling into a lock-taking wrapper and a vc.lock-held
body. The later LL event path needs to validate its recorded event under
vc.lock before running the existing DONE state machine.
No functional change.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- New prep patch split from the LL event/restart serialization change
to keep its functional diff focused. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 44 ++++++++++++++++-----------
drivers/dma/dw-edma/dw-edma-core.h | 16 +++++++---
drivers/dma/dw-edma/dw-edma-v0-core.c | 6 ++--
drivers/dma/dw-edma/dw-hdma-v0-core.c | 6 ++--
4 files changed, 44 insertions(+), 28 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index b84aed59bf77..bb57f2d39d1c 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -702,17 +702,16 @@ dw_edma_device_prep_interleaved_dma(struct dma_chan *dchan,
return dw_edma_device_transfer(&xfer, dw_edma_device_get_config(dchan, NULL));
}
-static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
+/* Must be called with vc.lock held. */
+static void dw_edma_done_interrupt_locked(struct dw_edma_chan *chan)
{
struct dw_edma_desc *desc;
struct virt_dma_desc *vd;
- unsigned long flags;
- spin_lock_irqsave(&chan->vc.lock, flags);
- if (chan->status == EDMA_ST_PAUSE) {
- spin_unlock_irqrestore(&chan->vc.lock, flags);
+ lockdep_assert_held(&chan->vc.lock);
+
+ if (chan->status == EDMA_ST_PAUSE)
return;
- }
switch (chan->request) {
case EDMA_REQ_NONE:
@@ -751,7 +750,14 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
break;
}
dw_edma_core_ch_maybe_doorbell(chan);
+}
+static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
+{
+ unsigned long flags;
+
+ spin_lock_irqsave(&chan->vc.lock, flags);
+ dw_edma_done_interrupt_locked(chan);
spin_unlock_irqrestore(&chan->vc.lock, flags);
}
@@ -793,20 +799,24 @@ static void dw_edma_irq_work(struct work_struct *work)
}
static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
- enum dw_edma_deferred_event event)
+ unsigned int events)
{
- atomic_or(event, &chan->irq_pending);
+ atomic_or(events, &chan->irq_pending);
queue_work(chan->dw->wq, &chan->irq_work);
}
-static void dw_edma_done_interrupt_deferred(struct dw_edma_chan *chan)
+static void dw_edma_record_irq(struct dw_edma_chan *chan, unsigned int events)
{
- dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_DONE);
-}
+ unsigned int pending = 0;
-static void dw_edma_abort_interrupt_deferred(struct dw_edma_chan *chan)
-{
- dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_ABORT);
+ if (events & (DW_EDMA_IRQ_DONE | DW_EDMA_IRQ_PROGRESS |
+ DW_EDMA_IRQ_STOP))
+ pending |= DW_EDMA_DEFERRED_DONE;
+ if (events & DW_EDMA_IRQ_ABORT)
+ pending |= DW_EDMA_DEFERRED_ABORT;
+
+ if (pending)
+ dw_edma_queue_irq_work(chan, pending);
}
static void dw_edma_emul_irq_ack(struct irq_data *d)
@@ -906,8 +916,7 @@ static inline irqreturn_t dw_edma_interrupt_write_inner(int irq, void *data)
struct dw_edma_irq *dw_irq = data;
return dw_edma_core_handle_int(dw_irq, EDMA_DIR_WRITE,
- dw_edma_done_interrupt_deferred,
- dw_edma_abort_interrupt_deferred);
+ dw_edma_record_irq);
}
static inline irqreturn_t dw_edma_interrupt_read_inner(int irq, void *data)
@@ -915,8 +924,7 @@ static inline irqreturn_t dw_edma_interrupt_read_inner(int irq, void *data)
struct dw_edma_irq *dw_irq = data;
return dw_edma_core_handle_int(dw_irq, EDMA_DIR_READ,
- dw_edma_done_interrupt_deferred,
- dw_edma_abort_interrupt_deferred);
+ dw_edma_record_irq);
}
static inline irqreturn_t dw_edma_interrupt_write(int irq, void *data)
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index 95bd4bf47ea2..6b0d475bb8b5 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -41,6 +41,13 @@ enum dw_edma_xfer_type {
EDMA_XFER_INTERLEAVED
};
+enum dw_edma_irq_event {
+ DW_EDMA_IRQ_DONE = BIT(0),
+ DW_EDMA_IRQ_PROGRESS = BIT(1),
+ DW_EDMA_IRQ_STOP = BIT(2),
+ DW_EDMA_IRQ_ABORT = BIT(3),
+};
+
enum dw_edma_event_scope {
DW_EDMA_EVENT_PER_CHAN,
DW_EDMA_EVENT_PER_DIR,
@@ -152,7 +159,8 @@ struct dw_edma {
const struct dw_edma_core_ops *core;
};
-typedef void (*dw_edma_handler_t)(struct dw_edma_chan *);
+typedef void (*dw_edma_handler_t)(struct dw_edma_chan *chan,
+ unsigned int events);
struct dw_edma_core_ops {
void (*off)(struct dw_edma *dw);
@@ -162,7 +170,7 @@ struct dw_edma_core_ops {
enum dma_status (*ch_status)(struct dw_edma_chan *chan);
enum dw_edma_event_scope event_scope;
irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
- dw_edma_handler_t done, dw_edma_handler_t abort);
+ dw_edma_handler_t handler);
void (*non_ll_start)(struct dw_edma_chan *chan, struct dw_edma_burst *child);
void (*ll_data)(struct dw_edma_chan *chan, struct dw_edma_burst *burst,
u32 idx, bool cb, bool irq);
@@ -262,9 +270,9 @@ enum dma_status dw_edma_core_ch_status(struct dw_edma_chan *chan)
static inline irqreturn_t
dw_edma_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
- dw_edma_handler_t done, dw_edma_handler_t abort)
+ dw_edma_handler_t handler)
{
- return dw_irq->dw->core->handle_int(dw_irq, dir, done, abort);
+ return dw_irq->dw->core->handle_int(dw_irq, dir, handler);
}
static inline
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index d497d36f5b28..d883ca446f5a 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -336,7 +336,7 @@ static void dw_edma_v0_core_clear_abort_int(struct dw_edma_chan *chan)
static irqreturn_t
dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
- dw_edma_handler_t done, dw_edma_handler_t abort)
+ dw_edma_handler_t handler)
{
struct dw_edma *dw = dw_irq->dw;
unsigned long total, pos, val;
@@ -375,7 +375,7 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
continue;
dw_edma_v0_core_clear_done_int(chan);
- done(chan);
+ handler(chan, DW_EDMA_IRQ_DONE);
ret = IRQ_HANDLED;
}
@@ -389,7 +389,7 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
continue;
dw_edma_v0_core_clear_abort_int(chan);
- abort(chan);
+ handler(chan, DW_EDMA_IRQ_ABORT);
ret = IRQ_HANDLED;
}
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index b181603bf2c7..afc2f24fecd3 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -174,7 +174,7 @@ static u32 dw_hdma_v0_core_status_int(struct dw_edma_chan *chan)
static irqreturn_t
dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
- dw_edma_handler_t done, dw_edma_handler_t abort)
+ dw_edma_handler_t handler)
{
struct dw_edma *dw = dw_irq->dw;
unsigned long total, pos, val;
@@ -200,14 +200,14 @@ dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
val = dw_hdma_v0_core_status_int(chan);
if (FIELD_GET(HDMA_V0_STOP_INT_MASK, val)) {
dw_hdma_v0_core_clear_done_int(chan);
- done(chan);
+ handler(chan, DW_EDMA_IRQ_STOP);
ret = IRQ_HANDLED;
}
if (FIELD_GET(HDMA_V0_ABORT_INT_MASK, val)) {
dw_hdma_v0_core_clear_abort_int(chan);
- abort(chan);
+ handler(chan, DW_EDMA_IRQ_ABORT);
ret = IRQ_HANDLED;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 09/24] dmaengine: dw-edma: Prepare deferred IRQ reporting for LL events
2026-07-27 17:03 ` [PATCH v3 09/24] dmaengine: dw-edma: Prepare deferred IRQ reporting for LL events Koichiro Den
@ 2026-07-27 20:12 ` Frank Li
0 siblings, 0 replies; 40+ messages in thread
From: Frank Li @ 2026-07-27 20:12 UTC (permalink / raw)
To: Koichiro Den
Cc: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel, Devendra K Verma, dmaengine, linux-kernel
On Tue, Jul 28, 2026 at 02:03:08AM +0900, Koichiro Den wrote:
> A later change serializes status capture, interrupt clear, and event
> recording against channel restart. It must also publish all causes
> observed for a channel in that critical section through one callback.
> Otherwise, the deferred worker can consume one cause before another from
> the same status pass is recorded.
>
> Replace the DONE and ABORT callback pair with one callback carrying an
> event bitmap. For now, map the bitmap back to the existing deferred DONE
> and ABORT work, so behavior remains unchanged.
>
> Also split DONE handling into a lock-taking wrapper and a vc.lock-held
> body. The later LL event path needs to validate its recorded event under
> vc.lock before running the existing DONE state machine.
>
> No functional change.
>
> Signed-off-by: Koichiro Den <den@valinux.co.jp>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Changes in v3:
> - New prep patch split from the LL event/restart serialization change
> to keep its functional diff focused. (Sashiko)
>
> drivers/dma/dw-edma/dw-edma-core.c | 44 ++++++++++++++++-----------
> drivers/dma/dw-edma/dw-edma-core.h | 16 +++++++---
> drivers/dma/dw-edma/dw-edma-v0-core.c | 6 ++--
> drivers/dma/dw-edma/dw-hdma-v0-core.c | 6 ++--
> 4 files changed, 44 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index b84aed59bf77..bb57f2d39d1c 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
> @@ -702,17 +702,16 @@ dw_edma_device_prep_interleaved_dma(struct dma_chan *dchan,
> return dw_edma_device_transfer(&xfer, dw_edma_device_get_config(dchan, NULL));
> }
>
> -static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
> +/* Must be called with vc.lock held. */
> +static void dw_edma_done_interrupt_locked(struct dw_edma_chan *chan)
> {
> struct dw_edma_desc *desc;
> struct virt_dma_desc *vd;
> - unsigned long flags;
>
> - spin_lock_irqsave(&chan->vc.lock, flags);
> - if (chan->status == EDMA_ST_PAUSE) {
> - spin_unlock_irqrestore(&chan->vc.lock, flags);
> + lockdep_assert_held(&chan->vc.lock);
> +
> + if (chan->status == EDMA_ST_PAUSE)
> return;
> - }
>
> switch (chan->request) {
> case EDMA_REQ_NONE:
> @@ -751,7 +750,14 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
> break;
> }
> dw_edma_core_ch_maybe_doorbell(chan);
> +}
>
> +static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
> +{
> + unsigned long flags;
> +
> + spin_lock_irqsave(&chan->vc.lock, flags);
> + dw_edma_done_interrupt_locked(chan);
> spin_unlock_irqrestore(&chan->vc.lock, flags);
> }
>
> @@ -793,20 +799,24 @@ static void dw_edma_irq_work(struct work_struct *work)
> }
>
> static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
> - enum dw_edma_deferred_event event)
> + unsigned int events)
> {
> - atomic_or(event, &chan->irq_pending);
> + atomic_or(events, &chan->irq_pending);
> queue_work(chan->dw->wq, &chan->irq_work);
> }
>
> -static void dw_edma_done_interrupt_deferred(struct dw_edma_chan *chan)
> +static void dw_edma_record_irq(struct dw_edma_chan *chan, unsigned int events)
> {
> - dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_DONE);
> -}
> + unsigned int pending = 0;
>
> -static void dw_edma_abort_interrupt_deferred(struct dw_edma_chan *chan)
> -{
> - dw_edma_queue_irq_work(chan, DW_EDMA_DEFERRED_ABORT);
> + if (events & (DW_EDMA_IRQ_DONE | DW_EDMA_IRQ_PROGRESS |
> + DW_EDMA_IRQ_STOP))
> + pending |= DW_EDMA_DEFERRED_DONE;
> + if (events & DW_EDMA_IRQ_ABORT)
> + pending |= DW_EDMA_DEFERRED_ABORT;
> +
> + if (pending)
> + dw_edma_queue_irq_work(chan, pending);
> }
>
> static void dw_edma_emul_irq_ack(struct irq_data *d)
> @@ -906,8 +916,7 @@ static inline irqreturn_t dw_edma_interrupt_write_inner(int irq, void *data)
> struct dw_edma_irq *dw_irq = data;
>
> return dw_edma_core_handle_int(dw_irq, EDMA_DIR_WRITE,
> - dw_edma_done_interrupt_deferred,
> - dw_edma_abort_interrupt_deferred);
> + dw_edma_record_irq);
> }
>
> static inline irqreturn_t dw_edma_interrupt_read_inner(int irq, void *data)
> @@ -915,8 +924,7 @@ static inline irqreturn_t dw_edma_interrupt_read_inner(int irq, void *data)
> struct dw_edma_irq *dw_irq = data;
>
> return dw_edma_core_handle_int(dw_irq, EDMA_DIR_READ,
> - dw_edma_done_interrupt_deferred,
> - dw_edma_abort_interrupt_deferred);
> + dw_edma_record_irq);
> }
>
> static inline irqreturn_t dw_edma_interrupt_write(int irq, void *data)
> diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
> index 95bd4bf47ea2..6b0d475bb8b5 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.h
> +++ b/drivers/dma/dw-edma/dw-edma-core.h
> @@ -41,6 +41,13 @@ enum dw_edma_xfer_type {
> EDMA_XFER_INTERLEAVED
> };
>
> +enum dw_edma_irq_event {
> + DW_EDMA_IRQ_DONE = BIT(0),
> + DW_EDMA_IRQ_PROGRESS = BIT(1),
> + DW_EDMA_IRQ_STOP = BIT(2),
> + DW_EDMA_IRQ_ABORT = BIT(3),
> +};
> +
> enum dw_edma_event_scope {
> DW_EDMA_EVENT_PER_CHAN,
> DW_EDMA_EVENT_PER_DIR,
> @@ -152,7 +159,8 @@ struct dw_edma {
> const struct dw_edma_core_ops *core;
> };
>
> -typedef void (*dw_edma_handler_t)(struct dw_edma_chan *);
> +typedef void (*dw_edma_handler_t)(struct dw_edma_chan *chan,
> + unsigned int events);
>
> struct dw_edma_core_ops {
> void (*off)(struct dw_edma *dw);
> @@ -162,7 +170,7 @@ struct dw_edma_core_ops {
> enum dma_status (*ch_status)(struct dw_edma_chan *chan);
> enum dw_edma_event_scope event_scope;
> irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> - dw_edma_handler_t done, dw_edma_handler_t abort);
> + dw_edma_handler_t handler);
> void (*non_ll_start)(struct dw_edma_chan *chan, struct dw_edma_burst *child);
> void (*ll_data)(struct dw_edma_chan *chan, struct dw_edma_burst *burst,
> u32 idx, bool cb, bool irq);
> @@ -262,9 +270,9 @@ enum dma_status dw_edma_core_ch_status(struct dw_edma_chan *chan)
>
> static inline irqreturn_t
> dw_edma_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> - dw_edma_handler_t done, dw_edma_handler_t abort)
> + dw_edma_handler_t handler)
> {
> - return dw_irq->dw->core->handle_int(dw_irq, dir, done, abort);
> + return dw_irq->dw->core->handle_int(dw_irq, dir, handler);
> }
>
> static inline
> diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
> index d497d36f5b28..d883ca446f5a 100644
> --- a/drivers/dma/dw-edma/dw-edma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
> @@ -336,7 +336,7 @@ static void dw_edma_v0_core_clear_abort_int(struct dw_edma_chan *chan)
>
> static irqreturn_t
> dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> - dw_edma_handler_t done, dw_edma_handler_t abort)
> + dw_edma_handler_t handler)
> {
> struct dw_edma *dw = dw_irq->dw;
> unsigned long total, pos, val;
> @@ -375,7 +375,7 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> continue;
>
> dw_edma_v0_core_clear_done_int(chan);
> - done(chan);
> + handler(chan, DW_EDMA_IRQ_DONE);
>
> ret = IRQ_HANDLED;
> }
> @@ -389,7 +389,7 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> continue;
>
> dw_edma_v0_core_clear_abort_int(chan);
> - abort(chan);
> + handler(chan, DW_EDMA_IRQ_ABORT);
>
> ret = IRQ_HANDLED;
> }
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> index b181603bf2c7..afc2f24fecd3 100644
> --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
> @@ -174,7 +174,7 @@ static u32 dw_hdma_v0_core_status_int(struct dw_edma_chan *chan)
>
> static irqreturn_t
> dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> - dw_edma_handler_t done, dw_edma_handler_t abort)
> + dw_edma_handler_t handler)
> {
> struct dw_edma *dw = dw_irq->dw;
> unsigned long total, pos, val;
> @@ -200,14 +200,14 @@ dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
> val = dw_hdma_v0_core_status_int(chan);
> if (FIELD_GET(HDMA_V0_STOP_INT_MASK, val)) {
> dw_hdma_v0_core_clear_done_int(chan);
> - done(chan);
> + handler(chan, DW_EDMA_IRQ_STOP);
>
> ret = IRQ_HANDLED;
> }
>
> if (FIELD_GET(HDMA_V0_ABORT_INT_MASK, val)) {
> dw_hdma_v0_core_clear_abort_int(chan);
> - abort(chan);
> + handler(chan, DW_EDMA_IRQ_ABORT);
>
> ret = IRQ_HANDLED;
> }
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 10/24] dmaengine: dw-edma: Prepare LL kicks for event serialization
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (8 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 09/24] dmaengine: dw-edma: Prepare deferred IRQ reporting for LL events Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 11/24] dmaengine: dw-edma: Serialize LL event capture with channel kicks Koichiro Den
` (13 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
Both eDMA and HDMA perform the same remote LL read-back immediately
before writing the doorbell register.
A later patch serializes each LL doorbell write against IRQ event
capture with a raw spinlock. Keeping the read-back in the provider
callback would hold that lock across a remote read. Move the common
read-back into a core kick helper, where it can run before the
serialized section, and leave dw_edma_core_ch_maybe_doorbell() to decide
whether a kick is needed.
No functional change.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- New prep patch split from "Centralize LL doorbell decisions" to keep
that policy change focused and the remote LL read-back outside the
event lock added later. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 20 +++++++++++++++++++-
drivers/dma/dw-edma/dw-edma-v0-core.c | 16 ----------------
drivers/dma/dw-edma/dw-hdma-v0-core.c | 16 ----------------
3 files changed, 19 insertions(+), 33 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index bb57f2d39d1c..e3d0559206d8 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -13,6 +13,7 @@
#include <linux/dmaengine.h>
#include <linux/err.h>
#include <linux/interrupt.h>
+#include <linux/io.h>
#include <linux/irq.h>
#include <linux/dma/edma.h>
#include <linux/dma-mapping.h>
@@ -254,6 +255,23 @@ static void dw_edma_finish_termination(struct dw_edma_chan *chan)
chan->status = EDMA_ST_IDLE;
}
+static void dw_edma_core_ll_sync(struct dw_edma_chan *chan)
+{
+ /*
+ * Remote controller registers and LL memory may be reached through
+ * different paths. Complete posted LL writes before the doorbell.
+ */
+ if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL))
+ readl(chan->ll_region.vaddr.io);
+}
+
+/* Must be called with vc.lock held for an LL channel. */
+static void dw_edma_core_ch_kick(struct dw_edma_chan *chan)
+{
+ dw_edma_core_ll_sync(chan);
+ dw_edma_core_ch_doorbell(chan);
+}
+
/* Must be called with vc.lock held. */
static void dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
{
@@ -261,7 +279,7 @@ static void dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
chan->status != EDMA_ST_BUSY || !dw_edma_ll_pending(chan))
return;
- dw_edma_core_ch_doorbell(chan);
+ dw_edma_core_ch_kick(chan);
}
static void dw_edma_device_caps(struct dma_chan *dchan,
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index d883ca446f5a..b3098eb83442 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -480,20 +480,6 @@ static void dw_edma_v0_core_ch_enable(struct dw_edma_chan *chan)
upper_32_bits(chan->ll_region.paddr));
}
-static void dw_edma_v0_sync_ll_data(struct dw_edma_chan *chan)
-{
- /*
- * In case of remote eDMA engine setup, the DW PCIe RP/EP internal
- * configuration registers and application memory are normally accessed
- * over different buses. Ensure LL-data reaches the memory before the
- * doorbell register is toggled by issuing the dummy-read from the remote
- * LL memory in a hope that the MRd TLP will return only after the
- * last MWr TLP is completed
- */
- if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL))
- readl(chan->ll_region.vaddr.io);
-}
-
static void dw_edma_v0_core_ch_config(struct dw_edma_chan *chan)
{
struct dw_edma *dw = chan->dw;
@@ -624,8 +610,6 @@ static void dw_edma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
{
struct dw_edma *dw = chan->dw;
- dw_edma_v0_sync_ll_data(chan);
-
/* Doorbell */
SET_RW_32(dw, chan->dir, doorbell,
FIELD_PREP(EDMA_V0_DOORBELL_CH_MASK, chan->id));
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index afc2f24fecd3..64a07fbc5be3 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -282,20 +282,6 @@ static void dw_hdma_v0_core_ch_enable(struct dw_edma_chan *chan)
HDMA_V0_CONSUMER_CYCLE_STAT | HDMA_V0_CONSUMER_CYCLE_BIT);
}
-static void dw_hdma_v0_sync_ll_data(struct dw_edma_chan *chan)
-{
- /*
- * In case of remote HDMA engine setup, the DW PCIe RP/EP internal
- * configuration registers and application memory are normally accessed
- * over different buses. Ensure LL-data reaches the memory before the
- * doorbell register is toggled by issuing the dummy-read from the remote
- * LL memory in a hope that the MRd TLP will return only after the
- * last MWr TLP is completed
- */
- if (!(chan->dw->chip->flags & DW_EDMA_CHIP_LOCAL))
- readl(chan->ll_region.vaddr.io);
-}
-
static void dw_hdma_v0_core_non_ll_start(struct dw_edma_chan *chan,
struct dw_edma_burst *child)
{
@@ -393,8 +379,6 @@ static void dw_hdma_v0_core_ch_doorbell(struct dw_edma_chan *chan)
{
struct dw_edma *dw = chan->dw;
- dw_hdma_v0_sync_ll_data(chan);
-
/* Doorbell */
SET_CH_32(dw, chan->dir, chan->id, doorbell, HDMA_V0_DOORBELL_START);
}
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 11/24] dmaengine: dw-edma: Serialize LL event capture with channel kicks
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (9 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 10/24] dmaengine: dw-edma: Prepare LL kicks for event serialization Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 12/24] dmaengine: dw-edma: Keep channels stopped while ABORT is pending Koichiro Den
` (12 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
The hard IRQ path clears interrupt status before deferred handling takes
vc.lock. If a doorbell starts a new hardware run in between, the
deferred handler can apply an event from the previous run.
Use the event lock to serialize the interrupt status read and clear,
snapshot recording, and LL doorbell writes. Do not write another
doorbell while a snapshot is pending. A ring reset discards the snapshot
under the same lock. When events coalesce, keep STOP over PROGRESS.
Changing chan->request alone neither changes the ring nor writes a
doorbell, so it does not invalidate the snapshot. Preserve it across
request changes. A later patch uses PROGRESS and STOP to decide whether
a pending STOP or PAUSE request can finish.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- New patch to serialize IRQ event capture with LL doorbell writes and
defer doorbells while an LL event is pending. (Sashiko)
- Add explicit PROGRESS and STOP types for deferred LL snapshots.
(Frank)
drivers/dma/dw-edma/dw-edma-core.c | 101 +++++++++++++++++++++++++-
drivers/dma/dw-edma/dw-edma-core.h | 37 ++++++++++
drivers/dma/dw-edma/dw-edma-v0-core.c | 64 ++++++++--------
drivers/dma/dw-edma/dw-hdma-v0-core.c | 32 +++++---
4 files changed, 187 insertions(+), 47 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index e3d0559206d8..3970b066dca2 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -33,7 +33,8 @@ struct dw_edma_desc *vd2dw_edma_desc(struct virt_dma_desc *vd)
enum dw_edma_deferred_event {
DW_EDMA_DEFERRED_DONE = BIT(0),
- DW_EDMA_DEFERRED_ABORT = BIT(1),
+ DW_EDMA_DEFERRED_LL = BIT(1),
+ DW_EDMA_DEFERRED_ABORT = BIT(2),
};
static inline
@@ -74,6 +75,52 @@ static void vchan_free_desc(struct virt_dma_desc *vdesc)
kfree(vd2dw_edma_desc(vdesc));
}
+static void dw_edma_ll_snapshot_discard_locked(struct dw_edma_chan *chan)
+{
+ lockdep_assert_held(dw_edma_event_lock(chan));
+
+ chan->ll_irq.event = DW_EDMA_LL_EVENT_NONE;
+}
+
+static void dw_edma_ll_snapshot_discard(struct dw_edma_chan *chan)
+{
+ guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
+
+ dw_edma_ll_snapshot_discard_locked(chan);
+}
+
+/* Must be called with vc.lock held. */
+static bool
+dw_edma_ll_snapshot_take(struct dw_edma_chan *chan,
+ struct dw_edma_ll_snapshot *snapshot)
+{
+ guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
+
+ if (chan->ll_irq.event == DW_EDMA_LL_EVENT_NONE)
+ return false;
+
+ *snapshot = chan->ll_irq;
+ dw_edma_ll_snapshot_discard_locked(chan);
+
+ return true;
+}
+
+static void dw_edma_ll_event_discard_locked(struct dw_edma_chan *chan)
+{
+ lockdep_assert_held(dw_edma_event_lock(chan));
+
+ dw_edma_core_ll_irq_clear(chan);
+ dw_edma_ll_snapshot_discard_locked(chan);
+}
+
+/* Must be called with vc.lock held for an LL channel. */
+static void dw_edma_ll_event_discard(struct dw_edma_chan *chan)
+{
+ guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
+
+ dw_edma_ll_event_discard_locked(chan);
+}
+
/* Must be called with vc.lock held. */
static void
dw_edma_set_request(struct dw_edma_chan *chan, enum dw_edma_request request)
@@ -120,6 +167,7 @@ static void dw_edma_core_reset_ll(struct dw_edma_chan *chan)
dw_edma_core_ll_link(chan, chan->ll_max, chan->cb,
chan->ll_region.paddr);
+ dw_edma_ll_event_discard(chan);
dw_edma_core_ch_enable(chan);
chan->ll_valid = true;
}
@@ -269,6 +317,17 @@ static void dw_edma_core_ll_sync(struct dw_edma_chan *chan)
static void dw_edma_core_ch_kick(struct dw_edma_chan *chan)
{
dw_edma_core_ll_sync(chan);
+
+ guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
+
+ /*
+ * A recorded event belongs to the current ring and must be consumed
+ * before starting another hardware run.
+ */
+ if (chan->ll_irq.event != DW_EDMA_LL_EVENT_NONE)
+ return;
+
+ dw_edma_ll_event_discard_locked(chan);
dw_edma_core_ch_doorbell(chan);
}
@@ -779,6 +838,18 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
spin_unlock_irqrestore(&chan->vc.lock, flags);
}
+static void dw_edma_ll_interrupt(struct dw_edma_chan *chan)
+{
+ struct dw_edma_ll_snapshot snapshot;
+
+ guard(spinlock_irqsave)(&chan->vc.lock);
+
+ if (!dw_edma_ll_snapshot_take(chan, &snapshot))
+ return;
+
+ dw_edma_done_interrupt_locked(chan);
+}
+
static void dw_edma_abort_interrupt(struct dw_edma_chan *chan)
{
struct virt_dma_desc *vd;
@@ -811,6 +882,8 @@ static void dw_edma_irq_work(struct work_struct *work)
if (events & DW_EDMA_DEFERRED_DONE)
dw_edma_done_interrupt(chan);
+ if (events & DW_EDMA_DEFERRED_LL)
+ dw_edma_ll_interrupt(chan);
if (events & DW_EDMA_DEFERRED_ABORT)
dw_edma_abort_interrupt(chan);
} while (atomic_read(&chan->irq_pending));
@@ -825,14 +898,29 @@ static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
static void dw_edma_record_irq(struct dw_edma_chan *chan, unsigned int events)
{
+ struct dw_edma_ll_snapshot snapshot = {
+ .event = events & DW_EDMA_IRQ_STOP ?
+ DW_EDMA_LL_EVENT_STOP : DW_EDMA_LL_EVENT_PROGRESS,
+ };
unsigned int pending = 0;
- if (events & (DW_EDMA_IRQ_DONE | DW_EDMA_IRQ_PROGRESS |
- DW_EDMA_IRQ_STOP))
- pending |= DW_EDMA_DEFERRED_DONE;
+ lockdep_assert_held(dw_edma_event_lock(chan));
+
if (events & DW_EDMA_IRQ_ABORT)
pending |= DW_EDMA_DEFERRED_ABORT;
+ if (chan->non_ll) {
+ if (events & (DW_EDMA_IRQ_DONE | DW_EDMA_IRQ_STOP))
+ pending |= DW_EDMA_DEFERRED_DONE;
+ } else if (events & (DW_EDMA_IRQ_DONE | DW_EDMA_IRQ_PROGRESS |
+ DW_EDMA_IRQ_STOP)) {
+ /* STOP is final for this run; do not replace it with progress. */
+ if (chan->ll_irq.event != DW_EDMA_LL_EVENT_STOP ||
+ snapshot.event == DW_EDMA_LL_EVENT_STOP)
+ chan->ll_irq = snapshot;
+ pending |= DW_EDMA_DEFERRED_LL;
+ }
+
if (pending)
dw_edma_queue_irq_work(chan, pending);
}
@@ -1020,6 +1108,7 @@ static void dw_edma_device_synchronize(struct dma_chan *dchan)
dw_edma_wait_termination(dchan);
cancel_work_sync(&chan->irq_work);
atomic_set(&chan->irq_pending, 0);
+ dw_edma_ll_snapshot_discard(chan);
vchan_synchronize(&chan->vc);
}
@@ -1071,6 +1160,8 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u32 wr_alloc, u32 rd_alloc)
chan->irq_mode = dw_edma_get_default_irq_mode(chan);
INIT_WORK(&chan->irq_work, dw_edma_irq_work);
atomic_set(&chan->irq_pending, 0);
+ chan->ll_irq.event = DW_EDMA_LL_EVENT_NONE;
+ raw_spin_lock_init(&chan->event_lock);
if (chan->dir == EDMA_DIR_WRITE)
chan->ll_region = chip->ll_region_wr[chan->id];
@@ -1307,6 +1398,8 @@ int dw_edma_probe(struct dw_edma_chip *chip)
}
raw_spin_lock_init(&dw->lock);
+ for (i = 0; i < ARRAY_SIZE(dw->event_lock); i++)
+ raw_spin_lock_init(&dw->event_lock[i]);
/*
* chip->ll_*_cnt describes the channels exposed by this instance. Keep
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index 6b0d475bb8b5..9f528f160cea 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -48,6 +48,12 @@ enum dw_edma_irq_event {
DW_EDMA_IRQ_ABORT = BIT(3),
};
+enum dw_edma_ll_event {
+ DW_EDMA_LL_EVENT_NONE,
+ DW_EDMA_LL_EVENT_PROGRESS,
+ DW_EDMA_LL_EVENT_STOP,
+};
+
enum dw_edma_event_scope {
DW_EDMA_EVENT_PER_CHAN,
DW_EDMA_EVENT_PER_DIR,
@@ -76,6 +82,10 @@ struct dw_edma_desc {
struct dw_edma_burst burst[] __counted_by(nburst);
};
+struct dw_edma_ll_snapshot {
+ enum dw_edma_ll_event event;
+};
+
struct dw_edma_chan {
struct virt_dma_chan vc;
struct dw_edma *dw;
@@ -104,6 +114,14 @@ struct dw_edma_chan {
u32 ll_head;
u32 ll_done;
+ /*
+ * LL event recorded by the hard IRQ handler. The event scope lock
+ * serializes its capture with a new hardware run; vc.lock serializes
+ * its consumption with LL state.
+ */
+ struct dw_edma_ll_snapshot ll_irq;
+ raw_spinlock_t event_lock;
+
u32 ll_max; /* Data entries */
struct dw_edma_region ll_region; /* Linked list */
bool ll_valid; /* LL context programmed */
@@ -153,6 +171,7 @@ struct dw_edma {
struct workqueue_struct *wq;
raw_spinlock_t lock; /* Protect v0 shared registers */
+ raw_spinlock_t event_lock[2]; /* Per-direction event scopes */
struct dw_edma_chip *chip;
@@ -177,7 +196,9 @@ struct dw_edma_core_ops {
void (*ll_link)(struct dw_edma_chan *chan, u32 idx, bool cb, u64 addr);
void (*ll_clear)(struct dw_edma_chan *chan, u32 idx);
int (*ll_cur_idx)(struct dw_edma_chan *chan);
+ /* Called with the event scope locked. */
void (*ll_irq_clear)(struct dw_edma_chan *chan);
+ /* Called with the event scope locked for an LL channel. */
void (*ch_doorbell)(struct dw_edma_chan *chan);
void (*ch_enable)(struct dw_edma_chan *chan);
void (*ch_config)(struct dw_edma_chan *chan);
@@ -221,6 +242,22 @@ struct dw_edma_chan *dchan2dw_edma_chan(struct dma_chan *dchan)
return vc2dw_edma_chan(to_virt_chan(dchan));
}
+/*
+ * Lock ordering:
+ *
+ * chan->vc.lock -> dw_edma_event_lock(chan)
+ *
+ * Interrupt providers invoke the dw_edma_handler_t callback with the event
+ * lock held. The callback must not take vc.lock.
+ */
+static inline raw_spinlock_t *dw_edma_event_lock(struct dw_edma_chan *chan)
+{
+ if (chan->dw->core->event_scope == DW_EDMA_EVENT_PER_DIR)
+ return &chan->dw->event_lock[chan->dir];
+
+ return &chan->event_lock;
+}
+
/*
* Return the current LL entry index. A negative value means that the channel
* context is not initialized or was lost after a link reset.
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index b3098eb83442..43e33a400a3e 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -339,8 +339,8 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
dw_edma_handler_t handler)
{
struct dw_edma *dw = dw_irq->dw;
- unsigned long total, pos, val;
- irqreturn_t ret = IRQ_NONE;
+ u8 events[EDMA_V0_MAX_NR_CH] = {};
+ unsigned long total, pos, val, active = 0;
struct dw_edma_chan *chan;
unsigned long off;
unsigned long *mask;
@@ -356,45 +356,45 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
mask = dw_irq->rd_mask;
}
- /*
- * DONE and ABORT status share one register, and on remote setups
- * every read is a non-posted round trip across the PCIe link. Take
- * one snapshot and derive both views from it. An abort raised
- * after the snapshot is deferred, not lost: only bits observed in
- * the snapshot are ever cleared below, so its status remains set and
- * triggers another handler pass.
- */
- sts = GET_RW_32(dw, dir, int_status);
-
- val = FIELD_GET(EDMA_V0_DONE_INT_MASK, sts);
- val &= *mask;
- for_each_set_bit(pos, &val, total) {
- chan = &dw->chan[pos + off];
+ scoped_guard(raw_spinlock_irqsave, &dw->event_lock[dir]) {
+ /*
+ * DONE and ABORT status share one register, and on remote setups
+ * every read is a non-posted round trip across the PCIe link. Take
+ * one snapshot and derive both views from it.
+ */
+ sts = GET_RW_32(dw, dir, int_status);
- if (unlikely(dw_edma_core_ch_ignore_irq(chan)))
- continue;
+ val = FIELD_GET(EDMA_V0_DONE_INT_MASK, sts);
+ val &= *mask;
+ for_each_set_bit(pos, &val, total) {
+ chan = &dw->chan[pos + off];
- dw_edma_v0_core_clear_done_int(chan);
- handler(chan, DW_EDMA_IRQ_DONE);
+ if (unlikely(dw_edma_core_ch_ignore_irq(chan)))
+ continue;
- ret = IRQ_HANDLED;
- }
+ events[pos] |= DW_EDMA_IRQ_DONE;
+ active |= BIT(pos);
+ dw_edma_v0_core_clear_done_int(chan);
+ }
- val = FIELD_GET(EDMA_V0_ABORT_INT_MASK, sts);
- val &= *mask;
- for_each_set_bit(pos, &val, total) {
- chan = &dw->chan[pos + off];
+ val = FIELD_GET(EDMA_V0_ABORT_INT_MASK, sts);
+ val &= *mask;
+ for_each_set_bit(pos, &val, total) {
+ chan = &dw->chan[pos + off];
- if (unlikely(dw_edma_core_ch_ignore_irq(chan)))
- continue;
+ if (unlikely(dw_edma_core_ch_ignore_irq(chan)))
+ continue;
- dw_edma_v0_core_clear_abort_int(chan);
- handler(chan, DW_EDMA_IRQ_ABORT);
+ events[pos] |= DW_EDMA_IRQ_ABORT;
+ active |= BIT(pos);
+ dw_edma_v0_core_clear_abort_int(chan);
+ }
- ret = IRQ_HANDLED;
+ for_each_set_bit(pos, &active, total)
+ handler(&dw->chan[pos + off], events[pos]);
}
- return ret;
+ return active ? IRQ_HANDLED : IRQ_NONE;
}
static void dw_edma_v0_write_ll_data(struct dw_edma_chan *chan, int i,
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index 64a07fbc5be3..bbf9ee0392f8 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -177,10 +177,12 @@ dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
dw_edma_handler_t handler)
{
struct dw_edma *dw = dw_irq->dw;
- unsigned long total, pos, val;
+ unsigned int events;
+ unsigned long total, pos;
irqreturn_t ret = IRQ_NONE;
struct dw_edma_chan *chan;
unsigned long off, *mask;
+ u32 val;
if (dir == EDMA_DIR_WRITE) {
total = dw->wr_ch_cnt;
@@ -197,20 +199,28 @@ dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
if (unlikely(dw_edma_core_ch_ignore_irq(chan)))
continue;
- val = dw_hdma_v0_core_status_int(chan);
- if (FIELD_GET(HDMA_V0_STOP_INT_MASK, val)) {
- dw_hdma_v0_core_clear_done_int(chan);
- handler(chan, DW_EDMA_IRQ_STOP);
+ events = 0;
+ scoped_guard(raw_spinlock_irqsave, dw_edma_event_lock(chan)) {
+ val = dw_hdma_v0_core_status_int(chan);
- ret = IRQ_HANDLED;
- }
+ if (FIELD_GET(HDMA_V0_STOP_INT_MASK, val)) {
+ events |= DW_EDMA_IRQ_STOP;
+ dw_hdma_v0_core_clear_done_int(chan);
+ }
- if (FIELD_GET(HDMA_V0_ABORT_INT_MASK, val)) {
- dw_hdma_v0_core_clear_abort_int(chan);
- handler(chan, DW_EDMA_IRQ_ABORT);
+ if (FIELD_GET(HDMA_V0_ABORT_INT_MASK, val)) {
+ events |= DW_EDMA_IRQ_ABORT;
+ dw_hdma_v0_core_clear_abort_int(chan);
+ }
- ret = IRQ_HANDLED;
+ if (events)
+ handler(chan, events);
}
+
+ if (!events)
+ continue;
+
+ ret = IRQ_HANDLED;
}
return ret;
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 12/24] dmaengine: dw-edma: Keep channels stopped while ABORT is pending
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (10 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 11/24] dmaengine: dw-edma: Serialize LL event capture with channel kicks Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:19 ` sashiko-bot
2026-07-27 17:03 ` [PATCH v3 13/24] dmaengine: dw-edma: Reclaim issued descriptors from IRQ-paired LL progress Koichiro Den
` (11 subsequent siblings)
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
The hard IRQ path clears the ABORT interrupt status before deferred
handling. Keep the event pending until the worker has handled it;
otherwise a new start can race ahead after the status has been cleared.
Set abort_pending before clearing the status. Before a non-LL start or
LL doorbell, check both the pending flag and hardware status while
holding the event lock. This covers the case where the start path gets
the lock before the IRQ handler has latched the event.
Handle ABORT before coalesced DONE or LL work. Also block LL progress
consumers while ABORT is pending; tx_status() can otherwise complete a
descriptor before the ABORT worker runs. ABORT cleanup makes that
progress stale by completing or terminating descriptors and, for an LL
channel, resetting the ring. Clear abort_pending only after cleanup.
If termination sees a pending ABORT, leave EDMA_REQ_STOP set until the
ABORT worker finishes. This prevents dw_edma_device_synchronize() from
discarding the event before cleanup.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- New patch to latch ABORT before clearing its interrupt status, block
channel restart and LL progress consumers while it is pending, and
keep termination pending until deferred cleanup completes. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 82 ++++++++++++++++++++++++---
drivers/dma/dw-edma/dw-edma-core.h | 17 ++++++
drivers/dma/dw-edma/dw-edma-v0-core.c | 9 +++
drivers/dma/dw-edma/dw-hdma-v0-core.c | 8 +++
4 files changed, 107 insertions(+), 9 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 3970b066dca2..5bf08ff0fe46 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -82,11 +82,30 @@ static void dw_edma_ll_snapshot_discard_locked(struct dw_edma_chan *chan)
chan->ll_irq.event = DW_EDMA_LL_EVENT_NONE;
}
-static void dw_edma_ll_snapshot_discard(struct dw_edma_chan *chan)
+static void dw_edma_irq_events_discard(struct dw_edma_chan *chan)
{
guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
dw_edma_ll_snapshot_discard_locked(chan);
+ chan->abort_pending = false;
+}
+
+static bool dw_edma_abort_latch_locked(struct dw_edma_chan *chan)
+{
+ lockdep_assert_held(dw_edma_event_lock(chan));
+
+ if (!chan->abort_pending &&
+ dw_edma_core_ch_abort_int_pending(chan))
+ dw_edma_abort_event_mark(chan);
+
+ return chan->abort_pending;
+}
+
+static bool dw_edma_abort_is_pending(struct dw_edma_chan *chan)
+{
+ guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
+
+ return chan->abort_pending;
}
/* Must be called with vc.lock held. */
@@ -99,12 +118,23 @@ dw_edma_ll_snapshot_take(struct dw_edma_chan *chan,
if (chan->ll_irq.event == DW_EDMA_LL_EVENT_NONE)
return false;
+ if (dw_edma_abort_latch_locked(chan))
+ return false;
+
*snapshot = chan->ll_irq;
dw_edma_ll_snapshot_discard_locked(chan);
return true;
}
+/* Must be called with vc.lock held. */
+static void dw_edma_abort_event_clear(struct dw_edma_chan *chan)
+{
+ guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
+
+ chan->abort_pending = false;
+}
+
static void dw_edma_ll_event_discard_locked(struct dw_edma_chan *chan)
{
lockdep_assert_held(dw_edma_event_lock(chan));
@@ -253,7 +283,20 @@ static int dw_edma_start_transfer(struct dw_edma_chan *chan)
if (!desc)
return 0;
- if (!chan->non_ll && !chan->ll_valid)
+ if (chan->non_ll) {
+ guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
+
+ if (dw_edma_abort_latch_locked(chan))
+ return 0;
+
+ dw_edma_core_start(desc);
+ return 1;
+ }
+
+ if (dw_edma_abort_is_pending(chan))
+ return 0;
+
+ if (!chan->ll_valid)
dw_edma_core_reset_ll(chan);
dw_edma_core_start(desc);
@@ -293,6 +336,11 @@ static void dw_edma_terminate_all_descs(struct dw_edma_chan *chan)
/* Must be called with vc.lock held after the channel has stopped. */
static void dw_edma_finish_termination(struct dw_edma_chan *chan)
{
+ if (dw_edma_abort_is_pending(chan)) {
+ dw_edma_set_request(chan, EDMA_REQ_STOP);
+ return;
+ }
+
dw_edma_terminate_all_descs(chan);
/* Preserve a clean ring; resync only if entries remain published. */
@@ -320,6 +368,9 @@ static void dw_edma_core_ch_kick(struct dw_edma_chan *chan)
guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
+ if (dw_edma_abort_latch_locked(chan))
+ return;
+
/*
* A recorded event belongs to the current ring and must be consumed
* before starting another hardware run.
@@ -496,7 +547,8 @@ static int dw_edma_device_terminate_all(struct dma_chan *dchan)
} else {
dw_edma_set_request(chan, EDMA_REQ_STOP);
}
- if (chan->status == EDMA_ST_IDLE)
+ if (chan->status == EDMA_ST_IDLE &&
+ !dw_edma_abort_is_pending(chan))
dw_edma_set_request(chan, EDMA_REQ_NONE);
return err;
@@ -850,14 +902,19 @@ static void dw_edma_ll_interrupt(struct dw_edma_chan *chan)
dw_edma_done_interrupt_locked(chan);
}
-static void dw_edma_abort_interrupt(struct dw_edma_chan *chan)
+static bool dw_edma_abort_interrupt(struct dw_edma_chan *chan)
{
struct virt_dma_desc *vd;
unsigned long flags;
spin_lock_irqsave(&chan->vc.lock, flags);
+ if (!dw_edma_abort_is_pending(chan)) {
+ spin_unlock_irqrestore(&chan->vc.lock, flags);
+ return false;
+ }
+
vd = vchan_next_desc(&chan->vc);
- if (vd && chan->request == EDMA_REQ_STOP) {
+ if (chan->request == EDMA_REQ_STOP) {
dw_edma_terminate_all_descs(chan);
} else if (vd) {
dw_hdma_set_callback_result(vd, DMA_TRANS_ABORTED);
@@ -868,7 +925,11 @@ static void dw_edma_abort_interrupt(struct dw_edma_chan *chan)
dw_edma_core_reset_ll(chan);
dw_edma_set_request(chan, EDMA_REQ_NONE);
chan->status = EDMA_ST_IDLE;
+ dw_edma_abort_event_clear(chan);
+
spin_unlock_irqrestore(&chan->vc.lock, flags);
+
+ return true;
}
static void dw_edma_irq_work(struct work_struct *work)
@@ -880,12 +941,14 @@ static void dw_edma_irq_work(struct work_struct *work)
do {
events = atomic_xchg(&chan->irq_pending, 0);
+ /* ABORT cleanup makes coalesced DONE and LL work stale. */
+ if ((events & DW_EDMA_DEFERRED_ABORT) &&
+ dw_edma_abort_interrupt(chan))
+ continue;
if (events & DW_EDMA_DEFERRED_DONE)
dw_edma_done_interrupt(chan);
if (events & DW_EDMA_DEFERRED_LL)
dw_edma_ll_interrupt(chan);
- if (events & DW_EDMA_DEFERRED_ABORT)
- dw_edma_abort_interrupt(chan);
} while (atomic_read(&chan->irq_pending));
}
@@ -906,7 +969,7 @@ static void dw_edma_record_irq(struct dw_edma_chan *chan, unsigned int events)
lockdep_assert_held(dw_edma_event_lock(chan));
- if (events & DW_EDMA_IRQ_ABORT)
+ if ((events & DW_EDMA_IRQ_ABORT) && chan->abort_pending)
pending |= DW_EDMA_DEFERRED_ABORT;
if (chan->non_ll) {
@@ -1108,7 +1171,7 @@ static void dw_edma_device_synchronize(struct dma_chan *dchan)
dw_edma_wait_termination(dchan);
cancel_work_sync(&chan->irq_work);
atomic_set(&chan->irq_pending, 0);
- dw_edma_ll_snapshot_discard(chan);
+ dw_edma_irq_events_discard(chan);
vchan_synchronize(&chan->vc);
}
@@ -1161,6 +1224,7 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u32 wr_alloc, u32 rd_alloc)
INIT_WORK(&chan->irq_work, dw_edma_irq_work);
atomic_set(&chan->irq_pending, 0);
chan->ll_irq.event = DW_EDMA_LL_EVENT_NONE;
+ chan->abort_pending = false;
raw_spin_lock_init(&chan->event_lock);
if (chan->dir == EDMA_DIR_WRITE)
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index 9f528f160cea..2bfbd1b25703 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -120,6 +120,8 @@ struct dw_edma_chan {
* its consumption with LL state.
*/
struct dw_edma_ll_snapshot ll_irq;
+ /* ABORT is terminal and remains pending across LL state changes. */
+ bool abort_pending;
raw_spinlock_t event_lock;
u32 ll_max; /* Data entries */
@@ -187,6 +189,8 @@ struct dw_edma_core_ops {
int (*ch_quiesce)(struct dw_edma_chan *chan);
u16 (*ch_count)(struct dw_edma *dw, enum dw_edma_dir dir);
enum dma_status (*ch_status)(struct dw_edma_chan *chan);
+ /* Called with the event scope locked. */
+ bool (*ch_abort_int_pending)(struct dw_edma_chan *chan);
enum dw_edma_event_scope event_scope;
irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
dw_edma_handler_t handler);
@@ -258,6 +262,13 @@ static inline raw_spinlock_t *dw_edma_event_lock(struct dw_edma_chan *chan)
return &chan->event_lock;
}
+static inline void dw_edma_abort_event_mark(struct dw_edma_chan *chan)
+{
+ lockdep_assert_held(dw_edma_event_lock(chan));
+
+ chan->abort_pending = true;
+}
+
/*
* Return the current LL entry index. A negative value means that the channel
* context is not initialized or was lost after a link reset.
@@ -305,6 +316,12 @@ enum dma_status dw_edma_core_ch_status(struct dw_edma_chan *chan)
return chan->dw->core->ch_status(chan);
}
+static inline bool
+dw_edma_core_ch_abort_int_pending(struct dw_edma_chan *chan)
+{
+ return chan->dw->core->ch_abort_int_pending(chan);
+}
+
static inline irqreturn_t
dw_edma_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
dw_edma_handler_t handler)
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index 43e33a400a3e..91b5d331cfa3 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -318,6 +318,13 @@ static enum dma_status dw_edma_v0_core_ch_status(struct dw_edma_chan *chan)
return DMA_ERROR;
}
+static bool dw_edma_v0_core_ch_abort_int_pending(struct dw_edma_chan *chan)
+{
+ u32 sts = GET_RW_32(chan->dw, chan->dir, int_status);
+
+ return FIELD_GET(EDMA_V0_ABORT_INT_MASK, sts) & BIT(chan->id);
+}
+
static void dw_edma_v0_core_clear_done_int(struct dw_edma_chan *chan)
{
struct dw_edma *dw = chan->dw;
@@ -387,6 +394,7 @@ dw_edma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
events[pos] |= DW_EDMA_IRQ_ABORT;
active |= BIT(pos);
+ dw_edma_abort_event_mark(chan);
dw_edma_v0_core_clear_abort_int(chan);
}
@@ -664,6 +672,7 @@ static const struct dw_edma_core_ops dw_edma_v0_core = {
.ch_quiesce = dw_edma_v0_core_ch_quiesce,
.ch_count = dw_edma_v0_core_ch_count,
.ch_status = dw_edma_v0_core_ch_status,
+ .ch_abort_int_pending = dw_edma_v0_core_ch_abort_int_pending,
.event_scope = DW_EDMA_EVENT_PER_DIR,
.handle_int = dw_edma_v0_core_handle_int,
.ll_data = dw_edma_v0_core_ll_data,
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index bbf9ee0392f8..5d0d7575bae9 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -172,6 +172,12 @@ static u32 dw_hdma_v0_core_status_int(struct dw_edma_chan *chan)
return GET_CH_32(dw, chan->dir, chan->id, int_stat);
}
+static bool dw_hdma_v0_core_ch_abort_int_pending(struct dw_edma_chan *chan)
+{
+ return FIELD_GET(HDMA_V0_ABORT_INT_MASK,
+ dw_hdma_v0_core_status_int(chan));
+}
+
static irqreturn_t
dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
dw_edma_handler_t handler)
@@ -210,6 +216,7 @@ dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
if (FIELD_GET(HDMA_V0_ABORT_INT_MASK, val)) {
events |= DW_EDMA_IRQ_ABORT;
+ dw_edma_abort_event_mark(chan);
dw_hdma_v0_core_clear_abort_int(chan);
}
@@ -429,6 +436,7 @@ static const struct dw_edma_core_ops dw_hdma_v0_core = {
.ch_quiesce = dw_hdma_v0_core_ch_quiesce,
.ch_count = dw_hdma_v0_core_ch_count,
.ch_status = dw_hdma_v0_core_ch_status,
+ .ch_abort_int_pending = dw_hdma_v0_core_ch_abort_int_pending,
.event_scope = DW_EDMA_EVENT_PER_CHAN,
.handle_int = dw_hdma_v0_core_handle_int,
.non_ll_start = dw_hdma_v0_core_non_ll_start,
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 12/24] dmaengine: dw-edma: Keep channels stopped while ABORT is pending
2026-07-27 17:03 ` [PATCH v3 12/24] dmaengine: dw-edma: Keep channels stopped while ABORT is pending Koichiro Den
@ 2026-07-27 17:19 ` sashiko-bot
0 siblings, 0 replies; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:19 UTC (permalink / raw)
To: Koichiro Den; +Cc: dmaengine, Frank.Li, vkoul
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Skipping coalesced DONE and LL events during an ABORT permanently strands successfully completed or pending fully-published descriptors in the software queue, causing resource leaks, hangs, and silent data corruption.
--
--- Patch [12]: [PATCH v3 12/24] dmaengine: dw-edma: Keep channels stopped while ABORT is pending ---
commit 2cbef110fae6e22ffd20e7452128a0fd69fc4545
Author: Koichiro Den <den@valinux.co.jp>
dmaengine: dw-edma: Keep channels stopped while ABORT is pending
This commit delays deferred handling of ABORT interrupts until the worker runs.
It introduces a pending flag to block channel restarts and other progress
consumers until the ABORT cleanup finishes.
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index 3970b066dca22..5bf08ff0fe464 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
> @@ -880,12 +941,14 @@ static void dw_edma_irq_work(struct work_struct *work)
> do {
> events = atomic_xchg(&chan->irq_pending, 0);
>
> + /* ABORT cleanup makes coalesced DONE and LL work stale. */
> + if ((events & DW_EDMA_DEFERRED_ABORT) &&
> + dw_edma_abort_interrupt(chan))
> + continue;
> if (events & DW_EDMA_DEFERRED_DONE)
> dw_edma_done_interrupt(chan);
> if (events & DW_EDMA_DEFERRED_LL)
> dw_edma_ll_interrupt(chan);
> - if (events & DW_EDMA_DEFERRED_ABORT)
> - dw_edma_abort_interrupt(chan);
> } while (atomic_read(&chan->irq_pending));
> }
[Severity: High]
Does skipping the DONE events here strand pending and successfully completed
descriptors if the events coalesce?
If two or more descriptors are submitted and fully published to the hardware
ring, and the first completes successfully (DONE) while the second fails
(ABORT), these IRQs can coalesce.
When dw_edma_irq_work() encounters the continue statement above, it discards
the DONE event.
dw_edma_abort_interrupt() then pops only the first descriptor, which actually
succeeded, and incorrectly completes it as DMA_TRANS_ABORTED.
The second descriptor, which actually failed, remains stuck in the desc_issued
list.
Later calls to dw_edma_start_transfer() skip it because it is fully
published:
drivers/dma/dw-edma/dw-edma-core.c:dw_edma_start_transfer() {
...
/* A fully published descriptor may still be pending in hardware. */
if (desc->start_burst == desc->nburst)
continue;
...
}
Will this permanently break the driver when a subsequent valid transfer
completes and dw_edma_ll_clean_pending() hits the WARN_ON_ONCE
(desc->ll_start != chan->ll_done)?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=12
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 13/24] dmaengine: dw-edma: Reclaim issued descriptors from IRQ-paired LL progress
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (11 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 12/24] dmaengine: dw-edma: Keep channels stopped while ABORT is pending Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 14/24] dmaengine: dw-edma: Add LL interrupt placement policy Koichiro Den
` (10 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
Dynamic append can place entries from several descriptors in one LL
ring. Track the consumed boundary in ll_done, reuse entries behind it,
and complete descriptors in issue order as done_burst advances.
Normalize each IRQ-paired LLP sample to the exclusive boundary used by
ll_done. A stopped sample points to the next entry. Keep a running
sample one entry behind the raw LLP so an entry is not recycled before
payload completion is established. For legacy eDMA, treat DONE as a
stopped boundary only when channel status is complete and transfer size
is zero.
Record the first outstanding physical LL entry in each descriptor and
verify that it matches ll_done before consuming that descriptor. On a
mismatch, warn and resynchronize only if the sampled boundary has
reached the descriptor; otherwise stop without completing it.
Reclaiming entries as they are consumed also lets a descriptor larger
than the ring advance. Keep one data entry free so a physical index
remains unambiguous in the active producer window. Clear any published
ring state on termination or abort before starting another transfer.
LL progress now has its own completion path, so fold the temporary
lock-held DONE helper back into its only caller.
Suggested-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Keep STOP and ABORT ring resets when switching the consumer boundary
to ll_done. (Frank, Sashiko)
- Use explicit LL event types for LLP normalization and clarify ring
occupancy and one-shot snapshot handling. (Frank)
- State the strict descriptor publication and retirement order.
(Frank)
- Record each descriptor's physical LL boundary and check it before
consuming progress. (Frank)
- Split event capture and channel-start serialization into preparatory
patches, then fold the temporary lock-held DONE helper once LL
progress gets its own path. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 289 ++++++++++++++++++++++----
drivers/dma/dw-edma/dw-edma-core.h | 4 +
drivers/dma/dw-edma/dw-edma-v0-core.c | 6 +
3 files changed, 254 insertions(+), 45 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 5bf08ff0fe46..d4c0be2cbaef 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -53,13 +53,6 @@ dw_edma_alloc_desc(struct dw_edma_chan *chan, size_t nburst)
{
struct dw_edma_desc *desc;
- /*
- * For now, a descriptor that does not fit would stall the channel
- * forever: reject it up front.
- */
- if (!chan->non_ll && nburst > chan->ll_max - 1)
- return NULL;
-
desc = kzalloc_flex(*desc, burst, nburst, GFP_NOWAIT);
if (unlikely(!desc))
return NULL;
@@ -79,9 +72,17 @@ static void dw_edma_ll_snapshot_discard_locked(struct dw_edma_chan *chan)
{
lockdep_assert_held(dw_edma_event_lock(chan));
+ chan->ll_irq.idx = -1;
chan->ll_irq.event = DW_EDMA_LL_EVENT_NONE;
}
+static void dw_edma_ll_snapshot_discard(struct dw_edma_chan *chan)
+{
+ guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
+
+ dw_edma_ll_snapshot_discard_locked(chan);
+}
+
static void dw_edma_irq_events_discard(struct dw_edma_chan *chan)
{
guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
@@ -121,6 +122,7 @@ dw_edma_ll_snapshot_take(struct dw_edma_chan *chan,
if (dw_edma_abort_latch_locked(chan))
return false;
+ /* Consume each snapshot once, even if its boundary is later rejected. */
*snapshot = chan->ll_irq;
dw_edma_ll_snapshot_discard_locked(chan);
@@ -214,7 +216,13 @@ static u32 dw_edma_core_get_used_num(struct dw_edma_chan *chan)
static u32 dw_edma_core_get_free_num(struct dw_edma_chan *chan)
{
- /* Keep one data entry free so equal indices mean an empty ring. */
+ /*
+ * ll_done is the consumer boundary, so only the distance from ll_done
+ * to ll_head is occupied. Descriptor completion is tracked separately
+ * with done_burst.
+ *
+ * Keep one data entry free so equal indices mean an empty ring.
+ */
return chan->ll_max - 1 - dw_edma_core_get_used_num(chan);
}
@@ -223,6 +231,25 @@ static bool dw_edma_ll_pending(struct dw_edma_chan *chan)
return chan->ll_head != chan->ll_done;
}
+static u32 dw_edma_core_ch_transfer_size(struct dw_edma_chan *chan)
+{
+ if (!chan->dw->core->ch_transfer_size)
+ return U32_MAX;
+
+ return chan->dw->core->ch_transfer_size(chan);
+}
+
+static bool dw_edma_ll_done_is_stopped(struct dw_edma_chan *chan)
+{
+ /*
+ * Native HDMA reports STOP separately. The legacy interrupt interface
+ * uses DONE for both progress and stop, so confirm a stopped boundary
+ * with channel status and transfer size.
+ */
+ return dw_edma_core_ch_status(chan) == DMA_COMPLETE &&
+ dw_edma_core_ch_transfer_size(chan) == 0;
+}
+
static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
{
struct dw_edma_chan *chan = desc->chan;
@@ -230,6 +257,9 @@ static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
u32 free;
free = dw_edma_core_get_free_num(chan);
+ if (free && desc->start_burst == desc->done_burst)
+ desc->ll_start = chan->ll_head;
+
for (i = desc->start_burst; i < desc->nburst && free; i++, free--) {
/*
* Refresh the link element before filling the last data slot so
@@ -251,7 +281,6 @@ static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
}
}
- desc->done_burst = desc->start_burst;
desc->start_burst = i;
}
@@ -351,6 +380,134 @@ static void dw_edma_finish_termination(struct dw_edma_chan *chan)
chan->status = EDMA_ST_IDLE;
}
+/* Must be called with vc.lock held. */
+static bool dw_edma_ll_clean_pending(struct dw_edma_chan *chan, int idx)
+{
+ struct virt_dma_desc *vd, *_vd;
+ bool advanced = false;
+ u32 done, gap;
+
+ if (idx < 0 || (u32)idx >= chan->ll_max)
+ return false;
+
+ done = dw_edma_core_get_ll_dist(chan, chan->ll_done, idx);
+ if (!done || done > dw_edma_core_get_used_num(chan))
+ return false;
+
+ list_for_each_entry_safe(vd, _vd, &chan->vc.desc_issued, node) {
+ struct dw_edma_desc *desc = vd2dw_edma_desc(vd);
+ u32 consumed;
+
+ if (!done)
+ break;
+
+ if (WARN_ON_ONCE(desc->done_burst > desc->start_burst ||
+ desc->start_burst > desc->nburst))
+ return advanced;
+
+ /*
+ * start_burst is the next burst to append. done_burst counts
+ * bursts already consumed by hardware.
+ */
+ consumed = desc->start_burst - desc->done_burst;
+ if (!consumed)
+ break;
+
+ /*
+ * ll_start ties the descriptor counters to the physical ring.
+ * If accounting lost entries before this descriptor, skip them
+ * only after the sampled boundary has reached ll_start.
+ */
+ if (WARN_ON_ONCE(desc->ll_start != chan->ll_done)) {
+ gap = dw_edma_core_get_ll_dist(chan, chan->ll_done,
+ desc->ll_start);
+ if (gap > done)
+ return advanced;
+
+ chan->ll_done = desc->ll_start;
+ done -= gap;
+ advanced = true;
+ if (!done)
+ break;
+ }
+
+ consumed = min(done, consumed);
+ desc->done_burst += consumed;
+ desc->ll_start = (desc->ll_start + consumed) % chan->ll_max;
+ chan->ll_done = desc->ll_start;
+ done -= consumed;
+ advanced = true;
+
+ /*
+ * Descriptors are published and retired in strict list order. A
+ * later descriptor cannot complete until this one is fully consumed.
+ */
+ if (desc->done_burst != desc->nburst)
+ break;
+
+ /* Hardware has consumed this descriptor's LL entries. */
+ dw_hdma_set_callback_result(vd, DMA_TRANS_NOERROR);
+ list_del(&vd->node);
+ vchan_cookie_complete(vd);
+ }
+
+ WARN_ON_ONCE(done);
+
+ return advanced;
+}
+
+static int
+dw_edma_ll_recycle_idx(struct dw_edma_chan *chan, int idx,
+ enum dw_edma_ll_event event)
+{
+ if (idx < 0 || (u32)idx > chan->ll_max)
+ return -EINVAL;
+
+ /*
+ * Convert the raw LLP index to the exclusive boundary used by ll_done.
+ * For both eDMA and HDMA, once the engine has stopped, LLP points to
+ * the next element. ll_max is the link element, hence the following
+ * data boundary is 0.
+ */
+ if (event == DW_EDMA_LL_EVENT_STOP)
+ return idx == chan->ll_max ? 0 : idx;
+
+ /*
+ * Moving a running index one entry back cannot represent index 0
+ * without wrapping it to ll_max - 1. That could falsely consume a full
+ * producer window, so wait for another sample or STOP.
+ */
+ if (!idx)
+ return -EINVAL;
+
+ /*
+ * A running eDMA LLP can move ahead of payload completion, so keep the
+ * boundary one entry behind it.
+ *
+ * DWC PCIe Controller Databook 6.10a-lca06, Section 7.2.1, Table 7-3
+ * describes an HDMA watermark LLP as an inclusive LLE recycling
+ * boundary, which would normally translate to idx + 1. During testing
+ * on a DWC HDMA 6.30a integration, using that boundary for DMAengine
+ * completion let clients release DMA mappings while hardware still
+ * accessed them, causing IOMMU faults. Keep the boundary one entry
+ * behind the raw LLP for HDMA as well. Stopped samples continue to use
+ * the next-entry boundary above.
+ */
+ return idx == chan->ll_max ? chan->ll_max - 1 : idx - 1;
+}
+
+/*
+ * Must be called with vc.lock held. Consume a recorded LL progress
+ * boundary, if any. Advance ll_done and complete descriptors covered by
+ * the newly consumed range. Return true if ll_done advanced.
+ */
+static bool
+dw_edma_ll_consume_progress(struct dw_edma_chan *chan, int idx)
+{
+ /* Ignore duplicate or stale progress. */
+ return dw_edma_ll_clean_pending(chan, idx);
+}
+
static void dw_edma_core_ll_sync(struct dw_edma_chan *chan)
{
/*
@@ -563,6 +720,8 @@ static void dw_edma_device_issue_pending(struct dma_chan *dchan)
if (chan->configured && vchan_issue_pending(&chan->vc) &&
chan->request == EDMA_REQ_NONE &&
chan->status == EDMA_ST_IDLE) {
+ if (!chan->non_ll && !dw_edma_ll_pending(chan))
+ dw_edma_ll_snapshot_discard(chan);
chan->status = EDMA_ST_BUSY;
dw_edma_start_transfer(chan);
dw_edma_core_ch_maybe_doorbell(chan);
@@ -831,31 +990,30 @@ dw_edma_device_prep_interleaved_dma(struct dma_chan *dchan,
return dw_edma_device_transfer(&xfer, dw_edma_device_get_config(dchan, NULL));
}
-/* Must be called with vc.lock held. */
-static void dw_edma_done_interrupt_locked(struct dw_edma_chan *chan)
+static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
{
struct dw_edma_desc *desc;
struct virt_dma_desc *vd;
+ unsigned long flags;
- lockdep_assert_held(&chan->vc.lock);
-
- if (chan->status == EDMA_ST_PAUSE)
+ spin_lock_irqsave(&chan->vc.lock, flags);
+ if (chan->status == EDMA_ST_PAUSE) {
+ spin_unlock_irqrestore(&chan->vc.lock, flags);
return;
+ }
switch (chan->request) {
case EDMA_REQ_NONE:
case EDMA_REQ_PAUSE:
vd = vchan_next_desc(&chan->vc);
- if (!vd)
- break;
-
- desc = vd2dw_edma_desc(vd);
- if (desc->start_burst >= desc->nburst) {
- dw_hdma_set_callback_result(vd, DMA_TRANS_NOERROR);
- list_del(&vd->node);
- vchan_cookie_complete(vd);
- if (!chan->non_ll)
- chan->ll_done = chan->ll_head;
+ if (vd) {
+ desc = vd2dw_edma_desc(vd);
+ if (desc->start_burst >= desc->nburst) {
+ dw_hdma_set_callback_result(vd,
+ DMA_TRANS_NOERROR);
+ list_del(&vd->node);
+ vchan_cookie_complete(vd);
+ }
}
if (chan->request == EDMA_REQ_PAUSE) {
@@ -868,25 +1026,12 @@ static void dw_edma_done_interrupt_locked(struct dw_edma_chan *chan)
break;
case EDMA_REQ_STOP:
- vd = vchan_next_desc(&chan->vc);
- if (!vd)
- break;
-
dw_edma_finish_termination(chan);
break;
default:
break;
}
- dw_edma_core_ch_maybe_doorbell(chan);
-}
-
-static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
-{
- unsigned long flags;
-
- spin_lock_irqsave(&chan->vc.lock, flags);
- dw_edma_done_interrupt_locked(chan);
spin_unlock_irqrestore(&chan->vc.lock, flags);
}
@@ -899,7 +1044,37 @@ static void dw_edma_ll_interrupt(struct dw_edma_chan *chan)
if (!dw_edma_ll_snapshot_take(chan, &snapshot))
return;
- dw_edma_done_interrupt_locked(chan);
+ if (chan->status == EDMA_ST_PAUSE)
+ return;
+
+ dw_edma_ll_consume_progress(chan, snapshot.idx);
+
+ if (snapshot.event == DW_EDMA_LL_EVENT_PROGRESS &&
+ chan->request != EDMA_REQ_NONE)
+ goto out;
+
+ switch (chan->request) {
+ case EDMA_REQ_NONE:
+ dw_edma_start_transfer(chan);
+ chan->status = dw_edma_ll_pending(chan) ?
+ EDMA_ST_BUSY : EDMA_ST_IDLE;
+ break;
+
+ case EDMA_REQ_PAUSE:
+ dw_edma_set_request(chan, EDMA_REQ_NONE);
+ chan->status = EDMA_ST_PAUSE;
+ break;
+
+ case EDMA_REQ_STOP:
+ dw_edma_finish_termination(chan);
+ break;
+
+ default:
+ break;
+ }
+
+out:
+ dw_edma_core_ch_maybe_doorbell(chan);
}
static bool dw_edma_abort_interrupt(struct dw_edma_chan *chan)
@@ -962,21 +1137,44 @@ static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
static void dw_edma_record_irq(struct dw_edma_chan *chan, unsigned int events)
{
struct dw_edma_ll_snapshot snapshot = {
- .event = events & DW_EDMA_IRQ_STOP ?
- DW_EDMA_LL_EVENT_STOP : DW_EDMA_LL_EVENT_PROGRESS,
+ .idx = -1,
+ .event = DW_EDMA_LL_EVENT_NONE,
};
unsigned int pending = 0;
lockdep_assert_held(dw_edma_event_lock(chan));
+ /*
+ * Classify the LL event before normalizing its LLP sample to the
+ * exclusive consumer boundary. Keep STOP even without a valid
+ * boundary so deferred handling still sees that the run ended.
+ */
+ if (!chan->non_ll &&
+ (events & (DW_EDMA_IRQ_DONE | DW_EDMA_IRQ_PROGRESS |
+ DW_EDMA_IRQ_STOP))) {
+ if ((events & DW_EDMA_IRQ_STOP) ||
+ ((events & DW_EDMA_IRQ_DONE) &&
+ dw_edma_ll_done_is_stopped(chan)))
+ snapshot.event = DW_EDMA_LL_EVENT_STOP;
+ else
+ snapshot.event = DW_EDMA_LL_EVENT_PROGRESS;
+
+ snapshot.idx = dw_edma_ll_recycle_idx(chan,
+ dw_edma_core_ll_cur_idx(chan),
+ snapshot.event);
+ if (snapshot.idx < 0 &&
+ snapshot.event != DW_EDMA_LL_EVENT_STOP)
+ snapshot.event = DW_EDMA_LL_EVENT_NONE;
+ }
+
if ((events & DW_EDMA_IRQ_ABORT) && chan->abort_pending)
pending |= DW_EDMA_DEFERRED_ABORT;
- if (chan->non_ll) {
- if (events & (DW_EDMA_IRQ_DONE | DW_EDMA_IRQ_STOP))
- pending |= DW_EDMA_DEFERRED_DONE;
- } else if (events & (DW_EDMA_IRQ_DONE | DW_EDMA_IRQ_PROGRESS |
- DW_EDMA_IRQ_STOP)) {
+ if (chan->non_ll &&
+ (events & (DW_EDMA_IRQ_DONE | DW_EDMA_IRQ_STOP)))
+ pending |= DW_EDMA_DEFERRED_DONE;
+
+ if (snapshot.event != DW_EDMA_LL_EVENT_NONE) {
/* STOP is final for this run; do not replace it with progress. */
if (chan->ll_irq.event != DW_EDMA_LL_EVENT_STOP ||
snapshot.event == DW_EDMA_LL_EVENT_STOP)
@@ -1223,6 +1421,7 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u32 wr_alloc, u32 rd_alloc)
chan->irq_mode = dw_edma_get_default_irq_mode(chan);
INIT_WORK(&chan->irq_work, dw_edma_irq_work);
atomic_set(&chan->irq_pending, 0);
+ chan->ll_irq.idx = -1;
chan->ll_irq.event = DW_EDMA_LL_EVENT_NONE;
chan->abort_pending = false;
raw_spin_lock_init(&chan->event_lock);
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index 2bfbd1b25703..3d4844b5c6e3 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -76,6 +76,7 @@ struct dw_edma_desc {
u32 alloc_sz;
+ u32 ll_start; /* First outstanding LL entry */
size_t done_burst;
size_t start_burst;
size_t nburst;
@@ -83,6 +84,7 @@ struct dw_edma_desc {
};
struct dw_edma_ll_snapshot {
+ int idx;
enum dw_edma_ll_event event;
};
@@ -118,6 +120,7 @@ struct dw_edma_chan {
* LL event recorded by the hard IRQ handler. The event scope lock
* serializes its capture with a new hardware run; vc.lock serializes
* its consumption with LL state.
+ * Valid indices use the exclusive boundary convention of ll_done.
*/
struct dw_edma_ll_snapshot ll_irq;
/* ABORT is terminal and remains pending across LL state changes. */
@@ -191,6 +194,7 @@ struct dw_edma_core_ops {
enum dma_status (*ch_status)(struct dw_edma_chan *chan);
/* Called with the event scope locked. */
bool (*ch_abort_int_pending)(struct dw_edma_chan *chan);
+ u32 (*ch_transfer_size)(struct dw_edma_chan *chan);
enum dw_edma_event_scope event_scope;
irqreturn_t (*handle_int)(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
dw_edma_handler_t handler);
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index 91b5d331cfa3..5efeaaaa404e 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -318,6 +318,11 @@ static enum dma_status dw_edma_v0_core_ch_status(struct dw_edma_chan *chan)
return DMA_ERROR;
}
+static u32 dw_edma_v0_core_ch_transfer_size(struct dw_edma_chan *chan)
+{
+ return GET_CH_32(chan->dw, chan->dir, chan->id, transfer_size);
+}
+
static bool dw_edma_v0_core_ch_abort_int_pending(struct dw_edma_chan *chan)
{
u32 sts = GET_RW_32(chan->dw, chan->dir, int_status);
@@ -673,6 +678,7 @@ static const struct dw_edma_core_ops dw_edma_v0_core = {
.ch_count = dw_edma_v0_core_ch_count,
.ch_status = dw_edma_v0_core_ch_status,
.ch_abort_int_pending = dw_edma_v0_core_ch_abort_int_pending,
+ .ch_transfer_size = dw_edma_v0_core_ch_transfer_size,
.event_scope = DW_EDMA_EVENT_PER_DIR,
.handle_int = dw_edma_v0_core_handle_int,
.ll_data = dw_edma_v0_core_ll_data,
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 14/24] dmaengine: dw-edma: Add LL interrupt placement policy
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (12 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 13/24] dmaengine: dw-edma: Reclaim issued descriptors from IRQ-paired LL progress Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:21 ` sashiko-bot
2026-07-27 17:03 ` [PATCH v3 15/24] dmaengine: dw-edma: Recheck stopped LL channels before restart Koichiro Den
` (9 subsequent siblings)
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
Choose LL interrupt positions in the common core. Always request one at
descriptor ends, at the last free slot, and before each link. Add one
every four entries when the rest of the descriptor does not fit or more
issued work follows.
Four entries is an empirically chosen coalescing interval.
Suggested-by: Frank Li <Frank.li@oss.nxp.com>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Move interrupt placement policy from providers into the common core
and even use the same four-entry progress interval for eDMA and HDMA.
(Frank)
- Move this patch after LL progress reclamation to keep the series
bisectable.
drivers/dma/dw-edma/dw-edma-core.c | 29 ++++++++++++++++++++++++++++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index d4c0be2cbaef..d28e3633a866 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -25,6 +25,9 @@
#include "../dmaengine.h"
#include "../virt-dma.h"
+/* Empirically chosen progress interval. */
+#define DW_EDMA_LL_PROGRESS_INTERVAL 4
+
static inline
struct dw_edma_desc *vd2dw_edma_desc(struct virt_dma_desc *vd)
{
@@ -250,6 +253,30 @@ static bool dw_edma_ll_done_is_stopped(struct dw_edma_chan *chan)
dw_edma_core_ch_transfer_size(chan) == 0;
}
+static bool dw_edma_core_enable_ll_irq(struct dw_edma_desc *desc, u32 i,
+ u32 free)
+{
+ struct dw_edma_chan *chan = desc->chan;
+
+ /* Always report descriptor ends and the last free slot. */
+ if (i == desc->nburst - 1 || free == 1)
+ return true;
+
+ /* Keep one progress point per physical ring lap. */
+ if (chan->ll_head == chan->ll_max - 1)
+ return true;
+
+ /*
+ * Add periodic progress points only while this descriptor does not fit
+ * in the current free space or more issued work follows it.
+ */
+ if (desc->nburst - i <= free &&
+ list_is_last(&desc->vd.node, &chan->vc.desc_issued))
+ return false;
+
+ return (chan->ll_head + 1) % DW_EDMA_LL_PROGRESS_INTERVAL == 0;
+}
+
static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
{
struct dw_edma_chan *chan = desc->chan;
@@ -271,7 +298,7 @@ static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
dw_edma_core_ll_data(chan, &desc->burst[i],
chan->ll_head, chan->cb,
- i == desc->nburst - 1 || free == 1);
+ dw_edma_core_enable_ll_irq(desc, i, free));
chan->ll_head++;
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 14/24] dmaengine: dw-edma: Add LL interrupt placement policy
2026-07-27 17:03 ` [PATCH v3 14/24] dmaengine: dw-edma: Add LL interrupt placement policy Koichiro Den
@ 2026-07-27 17:21 ` sashiko-bot
0 siblings, 0 replies; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:21 UTC (permalink / raw)
To: Koichiro Den; +Cc: vkoul, Frank.Li, dmaengine
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The logic to enable periodic LL interrupts when 'more issued work follows' is ineffective and causes spurious interrupts because the driver's submission mechanism cannot pipeline multiple descriptors.
--
--- Patch [14]: [PATCH v3 14/24] dmaengine: dw-edma: Add LL interrupt placement policy ---
commit a9910cf03e474780cd4b172ac661f19546045a22
Author: Koichiro Den <den@valinux.co.jp>
dmaengine: dw-edma: Add LL interrupt placement policy
This commit moves the linked list (LL) interrupt placement policy into the
common core. It configures interrupts at descriptor ends, at the last free
slot, and adds a periodic interrupt every four entries if the descriptor
does not fit or if more work is queued.
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index d4c0be2cbaef1..d28e3633a8665 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
> @@ -250,6 +253,30 @@ static bool dw_edma_ll_done_is_stopped(struct dw_edma_chan *chan)
> dw_edma_core_ch_transfer_size(chan) == 0;
> }
>
> +static bool dw_edma_core_enable_ll_irq(struct dw_edma_desc *desc, u32 i,
> + u32 free)
> +{
> + struct dw_edma_chan *chan = desc->chan;
> +
> + /* Always report descriptor ends and the last free slot. */
> + if (i == desc->nburst - 1 || free == 1)
> + return true;
> +
> + /* Keep one progress point per physical ring lap. */
> + if (chan->ll_head == chan->ll_max - 1)
> + return true;
> +
> + /*
> + * Add periodic progress points only while this descriptor does not fit
> + * in the current free space or more issued work follows it.
> + */
> + if (desc->nburst - i <= free &&
> + list_is_last(&desc->vd.node, &chan->vc.desc_issued))
> + return false;
[Severity: Medium]
Does this logic result in spurious interrupts instead of pipelining the next
descriptor?
When multiple descriptors are queued, !list_is_last() will evaluate to true,
enabling periodic interrupts. However, looking at the submission path,
dw_edma_start_transfer() only fetches the very first descriptor:
dw_edma_start_transfer() {
...
vd = vchan_next_desc(&chan->vc);
...
}
Since dw_edma_ll_clean_pending() does not unlink the running descriptor from
the desc_issued list until it is completely finished:
dw_edma_ll_clean_pending() {
...
if (desc->done_burst != desc->nburst)
break;
/* Hardware has consumed this descriptor's LL entries. */
dw_hdma_set_callback_result(vd, DMA_TRANS_NOERROR);
list_del(&vd->node);
...
}
Won't these intermediate periodic interrupts just fetch the same running
descriptor, see it is already fully programmed, and do nothing?
This appears to prevent subsequent descriptors from being pipelined until the
first one completes, meaning the extra interrupts just add CPU overhead.
> +
> + return (chan->ll_head + 1) % DW_EDMA_LL_PROGRESS_INTERVAL == 0;
> +}
> +
> static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
> {
> struct dw_edma_chan *chan = desc->chan;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=14
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 15/24] dmaengine: dw-edma: Recheck stopped LL channels before restart
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (13 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 14/24] dmaengine: dw-edma: Add LL interrupt placement policy Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:21 ` sashiko-bot
2026-07-27 17:03 ` [PATCH v3 16/24] dmaengine: dw-edma: Use HDMA watermarks as progress events Koichiro Den
` (8 subsequent siblings)
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
A DMA_LLP sample taken for a DONE interrupt through the eDMA-compatible
interface can race with the final DMA_LLP update and leave the recorded
consumer boundary one entry short. If the channel stops there, no later
interrupt reports the missing progress.
Before restarting a stopped LL channel, sample DMA_LLP again and reclaim
any newly visible progress. If the channel still reports running, do not
ring another doorbell. It may stop at a CB mismatch just after the
status read, so schedule one delayed recheck. Native HDMA reports STOP
separately and does not need this recheck.
Serialize the stopped-state check, LLP sample and interrupt-status clear
against IRQ capture. Do not reconcile a stopped boundary while ABORT is
pending. Keep stopped-boundary reconciliation separate from refilling so
STOP and PAUSE drain paths can consume it without publishing more entries.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Rework and rename v2's "Reconcile lost completions from a stopped
LLP re-sample"; retain the stopped LLP re-sample and add one delayed
recheck for interfaces without a dedicated STOP event. (Sashiko)
- Serialize the stopped-state check, LLP sample and interrupt-status
clear against IRQ capture, block reconciliation while ABORT is
pending, and separate stopped reconciliation from refill. (Sashiko)
- Route normal kick paths through the helper that arms the delayed
recheck after observing a running channel. (Sashiko)
- Gate asynchronous work, unregister the DMA device before quiesce,
and quiesce the hardware before freeing IRQs. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 201 +++++++++++++++++++++++++++--
drivers/dma/dw-edma/dw-edma-core.h | 5 +
2 files changed, 194 insertions(+), 12 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index d28e3633a866..dbccd11aa92f 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -27,6 +27,7 @@
/* Empirically chosen progress interval. */
#define DW_EDMA_LL_PROGRESS_INTERVAL 4
+#define DW_EDMA_LL_RECHECK_DELAY_MS 30
static inline
struct dw_edma_desc *vd2dw_edma_desc(struct virt_dma_desc *vd)
@@ -148,6 +149,26 @@ static void dw_edma_ll_event_discard_locked(struct dw_edma_chan *chan)
dw_edma_ll_snapshot_discard_locked(chan);
}
+/* Must be called with vc.lock held. */
+static void dw_edma_ll_recheck_cancel(struct dw_edma_chan *chan)
+{
+ chan->ll_recheck_at = 0;
+ cancel_delayed_work(&chan->ll_recheck_work);
+}
+
+/* Must be called with vc.lock held. */
+static void dw_edma_ll_recheck_schedule(struct dw_edma_chan *chan)
+{
+ unsigned long delay =
+ msecs_to_jiffies(DW_EDMA_LL_RECHECK_DELAY_MS);
+
+ if (unlikely(READ_ONCE(chan->dw->teardown)))
+ return;
+
+ chan->ll_recheck_at = jiffies + delay;
+ mod_delayed_work(chan->dw->wq, &chan->ll_recheck_work, delay);
+}
+
/* Must be called with vc.lock held for an LL channel. */
static void dw_edma_ll_event_discard(struct dw_edma_chan *chan)
{
@@ -160,6 +181,8 @@ static void dw_edma_ll_event_discard(struct dw_edma_chan *chan)
static void
dw_edma_set_request(struct dw_edma_chan *chan, enum dw_edma_request request)
{
+ if (!chan->non_ll && chan->request != request)
+ dw_edma_ll_recheck_cancel(chan);
chan->request = request;
}
@@ -192,6 +215,8 @@ static void dw_edma_core_reset_ll(struct dw_edma_chan *chan)
{
u32 i;
+ dw_edma_ll_recheck_cancel(chan);
+
chan->ll_head = 0;
chan->ll_done = 0;
/* Drop stale CB bits before reusing the circular LL ring. */
@@ -430,7 +455,7 @@ static bool dw_edma_ll_clean_pending(struct dw_edma_chan *chan, int idx)
if (WARN_ON_ONCE(desc->done_burst > desc->start_burst ||
desc->start_burst > desc->nburst))
- return advanced;
+ goto out;
/*
* start_burst is the next burst to append. done_burst counts
@@ -449,7 +474,7 @@ static bool dw_edma_ll_clean_pending(struct dw_edma_chan *chan, int idx)
gap = dw_edma_core_get_ll_dist(chan, chan->ll_done,
desc->ll_start);
if (gap > done)
- return advanced;
+ goto out;
chan->ll_done = desc->ll_start;
done -= gap;
@@ -480,6 +505,10 @@ static bool dw_edma_ll_clean_pending(struct dw_edma_chan *chan, int idx)
WARN_ON_ONCE(done);
+out:
+ if (advanced)
+ dw_edma_ll_recheck_cancel(chan);
+
return advanced;
}
@@ -535,6 +564,59 @@ dw_edma_ll_consume_progress(struct dw_edma_chan *chan, int idx)
return dw_edma_ll_clean_pending(chan, idx);
}
+static bool dw_edma_ll_has_hdma_stop_event(struct dw_edma_chan *chan)
+{
+ return chan->dw->chip->mf == EDMA_MF_HDMA_NATIVE;
+}
+
+/*
+ * Must be called with vc.lock held. A DONE-time DMA_LLP sample may miss
+ * the final burst element. For the legacy interrupt interface, accept a
+ * fresh LLP sample only when status is STOPPED and transfer size is zero.
+ * Native HDMA reports STOP directly.
+ */
+static bool dw_edma_ll_reconcile_stopped(struct dw_edma_chan *chan)
+{
+ int idx;
+
+ scoped_guard(raw_spinlock_irqsave, dw_edma_event_lock(chan)) {
+ if (dw_edma_abort_latch_locked(chan))
+ return false;
+
+ /*
+ * Leave an IRQ-captured event to its worker. Otherwise pair the
+ * stopped boundary with the status clear before another kick.
+ */
+ if (chan->ll_irq.event != DW_EDMA_LL_EVENT_NONE ||
+ dw_edma_core_ch_status(chan) != DMA_COMPLETE)
+ return false;
+
+ /* Native HDMA reports STOP without a transfer-size check. */
+ if (!dw_edma_ll_has_hdma_stop_event(chan) &&
+ dw_edma_core_ch_transfer_size(chan) != 0)
+ return false;
+
+ idx = dw_edma_ll_recycle_idx(chan,
+ dw_edma_core_ll_cur_idx(chan),
+ DW_EDMA_LL_EVENT_STOP);
+ dw_edma_core_ll_irq_clear(chan);
+ }
+
+ return dw_edma_ll_clean_pending(chan, idx);
+}
+
+static bool dw_edma_ll_reconcile_and_refill(struct dw_edma_chan *chan)
+{
+ if (!dw_edma_ll_reconcile_stopped(chan))
+ return false;
+
+ dw_edma_start_transfer(chan);
+ chan->status = dw_edma_ll_pending(chan) ?
+ EDMA_ST_BUSY : EDMA_ST_IDLE;
+
+ return true;
+}
+
static void dw_edma_core_ll_sync(struct dw_edma_chan *chan)
{
/*
@@ -548,6 +630,15 @@ static void dw_edma_core_ll_sync(struct dw_edma_chan *chan)
/* Must be called with vc.lock held for an LL channel. */
static void dw_edma_core_ch_kick(struct dw_edma_chan *chan)
{
+ if (unlikely(READ_ONCE(chan->dw->teardown)))
+ return;
+
+ dw_edma_ll_recheck_cancel(chan);
+
+ /*
+ * Complete the remote LL publication before serializing the new
+ * hardware run with IRQ capture.
+ */
dw_edma_core_ll_sync(chan);
guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
@@ -566,14 +657,71 @@ static void dw_edma_core_ch_kick(struct dw_edma_chan *chan)
dw_edma_core_ch_doorbell(chan);
}
-/* Must be called with vc.lock held. */
-static void dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
+/*
+ * Must be called with vc.lock held. Return true when published work is still
+ * running and may need one later stop recheck.
+ */
+static bool dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
{
if (chan->non_ll || chan->request != EDMA_REQ_NONE ||
- chan->status != EDMA_ST_BUSY || !dw_edma_ll_pending(chan))
- return;
+ chan->status != EDMA_ST_BUSY || !dw_edma_ll_pending(chan) ||
+ dw_edma_abort_is_pending(chan))
+ return false;
+
+ /*
+ * While running, both eDMA and HDMA consume newly published
+ * elements without another doorbell.
+ */
+ if (dw_edma_core_ch_status(chan) == DMA_IN_PROGRESS)
+ return true;
+
+ dw_edma_ll_reconcile_and_refill(chan);
+ if (!dw_edma_ll_pending(chan))
+ return false;
dw_edma_core_ch_kick(chan);
+
+ return false;
+}
+
+/*
+ * eDMA may stop at a CB mismatch just after reporting RUNNING.
+ * Recheck once so the stopped tail is not left pending.
+ */
+static void
+dw_edma_core_ch_maybe_doorbell_or_recheck(struct dw_edma_chan *chan)
+{
+ if (dw_edma_core_ch_maybe_doorbell(chan) &&
+ !dw_edma_ll_has_hdma_stop_event(chan))
+ dw_edma_ll_recheck_schedule(chan);
+}
+
+static void dw_edma_ll_recheck_work(struct work_struct *work)
+{
+ struct dw_edma_chan *chan =
+ container_of(to_delayed_work(work), struct dw_edma_chan,
+ ll_recheck_work);
+ unsigned long delay;
+
+ guard(spinlock_irqsave)(&chan->vc.lock);
+
+ if (unlikely(READ_ONCE(chan->dw->teardown))) {
+ chan->ll_recheck_at = 0;
+ return;
+ }
+
+ if (!chan->ll_recheck_at)
+ return;
+
+ if (time_before(jiffies, chan->ll_recheck_at)) {
+ delay = chan->ll_recheck_at - jiffies;
+ mod_delayed_work(chan->dw->wq, &chan->ll_recheck_work, delay);
+ return;
+ }
+
+ chan->ll_recheck_at = 0;
+ if (chan->request == EDMA_REQ_NONE)
+ dw_edma_core_ch_maybe_doorbell(chan);
}
static void dw_edma_device_caps(struct dma_chan *dchan,
@@ -701,7 +849,7 @@ static int dw_edma_device_resume(struct dma_chan *dchan)
chan->status = EDMA_ST_BUSY;
if (!dw_edma_start_transfer(chan))
chan->status = EDMA_ST_IDLE;
- dw_edma_core_ch_maybe_doorbell(chan);
+ dw_edma_core_ch_maybe_doorbell_or_recheck(chan);
}
return err;
@@ -751,7 +899,7 @@ static void dw_edma_device_issue_pending(struct dma_chan *dchan)
dw_edma_ll_snapshot_discard(chan);
chan->status = EDMA_ST_BUSY;
dw_edma_start_transfer(chan);
- dw_edma_core_ch_maybe_doorbell(chan);
+ dw_edma_core_ch_maybe_doorbell_or_recheck(chan);
}
spin_unlock_irqrestore(&chan->vc.lock, flags);
}
@@ -1101,7 +1249,7 @@ static void dw_edma_ll_interrupt(struct dw_edma_chan *chan)
}
out:
- dw_edma_core_ch_maybe_doorbell(chan);
+ dw_edma_core_ch_maybe_doorbell_or_recheck(chan);
}
static bool dw_edma_abort_interrupt(struct dw_edma_chan *chan)
@@ -1140,6 +1288,11 @@ static void dw_edma_irq_work(struct work_struct *work)
irq_work);
unsigned int events;
+ if (unlikely(READ_ONCE(chan->dw->teardown))) {
+ atomic_set(&chan->irq_pending, 0);
+ return;
+ }
+
do {
events = atomic_xchg(&chan->irq_pending, 0);
@@ -1157,6 +1310,9 @@ static void dw_edma_irq_work(struct work_struct *work)
static void dw_edma_queue_irq_work(struct dw_edma_chan *chan,
unsigned int events)
{
+ if (unlikely(READ_ONCE(chan->dw->teardown)))
+ return;
+
atomic_or(events, &chan->irq_pending);
queue_work(chan->dw->wq, &chan->irq_work);
}
@@ -1394,6 +1550,9 @@ static void dw_edma_device_synchronize(struct dma_chan *dchan)
struct dw_edma_chan *chan = dchan2dw_edma_chan(dchan);
dw_edma_wait_termination(dchan);
+ scoped_guard(spinlock_irqsave, &chan->vc.lock)
+ dw_edma_ll_recheck_cancel(chan);
+ cancel_delayed_work_sync(&chan->ll_recheck_work);
cancel_work_sync(&chan->irq_work);
atomic_set(&chan->irq_pending, 0);
dw_edma_irq_events_discard(chan);
@@ -1447,6 +1606,8 @@ static int dw_edma_channel_setup(struct dw_edma *dw, u32 wr_alloc, u32 rd_alloc)
chan->status = EDMA_ST_IDLE;
chan->irq_mode = dw_edma_get_default_irq_mode(chan);
INIT_WORK(&chan->irq_work, dw_edma_irq_work);
+ INIT_DELAYED_WORK(&chan->ll_recheck_work,
+ dw_edma_ll_recheck_work);
atomic_set(&chan->irq_pending, 0);
chan->ll_irq.idx = -1;
chan->ll_irq.event = DW_EDMA_LL_EVENT_NONE;
@@ -1789,23 +1950,39 @@ int dw_edma_remove(struct dw_edma_chip *chip)
if (!dw)
return -ENODEV;
+ /*
+ * Stop new clients and asynchronous hardware access before dismantling
+ * their execution context.
+ */
+ WRITE_ONCE(dw->teardown, true);
+ dma_async_device_unregister(&dw->dma);
+
+ /*
+ * Drain channel work that may have passed the teardown gate before
+ * stopping the hardware. IRQ handlers remain installed while it is
+ * active.
+ */
+ for (i = 0; i < dw->wr_ch_cnt + dw->rd_ch_cnt; i++) {
+ disable_delayed_work_sync(&dw->chan[i].ll_recheck_work);
+ cancel_work_sync(&dw->chan[i].irq_work);
+ }
+
if (chip->flags & DW_EDMA_CHIP_PARTIAL)
err = dw_edma_core_quiesce(dw);
else
dw_edma_core_off(dw);
- /* Free irqs */
+ /* No new hardware event can be raised after the quiesce. */
for (i = (dw->nr_irqs - 1); i >= 0; i--)
free_irq(chip->ops->irq_vector(dev, i), &dw->irq[i]);
dw_edma_emul_irq_free(dw);
+ /* Drain IRQ work queued by a handler that raced with the gate. */
for (i = 0; i < dw->wr_ch_cnt + dw->rd_ch_cnt; i++)
cancel_work_sync(&dw->chan[i].irq_work);
destroy_workqueue(dw->wq);
- /* Deregister eDMA device */
- dma_async_device_unregister(&dw->dma);
list_for_each_entry_safe(chan, _chan, &dw->dma.channels,
vc.chan.device_node) {
tasklet_kill(&chan->vc.task);
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index 3d4844b5c6e3..f56885747e57 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -127,6 +127,9 @@ struct dw_edma_chan {
bool abort_pending;
raw_spinlock_t event_lock;
+ struct delayed_work ll_recheck_work;
+ unsigned long ll_recheck_at;
+
u32 ll_max; /* Data entries */
struct dw_edma_region ll_region; /* Linked list */
bool ll_valid; /* LL context programmed */
@@ -175,6 +178,8 @@ struct dw_edma {
*/
struct workqueue_struct *wq;
+ bool teardown; /* Gate asynchronous hardware access */
+
raw_spinlock_t lock; /* Protect v0 shared registers */
raw_spinlock_t event_lock[2]; /* Per-direction event scopes */
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 15/24] dmaengine: dw-edma: Recheck stopped LL channels before restart
2026-07-27 17:03 ` [PATCH v3 15/24] dmaengine: dw-edma: Recheck stopped LL channels before restart Koichiro Den
@ 2026-07-27 17:21 ` sashiko-bot
0 siblings, 0 replies; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:21 UTC (permalink / raw)
To: Koichiro Den; +Cc: dmaengine, vkoul, Frank.Li
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Using 0 as a sentinel for `ll_recheck_at` leads to missed DMA rechecks when `jiffies + delay` evaluates to exactly 0.
--
--- Patch [15]: [PATCH v3 15/24] dmaengine: dw-edma: Recheck stopped LL channels before restart ---
commit 204ac5e83f10ca496840d5ab003b724253b46bfe
Author: Koichiro Den <den@valinux.co.jp>
dmaengine: dw-edma: Recheck stopped LL channels before restart
This commit introduces a mechanism to recheck a stopped linked-list
channel before restarting it. It samples DMA_LLP again to reclaim any
newly visible progress for interfaces without a dedicated STOP event. It
also schedules a delayed recheck if the channel reports it is running.
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index d28e3633a8665..dbccd11aa92fa 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
> @@ -148,6 +149,26 @@ static void dw_edma_ll_event_discard_locked(struct dw_edma_chan *chan)
> dw_edma_ll_snapshot_discard_locked(chan);
> }
>
> +/* Must be called with vc.lock held. */
> +static void dw_edma_ll_recheck_cancel(struct dw_edma_chan *chan)
> +{
> + chan->ll_recheck_at = 0;
> + cancel_delayed_work(&chan->ll_recheck_work);
> +}
> +
> +/* Must be called with vc.lock held. */
> +static void dw_edma_ll_recheck_schedule(struct dw_edma_chan *chan)
> +{
> + unsigned long delay =
> + msecs_to_jiffies(DW_EDMA_LL_RECHECK_DELAY_MS);
> +
> + if (unlikely(READ_ONCE(chan->dw->teardown)))
> + return;
> +
> + chan->ll_recheck_at = jiffies + delay;
[Severity: Medium]
If jiffies + delay evaluates to exactly 0 when it wraps around, will the
delayed work function mistake this for a cancelled timer?
> + mod_delayed_work(chan->dw->wq, &chan->ll_recheck_work, delay);
> +}
[ ... ]
> +static void dw_edma_ll_recheck_work(struct work_struct *work)
> +{
> + struct dw_edma_chan *chan =
> + container_of(to_delayed_work(work), struct dw_edma_chan,
> + ll_recheck_work);
> + unsigned long delay;
> +
> + guard(spinlock_irqsave)(&chan->vc.lock);
> +
> + if (unlikely(READ_ONCE(chan->dw->teardown))) {
> + chan->ll_recheck_at = 0;
> + return;
> + }
> +
> + if (!chan->ll_recheck_at)
> + return;
[Severity: Medium]
If the scheduled time wrapped to 0, does this check incorrectly abort
the function and miss the necessary recheck of the stopped boundary?
> +
> + if (time_before(jiffies, chan->ll_recheck_at)) {
> + delay = chan->ll_recheck_at - jiffies;
> + mod_delayed_work(chan->dw->wq, &chan->ll_recheck_work, delay);
> + return;
> + }
> +
> + chan->ll_recheck_at = 0;
> + if (chan->request == EDMA_REQ_NONE)
> + dw_edma_core_ch_maybe_doorbell(chan);
> }
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=15
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 16/24] dmaengine: dw-edma: Use HDMA watermarks as progress events
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (14 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 15/24] dmaengine: dw-edma: Recheck stopped LL channels before restart Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 17/24] dmaengine: dw-edma: Recover stopped channels from tx_status() Koichiro Den
` (7 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
HDMA reports running LL progress through WATERMARK and channel stop
through STOP. Wire watermark setup, clearing, MSI programming, and
LWIE/RWIE into the core interrupt path. Record WATERMARK as progress;
STOP remains a stopped event.
DWC PCIe Controller Databook 6.10a, Section 7.2.1, permits recycling
LLEs through the watermark LLP. Testing on a 6.30a integration found
that boundary unsafe for DMAengine completion: clients released mappings
while hardware still accessed them. Keep completion one entry behind the
raw LLP. Once the channel has stopped, LLP points to the next entry and
needs no such margin.
Leave EDMA_REQ_STOP and EDMA_REQ_PAUSE to the STOP path instead of
handling their watermark as normal running progress. The eDMA path is
unchanged.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Record HDMA STOP, WATERMARK, and ABORT status under its per-channel
event lock. (Sashiko)
drivers/dma/dw-edma/dw-hdma-v0-core.c | 69 +++++++++++++++++++++++----
drivers/dma/dw-edma/dw-hdma-v0-regs.h | 1 +
2 files changed, 60 insertions(+), 10 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c
index 5d0d7575bae9..cbf9ef109e08 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c
@@ -53,7 +53,8 @@ static u32 dw_hdma_v0_core_int_setup(struct dw_edma_chan *chan, u32 val)
{
val &= ~(HDMA_V0_LOCAL_ABORT_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN |
HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_REMOTE_STOP_INT_EN |
- HDMA_V0_ABORT_INT_MASK | HDMA_V0_STOP_INT_MASK);
+ HDMA_V0_ABORT_INT_MASK | HDMA_V0_WATERMARK_INT_MASK |
+ HDMA_V0_STOP_INT_MASK);
/*
* HDMA_INT_STATUS.STOP and .ABORT are latched only when LSIE and
@@ -63,10 +64,14 @@ static u32 dw_hdma_v0_core_int_setup(struct dw_edma_chan *chan, u32 val)
*/
val |= HDMA_V0_LOCAL_ABORT_INT_EN | HDMA_V0_LOCAL_STOP_INT_EN;
- if (chan->irq_mode == DW_EDMA_CH_IRQ_REMOTE)
+ if (chan->irq_mode == DW_EDMA_CH_IRQ_REMOTE) {
+ if (!chan->non_ll)
+ val |= HDMA_V0_WATERMARK_INT_MASK;
+
val |= HDMA_V0_REMOTE_ABORT_INT_EN |
HDMA_V0_REMOTE_STOP_INT_EN |
HDMA_V0_ABORT_INT_MASK | HDMA_V0_STOP_INT_MASK;
+ }
return val;
}
@@ -76,10 +81,12 @@ static void dw_hdma_v0_core_ch_off(struct dw_edma *dw, enum dw_edma_dir dir,
u16 id)
{
SET_CH_32(dw, dir, id, int_setup,
- HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK);
+ HDMA_V0_STOP_INT_MASK | HDMA_V0_WATERMARK_INT_MASK |
+ HDMA_V0_ABORT_INT_MASK);
SET_CH_32(dw, dir, id, ch_en, 0);
SET_CH_32(dw, dir, id, int_clear,
- HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK);
+ HDMA_V0_STOP_INT_MASK | HDMA_V0_WATERMARK_INT_MASK |
+ HDMA_V0_ABORT_INT_MASK);
}
static void dw_hdma_v0_core_off(struct dw_edma *dw)
@@ -90,18 +97,26 @@ static void dw_hdma_v0_core_off(struct dw_edma *dw)
dir = EDMA_DIR_WRITE;
for (id = 0; id < dw->wr_ch_cnt; id++) {
SET_CH_32(dw, dir, id, int_setup,
- HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK);
+ HDMA_V0_STOP_INT_MASK |
+ HDMA_V0_WATERMARK_INT_MASK |
+ HDMA_V0_ABORT_INT_MASK);
SET_CH_32(dw, dir, id, int_clear,
- HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK);
+ HDMA_V0_STOP_INT_MASK |
+ HDMA_V0_WATERMARK_INT_MASK |
+ HDMA_V0_ABORT_INT_MASK);
SET_CH_32(dw, dir, id, ch_en, 0);
}
dir = EDMA_DIR_READ;
for (id = 0; id < dw->rd_ch_cnt; id++) {
SET_CH_32(dw, dir, id, int_setup,
- HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK);
+ HDMA_V0_STOP_INT_MASK |
+ HDMA_V0_WATERMARK_INT_MASK |
+ HDMA_V0_ABORT_INT_MASK);
SET_CH_32(dw, dir, id, int_clear,
- HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK);
+ HDMA_V0_STOP_INT_MASK |
+ HDMA_V0_WATERMARK_INT_MASK |
+ HDMA_V0_ABORT_INT_MASK);
SET_CH_32(dw, dir, id, ch_en, 0);
}
}
@@ -158,6 +173,22 @@ static void dw_hdma_v0_core_clear_done_int(struct dw_edma_chan *chan)
SET_CH_32(dw, chan->dir, chan->id, int_clear, HDMA_V0_STOP_INT_MASK);
}
+static void dw_hdma_v0_core_clear_watermark_int(struct dw_edma_chan *chan)
+{
+ struct dw_edma *dw = chan->dw;
+
+ SET_CH_32(dw, chan->dir, chan->id, int_clear,
+ HDMA_V0_WATERMARK_INT_MASK);
+}
+
+static void dw_hdma_v0_core_clear_ll_int(struct dw_edma_chan *chan)
+{
+ struct dw_edma *dw = chan->dw;
+
+ SET_CH_32(dw, chan->dir, chan->id, int_clear,
+ HDMA_V0_STOP_INT_MASK | HDMA_V0_WATERMARK_INT_MASK);
+}
+
static void dw_hdma_v0_core_clear_abort_int(struct dw_edma_chan *chan)
{
struct dw_edma *dw = chan->dw;
@@ -214,6 +245,12 @@ dw_hdma_v0_core_handle_int(struct dw_edma_irq *dw_irq, enum dw_edma_dir dir,
dw_hdma_v0_core_clear_done_int(chan);
}
+ if (FIELD_GET(HDMA_V0_WATERMARK_INT_MASK, val)) {
+ if (!(events & DW_EDMA_IRQ_STOP))
+ events |= DW_EDMA_IRQ_PROGRESS;
+ dw_hdma_v0_core_clear_watermark_int(chan);
+ }
+
if (FIELD_GET(HDMA_V0_ABORT_INT_MASK, val)) {
events |= DW_EDMA_IRQ_ABORT;
dw_edma_abort_event_mark(chan);
@@ -282,7 +319,7 @@ static void dw_hdma_v0_core_ch_enable(struct dw_edma_chan *chan)
/* Enable engine */
SET_CH_32(dw, chan->dir, chan->id, ch_en, BIT(0));
- /* Interrupt unmask - stop, abort */
+ /* Interrupt unmask - stop, watermark, abort */
tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup);
tmp = dw_hdma_v0_core_int_setup(chan, tmp);
SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp);
@@ -343,6 +380,11 @@ static void dw_hdma_v0_core_ch_config(struct dw_edma_chan *chan)
/* MSI done addr - low, high */
SET_CH_32(dw, chan->dir, chan->id, msi_stop.lsb, chan->msi.address_lo);
SET_CH_32(dw, chan->dir, chan->id, msi_stop.msb, chan->msi.address_hi);
+ /* MSI watermark addr - low, high */
+ SET_CH_32(dw, chan->dir, chan->id, msi_watermark.lsb,
+ chan->msi.address_lo);
+ SET_CH_32(dw, chan->dir, chan->id, msi_watermark.msb,
+ chan->msi.address_hi);
/* MSI abort addr - low, high */
SET_CH_32(dw, chan->dir, chan->id, msi_abort.lsb, chan->msi.address_lo);
SET_CH_32(dw, chan->dir, chan->id, msi_abort.msb, chan->msi.address_hi);
@@ -362,6 +404,13 @@ dw_hdma_v0_core_ll_data(struct dw_edma_chan *chan, struct dw_edma_burst *burst,
if (cb)
control |= DW_HDMA_V0_CB;
+ if (irq) {
+ control |= DW_HDMA_V0_LWIE;
+
+ if (chan->irq_mode == DW_EDMA_CH_IRQ_REMOTE)
+ control |= DW_HDMA_V0_RWIE;
+ }
+
dw_hdma_v0_write_ll_data(chan, idx, control, burst->sz, burst->sar,
burst->dar);
}
@@ -444,7 +493,7 @@ static const struct dw_edma_core_ops dw_hdma_v0_core = {
.ll_link = dw_hdma_v0_core_ll_link,
.ll_clear = dw_hdma_v0_core_ll_clear,
.ll_cur_idx = dw_hdma_v0_core_ll_cur_idx,
- .ll_irq_clear = dw_hdma_v0_core_clear_done_int,
+ .ll_irq_clear = dw_hdma_v0_core_clear_ll_int,
.ch_doorbell = dw_hdma_v0_core_ch_doorbell,
.ch_enable = dw_hdma_v0_core_ch_enable,
.ch_config = dw_hdma_v0_core_ch_config,
diff --git a/drivers/dma/dw-edma/dw-hdma-v0-regs.h b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
index 2124c162a62f..60dc054adafa 100644
--- a/drivers/dma/dw-edma/dw-hdma-v0-regs.h
+++ b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
@@ -18,6 +18,7 @@
#define HDMA_V0_LOCAL_STOP_INT_EN BIT(4)
#define HDMA_V0_REMOTE_STOP_INT_EN BIT(3)
#define HDMA_V0_ABORT_INT_MASK BIT(2)
+#define HDMA_V0_WATERMARK_INT_MASK BIT(1)
#define HDMA_V0_STOP_INT_MASK BIT(0)
#define HDMA_V0_LINKLIST_EN BIT(0)
#define HDMA_V0_CONSUMER_CYCLE_STAT BIT(1)
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 17/24] dmaengine: dw-edma: Recover stopped channels from tx_status()
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (15 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 16/24] dmaengine: dw-edma: Use HDMA watermarks as progress events Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 18/24] dmaengine: dw-edma: Make the LL ring reset a full channel resync Koichiro Den
` (6 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
An LL channel can stop after an append without another interrupt. A
synchronous user may then time out with work still pending.
Let tx_status() consume IRQ-recorded progress under vc.lock. If the
channel is stopped with pending entries, reconcile a fresh LLP boundary
and re-kick it. If it still reports running, arm the bounded legacy-eDMA
tail recheck. Do not use a running LLP read as progress because it can
move ahead of payload completion.
Refill the ring after consuming progress and update BUSY or IDLE from
the remaining entries.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Use the serialized LL snapshot when tx_status() consumes progress.
(Sashiko)
- Arm the bounded stopped-tail recheck after consuming a snapshot.
(Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 40 ++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index dbccd11aa92f..fc8bea495aac 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -302,6 +302,14 @@ static bool dw_edma_core_enable_ll_irq(struct dw_edma_desc *desc, u32 i,
return (chan->ll_head + 1) % DW_EDMA_LL_PROGRESS_INTERVAL == 0;
}
+static bool dw_edma_ll_recoverable_pending(struct dw_edma_chan *chan,
+ enum dma_status ch_status)
+{
+ return chan->request == EDMA_REQ_NONE &&
+ chan->status != EDMA_ST_PAUSE &&
+ dw_edma_ll_pending(chan) && ch_status == DMA_COMPLETE;
+}
+
static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
{
struct dw_edma_chan *chan = desc->chan;
@@ -919,6 +927,38 @@ dw_edma_device_tx_status(struct dma_chan *dchan, dma_cookie_t cookie,
if (ret == DMA_COMPLETE)
return ret;
+ if (!chan->non_ll) {
+ scoped_guard(spinlock_irqsave, &chan->vc.lock) {
+ struct dw_edma_ll_snapshot snapshot;
+ enum dma_status ch_status;
+
+ ch_status = dw_edma_core_ch_status(chan);
+
+ /*
+ * Do not treat raw DMA_LLP polling as normal progress here. Only
+ * recycle progress recorded by the IRQ pass that consumed the
+ * status event.
+ */
+ if (chan->request == EDMA_REQ_NONE &&
+ chan->status != EDMA_ST_PAUSE &&
+ ch_status == DMA_COMPLETE &&
+ dw_edma_ll_snapshot_take(chan, &snapshot) &&
+ dw_edma_ll_consume_progress(chan, snapshot.idx)) {
+ dw_edma_start_transfer(chan);
+ chan->status = dw_edma_ll_pending(chan) ?
+ EDMA_ST_BUSY : EDMA_ST_IDLE;
+ }
+
+ if (dw_edma_ll_recoverable_pending(chan, ch_status))
+ chan->status = EDMA_ST_BUSY;
+ dw_edma_core_ch_maybe_doorbell_or_recheck(chan);
+ }
+
+ /* dw_edma_ll_clean_pending() may have completed this cookie. */
+ ret = dma_cookie_status(dchan, cookie, txstate);
+ if (ret == DMA_COMPLETE)
+ return ret;
+ }
if (ret == DMA_IN_PROGRESS && chan->status == EDMA_ST_PAUSE)
ret = DMA_PAUSED;
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 18/24] dmaengine: dw-edma: Make the LL ring reset a full channel resync
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (16 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 17/24] dmaengine: dw-edma: Recover stopped channels from tx_status() Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:24 ` sashiko-bot
2026-07-27 17:03 ` [PATCH v3 19/24] dmaengine: dw-edma: Drain LL entries for STOP and PAUSE Koichiro Den
` (5 subsequent siblings)
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
Reset currently clears the ring but leaves issued descriptors unchanged.
A descriptor with published entries is then stranded because LL progress
can no longer account for those entries.
Cancel any pending stopped-tail recheck before replacing the ring state.
Keep descriptors with no outstanding published entries so their
unpublished work can use the fresh ring. Abort descriptors with
outstanding entries because their consumption is unknown and replay is
unsafe.
Since resync can complete and remove descriptors, reset the ring before
looking up the next issued descriptor.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Reset before looking up the next issued descriptor. (Sashiko)
- Cancel any pending stopped-tail recheck before replacing the ring
state. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 32 ++++++++++++++++++++++++------
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index fc8bea495aac..0c30c0f51fea 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -213,10 +213,29 @@ static void dw_hdma_set_callback_result(struct virt_dma_desc *vd,
static void dw_edma_core_reset_ll(struct dw_edma_chan *chan)
{
+ struct virt_dma_desc *vd, *tmp;
u32 i;
dw_edma_ll_recheck_cancel(chan);
+ /*
+ * Software cannot tell which published entries completed before the
+ * reset. Replaying one could duplicate a transfer after its target
+ * changed ownership, while keeping descriptors with uncertain entries
+ * would block later in-order completions. Abort descriptors with published
+ * entries; untouched descriptors remain available for republishing.
+ */
+ list_for_each_entry_safe(vd, tmp, &chan->vc.desc_issued, node) {
+ struct dw_edma_desc *desc = vd2dw_edma_desc(vd);
+
+ if (desc->start_burst == desc->done_burst)
+ continue;
+
+ dw_hdma_set_callback_result(vd, DMA_TRANS_ABORTED);
+ list_del(&vd->node);
+ vchan_cookie_complete(vd);
+ }
+
chan->ll_head = 0;
chan->ll_done = 0;
/* Drop stale CB bits before reusing the circular LL ring. */
@@ -364,6 +383,13 @@ static int dw_edma_start_transfer(struct dw_edma_chan *chan)
struct dw_edma_desc *desc;
struct virt_dma_desc *vd;
+ if (!chan->non_ll) {
+ if (dw_edma_abort_is_pending(chan))
+ return 0;
+ if (!chan->ll_valid)
+ dw_edma_core_reset_ll(chan);
+ }
+
vd = vchan_next_desc(&chan->vc);
if (!vd)
return 0;
@@ -382,12 +408,6 @@ static int dw_edma_start_transfer(struct dw_edma_chan *chan)
return 1;
}
- if (dw_edma_abort_is_pending(chan))
- return 0;
-
- if (!chan->ll_valid)
- dw_edma_core_reset_ll(chan);
-
dw_edma_core_start(desc);
return 1;
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 18/24] dmaengine: dw-edma: Make the LL ring reset a full channel resync
2026-07-27 17:03 ` [PATCH v3 18/24] dmaengine: dw-edma: Make the LL ring reset a full channel resync Koichiro Den
@ 2026-07-27 17:24 ` sashiko-bot
0 siblings, 0 replies; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:24 UTC (permalink / raw)
To: Koichiro Den; +Cc: Frank.Li, dmaengine, vkoul
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The driver fails to dynamically append multiple descriptors to the LL ring concurrently, defeating the pipelining design.
--
--- Patch [18]: [PATCH v3 18/24] dmaengine: dw-edma: Make the LL ring reset a full channel resync ---
commit 5973888151d0718a6614eb2366d05e6ecc44461c
Author: Koichiro Den <den@valinux.co.jp>
dmaengine: dw-edma: Make the LL ring reset a full channel resync
This commit updates the channel reset logic for the dw-edma LL ring. It
clears out descriptors with published entries to prevent stale tracking
while keeping untouched descriptors available, and ensures the ring is
reset before looking up the next issued descriptor.
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
> @@ -364,6 +383,13 @@ static int dw_edma_start_transfer(struct dw_edma_chan *chan)
> struct dw_edma_desc *desc;
> struct virt_dma_desc *vd;
>
> + if (!chan->non_ll) {
> + if (dw_edma_abort_is_pending(chan))
> + return 0;
> + if (!chan->ll_valid)
> + dw_edma_core_reset_ll(chan);
> + }
> +
> vd = vchan_next_desc(&chan->vc);
[Severity: Medium]
Does this logic prevent dynamic appending of subsequent descriptors?
Since vchan_next_desc() only fetches the first descriptor in the desc_issued
list, if this descriptor has been fully published (start_burst == nburst) but
not yet fully consumed by hardware (done_burst < nburst), it remains on the
list.
In that scenario, dw_edma_start_transfer() will repeatedly fetch this same
descriptor, find no more elements to add, and return. This would completely
ignore any subsequent pending descriptors until the first one is completed
and removed, defeating the pipelining design of appending multiple
descriptors to the LL ring concurrently.
> if (!vd)
> return 0;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=18
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 19/24] dmaengine: dw-edma: Drain LL entries for STOP and PAUSE
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (17 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 18/24] dmaengine: dw-edma: Make the LL ring reset a full channel resync Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:30 ` sashiko-bot
2026-07-27 17:03 ` [PATCH v3 20/24] dmaengine: dw-edma: Dynamically append requests while running Koichiro Den
` (4 subsequent siblings)
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
An EDMA_REQ_STOP or EDMA_REQ_PAUSE can arrive while hardware still owns
published LL entries. Keep the request pending until hardware consumes
them instead of discarding the ring state immediately.
With the eDMA-compatible interrupt interface, a DONE interrupt can
report progress rather than a stop, and STOPPED status may still be
visible while a doorbell-triggered start takes effect. Before kicking
the remaining entries, serialize the stopped-state and
zero-transfer-size checks, the DMA_LLP sample and the interrupt-status
clear against IRQ capture. Consume that boundary without refilling so
the producer boundary stays fixed and the kick path cannot clear its
DONE status before accounting for the stop.
If the channel has already stopped when the request arrives, complete
the request once the stopped boundary consumes all published entries.
Otherwise, kick only the entries published before the request. If status
still reports the channel running, arm one delayed recheck to catch a
later stop at a CB mismatch. Native HDMA reports STOP separately; non-LL
completion and EDMA_ST_PAUSE also identify a stopped channel.
If an ABORT is pending, leave cleanup to its handler and do not ring
another doorbell. Once EDMA_REQ_STOP completes, terminate submitted and
issued descriptors without callbacks. EDMA_REQ_PAUSE leaves the channel
stopped for resume.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Rework and rename v2's "Reset LL state after terminate and abort":
move abnormal-path ring reset to the circular-ring patch and drain
published entries before completing EDMA_REQ_STOP or EDMA_REQ_PAUSE.
(Frank, Sashiko)
- Preserve an IRQ-captured LL event across request changes and leave
terminal cleanup to a pending ABORT. (Sashiko)
- Reconcile a stopped boundary not yet captured by the IRQ path before
kicking a request drain.
- Use the common kick helper for normal and request-drain paths.
- Continue waiting after the five-second warning in
device_synchronize(). (Sashiko)
- Arm one delayed stop recheck while draining EDMA_REQ_STOP or
EDMA_REQ_PAUSE. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 111 +++++++++++++++++++++--------
1 file changed, 81 insertions(+), 30 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 0c30c0f51fea..bbd417e98a9d 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -460,6 +460,13 @@ static void dw_edma_finish_termination(struct dw_edma_chan *chan)
chan->status = EDMA_ST_IDLE;
}
+/* Must be called with vc.lock held after the channel has stopped. */
+static void dw_edma_finish_pause(struct dw_edma_chan *chan)
+{
+ dw_edma_set_request(chan, EDMA_REQ_NONE);
+ chan->status = EDMA_ST_PAUSE;
+}
+
/* Must be called with vc.lock held. */
static bool dw_edma_ll_clean_pending(struct dw_edma_chan *chan, int idx)
{
@@ -691,8 +698,9 @@ static void dw_edma_core_ch_kick(struct dw_edma_chan *chan)
*/
static bool dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
{
- if (chan->non_ll || chan->request != EDMA_REQ_NONE ||
- chan->status != EDMA_ST_BUSY || !dw_edma_ll_pending(chan) ||
+ if (chan->non_ll ||
+ chan->status != EDMA_ST_BUSY ||
+ !dw_edma_ll_pending(chan) ||
dw_edma_abort_is_pending(chan))
return false;
@@ -703,9 +711,25 @@ static bool dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
if (dw_edma_core_ch_status(chan) == DMA_IN_PROGRESS)
return true;
- dw_edma_ll_reconcile_and_refill(chan);
- if (!dw_edma_ll_pending(chan))
- return false;
+ /*
+ * Normal work may refill a stopped tail. STOP and PAUSE freeze the
+ * producer boundary, so only kick entries published before the request.
+ */
+ if (chan->request == EDMA_REQ_NONE) {
+ dw_edma_ll_reconcile_and_refill(chan);
+ if (!dw_edma_ll_pending(chan))
+ return false;
+ } else {
+ dw_edma_ll_reconcile_stopped(chan);
+ if (!dw_edma_ll_pending(chan)) {
+ if (chan->request == EDMA_REQ_STOP)
+ dw_edma_finish_termination(chan);
+ else
+ dw_edma_finish_pause(chan);
+
+ return false;
+ }
+ }
dw_edma_core_ch_kick(chan);
@@ -748,8 +772,7 @@ static void dw_edma_ll_recheck_work(struct work_struct *work)
}
chan->ll_recheck_at = 0;
- if (chan->request == EDMA_REQ_NONE)
- dw_edma_core_ch_maybe_doorbell(chan);
+ dw_edma_core_ch_maybe_doorbell(chan);
}
static void dw_edma_device_caps(struct dma_chan *dchan,
@@ -841,6 +864,16 @@ dw_edma_device_get_config(struct dma_chan *dchan,
return &chan->config;
}
+/* Must be called with vc.lock held. */
+static void dw_edma_request_pause(struct dw_edma_chan *chan)
+{
+ dw_edma_set_request(chan, EDMA_REQ_PAUSE);
+ if (!chan->non_ll && !dw_edma_ll_pending(chan))
+ dw_edma_finish_pause(chan);
+ else
+ dw_edma_core_ch_maybe_doorbell_or_recheck(chan);
+}
+
static int dw_edma_device_pause(struct dma_chan *dchan)
{
struct dw_edma_chan *chan = dchan2dw_edma_chan(dchan);
@@ -855,7 +888,7 @@ static int dw_edma_device_pause(struct dma_chan *dchan)
else if (chan->request != EDMA_REQ_NONE)
err = -EPERM;
else
- dw_edma_set_request(chan, EDMA_REQ_PAUSE);
+ dw_edma_request_pause(chan);
return err;
}
@@ -883,35 +916,52 @@ static int dw_edma_device_resume(struct dma_chan *dchan)
return err;
}
+/* Must be called with vc.lock held. */
+static bool dw_edma_may_be_active(struct dw_edma_chan *chan)
+{
+ if (chan->non_ll)
+ return dw_edma_core_ch_status(chan) == DMA_IN_PROGRESS;
+
+ if (!dw_edma_ll_pending(chan))
+ return false;
+
+ /*
+ * eDMA can report STOPPED while a doorbell-triggered start is
+ * still pending. Native HDMA has a dedicated STOP event.
+ */
+ return !dw_edma_ll_has_hdma_stop_event(chan) ||
+ dw_edma_core_ch_status(chan) == DMA_IN_PROGRESS;
+}
+
static int dw_edma_device_terminate_all(struct dma_chan *dchan)
{
struct dw_edma_chan *chan = dchan2dw_edma_chan(dchan);
- int err = 0;
guard(spinlock_irqsave)(&chan->vc.lock);
if (!chan->configured) {
dw_edma_terminate_all_descs(chan);
+ chan->request = EDMA_REQ_NONE;
} else if (chan->status == EDMA_ST_PAUSE) {
+ /* A paused channel has already stopped. */
dw_edma_finish_termination(chan);
- } else if (chan->status == EDMA_ST_IDLE) {
- dw_edma_finish_termination(chan);
- } else if (dw_edma_core_ch_status(chan) == DMA_COMPLETE) {
+ } else if (dw_edma_may_be_active(chan)) {
/*
- * The channel is in a false BUSY state, probably didn't
- * receive or lost an interrupt
+ * Keep published entries intact until an IRQ sample confirms
+ * that the channel stopped. An outstanding EDMA_REQ_PAUSE is
+ * replaced by EDMA_REQ_STOP.
*/
- dw_edma_finish_termination(chan);
- } else if (chan->request > EDMA_REQ_PAUSE) {
- err = -EPERM;
- } else {
dw_edma_set_request(chan, EDMA_REQ_STOP);
+ dw_edma_core_ch_maybe_doorbell_or_recheck(chan);
+ } else {
+ /*
+ * No LL entry is hardware-owned, or non-LL status confirms that
+ * the one programmed burst is not running.
+ */
+ dw_edma_finish_termination(chan);
}
- if (chan->status == EDMA_ST_IDLE &&
- !dw_edma_abort_is_pending(chan))
- dw_edma_set_request(chan, EDMA_REQ_NONE);
- return err;
+ return 0;
}
static void dw_edma_device_issue_pending(struct dma_chan *dchan)
@@ -1252,8 +1302,7 @@ static void dw_edma_done_interrupt(struct dw_edma_chan *chan)
}
if (chan->request == EDMA_REQ_PAUSE) {
- dw_edma_set_request(chan, EDMA_REQ_NONE);
- chan->status = EDMA_ST_PAUSE;
+ dw_edma_finish_pause(chan);
break;
}
@@ -1296,8 +1345,7 @@ static void dw_edma_ll_interrupt(struct dw_edma_chan *chan)
break;
case EDMA_REQ_PAUSE:
- dw_edma_set_request(chan, EDMA_REQ_NONE);
- chan->status = EDMA_ST_PAUSE;
+ dw_edma_finish_pause(chan);
break;
case EDMA_REQ_STOP:
@@ -1591,18 +1639,21 @@ static void dw_edma_wait_termination(struct dma_chan *dchan)
* A STOP may be deferred to a later interrupt while the channel is still
* running. Wait until that handler completes the termination.
*/
- while (time_before(jiffies, timeout)) {
+ for (;;) {
scoped_guard(spinlock_irqsave, &chan->vc.lock)
stopping = chan->request == EDMA_REQ_STOP;
if (!stopping)
return;
+ if (time_after_eq(jiffies, timeout)) {
+ dev_warn(chan->dw->chip->dev,
+ "timeout waiting for channel termination; still waiting\n");
+ timeout = jiffies + msecs_to_jiffies(5000);
+ }
+
fsleep(1000);
}
-
- dev_warn(chan->dw->chip->dev,
- "timeout waiting for channel termination\n");
}
static void dw_edma_device_synchronize(struct dma_chan *dchan)
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 19/24] dmaengine: dw-edma: Drain LL entries for STOP and PAUSE
2026-07-27 17:03 ` [PATCH v3 19/24] dmaengine: dw-edma: Drain LL entries for STOP and PAUSE Koichiro Den
@ 2026-07-27 17:30 ` sashiko-bot
0 siblings, 0 replies; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:30 UTC (permalink / raw)
To: Koichiro Den; +Cc: Frank.Li, dmaengine, vkoul
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The delayed stop recheck is not armed when draining a stopped channel, leading to an infinite hang in dw_edma_wait_termination().
--
--- Patch [19]: [PATCH v3 19/24] dmaengine: dw-edma: Drain LL entries for STOP and PAUSE ---
commit 2379a4182966c17e3764b5d21a024f5b0063f553
Author: Koichiro Den <den@valinux.co.jp>
dmaengine: dw-edma: Drain LL entries for STOP and PAUSE
This commit modifies the handling of STOP and PAUSE requests to drain
published LL entries instead of discarding ring state immediately. It waits
for hardware to consume them and uses a delayed recheck to catch a later
stop.
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index 0c30c0f51fea2..bbd417e98a9d7 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
> @@ -883,35 +916,52 @@ static int dw_edma_device_resume(struct dma_chan *dchan)
[ ... ]
> static int dw_edma_device_terminate_all(struct dma_chan *dchan)
> {
> struct dw_edma_chan *chan = dchan2dw_edma_chan(dchan);
> - int err = 0;
>
> guard(spinlock_irqsave)(&chan->vc.lock);
>
> if (!chan->configured) {
> dw_edma_terminate_all_descs(chan);
> + chan->request = EDMA_REQ_NONE;
> } else if (chan->status == EDMA_ST_PAUSE) {
> + /* A paused channel has already stopped. */
> dw_edma_finish_termination(chan);
> - } else if (chan->status == EDMA_ST_IDLE) {
> - dw_edma_finish_termination(chan);
> - } else if (dw_edma_core_ch_status(chan) == DMA_COMPLETE) {
> + } else if (dw_edma_may_be_active(chan)) {
> /*
> - * The channel is in a false BUSY state, probably didn't
> - * receive or lost an interrupt
> + * Keep published entries intact until an IRQ sample confirms
> + * that the channel stopped. An outstanding EDMA_REQ_PAUSE is
> + * replaced by EDMA_REQ_STOP.
> */
> - dw_edma_finish_termination(chan);
> - } else if (chan->request > EDMA_REQ_PAUSE) {
> - err = -EPERM;
> - } else {
> dw_edma_set_request(chan, EDMA_REQ_STOP);
> + dw_edma_core_ch_maybe_doorbell_or_recheck(chan);
[Severity: High]
Does dw_edma_core_ch_maybe_doorbell() unconditionally return false after
kicking a stopped channel?
If dw_edma_core_ch_maybe_doorbell() returns false, it looks like
dw_edma_core_ch_maybe_doorbell_or_recheck() will fail to arm the delayed
recheck timer:
static void dw_edma_core_ch_maybe_doorbell_or_recheck(...)
{
if (dw_edma_core_ch_maybe_doorbell(chan) &&
!dw_edma_ll_has_hdma_stop_event(chan))
dw_edma_ll_recheck_schedule(chan);
}
Without an interrupt and with no recheck timer armed, could chan->request
remain EDMA_REQ_STOP indefinitely?
> }
[ ... ]
> @@ -1591,18 +1639,21 @@ static void dw_edma_wait_termination(struct dma_chan *dchan)
> * A STOP may be deferred to a later interrupt while the channel is still
> * running. Wait until that handler completes the termination.
> */
> - while (time_before(jiffies, timeout)) {
> + for (;;) {
> scoped_guard(spinlock_irqsave, &chan->vc.lock)
> stopping = chan->request == EDMA_REQ_STOP;
>
> if (!stopping)
> return;
>
> + if (time_after_eq(jiffies, timeout)) {
> + dev_warn(chan->dw->chip->dev,
> + "timeout waiting for channel termination; still waiting\n");
> + timeout = jiffies + msecs_to_jiffies(5000);
> + }
> +
> fsleep(1000);
> }
[Severity: High]
If the channel remains stuck in EDMA_REQ_STOP due to the missing recheck
timer, will a task calling dmaengine_terminate_sync() or
dmaengine_synchronize() hang indefinitely in this loop?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=19
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 20/24] dmaengine: dw-edma: Dynamically append requests while running
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (18 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 19/24] dmaengine: dw-edma: Drain LL entries for STOP and PAUSE Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 21/24] dmaengine: dw-edma: Add engine reset and enable operations Koichiro Den
` (3 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
From: Frank Li <Frank.Li@nxp.com>
Publish issued descriptors into free LL entries while the channel runs.
Skip descriptors already fully published and continue with later ones.
For LL channels, dw_edma_start_transfer() reports only whether this pass
published entries. Derive BUSY or IDLE from pending ring work instead.
Let issue_pending() feed a BUSY LL channel when neither EDMA_REQ_STOP
nor EDMA_REQ_PAUSE is pending; non-LL channels remain IDLE-only.
All kicks still use the common doorbell path, so running channels
continue without another kick and stopped channels use the
reconciliation and restart paths.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Co-developed-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Adapt start and append paths to serialized ABORT handling. (Sashiko)
- Move recovery gating to the later recovery-infrastructure patch.
drivers/dma/dw-edma/dw-edma-core.c | 53 ++++++++++++++++++------------
1 file changed, 32 insertions(+), 21 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index bbd417e98a9d..98b8732a6cb0 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -382,35 +382,42 @@ static int dw_edma_start_transfer(struct dw_edma_chan *chan)
{
struct dw_edma_desc *desc;
struct virt_dma_desc *vd;
+ int ret = 0;
- if (!chan->non_ll) {
- if (dw_edma_abort_is_pending(chan))
+ if (chan->non_ll) {
+ vd = vchan_next_desc(&chan->vc);
+ if (!vd)
return 0;
- if (!chan->ll_valid)
- dw_edma_core_reset_ll(chan);
- }
-
- vd = vchan_next_desc(&chan->vc);
- if (!vd)
- return 0;
- desc = vd2dw_edma_desc(vd);
- if (!desc)
- return 0;
-
- if (chan->non_ll) {
guard(raw_spinlock_irqsave)(dw_edma_event_lock(chan));
if (dw_edma_abort_latch_locked(chan))
return 0;
- dw_edma_core_start(desc);
+ dw_edma_core_start(vd2dw_edma_desc(vd));
return 1;
}
- dw_edma_core_start(desc);
+ if (dw_edma_abort_is_pending(chan))
+ return 0;
- return 1;
+ if (!chan->ll_valid)
+ dw_edma_core_reset_ll(chan);
+
+ list_for_each_entry(vd, &chan->vc.desc_issued, node) {
+ if (!dw_edma_core_get_free_num(chan))
+ break;
+
+ desc = vd2dw_edma_desc(vd);
+ /* A fully published descriptor may still be pending in hardware. */
+ if (desc->start_burst == desc->nburst)
+ continue;
+
+ dw_edma_core_start(desc);
+ ret = 1;
+ }
+
+ return ret;
}
static void dw_edma_terminate_vdesc(struct virt_dma_desc *vd)
@@ -896,6 +903,7 @@ static int dw_edma_device_pause(struct dma_chan *dchan)
static int dw_edma_device_resume(struct dma_chan *dchan)
{
struct dw_edma_chan *chan = dchan2dw_edma_chan(dchan);
+ bool active;
int err = 0;
guard(spinlock_irqsave)(&chan->vc.lock);
@@ -907,9 +915,10 @@ static int dw_edma_device_resume(struct dma_chan *dchan)
} else if (chan->request != EDMA_REQ_NONE) {
err = -EPERM;
} else {
- chan->status = EDMA_ST_BUSY;
- if (!dw_edma_start_transfer(chan))
- chan->status = EDMA_ST_IDLE;
+ active = dw_edma_start_transfer(chan);
+ if (!chan->non_ll)
+ active = dw_edma_ll_pending(chan);
+ chan->status = active ? EDMA_ST_BUSY : EDMA_ST_IDLE;
dw_edma_core_ch_maybe_doorbell_or_recheck(chan);
}
@@ -970,9 +979,11 @@ static void dw_edma_device_issue_pending(struct dma_chan *dchan)
unsigned long flags;
spin_lock_irqsave(&chan->vc.lock, flags);
+ /* Only LL channels can accept work while already running. */
if (chan->configured && vchan_issue_pending(&chan->vc) &&
chan->request == EDMA_REQ_NONE &&
- chan->status == EDMA_ST_IDLE) {
+ (chan->non_ll ? chan->status == EDMA_ST_IDLE :
+ chan->status != EDMA_ST_PAUSE)) {
if (!chan->non_ll && !dw_edma_ll_pending(chan))
dw_edma_ll_snapshot_discard(chan);
chan->status = EDMA_ST_BUSY;
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 21/24] dmaengine: dw-edma: Add engine reset and enable operations
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (19 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 20/24] dmaengine: dw-edma: Dynamically append requests while running Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 22/24] dmaengine: dw-edma: Add engine recovery infrastructure Koichiro Den
` (2 subsequent siblings)
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
Direction recovery must keep the engine disabled while all exposed LL
channel contexts are rebuilt.
Add separate engine_reset and engine_enable operations. For eDMA, reset
clears ENGINE_EN, waits for it to read back zero, then clears latched
DONE and ABORT status. If ENGINE_EN does not clear, dump the state and
do not try to enable it again. A separate enable operation lets the
caller rebuild channel contexts first.
Enable the direction after channel context programming. Reject reset and
keep enable a no-op in HDMA compatibility mode, which does not expose
ENGINE_EN.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Reject engine reset in HDMA compatibility mode instead of accessing
its unavailable ENGINE_EN register. (Sashiko)
- Clarify that recovery must rebuild every exposed LL context before
re-enabling a reset direction.
drivers/dma/dw-edma/dw-edma-core.h | 5 ++
drivers/dma/dw-edma/dw-edma-v0-core.c | 67 ++++++++++++++++++++++++++-
2 files changed, 70 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index f56885747e57..46962a9bb4a6 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -211,6 +211,9 @@ struct dw_edma_core_ops {
int (*ll_cur_idx)(struct dw_edma_chan *chan);
/* Called with the event scope locked. */
void (*ll_irq_clear)(struct dw_edma_chan *chan);
+ /* Reset one direction, clear its IRQ status, and leave it disabled. */
+ bool (*engine_reset)(struct dw_edma *dw, enum dw_edma_dir dir);
+ void (*engine_enable)(struct dw_edma *dw, enum dw_edma_dir dir);
/* Called with the event scope locked for an LL channel. */
void (*ch_doorbell)(struct dw_edma_chan *chan);
void (*ch_enable)(struct dw_edma_chan *chan);
@@ -375,6 +378,8 @@ static inline void dw_edma_core_ch_doorbell(struct dw_edma_chan *chan)
static inline void dw_edma_core_ch_enable(struct dw_edma_chan *chan)
{
chan->dw->core->ch_enable(chan);
+ if (chan->dw->core->engine_enable)
+ chan->dw->core->engine_enable(chan->dw, chan->dir);
}
static inline
diff --git a/drivers/dma/dw-edma/dw-edma-v0-core.c b/drivers/dma/dw-edma/dw-edma-v0-core.c
index 5efeaaaa404e..08d67b4d677e 100644
--- a/drivers/dma/dw-edma/dw-edma-v0-core.c
+++ b/drivers/dma/dw-edma/dw-edma-v0-core.c
@@ -220,6 +220,69 @@ static int dw_edma_v0_core_engine_disable(struct dw_edma *dw,
return ret;
}
+static void dw_edma_v0_core_engine_dump(struct dw_edma *dw,
+ enum dw_edma_dir dir)
+{
+ u16 cnt = dir == EDMA_DIR_WRITE ? dw->wr_ch_cnt : dw->rd_ch_cnt;
+ u16 i;
+
+ dev_warn(dw->chip->dev, "%s engine: int_status 0x%08x err_status 0x%08x\n",
+ dir == EDMA_DIR_WRITE ? "wr" : "rd",
+ GET_RW_32(dw, dir, int_status),
+ dir == EDMA_DIR_WRITE ? GET_32(dw, wr_err_status) :
+ GET_32(dw, rd_err_status.lsb));
+ for (i = 0; i < cnt; i++)
+ dev_warn(dw->chip->dev,
+ " ch%u: ch_control1 0x%08x transfer_size 0x%08x llp.lsb 0x%08x\n",
+ i, GET_CH_32(dw, dir, i, ch_control1),
+ GET_CH_32(dw, dir, i, transfer_size),
+ GET_CH_32(dw, dir, i, llp.lsb));
+}
+
+static bool dw_edma_v0_core_engine_reset(struct dw_edma *dw,
+ enum dw_edma_dir dir)
+{
+ /* HDMA compatibility mode does not implement ENGINE_EN. */
+ if (dw->chip->mf == EDMA_MF_HDMA_COMPAT)
+ return false;
+
+ /*
+ * The databook says clearing ENGINE_EN resets the DMA logic while
+ * preserving configuration registers, but does not document drain
+ * semantics. On the tested integration, ENGINE_EN read back as zero
+ * only after outstanding transactions appeared to drain; the stalled
+ * channel then resumed after reset.
+ *
+ * If ENGINE_EN does not clear, do not re-enable the engine. On the
+ * tested integration, re-enabling after such a timeout wedged the
+ * controller and also blocked inbound BAR accesses. Return failure so
+ * the caller can keep channels gated and retry.
+ */
+ if (dw_edma_v0_core_engine_disable(dw, dir)) {
+ dw_edma_v0_core_engine_dump(dw, dir);
+ return false;
+ }
+
+ /* Discard interrupt status belonging to the contexts being reset. */
+ SET_RW_32(dw, dir, int_clear,
+ EDMA_V0_DONE_INT_MASK | EDMA_V0_ABORT_INT_MASK);
+ GET_RW_32(dw, dir, int_status);
+
+ return true;
+}
+
+/*
+ * Re-enabling can resume a previously running channel from preserved
+ * internal state without a doorbell, so the caller must rebuild every
+ * channel context first.
+ */
+static void dw_edma_v0_core_engine_enable(struct dw_edma *dw,
+ enum dw_edma_dir dir)
+{
+ if (dw->chip->mf != EDMA_MF_HDMA_COMPAT)
+ SET_RW_32(dw, dir, engine_en, BIT(0));
+}
+
static int dw_edma_v0_core_dir_off(struct dw_edma *dw, enum dw_edma_dir dir)
{
u16 count, id;
@@ -458,8 +521,6 @@ static void dw_edma_v0_core_ch_enable(struct dw_edma_chan *chan)
unsigned long flags;
u32 tmp;
- /* Enable engine */
- SET_RW_32(dw, chan->dir, engine_en, BIT(0));
if (dw->chip->mf == EDMA_MF_HDMA_COMPAT)
dw_edma_v0_core_ch_power(dw, chan->dir, chan->id, true);
/* Interrupt mask/unmask - done, abort */
@@ -686,6 +747,8 @@ static const struct dw_edma_core_ops dw_edma_v0_core = {
.ll_clear = dw_edma_v0_core_ll_clear,
.ll_cur_idx = dw_edma_v0_core_ll_cur_idx,
.ll_irq_clear = dw_edma_v0_core_clear_done_int,
+ .engine_reset = dw_edma_v0_core_engine_reset,
+ .engine_enable = dw_edma_v0_core_engine_enable,
.ch_doorbell = dw_edma_v0_core_ch_doorbell,
.ch_enable = dw_edma_v0_core_ch_enable,
.ch_config = dw_edma_v0_core_ch_config,
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 22/24] dmaengine: dw-edma: Add engine recovery infrastructure
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (20 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 21/24] dmaengine: dw-edma: Add engine reset and enable operations Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:03 ` [PATCH v3 23/24] dmaengine: dw-edma: Detect and recover a stalled eDMA engine Koichiro Den
2026-07-27 17:03 ` [PATCH v3 24/24] dmaengine: dw-edma: Add trace support Koichiro Den
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
For eDMA, resetting one direction affects every channel in it. Add a
worker to coordinate that recovery.
Gate publication and doorbells, and prevent channel setup from
re-enabling the direction during recovery. Wait for active LL channels
to stop. If a transfer is still active, compare two transfer-size
samples. Retry when it is moving; treat an unchanged value as frozen.
For a frozen direction, drain IRQ handling so pending ABORT cleanup can
finish. If recovery is still needed, reset the direction, rebuild every
exposed LL context while it remains disabled, publish remote LL writes,
and enable it again. Honor EDMA_REQ_STOP and EDMA_REQ_PAUSE during the
rebuild; leave channels gated if reset keeps failing.
Providers opt in with engine_reset(), engine_enable(), and
ch_transfer_size(). No caller requests recovery until the next patch.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Drain pending IRQ and ABORT handling before and after reset.
- Complete remote LL publication before re-enabling the direction.
- Keep the direction disabled while rebuilding every exposed LL
context, including those of unconfigured channels.
- Queue every recovery request and stop recovery before hardware
teardown. (Sashiko)
- Avoid mixing scope-based lock guards with goto cleanup. (Sashiko)
- Trim recovery and teardown details from the commit message.
drivers/dma/dw-edma/dw-edma-core.c | 304 ++++++++++++++++++++++++++++-
drivers/dma/dw-edma/dw-edma-core.h | 22 ++-
2 files changed, 321 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 98b8732a6cb0..56032137a4bb 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -28,6 +28,9 @@
/* Empirically chosen progress interval. */
#define DW_EDMA_LL_PROGRESS_INTERVAL 4
#define DW_EDMA_LL_RECHECK_DELAY_MS 30
+#define DW_EDMA_ENGINE_QUIESCE_TIMEOUT_MS 250
+#define DW_EDMA_ENGINE_RESET_MAX_FAILS 5
+#define DW_EDMA_MAX_DIR_CH MAX(HDMA_MAX_WR_CH, HDMA_MAX_RD_CH)
static inline
struct dw_edma_desc *vd2dw_edma_desc(struct virt_dma_desc *vd)
@@ -186,6 +189,15 @@ dw_edma_set_request(struct dw_edma_chan *chan, enum dw_edma_request request)
chan->request = request;
}
+static void
+dw_edma_engine_recovery_queue(struct dw_edma_engine_recovery *rec)
+{
+ if (unlikely(READ_ONCE(rec->dw->teardown)))
+ return;
+
+ queue_work(rec->dw->wq, &rec->work);
+}
+
static void dw_hdma_set_callback_result(struct virt_dma_desc *vd,
enum dmaengine_tx_result result)
{
@@ -238,6 +250,7 @@ static void dw_edma_core_reset_ll(struct dw_edma_chan *chan)
chan->ll_head = 0;
chan->ll_done = 0;
+ chan->ll_recovery_pending = false;
/* Drop stale CB bits before reusing the circular LL ring. */
for (i = 0; i < chan->ll_max; i++)
dw_edma_core_ll_clear(chan, i);
@@ -398,7 +411,7 @@ static int dw_edma_start_transfer(struct dw_edma_chan *chan)
return 1;
}
- if (dw_edma_abort_is_pending(chan))
+ if (chan->ll_recovering || dw_edma_abort_is_pending(chan))
return 0;
if (!chan->ll_valid)
@@ -548,8 +561,10 @@ static bool dw_edma_ll_clean_pending(struct dw_edma_chan *chan, int idx)
WARN_ON_ONCE(done);
out:
- if (advanced)
+ if (advanced) {
dw_edma_ll_recheck_cancel(chan);
+ chan->ll_recovery_pending = false;
+ }
return advanced;
}
@@ -706,6 +721,7 @@ static void dw_edma_core_ch_kick(struct dw_edma_chan *chan)
static bool dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
{
if (chan->non_ll ||
+ chan->ll_recovering ||
chan->status != EDMA_ST_BUSY ||
!dw_edma_ll_pending(chan) ||
dw_edma_abort_is_pending(chan))
@@ -782,6 +798,279 @@ static void dw_edma_ll_recheck_work(struct work_struct *work)
dw_edma_core_ch_maybe_doorbell(chan);
}
+static bool
+dw_edma_engine_recovery_needed(struct dw_edma_engine_recovery *rec)
+{
+ struct dw_edma *dw = rec->dw;
+ u16 off = rec->dir == EDMA_DIR_WRITE ? 0 : dw->wr_ch_cnt;
+ u16 cnt = rec->dir == EDMA_DIR_WRITE ? dw->wr_ch_cnt : dw->rd_ch_cnt;
+ struct dw_edma_chan *chan;
+ bool found = false;
+ bool needed;
+ u16 i;
+
+ for (i = 0; i < cnt; i++) {
+ chan = &dw->chan[off + i];
+ scoped_guard(spinlock_irqsave, &chan->vc.lock) {
+ needed = chan->ll_recovery_pending && chan->configured &&
+ !chan->non_ll &&
+ chan->status != EDMA_ST_PAUSE;
+ if (needed && chan->request == EDMA_REQ_NONE &&
+ dw_edma_ll_reconcile_and_refill(chan))
+ dw_edma_core_ch_maybe_doorbell(chan);
+ needed = needed && chan->ll_recovery_pending &&
+ dw_edma_ll_pending(chan);
+ if (!needed)
+ chan->ll_recovery_pending = false;
+ }
+ found |= needed;
+ }
+
+ return found;
+}
+
+static void
+dw_edma_engine_recovery_release(struct dw_edma_engine_recovery *rec)
+{
+ struct dw_edma *dw = rec->dw;
+ u16 off = rec->dir == EDMA_DIR_WRITE ? 0 : dw->wr_ch_cnt;
+ u16 cnt = rec->dir == EDMA_DIR_WRITE ? dw->wr_ch_cnt : dw->rd_ch_cnt;
+ struct dw_edma_chan *chan;
+ u16 i;
+
+ rec->fails = 0;
+
+ for (i = 0; i < cnt; i++) {
+ chan = &dw->chan[off + i];
+ guard(spinlock_irqsave)(&chan->vc.lock);
+ chan->ll_recovering = false;
+
+ if (!READ_ONCE(dw->teardown) &&
+ chan->configured && !chan->non_ll &&
+ chan->request == EDMA_REQ_NONE &&
+ chan->status != EDMA_ST_PAUSE) {
+ dw_edma_start_transfer(chan);
+ chan->status = dw_edma_ll_pending(chan) ?
+ EDMA_ST_BUSY : EDMA_ST_IDLE;
+ dw_edma_core_ch_maybe_doorbell(chan);
+ }
+ }
+
+ WRITE_ONCE(rec->active, false);
+}
+
+static void
+dw_edma_engine_recovery_drain_irqs(struct dw_edma_engine_recovery *rec)
+{
+ struct dw_edma *dw = rec->dw;
+ struct device *dev = dw->chip->dev;
+ u16 off = rec->dir == EDMA_DIR_WRITE ? 0 : dw->wr_ch_cnt;
+ u16 cnt = rec->dir == EDMA_DIR_WRITE ? dw->wr_ch_cnt : dw->rd_ch_cnt;
+ struct dw_edma_chan *chan;
+ u16 i;
+
+ /* Drain events observed before the engine context changes. */
+ for (i = 0; i < dw->nr_irqs; i++) {
+ if (bitmap_empty(rec->dir == EDMA_DIR_WRITE ?
+ dw->irq[i].wr_mask : dw->irq[i].rd_mask, cnt))
+ continue;
+
+ synchronize_irq(dw->chip->ops->irq_vector(dev, i));
+ }
+
+ for (i = 0; i < cnt; i++) {
+ chan = &dw->chan[off + i];
+ flush_work(&chan->irq_work);
+ }
+}
+
+static void dw_edma_engine_recovery_work(struct work_struct *work)
+{
+ struct dw_edma_engine_recovery *rec =
+ container_of(work, struct dw_edma_engine_recovery, work);
+ struct dw_edma *dw = rec->dw;
+ const char *dir_name = str_write_read(rec->dir == EDMA_DIR_WRITE);
+ u16 off = rec->dir == EDMA_DIR_WRITE ? 0 : dw->wr_ch_cnt;
+ u16 cnt = rec->dir == EDMA_DIR_WRITE ? dw->wr_ch_cnt : dw->rd_ch_cnt;
+ unsigned long timeout =
+ jiffies + msecs_to_jiffies(DW_EDMA_ENGINE_QUIESCE_TIMEOUT_MS);
+ struct dw_edma_chan *chan;
+ bool configured_ll;
+ bool busy;
+ u16 i;
+
+ /*
+ * Recovery resets a whole direction. The legacy eDMA register map does
+ * not support partial ownership, while unrolled eDMA partial ownership
+ * and delegation are direction-granular. Native HDMA permits per-channel
+ * ownership, but does not provide direction recovery operations.
+ */
+ if (unlikely(READ_ONCE(dw->teardown)))
+ return;
+
+ if (!dw_edma_engine_recovery_needed(rec)) {
+ if (READ_ONCE(rec->active))
+ dw_edma_engine_recovery_release(rec);
+ return;
+ }
+
+ WRITE_ONCE(rec->active, true);
+
+ /* Gate each channel before inspecting or resetting the direction. */
+ for (i = 0; i < cnt; i++) {
+ chan = &dw->chan[off + i];
+ guard(spinlock_irqsave)(&chan->vc.lock);
+ chan->ll_recovering = true;
+ }
+
+ /*
+ * Gated channels stop at their first unpublished element. Wait for that
+ * point before resetting; otherwise a restart could skip the remainder
+ * of an in-flight element.
+ */
+ do {
+ busy = false;
+ for (i = 0; i < cnt; i++) {
+ chan = &dw->chan[off + i];
+ scoped_guard(spinlock_irqsave, &chan->vc.lock)
+ configured_ll = chan->configured && !chan->non_ll;
+ if (configured_ll &&
+ dw_edma_core_ch_status(chan) == DMA_IN_PROGRESS)
+ busy = true;
+ }
+ if (!busy)
+ break;
+ fsleep(1000);
+ } while (time_before(jiffies, timeout));
+
+ /* Progress after queueing makes this recovery request obsolete. */
+ if (!dw_edma_engine_recovery_needed(rec)) {
+ dw_edma_engine_recovery_release(rec);
+ return;
+ }
+
+ if (busy) {
+ DECLARE_BITMAP(busy_mask, DW_EDMA_MAX_DIR_CH) = { 0 };
+ u32 tsz[DW_EDMA_MAX_DIR_CH];
+ bool moving = false;
+
+ /*
+ * A transfer_size change or a transition out of DMA_IN_PROGRESS
+ * shows movement after the first sample. Retry while producers
+ * remain gated. If neither occurs, treat the channel as frozen
+ * within one element.
+ */
+ for (i = 0; i < cnt; i++) {
+ chan = &dw->chan[off + i];
+ scoped_guard(spinlock_irqsave, &chan->vc.lock)
+ configured_ll = chan->configured && !chan->non_ll;
+ if (configured_ll &&
+ dw_edma_core_ch_status(chan) == DMA_IN_PROGRESS) {
+ __set_bit(i, busy_mask);
+ tsz[i] = dw_edma_core_ch_transfer_size(chan);
+ }
+ }
+ fsleep(1000);
+ for_each_set_bit(i, busy_mask, cnt) {
+ chan = &dw->chan[off + i];
+ if (dw_edma_core_ch_status(chan) != DMA_IN_PROGRESS ||
+ tsz[i] != dw_edma_core_ch_transfer_size(chan))
+ moving = true;
+ }
+ if (!dw_edma_engine_recovery_needed(rec)) {
+ dw_edma_engine_recovery_release(rec);
+ return;
+ }
+ if (moving) {
+ dev_warn_ratelimited(dw->chip->dev,
+ "%s engine quiesce timed out with transfers still progressing, retrying\n",
+ dir_name);
+ dw_edma_engine_recovery_queue(rec);
+ return;
+ }
+
+ dev_warn(dw->chip->dev,
+ "%s engine reset with a channel frozen mid-element\n",
+ dir_name);
+ }
+
+ if (!dw_edma_engine_recovery_needed(rec)) {
+ dw_edma_engine_recovery_release(rec);
+ return;
+ }
+
+ /*
+ * Let a terminal ABORT finish its normal channel cleanup before a
+ * direction-wide reset. It may also make recovery unnecessary.
+ */
+ dw_edma_engine_recovery_drain_irqs(rec);
+ if (!dw_edma_engine_recovery_needed(rec)) {
+ dw_edma_engine_recovery_release(rec);
+ return;
+ }
+
+ if (!dw->core->engine_reset(dw, rec->dir)) {
+ /*
+ * Keep channels gated and do not re-enable the engine unless
+ * ENGINE_EN clears.
+ */
+ if (++rec->fails >= DW_EDMA_ENGINE_RESET_MAX_FAILS) {
+ dev_err(dw->chip->dev,
+ "%s engine did not drain after %u attempts; leaving channels gated\n",
+ dir_name, rec->fails);
+ return;
+ }
+ dw_edma_engine_recovery_queue(rec);
+ return;
+ }
+
+ if (rec->fails)
+ dev_warn(dw->chip->dev, "%s engine drained after %u retries\n",
+ dir_name, rec->fails);
+
+ /* Drain an event that raced with the engine reset. */
+ dw_edma_engine_recovery_drain_irqs(rec);
+
+ /*
+ * Keep the engine disabled until every LL channel context is rebuilt.
+ * On the tested integration, re-enabling a preserved context resumed an
+ * old element without a doorbell, causing an IOMMU fault and stalling the
+ * engine again. Reset each ring so it starts from a fresh context, and
+ * complete remote LL publication before re-enabling the direction.
+ */
+ for (i = 0; i < cnt; i++) {
+ bool stop;
+
+ chan = &dw->chan[off + i];
+ guard(spinlock_irqsave)(&chan->vc.lock);
+
+ if (chan->non_ll)
+ continue;
+
+ /* Honor EDMA_REQ_STOP and EDMA_REQ_PAUSE instead of republishing. */
+ stop = chan->request == EDMA_REQ_STOP;
+ if (stop)
+ dw_edma_terminate_all_descs(chan);
+
+ dw_edma_core_reset_ll(chan);
+ dw_edma_core_ll_sync(chan);
+
+ if (stop) {
+ dw_edma_set_request(chan, EDMA_REQ_NONE);
+ chan->status = EDMA_ST_IDLE;
+ } else if (chan->request == EDMA_REQ_PAUSE) {
+ dw_edma_set_request(chan, EDMA_REQ_NONE);
+ chan->status = EDMA_ST_PAUSE;
+ }
+ }
+
+ dw->core->engine_enable(dw, rec->dir);
+ dw_edma_engine_recovery_release(rec);
+
+ dev_warn(dw->chip->dev, "%s engine was reset to recover a stalled channel\n",
+ dir_name);
+}
+
static void dw_edma_device_caps(struct dma_chan *dchan,
struct dma_slave_caps *caps)
{
@@ -1974,6 +2263,13 @@ int dw_edma_probe(struct dw_edma_chip *chip)
for (i = 0; i < ARRAY_SIZE(dw->event_lock); i++)
raw_spin_lock_init(&dw->event_lock[i]);
+ for (i = 0; i < ARRAY_SIZE(dw->eng_recovery); i++) {
+ dw->eng_recovery[i].dw = dw;
+ dw->eng_recovery[i].dir = i;
+ INIT_WORK(&dw->eng_recovery[i].work,
+ dw_edma_engine_recovery_work);
+ }
+
/*
* chip->ll_*_cnt describes the channels exposed by this instance. Keep
* the usable hardware counts separate for partial ownership checks.
@@ -2079,6 +2375,10 @@ int dw_edma_remove(struct dw_edma_chip *chip)
WRITE_ONCE(dw->teardown, true);
dma_async_device_unregister(&dw->dma);
+ /* A recovery worker can re-enable the engine. */
+ disable_work_sync(&dw->eng_recovery[0].work);
+ disable_work_sync(&dw->eng_recovery[1].work);
+
/*
* Drain channel work that may have passed the teardown gate before
* stopping the hardware. IRQ handlers remain installed while it is
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index 46962a9bb4a6..a2699a663260 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -129,6 +129,9 @@ struct dw_edma_chan {
struct delayed_work ll_recheck_work;
unsigned long ll_recheck_at;
+ /* Per-channel recovery state. */
+ bool ll_recovery_pending;
+ bool ll_recovering;
u32 ll_max; /* Data entries */
struct dw_edma_region ll_region; /* Linked list */
@@ -159,6 +162,18 @@ struct dw_edma_irq {
DECLARE_BITMAP(rd_mask, HDMA_MAX_RD_CH);
};
+/*
+ * Direction-wide recovery state. active records that recovery has gated the
+ * channels; workqueue state coalesces duplicate requests.
+ */
+struct dw_edma_engine_recovery {
+ bool active;
+ unsigned int fails;
+ struct work_struct work;
+ struct dw_edma *dw;
+ enum dw_edma_dir dir;
+};
+
struct dw_edma {
char name[32];
@@ -173,12 +188,13 @@ struct dw_edma {
struct dw_edma_chan *chan;
/*
- * WQ_HIGHPRI keeps completion processing responsive under heavy load;
- * WQ_UNBOUND lets different channels run on different CPUs.
+ * WQ_HIGHPRI keeps completion and recovery work responsive under heavy
+ * load; WQ_UNBOUND lets independent work run on different CPUs.
*/
struct workqueue_struct *wq;
bool teardown; /* Gate asynchronous hardware access */
+ struct dw_edma_engine_recovery eng_recovery[2];
raw_spinlock_t lock; /* Protect v0 shared registers */
raw_spinlock_t event_lock[2]; /* Per-direction event scopes */
@@ -378,7 +394,7 @@ static inline void dw_edma_core_ch_doorbell(struct dw_edma_chan *chan)
static inline void dw_edma_core_ch_enable(struct dw_edma_chan *chan)
{
chan->dw->core->ch_enable(chan);
- if (chan->dw->core->engine_enable)
+ if (!chan->ll_recovering && chan->dw->core->engine_enable)
chan->dw->core->engine_enable(chan->dw, chan->dir);
}
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* [PATCH v3 23/24] dmaengine: dw-edma: Detect and recover a stalled eDMA engine
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (21 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 22/24] dmaengine: dw-edma: Add engine recovery infrastructure Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
2026-07-27 17:37 ` sashiko-bot
2026-07-27 17:03 ` [PATCH v3 24/24] dmaengine: dw-edma: Add trace support Koichiro Den
23 siblings, 1 reply; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
Under sustained multi-channel traffic on one eDMA integration, a write
channel occasionally stopped with pending work, no progress, and no
error. Repeated doorbells did not restart it; clearing ENGINE_EN did.
LL progress accounting already schedules a bounded recheck when a DONE
or STOP/PAUSE drain leaves published work running. Reuse it for passive
stall detection. When a check finds the channel stopped, run the normal
restart or drain path, kick it, and arm one more check. If it is still
stopped with no progress 30 ms later, queue direction recovery.
Queue every recovery request and let the workqueue coalesce duplicates,
so a request raised while the worker releases channels is not lost.
The condition uses only generic eDMA state: published work, STOPPED
status, and lack of progress. Providers opt in by supplying the recovery
operations; HDMA compatibility mode is excluded because it has no
ENGINE_EN. Normal progress cancels the check before recovery runs. The
30 ms threshold is empirical and should be validated on more hardware.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Reuse the bounded LL recheck for stall detection. (Sashiko)
- Queue a recovery request even while recovery is active, leaving
duplicate coalescing to the workqueue. (Sashiko)
drivers/dma/dw-edma/dw-edma-core.c | 55 ++++++++++++++++++++++++++++++
drivers/dma/dw-edma/dw-edma-core.h | 4 ++-
2 files changed, 58 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 56032137a4bb..262ea893174f 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -250,6 +250,7 @@ static void dw_edma_core_reset_ll(struct dw_edma_chan *chan)
chan->ll_head = 0;
chan->ll_done = 0;
+ chan->ll_stall_valid = false;
chan->ll_recovery_pending = false;
/* Drop stale CB bits before reusing the circular LL ring. */
for (i = 0; i < chan->ll_max; i++)
@@ -291,6 +292,54 @@ static bool dw_edma_ll_pending(struct dw_edma_chan *chan)
return chan->ll_head != chan->ll_done;
}
+static bool dw_edma_engine_recovery_supported(struct dw_edma *dw)
+{
+ /*
+ * DWC PCIe Controller Databook 6.10a-lca06, "Legacy DMA and HDMA
+ * Software Compatibility":
+ *
+ * "HDMA does not implement engine enable, that is
+ * DMA_[WRITE|READ]_ENGINE_EN_OFF.DMA_[WRITE|READ]_ENGINE field."
+ */
+ if (dw->chip->mf == EDMA_MF_HDMA_COMPAT)
+ return false;
+
+ return dw->core->engine_reset && dw->core->engine_enable &&
+ dw->core->ch_transfer_size;
+}
+
+/*
+ * Called with vc.lock held for a stopped channel with LL work pending. Queue
+ * direction recovery if repeated doorbells show no progress for one recheck
+ * interval.
+ */
+static bool dw_edma_ll_stall_check(struct dw_edma_chan *chan)
+{
+ struct dw_edma_engine_recovery *rec;
+
+ if (unlikely(READ_ONCE(chan->dw->teardown)))
+ return false;
+
+ if (!dw_edma_engine_recovery_supported(chan->dw))
+ return false;
+
+ if (!chan->ll_stall_valid) {
+ chan->ll_stall_valid = true;
+ chan->ll_stall_since = jiffies;
+ return true;
+ }
+
+ if (time_before(jiffies, chan->ll_stall_since +
+ msecs_to_jiffies(DW_EDMA_LL_RECHECK_DELAY_MS)))
+ return true;
+
+ rec = &chan->dw->eng_recovery[chan->dir];
+ chan->ll_recovery_pending = true;
+ dw_edma_engine_recovery_queue(rec);
+
+ return false;
+}
+
static u32 dw_edma_core_ch_transfer_size(struct dw_edma_chan *chan)
{
if (!chan->dw->core->ch_transfer_size)
@@ -563,6 +612,7 @@ static bool dw_edma_ll_clean_pending(struct dw_edma_chan *chan, int idx)
out:
if (advanced) {
dw_edma_ll_recheck_cancel(chan);
+ chan->ll_stall_valid = false;
chan->ll_recovery_pending = false;
}
@@ -720,6 +770,8 @@ static void dw_edma_core_ch_kick(struct dw_edma_chan *chan)
*/
static bool dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
{
+ bool recheck;
+
if (chan->non_ll ||
chan->ll_recovering ||
chan->status != EDMA_ST_BUSY ||
@@ -754,7 +806,10 @@ static bool dw_edma_core_ch_maybe_doorbell(struct dw_edma_chan *chan)
}
}
+ recheck = dw_edma_ll_stall_check(chan);
dw_edma_core_ch_kick(chan);
+ if (recheck)
+ dw_edma_ll_recheck_schedule(chan);
return false;
}
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index a2699a663260..0c9c17edd835 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -127,9 +127,11 @@ struct dw_edma_chan {
bool abort_pending;
raw_spinlock_t event_lock;
+ /* Per-channel stall and recovery state. */
struct delayed_work ll_recheck_work;
unsigned long ll_recheck_at;
- /* Per-channel recovery state. */
+ unsigned long ll_stall_since;
+ bool ll_stall_valid;
bool ll_recovery_pending;
bool ll_recovering;
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread* Re: [PATCH v3 23/24] dmaengine: dw-edma: Detect and recover a stalled eDMA engine
2026-07-27 17:03 ` [PATCH v3 23/24] dmaengine: dw-edma: Detect and recover a stalled eDMA engine Koichiro Den
@ 2026-07-27 17:37 ` sashiko-bot
0 siblings, 0 replies; 40+ messages in thread
From: sashiko-bot @ 2026-07-27 17:37 UTC (permalink / raw)
To: Koichiro Den; +Cc: vkoul, Frank.Li, dmaengine
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Unkillable hang in dw_edma_wait_termination() if the engine fails to recover from a stall.
--
--- Patch [23]: [PATCH v3 23/24] dmaengine: dw-edma: Detect and recover a stalled eDMA engine ---
commit 8c110ba5f33df8c06f35fa69ddd95a9b7e7cab52
Author: Koichiro Den <den@valinux.co.jp>
dmaengine: dw-edma: Detect and recover a stalled eDMA engine
This commit introduces passive stall detection for write channels under
sustained multi-channel traffic. It reuses the bounded LL recheck and queues a
recovery request if a channel remains stopped with no progress for 30 ms.
> diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
> index 56032137a4bb0..262ea893174f3 100644
> --- a/drivers/dma/dw-edma/dw-edma-core.c
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
[ ... ]
> @@ -291,6 +292,54 @@ static bool dw_edma_ll_pending(struct dw_edma_chan *chan)
> return chan->ll_head != chan->ll_done;
> }
>
[ ... ]
> +/*
> + * Called with vc.lock held for a stopped channel with LL work pending. Queue
> + * direction recovery if repeated doorbells show no progress for one recheck
> + * interval.
> + */
> +static bool dw_edma_ll_stall_check(struct dw_edma_chan *chan)
> +{
> + struct dw_edma_engine_recovery *rec;
> +
[ ... ]
> + rec = &chan->dw->eng_recovery[chan->dir];
> + chan->ll_recovery_pending = true;
> + dw_edma_engine_recovery_queue(rec);
[Severity: High]
If the hardware stalls and the recovery work queued here fails to reset it,
can this lead to an unkillable hang later when the channel is freed?
Looking at dw_edma_engine_recovery_work(), if the maximum reset attempts are
reached, the worker exits without clearing chan->ll_recovering:
drivers/dma/dw-edma/dw-edma-core.c:dw_edma_engine_recovery_work() {
...
if (++rec->fails >= DW_EDMA_ENGINE_RESET_MAX_FAILS) {
dev_err(dw->chip->dev,
"%s engine did not drain after %u attempts; leaving channels gated\n",
dir_name, rec->fails);
return;
}
...
}
If chan->ll_recovering remains true, the doorbell logic aborts early and does
not process the stop request when releasing the channel.
This causes dw_edma_wait_termination() to loop indefinitely because the loop
lacks a hard timeout break and the stop request is never cleared:
drivers/dma/dw-edma/dw-edma-core.c:dw_edma_wait_termination() {
...
for (;;) {
scoped_guard(spinlock_irqsave, &chan->vc.lock)
stopping = chan->request == EDMA_REQ_STOP;
if (!stopping)
return;
if (time_after_eq(jiffies, timeout)) {
dev_warn(chan->dw->chip->dev,
"timeout waiting for channel termination; still waiting\n");
timeout = jiffies + msecs_to_jiffies(5000);
}
fsleep(1000);
}
...
}
Could this result in an unkillable process hang when dw_edma_wait_termination()
polls indefinitely?
> +
> + return false;
> +}
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727170323.2321369-1-den@valinux.co.jp?part=23
^ permalink raw reply [flat|nested] 40+ messages in thread
* [PATCH v3 24/24] dmaengine: dw-edma: Add trace support
2026-07-27 17:02 [PATCH v3 00/24] dmaengine: dw-edma: Support dynamic LL appends Koichiro Den
` (22 preceding siblings ...)
2026-07-27 17:03 ` [PATCH v3 23/24] dmaengine: dw-edma: Detect and recover a stalled eDMA engine Koichiro Den
@ 2026-07-27 17:03 ` Koichiro Den
23 siblings, 0 replies; 40+ messages in thread
From: Koichiro Den @ 2026-07-27 17:03 UTC (permalink / raw)
To: Manivannan Sadhasivam, Vinod Koul, Frank Li, Gustavo Pimentel,
Kees Cook, Krzysztof Wilczyński, Kishon Vijay Abraham I,
Bjorn Helgaas, Christoph Hellwig, Serge Semin, Cai Huoqing,
Niklas Cassel
Cc: Devendra K Verma, dmaengine, linux-kernel
From: Frank Li <Frank.Li@nxp.com>
The circular LL ring has separate producer and consumer positions. Add
tracepoints for LL publication, descriptor append and completion,
IRQ-paired LL events, and engine recovery. The LL events cover both eDMA
and HDMA.
The recovery event records configured LL channels before a direction
reset. When disabled, static keys leave only a branch at each trace
site.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Co-developed-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes in v3:
- Record the full pending-entry count in recovery traces. (Sashiko)
- Trace the recorded LL event snapshot and update recovery tracing for
the revised recovery flow. (Sashiko)
- Replace single-use event classes with direct trace events.
drivers/dma/dw-edma/Makefile | 2 +
drivers/dma/dw-edma/dw-edma-core.c | 49 ++++++++
drivers/dma/dw-edma/dw-edma-core.h | 2 +
drivers/dma/dw-edma/dw-edma-trace.c | 4 +
drivers/dma/dw-edma/dw-edma-trace.h | 169 ++++++++++++++++++++++++++++
5 files changed, 226 insertions(+)
create mode 100644 drivers/dma/dw-edma/dw-edma-trace.c
create mode 100644 drivers/dma/dw-edma/dw-edma-trace.h
diff --git a/drivers/dma/dw-edma/Makefile b/drivers/dma/dw-edma/Makefile
index 83ab58f87760..5f395fa1ede4 100644
--- a/drivers/dma/dw-edma/Makefile
+++ b/drivers/dma/dw-edma/Makefile
@@ -1,8 +1,10 @@
# SPDX-License-Identifier: GPL-2.0
+CFLAGS_dw-edma-trace.o := -I$(src)
obj-$(CONFIG_DW_EDMA) += dw-edma.o
dw-edma-$(CONFIG_DEBUG_FS) := dw-edma-v0-debugfs.o \
dw-hdma-v0-debugfs.o
+dw-edma-$(CONFIG_TRACING) += dw-edma-trace.o
dw-edma-objs := dw-edma-core.o \
dw-edma-v0-core.o \
dw-hdma-v0-core.o $(dw-edma-y)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 262ea893174f..e94557d79d4c 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -414,6 +414,12 @@ static void dw_edma_core_ll_start(struct dw_edma_desc *desc)
chan->ll_head, chan->cb,
dw_edma_core_enable_ll_irq(desc, i, free));
+ trace_edma_fill_ll(chan, chan->ll_head,
+ desc->vd.tx.cookie,
+ desc->burst[i].sar,
+ desc->burst[i].dar, desc->burst[i].sz,
+ chan->cb);
+
chan->ll_head++;
if (chan->ll_head == chan->ll_max) {
@@ -475,6 +481,7 @@ static int dw_edma_start_transfer(struct dw_edma_chan *chan)
if (desc->start_burst == desc->nburst)
continue;
+ trace_edma_append_desc(desc);
dw_edma_core_start(desc);
ret = 1;
}
@@ -604,6 +611,7 @@ static bool dw_edma_ll_clean_pending(struct dw_edma_chan *chan, int idx)
/* Hardware has consumed this descriptor's LL entries. */
dw_hdma_set_callback_result(vd, DMA_TRANS_NOERROR);
list_del(&vd->node);
+ trace_edma_complete_desc(desc);
vchan_cookie_complete(vd);
}
@@ -939,6 +947,44 @@ dw_edma_engine_recovery_drain_irqs(struct dw_edma_engine_recovery *rec)
}
}
+static void
+dw_edma_trace_engine_recovery(struct dw_edma_engine_recovery *rec)
+{
+ struct dw_edma *dw = rec->dw;
+ u16 off = rec->dir == EDMA_DIR_WRITE ? 0 : dw->wr_ch_cnt;
+ u16 cnt = rec->dir == EDMA_DIR_WRITE ? dw->wr_ch_cnt : dw->rd_ch_cnt;
+ struct dw_edma_chan *chan;
+ u16 i;
+
+ if (!trace_edma_engine_recovery_enabled())
+ return;
+
+ for (i = 0; i < cnt; i++) {
+ enum dw_edma_request request;
+ enum dw_edma_status status;
+ bool configured_ll;
+ u32 ll_head, ll_done, pending;
+
+ chan = &dw->chan[off + i];
+ scoped_guard(spinlock_irqsave, &chan->vc.lock) {
+ configured_ll = chan->configured && !chan->non_ll;
+ if (configured_ll) {
+ request = chan->request;
+ status = chan->status;
+ ll_head = chan->ll_head;
+ ll_done = chan->ll_done;
+ pending = dw_edma_core_get_used_num(chan);
+ }
+ }
+ if (!configured_ll)
+ continue;
+
+ trace_edma_engine_recovery(chan, dw_edma_core_ch_status(chan),
+ request, status, ll_head, ll_done,
+ pending);
+ }
+}
+
static void dw_edma_engine_recovery_work(struct work_struct *work)
{
struct dw_edma_engine_recovery *rec =
@@ -1064,6 +1110,8 @@ static void dw_edma_engine_recovery_work(struct work_struct *work)
return;
}
+ dw_edma_trace_engine_recovery(rec);
+
if (!dw->core->engine_reset(dw, rec->dir)) {
/*
* Keep channels gated and do not re-enable the engine unless
@@ -1683,6 +1731,7 @@ static void dw_edma_ll_interrupt(struct dw_edma_chan *chan)
if (!dw_edma_ll_snapshot_take(chan, &snapshot))
return;
+ trace_edma_irq(chan, &snapshot);
if (chan->status == EDMA_ST_PAUSE)
return;
diff --git a/drivers/dma/dw-edma/dw-edma-core.h b/drivers/dma/dw-edma/dw-edma-core.h
index 0c9c17edd835..ca0f60ad5ab5 100644
--- a/drivers/dma/dw-edma/dw-edma-core.h
+++ b/drivers/dma/dw-edma/dw-edma-core.h
@@ -206,6 +206,8 @@ struct dw_edma {
const struct dw_edma_core_ops *core;
};
+#include "dw-edma-trace.h"
+
typedef void (*dw_edma_handler_t)(struct dw_edma_chan *chan,
unsigned int events);
diff --git a/drivers/dma/dw-edma/dw-edma-trace.c b/drivers/dma/dw-edma/dw-edma-trace.c
new file mode 100644
index 000000000000..2620ad61a943
--- /dev/null
+++ b/drivers/dma/dw-edma/dw-edma-trace.c
@@ -0,0 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#define CREATE_TRACE_POINTS
+#include "dw-edma-core.h"
diff --git a/drivers/dma/dw-edma/dw-edma-trace.h b/drivers/dma/dw-edma/dw-edma-trace.h
new file mode 100644
index 000000000000..e5b3eb57df06
--- /dev/null
+++ b/drivers/dma/dw-edma/dw-edma-trace.h
@@ -0,0 +1,169 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright 2023 NXP.
+ */
+
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM dw_edma
+
+#if !defined(__LINUX_DW_EDMA_TRACE) || defined(TRACE_HEADER_MULTI_READ)
+#define __LINUX_DW_EDMA_TRACE
+
+#include <linux/types.h>
+#include <linux/tracepoint.h>
+
+DECLARE_EVENT_CLASS(edma_desc_info,
+ TP_PROTO(struct dw_edma_desc *desc),
+ TP_ARGS(desc),
+ TP_STRUCT__entry(
+ __field(size_t, nburst)
+ __field(size_t, start_burst)
+ __field(dma_cookie_t, cookie)
+ __field(u32, id)
+ __field(u8, dir)
+ ),
+ TP_fast_assign(
+ __entry->nburst = desc->nburst;
+ __entry->start_burst = desc->start_burst;
+ __entry->id = desc->chan->id;
+ __entry->dir = desc->chan->dir;
+ __entry->cookie = desc->vd.tx.cookie;
+ ),
+ TP_printk("chan %u%c desc %d nburst %zu start_burst %zu",
+ __entry->id,
+ __entry->dir ? 'R' : 'W',
+ __entry->cookie,
+ __entry->nburst,
+ __entry->start_burst)
+);
+
+DEFINE_EVENT(edma_desc_info, edma_append_desc,
+ TP_PROTO(struct dw_edma_desc *desc),
+ TP_ARGS(desc)
+);
+
+DEFINE_EVENT(edma_desc_info, edma_complete_desc,
+ TP_PROTO(struct dw_edma_desc *desc),
+ TP_ARGS(desc)
+);
+
+TRACE_EVENT(edma_irq,
+ TP_PROTO(struct dw_edma_chan *chan,
+ const struct dw_edma_ll_snapshot *snapshot),
+ TP_ARGS(chan, snapshot),
+ TP_STRUCT__entry(
+ __field(u32, head)
+ __field(u32, done)
+ __field(u32, total)
+ __field(int, index)
+ __field(int, event)
+ __field(dma_cookie_t, completed_cookie)
+ __field(dma_cookie_t, cookie)
+ __field(u32, id)
+ __field(u8, dir)
+ ),
+ TP_fast_assign(
+ __entry->head = chan->ll_head;
+ __entry->done = chan->ll_done;
+ __entry->total = chan->ll_max;
+ __entry->index = snapshot->idx;
+ __entry->event = snapshot->event;
+ __entry->completed_cookie = chan->vc.chan.completed_cookie;
+ __entry->cookie = chan->vc.chan.cookie;
+ __entry->id = chan->id;
+ __entry->dir = chan->dir;
+ ),
+ TP_printk("chan %u%c event %s head %u done %u total %u idx %d completed %d cookie %d",
+ __entry->id,
+ __entry->dir ? 'R' : 'W',
+ __entry->event == DW_EDMA_LL_EVENT_STOP ? "stop" : "progress",
+ __entry->head,
+ __entry->done,
+ __entry->total,
+ __entry->index,
+ __entry->completed_cookie,
+ __entry->cookie)
+);
+
+TRACE_EVENT(edma_engine_recovery,
+ TP_PROTO(struct dw_edma_chan *chan, enum dma_status hw_status,
+ enum dw_edma_request request, enum dw_edma_status status,
+ u32 ll_head, u32 ll_done, u32 pending),
+ TP_ARGS(chan, hw_status, request, status, ll_head, ll_done, pending),
+ TP_STRUCT__entry(
+ __field(u32, id)
+ __field(u32, head)
+ __field(u32, done)
+ __field(u32, pending)
+ __field(int, hw_status)
+ __field(int, request)
+ __field(int, status)
+ __field(u8, dir)
+ ),
+ TP_fast_assign(
+ __entry->id = chan->id;
+ __entry->dir = chan->dir;
+ __entry->hw_status = hw_status;
+ __entry->request = request;
+ __entry->status = status;
+ __entry->head = ll_head;
+ __entry->done = ll_done;
+ __entry->pending = pending;
+ ),
+ TP_printk("chan %u%c hw %d request %d status %d head %u done %u pending %u",
+ __entry->id,
+ __entry->dir ? 'R' : 'W',
+ __entry->hw_status,
+ __entry->request,
+ __entry->status,
+ __entry->head,
+ __entry->done,
+ __entry->pending)
+);
+
+TRACE_EVENT(edma_fill_ll,
+ TP_PROTO(struct dw_edma_chan *chan, u32 idx, dma_cookie_t cookie, u64 src,
+ u64 dest, u32 sz, bool flag),
+ TP_ARGS(chan, idx, cookie, src, dest, sz, flag),
+ TP_STRUCT__entry(
+ __field(u32, idx)
+ __field(u64, src)
+ __field(u64, dest)
+ __field(u32, sz)
+ __field(u32, id)
+ __field(dma_cookie_t, cookie)
+ __field(bool, flag)
+ __field(u8, dir)
+ ),
+ TP_fast_assign(
+ __entry->idx = idx;
+ __entry->src = src;
+ __entry->dest = dest;
+ __entry->sz = sz;
+ __entry->id = chan->id;
+ __entry->dir = chan->dir;
+ __entry->cookie = cookie;
+ __entry->flag = flag;
+ ),
+ TP_printk("chan %u%c %d [%u] %c src: %08llx dest: %08llx sz: %04x",
+ __entry->id,
+ __entry->dir ? 'R' : 'W',
+ __entry->cookie,
+ __entry->idx,
+ __entry->flag ? 'C' : 'c',
+ __entry->src,
+ __entry->dest,
+ __entry->sz)
+);
+
+#endif
+
+/* This part must be outside the header guard. */
+
+#undef TRACE_INCLUDE_PATH
+#define TRACE_INCLUDE_PATH .
+
+#undef TRACE_INCLUDE_FILE
+#define TRACE_INCLUDE_FILE dw-edma-trace
+
+#include <trace/define_trace.h>
--
2.51.0
^ permalink raw reply related [flat|nested] 40+ messages in thread