DMA Engine development
 help / color / mirror / Atom feed
* [PATCH] dmaengine: ste_dma40: allow COMPILE_TEST
@ 2026-09-16 22:52 Rosen Penev
  2026-09-16 23:00 ` sashiko-bot
  2026-09-17  3:17 ` Frank Li
  0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2026-09-16 22:52 UTC (permalink / raw)
  To: dmaengine; +Cc: Vinod Koul, Frank Li, open list

The driver only uses portable kernel APIs and AMBA bit-field macros from
<linux/amba/bus.h>. Allow building on other architectures via
COMPILE_TEST for wider compile coverage.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index ae6a682c9f76..f16bd4059d84 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -559,7 +559,7 @@ config SOPHGO_CV1800B_DMAMUX
 
 config STE_DMA40
 	bool "ST-Ericsson DMA40 support"
-	depends on ARCH_U8500
+	depends on ARCH_U8500 || COMPILE_TEST
 	select DMA_ENGINE
 	select SRAM
 	help
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dmaengine: ste_dma40: allow COMPILE_TEST
  2026-09-16 22:52 [PATCH] dmaengine: ste_dma40: allow COMPILE_TEST Rosen Penev
@ 2026-09-16 23:00 ` sashiko-bot
  2026-09-17  3:17 ` Frank Li
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-09-16 23:00 UTC (permalink / raw)
  To: Rosen Penev; +Cc: Frank.Li, dmaengine, vkoul

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: STE_DMA40 missing HAS_IOMEM dependency for COMPILE_TEST
--

commit f5b43b7cb15b71f44f87940150c9d52817cad404
Author: Rosen Penev <rosenp@gmail.com>

dmaengine: ste_dma40: allow COMPILE_TEST

This commit loosens the Kconfig dependencies for STE_DMA40 to allow building
on other architectures via COMPILE_TEST. It aims to increase compile coverage
by exposing the driver to more build configurations.

> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index ae6a682c9f769..f16bd4059d84a 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -559,7 +559,7 @@ config SOPHGO_CV1800B_DMAMUX
>  
>  config STE_DMA40
>  	bool "ST-Ericsson DMA40 support"
> -	depends on ARCH_U8500
> +	depends on ARCH_U8500 || COMPILE_TEST
>  	select DMA_ENGINE
>  	select SRAM

[Severity: Low]
Does this also need a dependency on HAS_IOMEM?

By allowing COMPILE_TEST in drivers/dma/Kconfig for STE_DMA40 and keeping the
select for SRAM, architectures without HAS_IOMEM (like User-Mode Linux or
some s390 configurations) will trigger unmet dependency build warnings for
SRAM when COMPILE_TEST is enabled.

This can also lead to compilation failures on those architectures due to
missing I/O memory accessors like readl or writel that SRAM might depend on.

Could this be resolved by making STE_DMA40 depend on HAS_IOMEM?

>  	help

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916225241.280606-1-rosenp@gmail.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dmaengine: ste_dma40: allow COMPILE_TEST
  2026-09-16 22:52 [PATCH] dmaengine: ste_dma40: allow COMPILE_TEST Rosen Penev
  2026-09-16 23:00 ` sashiko-bot
@ 2026-09-17  3:17 ` Frank Li
  1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2026-09-17  3:17 UTC (permalink / raw)
  To: Rosen Penev; +Cc: dmaengine, Vinod Koul, Frank Li, open list

On Wed, Sep 16, 2026 at 03:52:41PM -0700, Rosen Penev wrote:
> The driver only uses portable kernel APIs and AMBA bit-field macros from
> <linux/amba/bus.h>. Allow building on other architectures via
> COMPILE_TEST for wider compile coverage.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index ae6a682c9f76..f16bd4059d84 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -559,7 +559,7 @@ config SOPHGO_CV1800B_DMAMUX
>
>  config STE_DMA40
>  	bool "ST-Ericsson DMA40 support"
> -	depends on ARCH_U8500
> +	depends on ARCH_U8500 || COMPILE_TEST
>  	select DMA_ENGINE
>  	select SRAM
>  	help
> --
> 2.55.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-17  3:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-16 22:52 [PATCH] dmaengine: ste_dma40: allow COMPILE_TEST Rosen Penev
2026-09-16 23:00 ` sashiko-bot
2026-09-17  3:17 ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox