From: Linus Walleij <linusw@kernel.org>
To: Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>
Cc: dmaengine@vger.kernel.org, phone-devel@vger.kernel.org,
Linus Walleij <linusw@kernel.org>,
sashiko-bot@kernel.org
Subject: [PATCH v4 21/23] dmaengine: ste_dma40: Search all blocks for fixed logical channels
Date: Sun, 20 Sep 2026 00:22:32 +0200 [thread overview]
Message-ID: <20260920-dma40-fixes-v4-21-d751b2d9c23f@kernel.org> (raw)
In-Reply-To: <20260920-dma40-fixes-v4-0-d751b2d9c23f@kernel.org>
Fixed logical channel allocation scans physical channels in blocks of
eight. When the requested physical channel does not belong to the first
block, d40_allocate_channel() returns -EINVAL instead of checking later
blocks.
Skip nonmatching blocks so controllers with more than eight physical
channels can allocate fixed logical channels from the later blocks.
Fixes: 5cd326fd27da ("dmaengine/ste_dma40: allow fixed physical channel")
Reported-by: sashiko-bot@kernel.org
Closes: https://lore.kernel.org/dmaengine/20260819225008.5F9651F000E9@smtp.kernel.org/
Assisted-by: LLM
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
drivers/dma/ste_dma40.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 1738a37da682..d68828acb186 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -2077,11 +2077,8 @@ static int d40_allocate_channel(struct d40_chan *d40c, bool *first_phy_user)
if (d40c->dma_cfg.use_fixed_channel) {
i = d40c->dma_cfg.phy_channel;
- if ((i != phy_num) && (i != phy_num + 1)) {
- dev_err(chan2dev(d40c),
- "invalid fixed phy channel %d\n", i);
- return -EINVAL;
- }
+ if (i != phy_num && i != phy_num + 1)
+ continue;
if (d40_alloc_mask_set(&phys[i], is_src, event_line,
is_log, first_phy_user))
--
2.55.0
next prev parent reply other threads:[~2026-09-19 22:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 22:22 [PATCH v4 00/23] dmaengine: ste_dma40: Fix numerous accumulated bugs Linus Walleij
2026-09-19 22:22 ` [PATCH v4 01/23] dmaengine: ste_dma40: Fix physical cyclic capability Linus Walleij
2026-09-19 22:22 ` [PATCH v4 02/23] dmaengine: ste_dma40: Fix cyclic transfer residue Linus Walleij
2026-09-19 22:22 ` [PATCH v4 03/23] dmaengine: ste_dma40: Recover coalesced cyclic callbacks Linus Walleij
2026-09-19 22:37 ` sashiko-bot
2026-09-19 22:22 ` [PATCH v4 04/23] dmaengine: ste_dma40: Fix failed start cleanup Linus Walleij
2026-09-19 22:22 ` [PATCH v4 05/23] dmaengine: ste_dma40: Fix probe runtime PM disable Linus Walleij
2026-09-19 22:22 ` [PATCH v4 06/23] dmaengine: ste_dma40: Check runtime PM in IRQ Linus Walleij
2026-09-19 22:22 ` [PATCH v4 07/23] dmaengine: ste_dma40: Handle runtime PM resume errors Linus Walleij
2026-09-19 22:22 ` [PATCH v4 08/23] dmaengine: ste_dma40: Return IRQ_NONE without interrupt status Linus Walleij
2026-09-19 22:36 ` sashiko-bot
2026-09-19 22:22 ` [PATCH v4 09/23] dmaengine: ste_dma40: Init hardware before registration Linus Walleij
2026-09-19 22:22 ` [PATCH v4 10/23] dmaengine: ste_dma40: Fix probe IRQ leak Linus Walleij
2026-09-19 22:22 ` [PATCH v4 11/23] dmaengine: ste_dma40: Fix DMA registration unwind Linus Walleij
2026-09-19 22:22 ` [PATCH v4 12/23] dmaengine: ste_dma40: Fix LCLA allocation order Linus Walleij
2026-09-19 22:22 ` [PATCH v4 13/23] dmaengine: ste_dma40: Fix probe LCLA free Linus Walleij
2026-09-19 22:22 ` [PATCH v4 14/23] dmaengine: ste_dma40: Put the LCPA SRAM node Linus Walleij
2026-09-19 22:22 ` [PATCH v4 15/23] dmaengine: ste_dma40: Fix memcpy channel parsing Linus Walleij
2026-09-19 22:22 ` [PATCH v4 16/23] dmaengine: ste_dma40: Validate disabled channel indexes Linus Walleij
2026-09-19 22:22 ` [PATCH v4 17/23] dmaengine: ste_dma40: Validate DMA specifier length Linus Walleij
2026-09-19 22:22 ` [PATCH v4 18/23] dmaengine: ste_dma40: Reject direction changes after allocation Linus Walleij
2026-09-19 22:22 ` [PATCH v4 19/23] dmaengine: ste_dma40: Fix logical channel bounds check Linus Walleij
2026-09-19 22:22 ` [PATCH v4 20/23] dmaengine: ste_dma40: Fix event group bounds Linus Walleij
2026-09-19 22:22 ` Linus Walleij [this message]
2026-09-19 22:22 ` [PATCH v4 22/23] dmaengine: ste_dma40: Validate fixed physical channel indexes Linus Walleij
2026-09-19 22:22 ` [PATCH v4 23/23] dmaengine: ste_dma40: Validate memcpy configuration Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920-dma40-fixes-v4-21-d751b2d9c23f@kernel.org \
--to=linusw@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox