From: Dave Jiang <dave.jiang@intel.com>
To: cgel.zte@gmail.com
Cc: vkoul@kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] dmaengine: idxd: Remove unnecessary synchronize_irq() before free_irq()
Date: Fri, 13 May 2022 07:30:35 -0700 [thread overview]
Message-ID: <2470523a-3508-e788-8407-d6142487b355@intel.com> (raw)
In-Reply-To: <20220513081622.1631073-1-chi.minghao@zte.com.cn>
On 5/13/2022 1:16 AM, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered, on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way) before any state associated with the IRQ is freed.
Fair enough. Thanks.
Acked-by: Dave Jiang <dave.jiang@intel.com>
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/dma/idxd/device.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 5363fb9218f2..9dd8e6bb21e6 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -1179,7 +1179,6 @@ void idxd_wq_free_irq(struct idxd_wq *wq)
> struct idxd_device *idxd = wq->idxd;
> struct idxd_irq_entry *ie = &wq->ie;
>
> - synchronize_irq(ie->vector);
> free_irq(ie->vector, ie);
> idxd_flush_pending_descs(ie);
> if (idxd->request_int_handles)
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-05-13 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 8:16 [PATCH] dmaengine: idxd: Remove unnecessary synchronize_irq() before free_irq() cgel.zte
2022-05-13 14:30 ` Dave Jiang [this message]
2022-05-16 11:32 ` Vinod Koul
2022-05-16 11:54 ` [PATCH V2] " cgel.zte
2022-05-16 17:50 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2470523a-3508-e788-8407-d6142487b355@intel.com \
--to=dave.jiang@intel.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox