From: Vinod Koul <vkoul@kernel.org>
To: cgel.zte@gmail.com
Cc: chi.minghao@zte.com.cn, dave.jiang@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
zealci@zte.com.cn
Subject: Re: [PATCH V2] dmaengine: idxd: Remove unnecessary synchronize_irq() before free_irq()
Date: Mon, 16 May 2022 23:20:29 +0530 [thread overview]
Message-ID: <YoKO5RFQVsgGSwqE@matsya> (raw)
In-Reply-To: <20220516115412.1651772-1-chi.minghao@zte.com.cn>
On 16-05-22, 11:54, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered, on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.
You should not have missed Dave's ack. I have added that and pushed
--
~Vinod
prev parent reply other threads:[~2022-05-16 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 8:16 [PATCH] dmaengine: idxd: Remove unnecessary synchronize_irq() before free_irq() cgel.zte
2022-05-13 14:30 ` Dave Jiang
2022-05-16 11:32 ` Vinod Koul
2022-05-16 11:54 ` [PATCH V2] " cgel.zte
2022-05-16 17:50 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoKO5RFQVsgGSwqE@matsya \
--to=vkoul@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox