DMA Engine development
 help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	fenghua.yu@intel.com, vkoul@kernel.org
Cc: dave.jiang@intel.com, tony.luck@intel.com,
	wajdi.k.feghali@intel.com, james.guilford@intel.com,
	kanchana.p.sridhar@intel.com, giovanni.cabiddu@intel.com,
	hdanton@sina.com, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v3 15/15] crypto: iaa - Add IAA Compression Accelerator stats
Date: Fri, 28 Apr 2023 16:06:50 -0500	[thread overview]
Message-ID: <374d40f829001d0ea737e776f5f9dca8b311fffd.camel@linux.intel.com> (raw)
In-Reply-To: <7f257119-339b-1d42-4252-181f9666d78e@infradead.org>

Hi Randy,

On Fri, 2023-04-28 at 14:00 -0700, Randy Dunlap wrote:
> Hi--
> 
> On 4/28/23 13:55, Tom Zanussi wrote:
> > diff --git a/drivers/crypto/intel/iaa/Kconfig
> > b/drivers/crypto/intel/iaa/Kconfig
> > index fcccb6ff7e29..cffb3a4359fc 100644
> > --- a/drivers/crypto/intel/iaa/Kconfig
> > +++ b/drivers/crypto/intel/iaa/Kconfig
> > @@ -8,3 +8,12 @@ config CRYPTO_DEV_IAA_CRYPTO
> >           decompression with the Intel Analytics Accelerator (IAA)
> >           hardware using the cryptographic API.  If you choose 'M'
> >           here, the module will be called iaa_crypto.
> > +
> > +config CRYPTO_DEV_IAA_CRYPTO_STATS
> > +       bool "Enable Intel(R) IAA Compression Accelerator
> > Statistics"
> > +       depends on CRYPTO_DEV_IAA_CRYPTO
> > +       default n
> > +       help
> > +          Enable statistics for the IAA compression accelerator.
> 
> The line above should use one tab + 2 spaces for indentation
> instead of bunch-of-spaces.

Yep, so much for consistency, will fix.  Thanks for pointing it out.

Tom

> 
> > +         These include per-device and per-workqueue statistics in
> > +         addition to global driver statistics.
> 
> Thanks.


      reply	other threads:[~2023-04-28 21:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 20:55 [PATCH v3 00/15] crypto: Add Intel Analytics Accelerator (IAA) crypto compression driver Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 01/15] dmaengine: idxd: add wq driver name support for accel-config user tool Tom Zanussi
2023-04-29  0:14   ` Fenghua Yu
2023-05-01 14:01     ` Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 02/15] dmaengine: idxd: add external module driver support for dsa_bus_type Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 03/15] dmaengine: idxd: Export drv_enable/disable and related functions Tom Zanussi
2023-05-01 18:39   ` Fenghua Yu
2023-04-28 20:55 ` [PATCH v3 04/15] dmaengine: idxd: Export descriptor management functions Tom Zanussi
2023-05-01 14:49   ` Dave Jiang
2023-05-01 18:41   ` Fenghua Yu
2023-04-28 20:55 ` [PATCH v3 05/15] dmaengine: idxd: Export wq resource " Tom Zanussi
2023-05-01 18:41   ` Fenghua Yu
2023-04-28 20:55 ` [PATCH v3 06/15] dmaengine: idxd: Add private_data to struct idxd_wq Tom Zanussi
2023-05-01 14:50   ` Dave Jiang
2023-05-01 18:50   ` Fenghua Yu
2023-04-28 20:55 ` [PATCH v3 07/15] dmaengine: idxd: add callback support for iaa crypto Tom Zanussi
2023-05-01 20:48   ` Fenghua Yu
2023-04-28 20:55 ` [PATCH v3 08/15] crypto: iaa - Add IAA Compression Accelerator Documentation Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 09/15] crypto: iaa - Add Intel IAA Compression Accelerator crypto driver core Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 10/15] crypto: iaa - Add per-cpu workqueue table with rebalancing Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 11/15] crypto: iaa - Add compression mode management along with fixed mode Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 12/15] crypto: iaa - Add support for iaa_crypto deflate compression algorithm Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 13/15] crypto: iaa - Add support for default IAA 'canned' compression mode Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 14/15] crypto: iaa - Add irq support for the crypto async interface Tom Zanussi
2023-04-28 20:55 ` [PATCH v3 15/15] crypto: iaa - Add IAA Compression Accelerator stats Tom Zanussi
2023-04-28 21:00   ` Randy Dunlap
2023-04-28 21:06     ` Tom Zanussi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=374d40f829001d0ea737e776f5f9dca8b311fffd.camel@linux.intel.com \
    --to=tom.zanussi@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=dmaengine@vger.kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=hdanton@sina.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=james.guilford@intel.com \
    --cc=kanchana.p.sridhar@intel.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=tony.luck@intel.com \
    --cc=vkoul@kernel.org \
    --cc=wajdi.k.feghali@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox