* [5/6] xhci: Use device_iommu_mapped()
@ 2018-12-17 11:21 Mathias Nyman
0 siblings, 0 replies; 2+ messages in thread
From: Mathias Nyman @ 2018-12-17 11:21 UTC (permalink / raw)
To: Joerg Roedel, iommu
Cc: Russell Currey, Sam Bobroff, oohall, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, Lorenzo Pieralisi, Hanjun Guo,
Sudeep Holla, Dan Williams, Vinod Koul, jroedel, Mathias Nyman,
Greg Kroah-Hartman, linux-kernel, linux-acpi, dmaengine,
linux-usb
On 11.12.2018 15:43, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Replace the dev->iommu_group check with a proper function
> call that better reprensents its purpose.
>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/usb/host/xhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index dae3be1b9c8f..8eacd2ed412b 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -244,7 +244,7 @@ static void xhci_zero_64b_regs(struct xhci_hcd *xhci)
> * an iommu. Doing anything when there is no iommu is definitely
> * unsafe...
> */
> - if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !dev->iommu_group)
> + if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !device_iommu_mapped(dev))
> return;
>
> xhci_info(xhci, "Zeroing 64bit base registers, expecting fault\n");
>
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [5/6] xhci: Use device_iommu_mapped()
@ 2018-12-11 13:43 Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2018-12-11 13:43 UTC (permalink / raw)
To: iommu
Cc: Russell Currey, Sam Bobroff, oohall, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, Lorenzo Pieralisi, Hanjun Guo,
Sudeep Holla, Dan Williams, Vinod Koul, Joerg Roedel, jroedel,
Mathias Nyman, Greg Kroah-Hartman, linux-kernel, linux-acpi,
dmaengine, linux-usb
From: Joerg Roedel <jroedel@suse.de>
Replace the dev->iommu_group check with a proper function
call that better reprensents its purpose.
Cc: Mathias Nyman <mathias.nyman@intel.com>
Acked-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
drivers/usb/host/xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index dae3be1b9c8f..8eacd2ed412b 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -244,7 +244,7 @@ static void xhci_zero_64b_regs(struct xhci_hcd *xhci)
* an iommu. Doing anything when there is no iommu is definitely
* unsafe...
*/
- if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !dev->iommu_group)
+ if (!(xhci->quirks & XHCI_ZERO_64B_REGS) || !device_iommu_mapped(dev))
return;
xhci_info(xhci, "Zeroing 64bit base registers, expecting fault\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-17 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-17 11:21 [5/6] xhci: Use device_iommu_mapped() Mathias Nyman
-- strict thread matches above, loose matches on Subject: below --
2018-12-11 13:43 Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox