Re: [PATCH] dmaengine: ti: k3-udma-glue: fix memory leak when register device fail

["Péter Ujfalusi" <peter.ujfalusi@gmail.com>]

On 20/10/2022 09:28, Yang Yingliang wrote:
> If device_register() fails, it should call put_device() to give
> up reference, the name allocated in dev_set_name() can be freed
> in callback function kobject_cleanup().

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> 
> Fixes: 5b65781d06ea ("dmaengine: ti: k3-udma-glue: Add support for K3 PKTDMA")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>   drivers/dma/ti/k3-udma-glue.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
> index 4fdd9f06b723..4f1aeb81e9c7 100644
> --- a/drivers/dma/ti/k3-udma-glue.c
> +++ b/drivers/dma/ti/k3-udma-glue.c
> @@ -299,6 +299,7 @@ struct k3_udma_glue_tx_channel *k3_udma_glue_request_tx_chn(struct device *dev,
>   	ret = device_register(&tx_chn->common.chan_dev);
>   	if (ret) {
>   		dev_err(dev, "Channel Device registration failed %d\n", ret);
> +		put_device(&tx_chn->common.chan_dev);
>   		tx_chn->common.chan_dev.parent = NULL;
>   		goto err;
>   	}
> @@ -917,6 +918,7 @@ k3_udma_glue_request_rx_chn_priv(struct device *dev, const char *name,
>   	ret = device_register(&rx_chn->common.chan_dev);
>   	if (ret) {
>   		dev_err(dev, "Channel Device registration failed %d\n", ret);
> +		put_device(&rx_chn->common.chan_dev);
>   		rx_chn->common.chan_dev.parent = NULL;
>   		goto err;
>   	}
> @@ -1048,6 +1050,7 @@ k3_udma_glue_request_remote_rx_chn(struct device *dev, const char *name,
>   	ret = device_register(&rx_chn->common.chan_dev);
>   	if (ret) {
>   		dev_err(dev, "Channel Device registration failed %d\n", ret);
> +		put_device(&rx_chn->common.chan_dev);
>   		rx_chn->common.chan_dev.parent = NULL;
>   		goto err;
>   	}

-- 
Péter