* [PATCH] dmaengine: ti: k3-udma-glue: fix memory leak when register device fail
@ 2022-10-20 6:28 Yang Yingliang
2022-10-26 17:14 ` Péter Ujfalusi
2022-11-04 14:38 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-10-20 6:28 UTC (permalink / raw)
To: dmaengine; +Cc: vigneshr, peter.ujfalusi, vkoul, yangyingliang
If device_register() fails, it should call put_device() to give
up reference, the name allocated in dev_set_name() can be freed
in callback function kobject_cleanup().
Fixes: 5b65781d06ea ("dmaengine: ti: k3-udma-glue: Add support for K3 PKTDMA")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/dma/ti/k3-udma-glue.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
index 4fdd9f06b723..4f1aeb81e9c7 100644
--- a/drivers/dma/ti/k3-udma-glue.c
+++ b/drivers/dma/ti/k3-udma-glue.c
@@ -299,6 +299,7 @@ struct k3_udma_glue_tx_channel *k3_udma_glue_request_tx_chn(struct device *dev,
ret = device_register(&tx_chn->common.chan_dev);
if (ret) {
dev_err(dev, "Channel Device registration failed %d\n", ret);
+ put_device(&tx_chn->common.chan_dev);
tx_chn->common.chan_dev.parent = NULL;
goto err;
}
@@ -917,6 +918,7 @@ k3_udma_glue_request_rx_chn_priv(struct device *dev, const char *name,
ret = device_register(&rx_chn->common.chan_dev);
if (ret) {
dev_err(dev, "Channel Device registration failed %d\n", ret);
+ put_device(&rx_chn->common.chan_dev);
rx_chn->common.chan_dev.parent = NULL;
goto err;
}
@@ -1048,6 +1050,7 @@ k3_udma_glue_request_remote_rx_chn(struct device *dev, const char *name,
ret = device_register(&rx_chn->common.chan_dev);
if (ret) {
dev_err(dev, "Channel Device registration failed %d\n", ret);
+ put_device(&rx_chn->common.chan_dev);
rx_chn->common.chan_dev.parent = NULL;
goto err;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: ti: k3-udma-glue: fix memory leak when register device fail
2022-10-20 6:28 [PATCH] dmaengine: ti: k3-udma-glue: fix memory leak when register device fail Yang Yingliang
@ 2022-10-26 17:14 ` Péter Ujfalusi
2022-11-04 14:38 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Péter Ujfalusi @ 2022-10-26 17:14 UTC (permalink / raw)
To: Yang Yingliang, dmaengine; +Cc: vigneshr, peter.ujfalusi, vkoul
On 20/10/2022 09:28, Yang Yingliang wrote:
> If device_register() fails, it should call put_device() to give
> up reference, the name allocated in dev_set_name() can be freed
> in callback function kobject_cleanup().
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
>
> Fixes: 5b65781d06ea ("dmaengine: ti: k3-udma-glue: Add support for K3 PKTDMA")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/dma/ti/k3-udma-glue.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
> index 4fdd9f06b723..4f1aeb81e9c7 100644
> --- a/drivers/dma/ti/k3-udma-glue.c
> +++ b/drivers/dma/ti/k3-udma-glue.c
> @@ -299,6 +299,7 @@ struct k3_udma_glue_tx_channel *k3_udma_glue_request_tx_chn(struct device *dev,
> ret = device_register(&tx_chn->common.chan_dev);
> if (ret) {
> dev_err(dev, "Channel Device registration failed %d\n", ret);
> + put_device(&tx_chn->common.chan_dev);
> tx_chn->common.chan_dev.parent = NULL;
> goto err;
> }
> @@ -917,6 +918,7 @@ k3_udma_glue_request_rx_chn_priv(struct device *dev, const char *name,
> ret = device_register(&rx_chn->common.chan_dev);
> if (ret) {
> dev_err(dev, "Channel Device registration failed %d\n", ret);
> + put_device(&rx_chn->common.chan_dev);
> rx_chn->common.chan_dev.parent = NULL;
> goto err;
> }
> @@ -1048,6 +1050,7 @@ k3_udma_glue_request_remote_rx_chn(struct device *dev, const char *name,
> ret = device_register(&rx_chn->common.chan_dev);
> if (ret) {
> dev_err(dev, "Channel Device registration failed %d\n", ret);
> + put_device(&rx_chn->common.chan_dev);
> rx_chn->common.chan_dev.parent = NULL;
> goto err;
> }
--
Péter
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: ti: k3-udma-glue: fix memory leak when register device fail
2022-10-20 6:28 [PATCH] dmaengine: ti: k3-udma-glue: fix memory leak when register device fail Yang Yingliang
2022-10-26 17:14 ` Péter Ujfalusi
@ 2022-11-04 14:38 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-11-04 14:38 UTC (permalink / raw)
To: Yang Yingliang; +Cc: dmaengine, vigneshr, peter.ujfalusi
On 20-10-22, 14:28, Yang Yingliang wrote:
> If device_register() fails, it should call put_device() to give
> up reference, the name allocated in dev_set_name() can be freed
> in callback function kobject_cleanup().
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-04 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-20 6:28 [PATCH] dmaengine: ti: k3-udma-glue: fix memory leak when register device fail Yang Yingliang
2022-10-26 17:14 ` Péter Ujfalusi
2022-11-04 14:38 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox