* [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()
@ 2024-06-26 8:27 Ma Ke
2024-06-26 15:26 ` Markus Elfring
2024-06-28 5:51 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Ma Ke @ 2024-06-26 8:27 UTC (permalink / raw)
To: vkoul, make24, andriy.shevchenko; +Cc: dmaengine, linux-kernel
As the possible failure of the dma_set_max_seg_size(), we should better
check the return value of the dma_set_max_seg_size().
Fixes: 17b3cf4233d7 ("dmaengine: hsu: set maximum allowed segment size for DMA")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/dma/hsu/hsu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/hsu/hsu.c b/drivers/dma/hsu/hsu.c
index af5a2e252c25..9d02277fa923 100644
--- a/drivers/dma/hsu/hsu.c
+++ b/drivers/dma/hsu/hsu.c
@@ -479,7 +479,9 @@ int hsu_dma_probe(struct hsu_dma_chip *chip)
hsu->dma.dev = chip->dev;
- dma_set_max_seg_size(hsu->dma.dev, HSU_CH_DxTSR_MASK);
+ ret = dma_set_max_seg_size(hsu->dma.dev, HSU_CH_DxTSR_MASK);
+ if (ret)
+ return ret;
ret = dma_async_device_register(&hsu->dma);
if (ret)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()
2024-06-26 8:27 [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe() Ma Ke
@ 2024-06-26 15:26 ` Markus Elfring
2024-06-28 5:51 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2024-06-26 15:26 UTC (permalink / raw)
To: Ma Ke, dmaengine, Andy Shevchenko, Vinod Koul; +Cc: LKML
> As the possible failure of the dma_set_max_seg_size(), we should better
> check the return value of the dma_set_max_seg_size().
Please avoid the repetition of a function name in such a change description.
Can it be improved with corresponding imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()
2024-06-26 8:27 [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe() Ma Ke
2024-06-26 15:26 ` Markus Elfring
@ 2024-06-28 5:51 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-06-28 5:51 UTC (permalink / raw)
To: Ma Ke; +Cc: vkoul, andriy.shevchenko, dmaengine, linux-kernel
On Wed, Jun 26, 2024 at 04:27:11PM +0800, Ma Ke wrote:
> As the possible failure of the dma_set_max_seg_size(), we should better
> check the return value of the dma_set_max_seg_size().
As I've told you before: no.
We'll remove the return value from dma_set_max_seg_size.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-28 5:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-26 8:27 [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe() Ma Ke
2024-06-26 15:26 ` Markus Elfring
2024-06-28 5:51 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox