* [PATCH v1 0/2] Macro Ordering and Typo Correction @ 2026-09-07 10:54 Devendra K Verma 2026-09-07 10:54 ` [PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position Devendra K Verma 2026-09-07 10:54 ` [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct Devendra K Verma 0 siblings, 2 replies; 9+ messages in thread From: Devendra K Verma @ 2026-09-07 10:54 UTC (permalink / raw) To: mani, vkoul, frank.li, den Cc: dmaengine, linux-pci, linux-kernel, michal.simek, devverma These are minor and cosmetic changes. o If the macros declaring the bit positions of a register are in order then it provides a good view. Corrected the ordering for once such register. o Corrected the typo under the IP related data struct to have the correct name under respective IP structs. Previous reviewed-by tags were part of the following review: https://lore.kernel.org/all/aoW7vxy2lpXEbmRq@SMW015318/ https://lore.kernel.org/all/dx5jvko7ygrqugzkt3k74l3d7lk7iauikmxrzuhvn2b4bdv5ub@s2l6zl3alx3z/#t Devendra K Verma (2): dmaengine: dw-edma: Macro order as per reg bit position dmaengine: dw-edma: IP name corrected under its struct drivers/dma/dw-edma/dw-edma-pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.43.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position 2026-09-07 10:54 [PATCH v1 0/2] Macro Ordering and Typo Correction Devendra K Verma @ 2026-09-07 10:54 ` Devendra K Verma 2026-09-07 10:59 ` sashiko-bot 2026-09-15 16:43 ` Frank Li 2026-09-07 10:54 ` [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct Devendra K Verma 1 sibling, 2 replies; 9+ messages in thread From: Devendra K Verma @ 2026-09-07 10:54 UTC (permalink / raw) To: mani, vkoul, frank.li, den Cc: dmaengine, linux-pci, linux-kernel, michal.simek, devverma For a register the macros providing masks for bit ranges. These macros if placed in order provide good view of the bits. Placed macros in ascending order. Signed-off-by: Devendra K Verma <devverma@amd.com> --- drivers/dma/dw-edma/dw-edma-pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 9f237ba916de..006dea7d6322 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -31,8 +31,8 @@ #define DW_PCIE_XILINX_MDB_VSEC_DMA_ID 0x6 #define DW_PCIE_XILINX_MDB_VSEC_ID 0x20 -#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR GENMASK(10, 8) #define DW_PCIE_XILINX_MDB_VSEC_DMA_MAP GENMASK(2, 0) +#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR GENMASK(10, 8) #define DW_PCIE_XILINX_MDB_VSEC_DMA_WR_CH GENMASK(9, 0) #define DW_PCIE_XILINX_MDB_VSEC_DMA_RD_CH GENMASK(25, 16) -- 2.43.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position 2026-09-07 10:54 ` [PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position Devendra K Verma @ 2026-09-07 10:59 ` sashiko-bot 2026-09-15 16:43 ` Frank Li 1 sibling, 0 replies; 9+ messages in thread From: sashiko-bot @ 2026-09-07 10:59 UTC (permalink / raw) To: Devendra K Verma; +Cc: linux-pci, dmaengine, Frank.Li, vkoul > For a register the macros providing masks for bit ranges. > These macros if placed in order provide good view of the bits. > Placed macros in ascending order. > > Signed-off-by: Devendra K Verma <devverma@amd.com> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/20260907105453.1940646-1-devverma@amd.com?part=1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position 2026-09-07 10:54 ` [PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position Devendra K Verma 2026-09-07 10:59 ` sashiko-bot @ 2026-09-15 16:43 ` Frank Li 1 sibling, 0 replies; 9+ messages in thread From: Frank Li @ 2026-09-15 16:43 UTC (permalink / raw) To: Devendra K Verma Cc: mani, vkoul, frank.li, den, dmaengine, linux-pci, linux-kernel, michal.simek On Mon, Sep 07, 2026 at 04:24:52PM +0530, Devendra K Verma wrote: > For a register the macros providing masks for bit ranges. > These macros if placed in order provide good view of the bits. > Placed macros in ascending order. dmaengine: dw-edma: sort register field macros by bit position Sort register field macros by bit position to improve readability. No functional change intended. Frank > > Signed-off-by: Devendra K Verma <devverma@amd.com> > --- > drivers/dma/dw-edma/dw-edma-pcie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c > index 9f237ba916de..006dea7d6322 100644 > --- a/drivers/dma/dw-edma/dw-edma-pcie.c > +++ b/drivers/dma/dw-edma/dw-edma-pcie.c > @@ -31,8 +31,8 @@ > > #define DW_PCIE_XILINX_MDB_VSEC_DMA_ID 0x6 > #define DW_PCIE_XILINX_MDB_VSEC_ID 0x20 > -#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR GENMASK(10, 8) > #define DW_PCIE_XILINX_MDB_VSEC_DMA_MAP GENMASK(2, 0) > +#define DW_PCIE_XILINX_MDB_VSEC_DMA_BAR GENMASK(10, 8) > #define DW_PCIE_XILINX_MDB_VSEC_DMA_WR_CH GENMASK(9, 0) > #define DW_PCIE_XILINX_MDB_VSEC_DMA_RD_CH GENMASK(25, 16) > > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct 2026-09-07 10:54 [PATCH v1 0/2] Macro Ordering and Typo Correction Devendra K Verma 2026-09-07 10:54 ` [PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position Devendra K Verma @ 2026-09-07 10:54 ` Devendra K Verma 2026-09-07 10:57 ` sashiko-bot 2026-09-15 16:47 ` Frank Li 1 sibling, 2 replies; 9+ messages in thread From: Devendra K Verma @ 2026-09-07 10:54 UTC (permalink / raw) To: mani, vkoul, frank.li, den Cc: dmaengine, linux-pci, linux-kernel, michal.simek, devverma For 'xilinx_cpm6_dma_data' struct which is CPM6 IP, the comment under this struct has typo and mentiones 'MDB' registers when it shall be 'CPM6' regisers. Signed-off-by: Devendra K Verma <devverma@amd.com> --- drivers/dma/dw-edma/dw-edma-pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 006dea7d6322..762a693ab55b 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -146,7 +146,7 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = { }; static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = { - /* MDB registers location */ + /* CPM6 registers location */ .rg.bar = BAR_0, .rg.off = SZ_4K, /* 4 Kbytes */ .rg.sz = SZ_8K, /* 8 Kbytes */ -- 2.43.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct 2026-09-07 10:54 ` [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct Devendra K Verma @ 2026-09-07 10:57 ` sashiko-bot 2026-09-15 16:47 ` Frank Li 1 sibling, 0 replies; 9+ messages in thread From: sashiko-bot @ 2026-09-07 10:57 UTC (permalink / raw) To: Devendra K Verma; +Cc: vkoul, dmaengine, Frank.Li, linux-pci > For 'xilinx_cpm6_dma_data' struct which is CPM6 IP, the comment > under this struct has typo and mentiones 'MDB' registers when > it shall be 'CPM6' regisers. > > Signed-off-by: Devendra K Verma <devverma@amd.com> Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review · https://sashiko.dev/#/patchset/20260907105453.1940646-1-devverma@amd.com?part=2 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct 2026-09-07 10:54 ` [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct Devendra K Verma 2026-09-07 10:57 ` sashiko-bot @ 2026-09-15 16:47 ` Frank Li 2026-09-17 9:09 ` Verma, Devendra 2026-09-17 9:13 ` Verma, Devendra 1 sibling, 2 replies; 9+ messages in thread From: Frank Li @ 2026-09-15 16:47 UTC (permalink / raw) To: Devendra K Verma Cc: mani, vkoul, frank.li, den, dmaengine, linux-pci, linux-kernel, michal.simek On Mon, Sep 07, 2026 at 04:24:53PM +0530, Devendra K Verma wrote: > For 'xilinx_cpm6_dma_data' struct which is CPM6 IP, the comment > under this struct has typo and mentiones 'MDB' registers when > it shall be 'CPM6' regisers. > > Signed-off-by: Devendra K Verma <devverma@amd.com> > --- dmaengine: dw-edma: correct IP name in xilinx_cpm6_dma_data comment Replace 'MDB' with 'CPM6' in the xilinx_cpm6_dma_data comment to fix the IP name typo. Frank > drivers/dma/dw-edma/dw-edma-pcie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c > index 006dea7d6322..762a693ab55b 100644 > --- a/drivers/dma/dw-edma/dw-edma-pcie.c > +++ b/drivers/dma/dw-edma/dw-edma-pcie.c > @@ -146,7 +146,7 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = { > }; > > static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = { > - /* MDB registers location */ > + /* CPM6 registers location */ > .rg.bar = BAR_0, > .rg.off = SZ_4K, /* 4 Kbytes */ > .rg.sz = SZ_8K, /* 8 Kbytes */ > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct 2026-09-15 16:47 ` Frank Li @ 2026-09-17 9:09 ` Verma, Devendra 2026-09-17 9:13 ` Verma, Devendra 1 sibling, 0 replies; 9+ messages in thread From: Verma, Devendra @ 2026-09-17 9:09 UTC (permalink / raw) To: Frank Li Cc: mani, vkoul, frank.li, den, dmaengine, linux-pci, linux-kernel, michal.simek, devverma On 15-Sep-26 22:17, Frank Li wrote: > On Mon, Sep 07, 2026 at 04:24:53PM +0530, Devendra K Verma wrote: >> For 'xilinx_cpm6_dma_data' struct which is CPM6 IP, the comment >> under this struct has typo and mentiones 'MDB' registers when >> it shall be 'CPM6' regisers. >> >> Signed-off-by: Devendra K Verma <devverma@amd.com> >> --- > > dmaengine: dw-edma: correct IP name in xilinx_cpm6_dma_data comment > > Replace 'MDB' with 'CPM6' in the xilinx_cpm6_dma_data comment to fix > the IP name typo. > Thanks Frank for the suggestion! Please check the v2 of the same series with updated titles. -Devendra > Frank > >> drivers/dma/dw-edma/dw-edma-pcie.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c >> index 006dea7d6322..762a693ab55b 100644 >> --- a/drivers/dma/dw-edma/dw-edma-pcie.c >> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c >> @@ -146,7 +146,7 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = { >> }; >> >> static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = { >> - /* MDB registers location */ >> + /* CPM6 registers location */ >> .rg.bar = BAR_0, >> .rg.off = SZ_4K, /* 4 Kbytes */ >> .rg.sz = SZ_8K, /* 8 Kbytes */ >> -- >> 2.43.0 >> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct 2026-09-15 16:47 ` Frank Li 2026-09-17 9:09 ` Verma, Devendra @ 2026-09-17 9:13 ` Verma, Devendra 1 sibling, 0 replies; 9+ messages in thread From: Verma, Devendra @ 2026-09-17 9:13 UTC (permalink / raw) To: Frank Li Cc: mani, vkoul, frank.li, den, dmaengine, linux-pci, linux-kernel, michal.simek, devverma On 15-Sep-26 22:17, Frank Li wrote: > On Mon, Sep 07, 2026 at 04:24:53PM +0530, Devendra K Verma wrote: >> For 'xilinx_cpm6_dma_data' struct which is CPM6 IP, the comment >> under this struct has typo and mentiones 'MDB' registers when >> it shall be 'CPM6' regisers. >> >> Signed-off-by: Devendra K Verma <devverma@amd.com> >> --- > > dmaengine: dw-edma: correct IP name in xilinx_cpm6_dma_data comment > > Replace 'MDB' with 'CPM6' in the xilinx_cpm6_dma_data comment to fix > the IP name typo. > Thank you for the suggestion. Please check the v2 of the same patch series. -Devendra > Frank > >> drivers/dma/dw-edma/dw-edma-pcie.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c >> index 006dea7d6322..762a693ab55b 100644 >> --- a/drivers/dma/dw-edma/dw-edma-pcie.c >> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c >> @@ -146,7 +146,7 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = { >> }; >> >> static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = { >> - /* MDB registers location */ >> + /* CPM6 registers location */ >> .rg.bar = BAR_0, >> .rg.off = SZ_4K, /* 4 Kbytes */ >> .rg.sz = SZ_8K, /* 8 Kbytes */ >> -- >> 2.43.0 >> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-09-17 9:14 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-09-07 10:54 [PATCH v1 0/2] Macro Ordering and Typo Correction Devendra K Verma 2026-09-07 10:54 ` [PATCH v1 1/2] dmaengine: dw-edma: Macro order as per reg bit position Devendra K Verma 2026-09-07 10:59 ` sashiko-bot 2026-09-15 16:43 ` Frank Li 2026-09-07 10:54 ` [PATCH v1 2/2] dmaengine: dw-edma: IP name corrected under its struct Devendra K Verma 2026-09-07 10:57 ` sashiko-bot 2026-09-15 16:47 ` Frank Li 2026-09-17 9:09 ` Verma, Devendra 2026-09-17 9:13 ` Verma, Devendra
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox