From: Vinod Koul <vkoul@kernel.org>
To: Cixi Geng <gengcixi@gmail.com>
Cc: orsonzhai@gmail.com, baolin.wang@linux.alibaba.com,
zhang.lyra@gmail.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, Cixi Geng <cixi.geng1@unisoc.com>
Subject: Re: [PATCH V2] dmaengine: sprd: Support two-stage dma interrupt
Date: Wed, 19 Oct 2022 19:37:26 +0530 [thread overview]
Message-ID: <Y1AEngC3y9+OyG5S@matsya> (raw)
In-Reply-To: <20221003234929.186290-1-gengcixi@gmail.com>
On 04-10-22, 07:49, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> Audio need to request Audio CP global dma interrupt, so Audio CP
> DMA should support two-stage interrupt to adapte it.
> It will occur interrupt when two-stage dma channel transfer done.
The patch looks fine to me but...
> diff --git a/include/linux/dma/sprd-dma.h b/include/linux/dma/sprd-dma.h
> index d09c6f6f6da5..26de41d6d915 100644
> --- a/include/linux/dma/sprd-dma.h
> +++ b/include/linux/dma/sprd-dma.h
> enum sprd_dma_int_type {
> SPRD_DMA_NO_INT,
> @@ -112,6 +120,10 @@ enum sprd_dma_int_type {
> SPRD_DMA_TRANS_BLK_INT,
> SPRD_DMA_LIST_INT,
> SPRD_DMA_CFGERR_INT,
> + SPRD_DMA_SRC_CHN0_INT,
> + SPRD_DMA_SRC_CHN1_INT,
> + SPRD_DMA_DST_CHN0_INT,
> + SPRD_DMA_DST_CHN1_INT,
why is sprd_dma_int_type part of driver interface. sprd_dma_int_type is
used only by this driver and should be moved into the driver..
Can you change that as well please
--
~Vinod
next prev parent reply other threads:[~2022-10-19 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 23:49 [PATCH V2] dmaengine: sprd: Support two-stage dma interrupt Cixi Geng
2022-10-10 6:30 ` Baolin Wang
2022-10-19 14:07 ` Vinod Koul [this message]
2022-10-20 7:33 ` Cixi Geng
2022-10-20 8:15 ` Baolin Wang
2022-10-20 11:22 ` Vinod Koul
2022-10-21 1:35 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1AEngC3y9+OyG5S@matsya \
--to=vkoul@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=cixi.geng1@unisoc.com \
--cc=dmaengine@vger.kernel.org \
--cc=gengcixi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox