From: Vinod Koul <vkoul@kernel.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Cixi Geng <gengcixi@gmail.com>,
orsonzhai@gmail.com, zhang.lyra@gmail.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Cixi Geng <cixi.geng1@unisoc.com>
Subject: Re: [PATCH V2] dmaengine: sprd: Support two-stage dma interrupt
Date: Thu, 20 Oct 2022 16:52:07 +0530 [thread overview]
Message-ID: <Y1EvX+hL/LWBnuvX@matsya> (raw)
In-Reply-To: <a20f43dd-3259-5251-6c13-73664a600c42@linux.alibaba.com>
On 20-10-22, 16:15, Baolin Wang wrote:
> > > why is sprd_dma_int_type part of driver interface. sprd_dma_int_type is
> > > used only by this driver and should be moved into the driver..
>
> Now we can not move this into dma driver, since we have some drivers in the
> mainline will set the DMA interrupt type, such as spi-sprd.c, sprd_serial.c
> and sprd-pcm-compress.c.
That may not sound right.. Why should peripheral set the DMA
interrupt..?
--
~Vinod
next prev parent reply other threads:[~2022-10-20 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 23:49 [PATCH V2] dmaengine: sprd: Support two-stage dma interrupt Cixi Geng
2022-10-10 6:30 ` Baolin Wang
2022-10-19 14:07 ` Vinod Koul
2022-10-20 7:33 ` Cixi Geng
2022-10-20 8:15 ` Baolin Wang
2022-10-20 11:22 ` Vinod Koul [this message]
2022-10-21 1:35 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1EvX+hL/LWBnuvX@matsya \
--to=vkoul@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=cixi.geng1@unisoc.com \
--cc=dmaengine@vger.kernel.org \
--cc=gengcixi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox