* [PATCH] dmaengine: fsl-edma: fix potential NULL pointer dereference in fsl_edma_tx_status()
@ 2022-10-26 10:18 Andrew Chernyakov
2022-11-04 14:37 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Chernyakov @ 2022-10-26 10:18 UTC (permalink / raw)
To: Vinod Koul; +Cc: Andrew Chernyakov, dmaengine, linux-kernel, lvc-project
fsl_edma_desc_residue() dereferences fsl_chan->edesc, but it is checked
for NULL only in one of two places where fsl_edma_desc_residue() is
called from fsl_edma_tx_status().
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Andrew Chernyakov <acherniakov@astralinux.ru>
---
drivers/dma/fsl-edma-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
index a06a1575a2a5..fb712d85d556 100644
--- a/drivers/dma/fsl-edma-common.c
+++ b/drivers/dma/fsl-edma-common.c
@@ -330,7 +330,7 @@ enum dma_status fsl_edma_tx_status(struct dma_chan *chan,
if (fsl_chan->edesc && cookie == fsl_chan->edesc->vdesc.tx.cookie)
txstate->residue =
fsl_edma_desc_residue(fsl_chan, vdesc, true);
- else if (vdesc)
+ else if (fsl_chan->edesc && vdesc)
txstate->residue =
fsl_edma_desc_residue(fsl_chan, vdesc, false);
else
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: fsl-edma: fix potential NULL pointer dereference in fsl_edma_tx_status()
2022-10-26 10:18 [PATCH] dmaengine: fsl-edma: fix potential NULL pointer dereference in fsl_edma_tx_status() Andrew Chernyakov
@ 2022-11-04 14:37 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-11-04 14:37 UTC (permalink / raw)
To: Andrew Chernyakov; +Cc: dmaengine, linux-kernel, lvc-project
On 26-10-22, 13:18, Andrew Chernyakov wrote:
> fsl_edma_desc_residue() dereferences fsl_chan->edesc, but it is checked
> for NULL only in one of two places where fsl_edma_desc_residue() is
> called from fsl_edma_tx_status().
Patch subject should be the change it introduces, pls revise
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrew Chernyakov <acherniakov@astralinux.ru>
> ---
> drivers/dma/fsl-edma-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
> index a06a1575a2a5..fb712d85d556 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -330,7 +330,7 @@ enum dma_status fsl_edma_tx_status(struct dma_chan *chan,
> if (fsl_chan->edesc && cookie == fsl_chan->edesc->vdesc.tx.cookie)
> txstate->residue =
> fsl_edma_desc_residue(fsl_chan, vdesc, true);
> - else if (vdesc)
> + else if (fsl_chan->edesc && vdesc)
> txstate->residue =
> fsl_edma_desc_residue(fsl_chan, vdesc, false);
> else
> --
> 2.35.1
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-04 14:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-26 10:18 [PATCH] dmaengine: fsl-edma: fix potential NULL pointer dereference in fsl_edma_tx_status() Andrew Chernyakov
2022-11-04 14:37 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox