Re: [linux-drivers-review] [PATCH V2 1/1] dmaengine: dw-axi-dmac: support parallel memory <--> peripheral transfers

[Vinod Koul <vkoul@kernel.org>]

On 14-07-21, 12:45, N, Pandith wrote:
> Hi Vinod,
> 
> Thanks for review, Please check for in-line response for the comments

Pls do not *top post*

> 
> Regards
> Pandith
> 
> > -----Original Message-----
> > From: Vinod Koul <vkoul@kernel.org>
> > Sent: Wednesday, July 14, 2021 10:20 AM
> > To: N, Pandith <pandith.n@intel.com>
> > Cc: Eugeniy.Paltsev@synopsys.com; dmaengine@vger.kernel.org; Raja
> > Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>; Pan, Kris
> > <kris.pan@intel.com>; Sangannavar, Mallikarjunappa
> > <mallikarjunappa.sangannavar@intel.com>; Thokala, Srikanth
> > <srikanth.thokala@intel.com>
> > Subject: Re: [linux-drivers-review] [PATCH V2 1/1] dmaengine: dw-axi-dmac:
> > support parallel memory <--> peripheral transfers
> > 
> > On 09-07-21, 15:21, pandith.n@intel.com wrote:
> > > From: Pandith N <pandith.n@intel.com>
> > >
> > > Added support for multiple DMA_MEM_TO_DEV, DMA_DEV_TO_MEM
> > transfers in
> > > parallel. This is required for peripherals using DMA for transmit and
> > > receive operations at the same time. APB slot number needs to be
> > > programmed in channel hardware handshaking interface.
> > >
> > > Removed free slot check algorithm in dw_axi_dma_set_hw_channel. For 8
> > > DMA channels, use respective handshake slot in DMA_HS_SEL APB register.
> > 
> > and why was that removed, maybe a different patch for that?
> > 
> For every channel, an dedicated slot is provided in  hardware handshake register.
> Peripheral source number is programmed in respective channel slots.

Pls explain that in the log as well

> 
> > >
> > > Burst length, DMA HW capability set in dt-binding is now used in driver.
> > 
> > Another patch...
> > 
> > So, too many changes below for the description above, pls split
> > 
> I will split the changes as separate patches in next version.

ok

-- 
~Vinod