* [PATCH] dmaengine: idxd: check GENCAP config support for gencfg register
@ 2021-10-12 18:01 Dave Jiang
2021-10-18 6:35 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2021-10-12 18:01 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine
DSA spec 1.2 has moved the GENCFG register under the GENCAP configuration
support with respect to writability. Add check in driver before writing to
GENCFG register.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/dma/idxd/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 419b206f8a42..1e153725432e 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -793,7 +793,7 @@ static int idxd_groups_config_write(struct idxd_device *idxd)
struct device *dev = &idxd->pdev->dev;
/* Setup bandwidth token limit */
- if (idxd->token_limit) {
+ if (idxd->hw.gen_cap.config_en && idxd->token_limit) {
reg.bits = ioread32(idxd->reg_base + IDXD_GENCFG_OFFSET);
reg.token_limit = idxd->token_limit;
iowrite32(reg.bits, idxd->reg_base + IDXD_GENCFG_OFFSET);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: idxd: check GENCAP config support for gencfg register
2021-10-12 18:01 [PATCH] dmaengine: idxd: check GENCAP config support for gencfg register Dave Jiang
@ 2021-10-18 6:35 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-10-18 6:35 UTC (permalink / raw)
To: Dave Jiang; +Cc: dmaengine
On 12-10-21, 11:01, Dave Jiang wrote:
> DSA spec 1.2 has moved the GENCFG register under the GENCAP configuration
> support with respect to writability. Add check in driver before writing to
> GENCFG register.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-18 6:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-12 18:01 [PATCH] dmaengine: idxd: check GENCAP config support for gencfg register Dave Jiang
2021-10-18 6:35 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox