* [PATCH] dmaengine: sh: rcar-dmac: Check for error num after setting mask
@ 2022-01-06 3:09 Jiasheng Jiang
2022-01-10 9:37 ` Geert Uytterhoeven
2022-02-15 5:27 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Jiasheng Jiang @ 2022-01-06 3:09 UTC (permalink / raw)
To: vkoul, geert+renesas, yoshihiro.shimoda.uh, laurent.pinchart,
wsa+renesas, zou_wei
Cc: dmaengine, linux-kernel, Jiasheng Jiang
Because of the possible failure of the dma_supported(), the
dma_set_mask_and_coherent() may return error num.
Therefore, it should be better to check it and return the error if
fails.
Fixes: dc312349e875 ("dmaengine: rcar-dmac: Widen DMA mask to 40 bits")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/dma/sh/rcar-dmac.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
index 6885b3dcd7a9..79901d0e9fbf 100644
--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -1869,7 +1869,9 @@ static int rcar_dmac_probe(struct platform_device *pdev)
dmac->dev = &pdev->dev;
platform_set_drvdata(pdev, dmac);
dma_set_max_seg_size(dmac->dev, RCAR_DMATCR_MASK);
- dma_set_mask_and_coherent(dmac->dev, DMA_BIT_MASK(40));
+ ret = dma_set_mask_and_coherent(dmac->dev, DMA_BIT_MASK(40));
+ if (ret)
+ return ret;
ret = rcar_dmac_parse_of(&pdev->dev, dmac);
if (ret < 0)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: sh: rcar-dmac: Check for error num after setting mask
2022-01-06 3:09 [PATCH] dmaengine: sh: rcar-dmac: Check for error num after setting mask Jiasheng Jiang
@ 2022-01-10 9:37 ` Geert Uytterhoeven
2022-02-15 5:27 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-01-10 9:37 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: Vinod, Yoshihiro Shimoda, Laurent Pinchart, Wolfram Sang, Zou Wei,
dmaengine, Linux Kernel Mailing List
Hi Jiasheng,
On Thu, Jan 6, 2022 at 4:09 AM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:
> Because of the possible failure of the dma_supported(), the
> dma_set_mask_and_coherent() may return error num.
> Therefore, it should be better to check it and return the error if
> fails.
>
> Fixes: dc312349e875 ("dmaengine: rcar-dmac: Widen DMA mask to 40 bits")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -1869,7 +1869,9 @@ static int rcar_dmac_probe(struct platform_device *pdev)
> dmac->dev = &pdev->dev;
> platform_set_drvdata(pdev, dmac);
> dma_set_max_seg_size(dmac->dev, RCAR_DMATCR_MASK);
dma_set_max_seg_size() can fail, too.
> - dma_set_mask_and_coherent(dmac->dev, DMA_BIT_MASK(40));
> + ret = dma_set_mask_and_coherent(dmac->dev, DMA_BIT_MASK(40));
> + if (ret)
> + return ret;
>
> ret = rcar_dmac_parse_of(&pdev->dev, dmac);
> if (ret < 0)
> --
> 2.25.1
>
--
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: sh: rcar-dmac: Check for error num after setting mask
2022-01-06 3:09 [PATCH] dmaengine: sh: rcar-dmac: Check for error num after setting mask Jiasheng Jiang
2022-01-10 9:37 ` Geert Uytterhoeven
@ 2022-02-15 5:27 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-02-15 5:27 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: geert+renesas, yoshihiro.shimoda.uh, laurent.pinchart,
wsa+renesas, zou_wei, dmaengine, linux-kernel
On 06-01-22, 11:09, Jiasheng Jiang wrote:
> Because of the possible failure of the dma_supported(), the
> dma_set_mask_and_coherent() may return error num.
> Therefore, it should be better to check it and return the error if
> fails.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-15 5:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-06 3:09 [PATCH] dmaengine: sh: rcar-dmac: Check for error num after setting mask Jiasheng Jiang
2022-01-10 9:37 ` Geert Uytterhoeven
2022-02-15 5:27 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox