* [PATCH] dmaengine: sh: rcar-dmac: Check for error num after dma_set_max_seg_size
@ 2022-01-11 1:12 Jiasheng Jiang
2022-01-11 9:42 ` Geert Uytterhoeven
2022-02-15 5:30 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Jiasheng Jiang @ 2022-01-11 1:12 UTC (permalink / raw)
To: geert
Cc: vkoul, yoshihiro.shimoda.uh, laurent.pinchart, wsa+renesas,
zou_wei, dmaengine, linux-kernel, Jiasheng Jiang,
Geert Uytterhoeven
As the possible failure of the dma_set_max_seg_size(), it should be
better to check the return value of the dma_set_max_seg_size().
Fixes: 97d49c59e219 ("dmaengine: rcar-dmac: set scatter/gather max segment size")
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/dma/sh/rcar-dmac.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
index 6885b3dcd7a9..63a0c8cb46b3 100644
--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -1868,7 +1868,10 @@ static int rcar_dmac_probe(struct platform_device *pdev)
dmac->dev = &pdev->dev;
platform_set_drvdata(pdev, dmac);
- dma_set_max_seg_size(dmac->dev, RCAR_DMATCR_MASK);
+ ret = dma_set_max_seg_size(dmac->dev, RCAR_DMATCR_MASK);
+ if (ret)
+ return ret;
+
dma_set_mask_and_coherent(dmac->dev, DMA_BIT_MASK(40));
ret = rcar_dmac_parse_of(&pdev->dev, dmac);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: sh: rcar-dmac: Check for error num after dma_set_max_seg_size
2022-01-11 1:12 [PATCH] dmaengine: sh: rcar-dmac: Check for error num after dma_set_max_seg_size Jiasheng Jiang
@ 2022-01-11 9:42 ` Geert Uytterhoeven
2022-02-15 5:30 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-01-11 9:42 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: Vinod, Yoshihiro Shimoda, Laurent Pinchart, Wolfram Sang, Zou Wei,
dmaengine, Linux Kernel Mailing List
On Tue, Jan 11, 2022 at 2:12 AM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:
> As the possible failure of the dma_set_max_seg_size(), it should be
> better to check the return value of the dma_set_max_seg_size().
>
> Fixes: 97d49c59e219 ("dmaengine: rcar-dmac: set scatter/gather max segment size")
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: sh: rcar-dmac: Check for error num after dma_set_max_seg_size
2022-01-11 1:12 [PATCH] dmaengine: sh: rcar-dmac: Check for error num after dma_set_max_seg_size Jiasheng Jiang
2022-01-11 9:42 ` Geert Uytterhoeven
@ 2022-02-15 5:30 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-02-15 5:30 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: geert, yoshihiro.shimoda.uh, laurent.pinchart, wsa+renesas,
zou_wei, dmaengine, linux-kernel, Geert Uytterhoeven
On 11-01-22, 09:12, Jiasheng Jiang wrote:
> As the possible failure of the dma_set_max_seg_size(), it should be
> better to check the return value of the dma_set_max_seg_size().
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-15 5:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-11 1:12 [PATCH] dmaengine: sh: rcar-dmac: Check for error num after dma_set_max_seg_size Jiasheng Jiang
2022-01-11 9:42 ` Geert Uytterhoeven
2022-02-15 5:30 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox