* [PATCH] dmaengine: mv_xor_v2: move spin_lock_bh to spin_lock
@ 2022-04-18 14:19 Yunbo Yu
2022-04-20 10:30 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Yunbo Yu @ 2022-04-18 14:19 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine, linux-kernel, Yunbo Yu
It is unnecessary to call spin_lock_bh() for that you are already in a
taselet.
Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
---
drivers/dma/mv_xor_v2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
index 9c8b4084ba2f..f10b29034da1 100644
--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -591,14 +591,14 @@ static void mv_xor_v2_tasklet(struct tasklet_struct *t)
dma_run_dependencies(&next_pending_sw_desc->async_tx);
/* Lock the channel */
- spin_lock_bh(&xor_dev->lock);
+ spin_lock(&xor_dev->lock);
/* add the SW descriptor to the free descriptors list */
list_add(&next_pending_sw_desc->free_list,
&xor_dev->free_sw_desc);
/* Release the channel */
- spin_unlock_bh(&xor_dev->lock);
+ spin_unlock(&xor_dev->lock);
/* increment the next descriptor */
pending_ptr++;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: mv_xor_v2: move spin_lock_bh to spin_lock
2022-04-18 14:19 [PATCH] dmaengine: mv_xor_v2: move spin_lock_bh to spin_lock Yunbo Yu
@ 2022-04-20 10:30 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-04-20 10:30 UTC (permalink / raw)
To: Yunbo Yu; +Cc: dmaengine, linux-kernel
On 18-04-22, 22:19, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for that you are already in a
if you are
> taselet.
tasklet
>
> Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
> ---
> drivers/dma/mv_xor_v2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
> index 9c8b4084ba2f..f10b29034da1 100644
> --- a/drivers/dma/mv_xor_v2.c
> +++ b/drivers/dma/mv_xor_v2.c
> @@ -591,14 +591,14 @@ static void mv_xor_v2_tasklet(struct tasklet_struct *t)
> dma_run_dependencies(&next_pending_sw_desc->async_tx);
>
> /* Lock the channel */
> - spin_lock_bh(&xor_dev->lock);
> + spin_lock(&xor_dev->lock);
>
> /* add the SW descriptor to the free descriptors list */
> list_add(&next_pending_sw_desc->free_list,
> &xor_dev->free_sw_desc);
>
> /* Release the channel */
> - spin_unlock_bh(&xor_dev->lock);
> + spin_unlock(&xor_dev->lock);
>
> /* increment the next descriptor */
> pending_ptr++;
> --
> 2.25.1
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-20 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-18 14:19 [PATCH] dmaengine: mv_xor_v2: move spin_lock_bh to spin_lock Yunbo Yu
2022-04-20 10:30 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox