* [PATCH] dmaengine: idxd: match type for retries var in idxd_enqcmds()
@ 2022-04-18 21:31 Dave Jiang
2022-04-20 10:34 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2022-04-18 21:31 UTC (permalink / raw)
To: vkoul; +Cc: Thiago Macieira, dmaengine
wq->enqcmds_retries is defined as unsigned int. However, retries on the
stack is defined as int. Change retries to unsigned int to compare the same
type.
Fixes: 7930d8553575 ("dmaengine: idxd: add knob for enqcmds retries")
Suggested-by: Thiago Macieira <thiago.macieira@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/dma/idxd/submit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/idxd/submit.c b/drivers/dma/idxd/submit.c
index e289fd48711a..554b0602d2e9 100644
--- a/drivers/dma/idxd/submit.c
+++ b/drivers/dma/idxd/submit.c
@@ -150,7 +150,8 @@ static void llist_abort_desc(struct idxd_wq *wq, struct idxd_irq_entry *ie,
*/
int idxd_enqcmds(struct idxd_wq *wq, void __iomem *portal, const void *desc)
{
- int rc, retries = 0;
+ unsigned int retries = 0;
+ int rc;
do {
rc = enqcmds(portal, desc);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: idxd: match type for retries var in idxd_enqcmds()
2022-04-18 21:31 [PATCH] dmaengine: idxd: match type for retries var in idxd_enqcmds() Dave Jiang
@ 2022-04-20 10:34 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-04-20 10:34 UTC (permalink / raw)
To: Dave Jiang; +Cc: Thiago Macieira, dmaengine
On 18-04-22, 14:31, Dave Jiang wrote:
> wq->enqcmds_retries is defined as unsigned int. However, retries on the
> stack is defined as int. Change retries to unsigned int to compare the same
> type.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-20 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-18 21:31 [PATCH] dmaengine: idxd: match type for retries var in idxd_enqcmds() Dave Jiang
2022-04-20 10:34 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox