From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Ben Walker <benjamin.walker@intel.com>, dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: set DMA_INTERRUPT cap bit
Date: Wed, 20 Apr 2022 17:18:20 +0530 [thread overview]
Message-ID: <Yl/zBG+XxFP9mgHg@matsya> (raw)
In-Reply-To: <164971497859.2201379.17925303210723708961.stgit@djiang5-desk3.ch.intel.com>
On 11-04-22, 15:09, Dave Jiang wrote:
> Even though idxd driver has always supported interrupt, it never actually
> set the DMA_INTERRUPT cap bit. Rectify this mistake so the interrupt
> capability is advertised.
Applied, thanks
>
> Reported-by: Ben Walker <benjamin.walker@intel.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
> index bfff59617d04..13e061944db9 100644
> --- a/drivers/dma/idxd/dma.c
> +++ b/drivers/dma/idxd/dma.c
> @@ -193,6 +193,7 @@ int idxd_register_dma_device(struct idxd_device *idxd)
> INIT_LIST_HEAD(&dma->channels);
> dma->dev = dev;
>
> + dma_cap_set(DMA_INTERRUPT, dma->cap_mask);
> dma_cap_set(DMA_PRIVATE, dma->cap_mask);
> dma_cap_set(DMA_COMPLETION_NO_ORDER, dma->cap_mask);
> dma->device_release = idxd_dma_release;
>
--
~Vinod
prev parent reply other threads:[~2022-04-20 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 22:09 [PATCH] dmaengine: idxd: set DMA_INTERRUPT cap bit Dave Jiang
2022-04-20 11:48 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl/zBG+XxFP9mgHg@matsya \
--to=vkoul@kernel.org \
--cc=benjamin.walker@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox