* [PATCH] dmaengine: idxd: set DMA_INTERRUPT cap bit
@ 2022-04-11 22:09 Dave Jiang
2022-04-20 11:48 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2022-04-11 22:09 UTC (permalink / raw)
To: vkoul; +Cc: Ben Walker, dmaengine
Even though idxd driver has always supported interrupt, it never actually
set the DMA_INTERRUPT cap bit. Rectify this mistake so the interrupt
capability is advertised.
Reported-by: Ben Walker <benjamin.walker@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
drivers/dma/idxd/dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
index bfff59617d04..13e061944db9 100644
--- a/drivers/dma/idxd/dma.c
+++ b/drivers/dma/idxd/dma.c
@@ -193,6 +193,7 @@ int idxd_register_dma_device(struct idxd_device *idxd)
INIT_LIST_HEAD(&dma->channels);
dma->dev = dev;
+ dma_cap_set(DMA_INTERRUPT, dma->cap_mask);
dma_cap_set(DMA_PRIVATE, dma->cap_mask);
dma_cap_set(DMA_COMPLETION_NO_ORDER, dma->cap_mask);
dma->device_release = idxd_dma_release;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: idxd: set DMA_INTERRUPT cap bit
2022-04-11 22:09 [PATCH] dmaengine: idxd: set DMA_INTERRUPT cap bit Dave Jiang
@ 2022-04-20 11:48 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-04-20 11:48 UTC (permalink / raw)
To: Dave Jiang; +Cc: Ben Walker, dmaengine
On 11-04-22, 15:09, Dave Jiang wrote:
> Even though idxd driver has always supported interrupt, it never actually
> set the DMA_INTERRUPT cap bit. Rectify this mistake so the interrupt
> capability is advertised.
Applied, thanks
>
> Reported-by: Ben Walker <benjamin.walker@intel.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
> index bfff59617d04..13e061944db9 100644
> --- a/drivers/dma/idxd/dma.c
> +++ b/drivers/dma/idxd/dma.c
> @@ -193,6 +193,7 @@ int idxd_register_dma_device(struct idxd_device *idxd)
> INIT_LIST_HEAD(&dma->channels);
> dma->dev = dev;
>
> + dma_cap_set(DMA_INTERRUPT, dma->cap_mask);
> dma_cap_set(DMA_PRIVATE, dma->cap_mask);
> dma_cap_set(DMA_COMPLETION_NO_ORDER, dma->cap_mask);
> dma->device_release = idxd_dma_release;
>
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-20 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-11 22:09 [PATCH] dmaengine: idxd: set DMA_INTERRUPT cap bit Dave Jiang
2022-04-20 11:48 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox