DMA Engine development
 help / color / mirror / Atom feed
* [PATCH 0/3] Add GPI DMA support for SM6350
@ 2022-08-12  8:27 Luca Weiss
  2022-08-12  8:27 ` [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible " Luca Weiss
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Luca Weiss @ 2022-08-12  8:27 UTC (permalink / raw)
  To: linux-arm-msm
  Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, devicetree,
	dmaengine, Konrad Dybcio, linux-kernel, Vinod Koul

This series hooks up GPI DMA support for the SM6350 I2C.

It has been tested using himax,hxcommon driver that I forward-ported
from the original vendor kernel on fairphone-fp4 - previously I have
used i2c-gpio bitbang in my tree.

This also requires the fix from Robin[0] that has already been
accepted into linux-next, otherwise I2C communication fails to work.

[0] https://lore.kernel.org/linux-arm-msm/20220807140455.409417-1-robin.reckmann@gmail.com/

Luca Weiss (3):
  dt-bindings: dmaengine: qcom: gpi: add compatible for SM6350
  dmaengine: qcom: gpi: Add SM6350 support
  arm64: dts: qcom: sm6350: Add GPI DMA nodes

 .../devicetree/bindings/dma/qcom,gpi.yaml     |  1 +
 arch/arm64/boot/dts/qcom/sm6350.dtsi          | 59 +++++++++++++++++++
 drivers/dma/qcom/gpi.c                        |  1 +
 3 files changed, 61 insertions(+)

-- 
2.37.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for SM6350
  2022-08-12  8:27 [PATCH 0/3] Add GPI DMA support for SM6350 Luca Weiss
@ 2022-08-12  8:27 ` Luca Weiss
  2022-08-12 10:05   ` Krzysztof Kozlowski
  2022-08-29 21:42   ` Bjorn Andersson
  2022-08-12  8:27 ` [PATCH 2/3] dmaengine: qcom: gpi: Add SM6350 support Luca Weiss
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 8+ messages in thread
From: Luca Weiss @ 2022-08-12  8:27 UTC (permalink / raw)
  To: linux-arm-msm
  Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Vinod Koul, Rob Herring,
	Krzysztof Kozlowski, dmaengine, devicetree, linux-kernel

Document the compatible for GPI DMA controller on SM6350 SoC.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
index 7d2fc4eb5530..eabf8a76d3a0 100644
--- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
@@ -21,6 +21,7 @@ properties:
     enum:
       - qcom,sc7280-gpi-dma
       - qcom,sdm845-gpi-dma
+      - qcom,sm6350-gpi-dma
       - qcom,sm8150-gpi-dma
       - qcom,sm8250-gpi-dma
       - qcom,sm8350-gpi-dma
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/3] dmaengine: qcom: gpi: Add SM6350 support
  2022-08-12  8:27 [PATCH 0/3] Add GPI DMA support for SM6350 Luca Weiss
  2022-08-12  8:27 ` [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible " Luca Weiss
@ 2022-08-12  8:27 ` Luca Weiss
  2022-08-29 21:42   ` Bjorn Andersson
  2022-08-29 23:46 ` (subset) [PATCH 0/3] Add GPI DMA support for SM6350 Bjorn Andersson
  2022-09-04 16:23 ` Vinod Koul
  3 siblings, 1 reply; 8+ messages in thread
From: Luca Weiss @ 2022-08-12  8:27 UTC (permalink / raw)
  To: linux-arm-msm
  Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Vinod Koul, dmaengine,
	linux-kernel

The Qualcomm SM6350 platform does, like the SM8450, provide a set of GPI
controllers with an ee-offset of 0x10000. Add this to the driver.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 drivers/dma/qcom/gpi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 8f0c9c4e2efd..89839864b4ec 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2288,6 +2288,7 @@ static int gpi_probe(struct platform_device *pdev)
 static const struct of_device_id gpi_of_match[] = {
 	{ .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 },
 	{ .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 },
+	{ .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 },
 	{ .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 },
 	{ .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
 	{ .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for SM6350
  2022-08-12  8:27 ` [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible " Luca Weiss
@ 2022-08-12 10:05   ` Krzysztof Kozlowski
  2022-08-29 21:42   ` Bjorn Andersson
  1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-12 10:05 UTC (permalink / raw)
  To: Luca Weiss, linux-arm-msm
  Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Vinod Koul, Rob Herring,
	Krzysztof Kozlowski, dmaengine, devicetree, linux-kernel

On 12/08/2022 11:27, Luca Weiss wrote:
> Document the compatible for GPI DMA controller on SM6350 SoC.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 1 +
>  1 file changed, 1 insertion(+)


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/3] dmaengine: qcom: gpi: Add SM6350 support
  2022-08-12  8:27 ` [PATCH 2/3] dmaengine: qcom: gpi: Add SM6350 support Luca Weiss
@ 2022-08-29 21:42   ` Bjorn Andersson
  0 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2022-08-29 21:42 UTC (permalink / raw)
  To: Luca Weiss
  Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Vinod Koul, dmaengine,
	linux-kernel

On Fri, Aug 12, 2022 at 10:27:20AM +0200, Luca Weiss wrote:
> The Qualcomm SM6350 platform does, like the SM8450, provide a set of GPI
> controllers with an ee-offset of 0x10000. Add this to the driver.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

> ---
>  drivers/dma/qcom/gpi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 8f0c9c4e2efd..89839864b4ec 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -2288,6 +2288,7 @@ static int gpi_probe(struct platform_device *pdev)
>  static const struct of_device_id gpi_of_match[] = {
>  	{ .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 },
>  	{ .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 },
> +	{ .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 },
>  	{ .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 },
>  	{ .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
>  	{ .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },
> -- 
> 2.37.1
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible for SM6350
  2022-08-12  8:27 ` [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible " Luca Weiss
  2022-08-12 10:05   ` Krzysztof Kozlowski
@ 2022-08-29 21:42   ` Bjorn Andersson
  1 sibling, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2022-08-29 21:42 UTC (permalink / raw)
  To: Luca Weiss
  Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Vinod Koul, Rob Herring,
	Krzysztof Kozlowski, dmaengine, devicetree, linux-kernel

On Fri, Aug 12, 2022 at 10:27:19AM +0200, Luca Weiss wrote:
> Document the compatible for GPI DMA controller on SM6350 SoC.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

> ---
>  Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> index 7d2fc4eb5530..eabf8a76d3a0 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> @@ -21,6 +21,7 @@ properties:
>      enum:
>        - qcom,sc7280-gpi-dma
>        - qcom,sdm845-gpi-dma
> +      - qcom,sm6350-gpi-dma
>        - qcom,sm8150-gpi-dma
>        - qcom,sm8250-gpi-dma
>        - qcom,sm8350-gpi-dma
> -- 
> 2.37.1
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: (subset) [PATCH 0/3] Add GPI DMA support for SM6350
  2022-08-12  8:27 [PATCH 0/3] Add GPI DMA support for SM6350 Luca Weiss
  2022-08-12  8:27 ` [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible " Luca Weiss
  2022-08-12  8:27 ` [PATCH 2/3] dmaengine: qcom: gpi: Add SM6350 support Luca Weiss
@ 2022-08-29 23:46 ` Bjorn Andersson
  2022-09-04 16:23 ` Vinod Koul
  3 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2022-08-29 23:46 UTC (permalink / raw)
  To: linux-arm-msm, luca.weiss
  Cc: vkoul, dmaengine, ~postmarketos/upstreaming, linux-kernel,
	konrad.dybcio, phone-devel, devicetree

On Fri, 12 Aug 2022 10:27:18 +0200, Luca Weiss wrote:
> This series hooks up GPI DMA support for the SM6350 I2C.
> 
> It has been tested using himax,hxcommon driver that I forward-ported
> from the original vendor kernel on fairphone-fp4 - previously I have
> used i2c-gpio bitbang in my tree.
> 
> This also requires the fix from Robin[0] that has already been
> accepted into linux-next, otherwise I2C communication fails to work.
> 
> [...]

Applied, thanks!

[3/3] arm64: dts: qcom: sm6350: Add GPI DMA nodes
      commit: 9f0149caf0dc1c1261a612b0653d31d998f80596

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/3] Add GPI DMA support for SM6350
  2022-08-12  8:27 [PATCH 0/3] Add GPI DMA support for SM6350 Luca Weiss
                   ` (2 preceding siblings ...)
  2022-08-29 23:46 ` (subset) [PATCH 0/3] Add GPI DMA support for SM6350 Bjorn Andersson
@ 2022-09-04 16:23 ` Vinod Koul
  3 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2022-09-04 16:23 UTC (permalink / raw)
  To: Luca Weiss
  Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel, devicetree,
	dmaengine, Konrad Dybcio, linux-kernel

On 12-08-22, 10:27, Luca Weiss wrote:
> This series hooks up GPI DMA support for the SM6350 I2C.
> 
> It has been tested using himax,hxcommon driver that I forward-ported
> from the original vendor kernel on fairphone-fp4 - previously I have
> used i2c-gpio bitbang in my tree.

Applied 1-2, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-09-04 16:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-12  8:27 [PATCH 0/3] Add GPI DMA support for SM6350 Luca Weiss
2022-08-12  8:27 ` [PATCH 1/3] dt-bindings: dmaengine: qcom: gpi: add compatible " Luca Weiss
2022-08-12 10:05   ` Krzysztof Kozlowski
2022-08-29 21:42   ` Bjorn Andersson
2022-08-12  8:27 ` [PATCH 2/3] dmaengine: qcom: gpi: Add SM6350 support Luca Weiss
2022-08-29 21:42   ` Bjorn Andersson
2022-08-29 23:46 ` (subset) [PATCH 0/3] Add GPI DMA support for SM6350 Bjorn Andersson
2022-09-04 16:23 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox