public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: dma: rz-dmac: Document clock-names and reset-names
@ 2023-03-15  6:47 Biju Das
  2023-03-15  7:53 ` Krzysztof Kozlowski
  2023-03-17 17:27 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Biju Das @ 2023-03-15  6:47 UTC (permalink / raw)
  To: Vinod Koul, Rob Herring, Krzysztof Kozlowski
  Cc: Biju Das, dmaengine, devicetree, Geert Uytterhoeven,
	Prabhakar Mahadev Lad, linux-renesas-soc

Document clock-names and reset-names properties as we have multiple
clocks and resets.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 .../devicetree/bindings/dma/renesas,rz-dmac.yaml   | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
index f638d3934e71..c284abc6784a 100644
--- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
@@ -54,6 +54,11 @@ properties:
       - description: DMA main clock
       - description: DMA register access clock
 
+  clock-names:
+    items:
+      - const: main
+      - const: register
+
   '#dma-cells':
     const: 1
     description:
@@ -77,16 +82,23 @@ properties:
       - description: Reset for DMA ARESETN reset terminal
       - description: Reset for DMA RST_ASYNC reset terminal
 
+  reset-names:
+    items:
+      - const: arst
+      - const: rst_async
+
 required:
   - compatible
   - reg
   - interrupts
   - interrupt-names
   - clocks
+  - clock-names
   - '#dma-cells'
   - dma-channels
   - power-domains
   - resets
+  - reset-names
 
 additionalProperties: false
 
@@ -124,9 +136,11 @@ examples:
                           "ch12", "ch13", "ch14", "ch15";
         clocks = <&cpg CPG_MOD R9A07G044_DMAC_ACLK>,
                  <&cpg CPG_MOD R9A07G044_DMAC_PCLK>;
+        clock-names = "main", "register";
         power-domains = <&cpg>;
         resets = <&cpg R9A07G044_DMAC_ARESETN>,
                  <&cpg R9A07G044_DMAC_RST_ASYNC>;
+        reset-names = "arst", "rst_async";
         #dma-cells = <1>;
         dma-channels = <16>;
     };
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] dt-bindings: dma: rz-dmac: Document clock-names and reset-names
  2023-03-15  6:47 [PATCH 1/2] dt-bindings: dma: rz-dmac: Document clock-names and reset-names Biju Das
@ 2023-03-15  7:53 ` Krzysztof Kozlowski
  2023-03-17 17:27 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-15  7:53 UTC (permalink / raw)
  To: Biju Das, Vinod Koul, Rob Herring, Krzysztof Kozlowski
  Cc: dmaengine, devicetree, Geert Uytterhoeven, Prabhakar Mahadev Lad,
	linux-renesas-soc

On 15/03/2023 07:47, Biju Das wrote:
> Document clock-names and reset-names properties as we have multiple
> clocks and resets.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  .../devicetree/bindings/dma/renesas,rz-dmac.yaml   | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> index f638d3934e71..c284abc6784a 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
> @@ -54,6 +54,11 @@ properties:
>        - description: DMA main clock
>        - description: DMA register access clock
>  
> +  clock-names:
> +    items:
> +      - const: main
> +      - const: register
> +
>    '#dma-cells':
>      const: 1
>      description:
> @@ -77,16 +82,23 @@ properties:
>        - description: Reset for DMA ARESETN reset terminal
>        - description: Reset for DMA RST_ASYNC reset terminal
>  
> +  reset-names:
> +    items:
> +      - const: arst
> +      - const: rst_async
> +
>  required:
>    - compatible
>    - reg
>    - interrupts
>    - interrupt-names
>    - clocks
> +  - clock-names
>    - '#dma-cells'
>    - dma-channels
>    - power-domains
>    - resets
> +  - reset-names

The clock and reset entries are ordered anyway, so requiring '-names' is
not really necessary.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] dt-bindings: dma: rz-dmac: Document clock-names and reset-names
  2023-03-15  6:47 [PATCH 1/2] dt-bindings: dma: rz-dmac: Document clock-names and reset-names Biju Das
  2023-03-15  7:53 ` Krzysztof Kozlowski
@ 2023-03-17 17:27 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-03-17 17:27 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Krzysztof Kozlowski, dmaengine, devicetree,
	Geert Uytterhoeven, Prabhakar Mahadev Lad, linux-renesas-soc

On 15-03-23, 06:47, Biju Das wrote:
> Document clock-names and reset-names properties as we have multiple
> clocks and resets.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-17 17:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-15  6:47 [PATCH 1/2] dt-bindings: dma: rz-dmac: Document clock-names and reset-names Biju Das
2023-03-15  7:53 ` Krzysztof Kozlowski
2023-03-17 17:27 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox