public inbox for dmaengine@vger.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Frank Li <Frank.li@nxp.com>
Cc: vkoul@kernel.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'
Date: Thu, 16 May 2024 15:28:41 +0000	[thread overview]
Message-ID: <ZkYmKVQ5NRwgSA53@gallifrey> (raw)
In-Reply-To: <ZkYeE2SgzCFDqKs2@lizhi-Precision-Tower-5810>

* Frank Li (Frank.li@nxp.com) wrote:
> On Thu, May 16, 2024 at 02:32:50PM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'moxart_filter_data' never appears to have been used.
> > Remove it.
> 
> You can duplicate subject.
> 
> Remove unused struct moxart_filter_data.

V2 sent.

Dave

> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  drivers/dma/moxart-dma.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
> > index c48d68cbff92..66dc6d31b603 100644
> > --- a/drivers/dma/moxart-dma.c
> > +++ b/drivers/dma/moxart-dma.c
> > @@ -148,11 +148,6 @@ struct moxart_dmadev {
> >  	unsigned int			irq;
> >  };
> >  
> > -struct moxart_filter_data {
> > -	struct moxart_dmadev		*mdc;
> > -	struct of_phandle_args		*dma_spec;
> > -};
> > -
> >  static const unsigned int es_bytes[] = {
> >  	[MOXART_DMA_DATA_TYPE_S8] = 1,
> >  	[MOXART_DMA_DATA_TYPE_S16] = 2,
> > -- 
> > 2.45.0
> > 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

      reply	other threads:[~2024-05-16 15:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 13:32 [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data' linux
2024-05-16 14:54 ` Frank Li
2024-05-16 15:28   ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZkYmKVQ5NRwgSA53@gallifrey \
    --to=linux@treblig.org \
    --cc=Frank.li@nxp.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox