* [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'
@ 2024-05-16 13:32 linux
2024-05-16 14:54 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: linux @ 2024-05-16 13:32 UTC (permalink / raw)
To: vkoul; +Cc: dmaengine, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'moxart_filter_data' never appears to have been used.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/dma/moxart-dma.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
index c48d68cbff92..66dc6d31b603 100644
--- a/drivers/dma/moxart-dma.c
+++ b/drivers/dma/moxart-dma.c
@@ -148,11 +148,6 @@ struct moxart_dmadev {
unsigned int irq;
};
-struct moxart_filter_data {
- struct moxart_dmadev *mdc;
- struct of_phandle_args *dma_spec;
-};
-
static const unsigned int es_bytes[] = {
[MOXART_DMA_DATA_TYPE_S8] = 1,
[MOXART_DMA_DATA_TYPE_S16] = 2,
--
2.45.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'
2024-05-16 13:32 [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data' linux
@ 2024-05-16 14:54 ` Frank Li
2024-05-16 15:28 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2024-05-16 14:54 UTC (permalink / raw)
To: linux; +Cc: vkoul, dmaengine, linux-kernel
On Thu, May 16, 2024 at 02:32:50PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'moxart_filter_data' never appears to have been used.
> Remove it.
You can duplicate subject.
Remove unused struct moxart_filter_data.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/dma/moxart-dma.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
> index c48d68cbff92..66dc6d31b603 100644
> --- a/drivers/dma/moxart-dma.c
> +++ b/drivers/dma/moxart-dma.c
> @@ -148,11 +148,6 @@ struct moxart_dmadev {
> unsigned int irq;
> };
>
> -struct moxart_filter_data {
> - struct moxart_dmadev *mdc;
> - struct of_phandle_args *dma_spec;
> -};
> -
> static const unsigned int es_bytes[] = {
> [MOXART_DMA_DATA_TYPE_S8] = 1,
> [MOXART_DMA_DATA_TYPE_S16] = 2,
> --
> 2.45.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data'
2024-05-16 14:54 ` Frank Li
@ 2024-05-16 15:28 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2024-05-16 15:28 UTC (permalink / raw)
To: Frank Li; +Cc: vkoul, dmaengine, linux-kernel
* Frank Li (Frank.li@nxp.com) wrote:
> On Thu, May 16, 2024 at 02:32:50PM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > 'moxart_filter_data' never appears to have been used.
> > Remove it.
>
> You can duplicate subject.
>
> Remove unused struct moxart_filter_data.
V2 sent.
Dave
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> > drivers/dma/moxart-dma.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
> > index c48d68cbff92..66dc6d31b603 100644
> > --- a/drivers/dma/moxart-dma.c
> > +++ b/drivers/dma/moxart-dma.c
> > @@ -148,11 +148,6 @@ struct moxart_dmadev {
> > unsigned int irq;
> > };
> >
> > -struct moxart_filter_data {
> > - struct moxart_dmadev *mdc;
> > - struct of_phandle_args *dma_spec;
> > -};
> > -
> > static const unsigned int es_bytes[] = {
> > [MOXART_DMA_DATA_TYPE_S8] = 1,
> > [MOXART_DMA_DATA_TYPE_S16] = 2,
> > --
> > 2.45.0
> >
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-16 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 13:32 [PATCH] dmaengine: moxart-dma: remove unused struct 'moxart_filter_data' linux
2024-05-16 14:54 ` Frank Li
2024-05-16 15:28 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox