* [PATCH v6 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add fallback compatible for CV1800B
2026-05-11 6:38 [PATCH v6 0/2] riscv: sophgo: allow DMA multiplexer set channel number for DMA controller Inochi Amaoto
@ 2026-05-11 6:38 ` Inochi Amaoto
2026-05-11 16:01 ` Conor Dooley
2026-05-11 6:38 ` [PATCH v6 2/2] riscv: dts: sophgo: cv180x: Allow the DMA multiplexer to set channel number for DMA controller Inochi Amaoto
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Inochi Amaoto @ 2026-05-11 6:38 UTC (permalink / raw)
To: Eugeniy Paltsev, Vinod Koul, Frank Li, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Chen Wang, Inochi Amaoto,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Alexander Sverdlin, Longbin Li, Yixun Lan, Anton D. Stavinskii
Cc: dmaengine, devicetree, linux-kernel, sophgo, linux-riscv,
Yixun Lan
The previous version of the binding change only add compatible
string without adding the fallback compatible, this breaks
backward compatibility. Add the needed fallback compatible to
fix this.
Fixes: be3e2a0419c6 ("dt-bindings: dma: snps,dw-axi-dmac: Add CV1800B compatible")
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
index 804514732dbe..0a30a455b0ee 100644
--- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
@@ -21,11 +21,12 @@ properties:
- enum:
- snps,axi-dma-1.01a
- intel,kmb-axi-dma
- - sophgo,cv1800b-axi-dma
- starfive,jh7110-axi-dma
- starfive,jh8100-axi-dma
- items:
- - const: altr,agilex5-axi-dma
+ - enum:
+ - altr,agilex5-axi-dma
+ - sophgo,cv1800b-axi-dma
- const: snps,axi-dma-1.01a
reg:
--
2.54.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v6 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add fallback compatible for CV1800B
2026-05-11 6:38 ` [PATCH v6 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add fallback compatible for CV1800B Inochi Amaoto
@ 2026-05-11 16:01 ` Conor Dooley
2026-05-11 22:04 ` Inochi Amaoto
0 siblings, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2026-05-11 16:01 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Eugeniy Paltsev, Vinod Koul, Frank Li, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Chen Wang, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Alexander Sverdlin,
Longbin Li, Yixun Lan, Anton D. Stavinskii, dmaengine, devicetree,
linux-kernel, sophgo, linux-riscv, Yixun Lan
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
On Mon, May 11, 2026 at 02:38:16PM +0800, Inochi Amaoto wrote:
> The previous version of the binding change only add compatible
> string without adding the fallback compatible, this breaks
> backward compatibility. Add the needed fallback compatible to
> fix this.
I don't understand how adding a specific comaptible affected backwards
compatibility. Did the dts originally use the snps compatible before the
device specific one was added?
>
> Fixes: be3e2a0419c6 ("dt-bindings: dma: snps,dw-axi-dmac: Add CV1800B compatible")
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 804514732dbe..0a30a455b0ee 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -21,11 +21,12 @@ properties:
> - enum:
> - snps,axi-dma-1.01a
> - intel,kmb-axi-dma
> - - sophgo,cv1800b-axi-dma
> - starfive,jh7110-axi-dma
> - starfive,jh8100-axi-dma
> - items:
> - - const: altr,agilex5-axi-dma
> + - enum:
> + - altr,agilex5-axi-dma
> + - sophgo,cv1800b-axi-dma
> - const: snps,axi-dma-1.01a
>
> reg:
> --
> 2.54.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v6 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add fallback compatible for CV1800B
2026-05-11 16:01 ` Conor Dooley
@ 2026-05-11 22:04 ` Inochi Amaoto
2026-05-12 16:57 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Inochi Amaoto @ 2026-05-11 22:04 UTC (permalink / raw)
To: Conor Dooley, Inochi Amaoto
Cc: Eugeniy Paltsev, Vinod Koul, Frank Li, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Chen Wang, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Alexander Sverdlin,
Longbin Li, Yixun Lan, Anton D. Stavinskii, dmaengine, devicetree,
linux-kernel, sophgo, linux-riscv, Yixun Lan
On Mon, May 11, 2026 at 05:01:01PM +0100, Conor Dooley wrote:
> On Mon, May 11, 2026 at 02:38:16PM +0800, Inochi Amaoto wrote:
> > The previous version of the binding change only add compatible
> > string without adding the fallback compatible, this breaks
> > backward compatibility. Add the needed fallback compatible to
> > fix this.
>
> I don't understand how adding a specific comaptible affected backwards
> compatibility. Did the dts originally use the snps compatible before the
> device specific one was added?
>
Yes, the device is already in DTS, and since I find an quirk for
it. A new compatible with fallback is necessary.
Regards,
Inochi
> >
> > Fixes: be3e2a0419c6 ("dt-bindings: dma: snps,dw-axi-dmac: Add CV1800B compatible")
> > Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> > ---
> > Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > index 804514732dbe..0a30a455b0ee 100644
> > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > @@ -21,11 +21,12 @@ properties:
> > - enum:
> > - snps,axi-dma-1.01a
> > - intel,kmb-axi-dma
> > - - sophgo,cv1800b-axi-dma
> > - starfive,jh7110-axi-dma
> > - starfive,jh8100-axi-dma
> > - items:
> > - - const: altr,agilex5-axi-dma
> > + - enum:
> > + - altr,agilex5-axi-dma
> > + - sophgo,cv1800b-axi-dma
> > - const: snps,axi-dma-1.01a
> >
> > reg:
> > --
> > 2.54.0
> >
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v6 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add fallback compatible for CV1800B
2026-05-11 22:04 ` Inochi Amaoto
@ 2026-05-12 16:57 ` Conor Dooley
0 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2026-05-12 16:57 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Eugeniy Paltsev, Vinod Koul, Frank Li, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Chen Wang, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Alexander Sverdlin,
Longbin Li, Yixun Lan, Anton D. Stavinskii, dmaengine, devicetree,
linux-kernel, sophgo, linux-riscv, Yixun Lan
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Tue, May 12, 2026 at 06:04:36AM +0800, Inochi Amaoto wrote:
> On Mon, May 11, 2026 at 05:01:01PM +0100, Conor Dooley wrote:
> > On Mon, May 11, 2026 at 02:38:16PM +0800, Inochi Amaoto wrote:
> > > The previous version of the binding change only add compatible
> > > string without adding the fallback compatible, this breaks
> > > backward compatibility. Add the needed fallback compatible to
> > > fix this.
> >
> > I don't understand how adding a specific comaptible affected backwards
> > compatibility. Did the dts originally use the snps compatible before the
> > device specific one was added?
> >
>
> Yes, the device is already in DTS, and since I find an quirk for
> it. A new compatible with fallback is necessary.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v6 2/2] riscv: dts: sophgo: cv180x: Allow the DMA multiplexer to set channel number for DMA controller
2026-05-11 6:38 [PATCH v6 0/2] riscv: sophgo: allow DMA multiplexer set channel number for DMA controller Inochi Amaoto
2026-05-11 6:38 ` [PATCH v6 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add fallback compatible for CV1800B Inochi Amaoto
@ 2026-05-11 6:38 ` Inochi Amaoto
2026-06-11 5:51 ` (subset) [PATCH v6 0/2] riscv: sophgo: allow DMA multiplexer " Vinod Koul
2026-07-29 1:54 ` Inochi Amaoto
3 siblings, 0 replies; 8+ messages in thread
From: Inochi Amaoto @ 2026-05-11 6:38 UTC (permalink / raw)
To: Eugeniy Paltsev, Vinod Koul, Frank Li, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Chen Wang, Inochi Amaoto,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Alexander Sverdlin, Longbin Li, Yixun Lan, Anton D. Stavinskii
Cc: dmaengine, devicetree, linux-kernel, sophgo, linux-riscv,
Yixun Lan
Change the DMA controller compatible to the sophgo,cv1800b-axi-dma,
which supports setting DMA channel number in DMA phandle args.
This dts change does not break backward compatibility as a fallback
compatiable string is added.
Fixes: 514951a81a5e ("riscv: dts: sophgo: cv18xx: add DMA controller")
Reported-by: Anton D. Stavinskii <stavinsky@gmail.com>
Closes: https://github.com/sophgo/linux/issues/9
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
Tested-by: Anton D. Stavinskii <stavinsky@gmail.com>
---
arch/riscv/boot/dts/sophgo/cv180x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/boot/dts/sophgo/cv180x.dtsi b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
index 06b0ce5a2db7..ecafdee79ac8 100644
--- a/arch/riscv/boot/dts/sophgo/cv180x.dtsi
+++ b/arch/riscv/boot/dts/sophgo/cv180x.dtsi
@@ -417,7 +417,7 @@ sdhci1: mmc@4320000 {
};
dmac: dma-controller@4330000 {
- compatible = "snps,axi-dma-1.01a";
+ compatible = "sophgo,cv1800b-axi-dma", "snps,axi-dma-1.01a";
reg = <0x04330000 0x1000>;
interrupts = <SOC_PERIPHERAL_IRQ(13) IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk CLK_SDMA_AXI>, <&clk CLK_SDMA_AXI>;
--
2.54.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: (subset) [PATCH v6 0/2] riscv: sophgo: allow DMA multiplexer set channel number for DMA controller
2026-05-11 6:38 [PATCH v6 0/2] riscv: sophgo: allow DMA multiplexer set channel number for DMA controller Inochi Amaoto
2026-05-11 6:38 ` [PATCH v6 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add fallback compatible for CV1800B Inochi Amaoto
2026-05-11 6:38 ` [PATCH v6 2/2] riscv: dts: sophgo: cv180x: Allow the DMA multiplexer to set channel number for DMA controller Inochi Amaoto
@ 2026-06-11 5:51 ` Vinod Koul
2026-07-29 1:54 ` Inochi Amaoto
3 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2026-06-11 5:51 UTC (permalink / raw)
To: Eugeniy Paltsev, Frank Li, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Chen Wang, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti, Alexander Sverdlin, Longbin Li, Yixun Lan,
Anton D. Stavinskii, Inochi Amaoto
Cc: dmaengine, devicetree, linux-kernel, sophgo, linux-riscv,
Yixun Lan
On Mon, 11 May 2026 14:38:15 +0800, Inochi Amaoto wrote:
> As the DMA controller on Sophgo CV1800 series SoC only has 8 channels,
> the SoC provides a dma multiplexer to reuse the DMA channel. However,
> the dma multiplexer also controlls the DMA interrupt multiplexer, which
> means that the dma multiplexer needs to know the channel number.
>
> Change the DMA phandle args parsing logic so it can use handshake
> number as channel number if necessary.
>
> [...]
Applied, thanks!
[1/2] dt-bindings: dma: snps,dw-axi-dmac: Add fallback compatible for CV1800B
commit: 7524fe142b5a772f8421aeee2132cf7e21a00103
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: (subset) [PATCH v6 0/2] riscv: sophgo: allow DMA multiplexer set channel number for DMA controller
2026-05-11 6:38 [PATCH v6 0/2] riscv: sophgo: allow DMA multiplexer set channel number for DMA controller Inochi Amaoto
` (2 preceding siblings ...)
2026-06-11 5:51 ` (subset) [PATCH v6 0/2] riscv: sophgo: allow DMA multiplexer " Vinod Koul
@ 2026-07-29 1:54 ` Inochi Amaoto
3 siblings, 0 replies; 8+ messages in thread
From: Inochi Amaoto @ 2026-07-29 1:54 UTC (permalink / raw)
To: Eugeniy Paltsev, Vinod Koul, Frank Li, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Chen Wang, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Longbin Li, Yixun Lan,
Anton D. Stavinskii, Alexander Sverdlin, Inochi Amaoto
Cc: dmaengine, devicetree, linux-kernel, sophgo, linux-riscv
On Mon, 11 May 2026 14:38:15 +0800, Inochi Amaoto wrote:
> As the DMA controller on Sophgo CV1800 series SoC only has 8 channels,
> the SoC provides a dma multiplexer to reuse the DMA channel. However,
> the dma multiplexer also controlls the DMA interrupt multiplexer, which
> means that the dma multiplexer needs to know the channel number.
>
> Change the DMA phandle args parsing logic so it can use handshake
> number as channel number if necessary.
>
> [...]
Applied to dt/riscv, thanks!
[2/2] riscv: dts: sophgo: cv180x: Allow the DMA multiplexer to set channel number for DMA controller
https://github.com/sophgo/linux/commit/3c698b64db0145fb5edc3f19e4170b41b4508281
Thanks,
Inochi
^ permalink raw reply [flat|nested] 8+ messages in thread