[PATCHv2] dmaengine: bestcomm: Enable compile testing

[PATCHv2] dmaengine: bestcomm: Enable compile testing

[Rosen Penev]

Allow the BestComm DMA engine to be selected for PowerPC
compile-test builds.

Assisted-by: Codex:GPT-5.5
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 v2: remove PATA driver change.
 drivers/dma/bestcomm/Kconfig | 3 +--
 1 file changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/bestcomm/Kconfig b/drivers/dma/bestcomm/Kconfig
index 5dd437295964..153b5492c93c 100644
--- a/drivers/dma/bestcomm/Kconfig
+++ b/drivers/dma/bestcomm/Kconfig
@@ -5,7 +5,7 @@
 
 config PPC_BESTCOMM
 	tristate "Bestcomm DMA engine support"
-	depends on PPC_MPC52xx
+	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
 	default n
 	select PPC_LIB_RHEAP
 	help
@@ -34,4 +34,3 @@ config PPC_BESTCOMM_GEN_BD
 	depends on PPC_BESTCOMM
 	help
 	  This option enables the support for the GenBD tasks.
-
-- 
2.54.0

[PATCHv2] dmaengine: bestcomm: Enable compile testing

[Rosen Penev]

Allow the BestComm DMA engine to be selected for PowerPC
compile-test builds.

The freescale ethernet and sound drivers now need a dependency on
PPC_MPC52xx as they use headers/functions from that platform.

Assisted-by: LLM
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 v2: keep it bestcomm only
 drivers/dma/bestcomm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion1(-)

diff --git a/drivers/dma/bestcomm/Kconfig b/drivers/dma/bestcomm/Kconfig
index 5dd437295964..153b5492c93c 100644
--- a/drivers/dma/bestcomm/Kconfig
+++ b/drivers/dma/bestcomm/Kconfig
@@ -5,7 +5,7 @@
 
 config PPC_BESTCOMM
 	tristate "Bestcomm DMA engine support"
-	depends on PPC_MPC52xx
+	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
 	default n
 	select PPC_LIB_RHEAP
 	help
-- 
2.55.0

Re: [PATCHv2] dmaengine: bestcomm: Enable compile testing

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: missing PPC_MPC52xx dependency for SND_SOC_MPC5200_AC97
--

commit 95cb68468081de8e2880323cb63c64d9da8626b0
Author: Rosen Penev <rosenp@gmail.com>

dmaengine: bestcomm: Enable compile testing

This commit relaxing the dependency for the BestComm DMA engine allows it to
be selected on PowerPC for compile-test builds. It adds an alternative
dependency on (PPC && COMPILE_TEST).

> diff --git a/drivers/dma/bestcomm/Kconfig b/drivers/dma/bestcomm/Kconfig
> index 5dd437295964d..e23ba4982d7ed 100644
> --- a/drivers/dma/bestcomm/Kconfig
> +++ b/drivers/dma/bestcomm/Kconfig
> @@ -5,7 +5,7 @@
>  
>  config PPC_BESTCOMM
>  	tristate "Bestcomm DMA engine support"
> -	depends on PPC_MPC52xx
> +	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)

[Severity: Low]
Does relaxing this dependency cause an unresolved symbol during link time for
SND_SOC_MPC5200_AC97?

When COMPILE_TEST is enabled on PowerPC, PPC_BESTCOMM can be selected without
PPC_MPC52xx. However, SND_SOC_MPC5200_AC97 in sound/soc/fsl/Kconfig depends
on PPC_BESTCOMM but lacks an explicit dependency on PPC_MPC52xx:

sound/soc/fsl/Kconfig:
    config SND_SOC_MPC5200_AC97
        tristate "Freescale MPC5200 PSC in AC97 mode driver"
        depends on PPC_BESTCOMM

This inherits PPC_BESTCOMM's relaxation and allows the driver to be built
when the platform code is absent. In psc_ac97_cold_reset(), the driver
unconditionally calls a platform function:

sound/soc/fsl/mpc5200_psc_ac97.c:psc_ac97_cold_reset() {
    ...
        mpc5200_psc_ac97_gpio_reset(psc_dma->id);
    ...
}

Since mpc5200_psc_ac97_gpio_reset() is only compiled when PPC_MPC52xx is
enabled, does this result in an undefined reference at link time?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918175950.21657-1-rosenp@gmail.com?part=1

Re: [PATCHv2] dmaengine: bestcomm: Enable compile testing

[Rosen Penev]

On Fri, Sep 18, 2026 at 11:10 AM <sashiko-bot@kernel.org> wrote:
>
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] kconfig: missing PPC_MPC52xx dependency for SND_SOC_MPC5200_AC97
This was merged:

https://lore.kernel.org/linux-sound/178967135736.285745.8925263446043052641.b4-ty@b4/
> --
>
> commit 95cb68468081de8e2880323cb63c64d9da8626b0
> Author: Rosen Penev <rosenp@gmail.com>
>
> dmaengine: bestcomm: Enable compile testing
>
> This commit relaxing the dependency for the BestComm DMA engine allows it to
> be selected on PowerPC for compile-test builds. It adds an alternative
> dependency on (PPC && COMPILE_TEST).
>
> > diff --git a/drivers/dma/bestcomm/Kconfig b/drivers/dma/bestcomm/Kconfig
> > index 5dd437295964d..e23ba4982d7ed 100644
> > --- a/drivers/dma/bestcomm/Kconfig
> > +++ b/drivers/dma/bestcomm/Kconfig
> > @@ -5,7 +5,7 @@
> >
> >  config PPC_BESTCOMM
> >       tristate "Bestcomm DMA engine support"
> > -     depends on PPC_MPC52xx
> > +     depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
>
> [Severity: Low]
> Does relaxing this dependency cause an unresolved symbol during link time for
> SND_SOC_MPC5200_AC97?
>
> When COMPILE_TEST is enabled on PowerPC, PPC_BESTCOMM can be selected without
> PPC_MPC52xx. However, SND_SOC_MPC5200_AC97 in sound/soc/fsl/Kconfig depends
> on PPC_BESTCOMM but lacks an explicit dependency on PPC_MPC52xx:
>
> sound/soc/fsl/Kconfig:
>     config SND_SOC_MPC5200_AC97
>         tristate "Freescale MPC5200 PSC in AC97 mode driver"
>         depends on PPC_BESTCOMM
>
> This inherits PPC_BESTCOMM's relaxation and allows the driver to be built
> when the platform code is absent. In psc_ac97_cold_reset(), the driver
> unconditionally calls a platform function:
>
> sound/soc/fsl/mpc5200_psc_ac97.c:psc_ac97_cold_reset() {
>     ...
>         mpc5200_psc_ac97_gpio_reset(psc_dma->id);
>     ...
> }
>
> Since mpc5200_psc_ac97_gpio_reset() is only compiled when PPC_MPC52xx is
> enabled, does this result in an undefined reference at link time?
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260918175950.21657-1-rosenp@gmail.com?part=1

Re: [PATCHv2] dmaengine: bestcomm: Enable compile testing

[Frank Li]

On Fri, Sep 18, 2026 at 10:59:50AM -0700, Rosen Penev wrote:
> Allow the BestComm DMA engine to be selected for PowerPC
> compile-test builds.
>
> The freescale ethernet and sound drivers now need a dependency on
> PPC_MPC52xx as they use headers/functions from that platform.
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  v2: keep it bestcomm only
>  drivers/dma/bestcomm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion1(-)
>
> diff --git a/drivers/dma/bestcomm/Kconfig b/drivers/dma/bestcomm/Kconfig
> index 5dd437295964..153b5492c93c 100644
> --- a/drivers/dma/bestcomm/Kconfig
> +++ b/drivers/dma/bestcomm/Kconfig
> @@ -5,7 +5,7 @@
>
>  config PPC_BESTCOMM
>  	tristate "Bestcomm DMA engine support"
> -	depends on PPC_MPC52xx
> +	depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
>  	default n
>  	select PPC_LIB_RHEAP
>  	help
> --
> 2.55.0
>

Re: [PATCHv2] dmaengine: bestcomm: Enable compile testing

[Vinod Koul]

On Fri, 18 Sep 2026 10:59:50 -0700, Rosen Penev wrote:
> Allow the BestComm DMA engine to be selected for PowerPC
> compile-test builds.
> 
> The freescale ethernet and sound drivers now need a dependency on
> PPC_MPC52xx as they use headers/functions from that platform.
> 
> 
> [...]

Applied, thanks!

[1/1] dmaengine: bestcomm: Enable compile testing
      commit: 57946765c242005bdb16d17944c27662c8c5b013

Best regards,
-- 
~Vinod