* [PATCH v2] dmaengine: loongson: Remove the %p pointer output
@ 2026-09-18 20:17 Sebastian Andrzej Siewior
2026-09-18 21:44 ` Frank Li
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2026-09-18 20:17 UTC (permalink / raw)
To: dmaengine; +Cc: Frank Li, dmaengine, Binbin Zhou, Vinod Koul, Frank Li
The %pK format modifier was meant for /proc kind of output, not general
printk output. Since commit ad67b74d2469d ("printk: hash addresses
printed with %p") pointers are hashed by default and the behaviour can
be controller by `hash_pointers' boot argument.
The policy on %p is to not introduce new ones. This is the only pointer
output in the driver.
Remove the pointer formating from debug output.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
v1…v2: https://lore.kernel.org/all/20260918103409.UV4g2ON7@linutronix.de/
- Update subject line (it is removed, not replaced).
drivers/dma/loongson/loongson2-apb-cmc-dma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
index 1c9a542edc859..27f8f7a5738d9 100644
--- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
+++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
@@ -337,7 +337,6 @@ static void loongson2_cmc_dma_issue_pending(struct dma_chan *chan)
guard(spinlock_irqsave)(&lchan->vchan.lock);
if (vchan_issue_pending(&lchan->vchan) && !lchan->desc) {
- dev_dbg(chan2dev(lchan), "vchan %pK: issued\n", &lchan->vchan);
loongson2_cmc_dma_start_transfer(lchan);
}
}
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] dmaengine: loongson: Remove the %p pointer output
2026-09-18 20:17 [PATCH v2] dmaengine: loongson: Remove the %p pointer output Sebastian Andrzej Siewior
@ 2026-09-18 21:44 ` Frank Li
0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-09-18 21:44 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: dmaengine, Binbin Zhou, Vinod Koul, Frank Li
On Fri, Sep 18, 2026 at 10:17:14PM +0200, Sebastian Andrzej Siewior wrote:
> The %pK format modifier was meant for /proc kind of output, not general
> printk output. Since commit ad67b74d2469d ("printk: hash addresses
> printed with %p") pointers are hashed by default and the behaviour can
> be controller by `hash_pointers' boot argument.
> The policy on %p is to not introduce new ones. This is the only pointer
> output in the driver.
>
> Remove the pointer formating from debug output.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> v1…v2: https://lore.kernel.org/all/20260918103409.UV4g2ON7@linutronix.de/
> - Update subject line (it is removed, not replaced).
please careful,
remove whole dev_dbg() when vchan_issue_pending() failure.
commit messesge should show why it is okay to remove dev_dbg() here.
Frank
>
> drivers/dma/loongson/loongson2-apb-cmc-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/loongson/loongson2-apb-cmc-dma.c b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> index 1c9a542edc859..27f8f7a5738d9 100644
> --- a/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> +++ b/drivers/dma/loongson/loongson2-apb-cmc-dma.c
> @@ -337,7 +337,6 @@ static void loongson2_cmc_dma_issue_pending(struct dma_chan *chan)
> guard(spinlock_irqsave)(&lchan->vchan.lock);
>
> if (vchan_issue_pending(&lchan->vchan) && !lchan->desc) {
> - dev_dbg(chan2dev(lchan), "vchan %pK: issued\n", &lchan->vchan);
> loongson2_cmc_dma_start_transfer(lchan);
> }
> }
> --
> 2.55.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-18 21:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-18 20:17 [PATCH v2] dmaengine: loongson: Remove the %p pointer output Sebastian Andrzej Siewior
2026-09-18 21:44 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox