* [PATCH] dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe()
@ 2026-11-19 16:06 Markus Elfring
2026-11-19 16:12 ` sashiko-bot
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2026-11-19 16:06 UTC (permalink / raw)
To: dmaengine, Andy Shevchenko, Frank Li, Vinod Koul, Viresh Kumar
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 19 Nov 2026 16:56:09 +0100
Reuse existing functionality from devm_clk_get_optional_enabled()
instead of keeping duplicate source code.
The source code was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/dma/dw/platform.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
index 7e76391475ac..9bb3c2cd0857 100644
--- a/drivers/dma/dw/platform.c
+++ b/drivers/dma/dw/platform.c
@@ -64,12 +64,9 @@ static int dw_probe(struct platform_device *pdev)
data->chip = chip;
- chip->clk = devm_clk_get_optional(chip->dev, "hclk");
+ chip->clk = devm_clk_get_optional_enabled(chip->dev, "hclk");
if (IS_ERR(chip->clk))
return PTR_ERR(chip->clk);
- ret = clk_prepare_enable(chip->clk);
- if (ret)
- return ret;
pm_runtime_enable(&pdev->dev);
--
2.56.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe()
2026-11-19 16:06 [PATCH] dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe() Markus Elfring
@ 2026-11-19 16:12 ` sashiko-bot
2026-11-19 16:53 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: sashiko-bot @ 2026-11-19 16:12 UTC (permalink / raw)
To: Markus Elfring, dmaengine; +Cc: vkoul, Frank.Li
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] dmaengine: dw: double clk_disable_unprepare() in dw_probe() and
dw_remove()
--
commit ff07f5838666895fdb235cca7d9f7155e7085b00
Author: Markus Elfring <elfring@users.sourceforge.net>
dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe()
This commit replaces devm_clk_get_optional() and clk_prepare_enable() in
dw_probe() with devm_clk_get_optional_enabled().
> diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> index 7e76391475ac1..9bb3c2cd08570 100644
> --- a/drivers/dma/dw/platform.c
> +++ b/drivers/dma/dw/platform.c
> @@ -64,12 +64,9 @@ static int dw_probe(struct platform_device *pdev)
>
> data->chip = chip;
>
> - chip->clk = devm_clk_get_optional(chip->dev, "hclk");
> + chip->clk = devm_clk_get_optional_enabled(chip->dev, "hclk");
> if (IS_ERR(chip->clk))
> return PTR_ERR(chip->clk);
> - ret = clk_prepare_enable(chip->clk);
> - if (ret)
> - return ret;
>
> pm_runtime_enable(&pdev->dev);
>
[Severity: High]
Does this cause a double clk_disable_unprepare() on chip->clk?
devm_clk_get_optional_enabled() registers a devres cleanup that disables
and unprepares chip->clk automatically, but both the err_dw_dma_probe
error path in dw_probe() and dw_remove() still call
clk_disable_unprepare(chip->clk) manually. When data->probe() fails or
the device is unbound, chip->clk is disabled and unprepared twice,
underflowing the clock reference counts and triggering WARN() splats in
the clock core.
--
Sashiko AI review · https://sashiko.dev/#/patchset/8e3534b7-ae64-4c1f-819d-0ba390737b84@web.de?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe()
2026-11-19 16:12 ` sashiko-bot
@ 2026-11-19 16:53 ` Frank Li
0 siblings, 0 replies; 3+ messages in thread
From: Frank Li @ 2026-11-19 16:53 UTC (permalink / raw)
To: sashiko-reviews; +Cc: Markus Elfring, dmaengine, vkoul, Frank.Li
On Thu, Nov 19, 2026 at 04:12:30PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] dmaengine: dw: double clk_disable_unprepare() in dw_probe() and
> dw_remove()
> --
>
> commit ff07f5838666895fdb235cca7d9f7155e7085b00
> Author: Markus Elfring <elfring@users.sourceforge.net>
>
> dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe()
>
> This commit replaces devm_clk_get_optional() and clk_prepare_enable() in
> dw_probe() with devm_clk_get_optional_enabled().
>
> > diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
> > index 7e76391475ac1..9bb3c2cd08570 100644
> > --- a/drivers/dma/dw/platform.c
> > +++ b/drivers/dma/dw/platform.c
> > @@ -64,12 +64,9 @@ static int dw_probe(struct platform_device *pdev)
> >
> > data->chip = chip;
> >
> > - chip->clk = devm_clk_get_optional(chip->dev, "hclk");
> > + chip->clk = devm_clk_get_optional_enabled(chip->dev, "hclk");
> > if (IS_ERR(chip->clk))
> > return PTR_ERR(chip->clk);
> > - ret = clk_prepare_enable(chip->clk);
> > - if (ret)
> > - return ret;
> >
> > pm_runtime_enable(&pdev->dev);
> >
>
> [Severity: High]
> Does this cause a double clk_disable_unprepare() on chip->clk?
>
> devm_clk_get_optional_enabled() registers a devres cleanup that disables
> and unprepares chip->clk automatically, but both the err_dw_dma_probe
> error path in dw_probe() and dw_remove() still call
> clk_disable_unprepare(chip->clk) manually. When data->probe() fails or
> the device is unbound, chip->clk is disabled and unprepared twice,
> underflowing the clock reference counts and triggering WARN() splats in
> the clock core.
Please fix this problem
Frank
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/8e3534b7-ae64-4c1f-819d-0ba390737b84@web.de?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-19 16:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 16:06 [PATCH] dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe() Markus Elfring
2026-11-19 16:12 ` sashiko-bot
2026-11-19 16:53 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox