From: Frank Li <Frank.li@oss.nxp.com>
To: David Yang <mmyangfl@gmail.com>
Cc: dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Frank Li <Frank.Li@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dmaengine: pl08x: Release the reset before reading registers
Date: Mon, 16 Nov 2026 14:24:03 -0600 [thread overview]
Message-ID: <avtmY1WaVWI_lxT_@SMW015318> (raw)
In-Reply-To: <20261106072602.77560-2-mmyangfl@gmail.com>
On Fri, Nov 06, 2026 at 03:25:58PM +0800, David Yang wrote:
> [You don't often get email from mmyangfl@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> amba_read_periphid() happens to release the reset. A node that carries
> arm,primecell-periphid never reaches it. Take the reset shared and
> release it ourselves.
>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/amba-pl08x.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 543c2eb8cfa8..9f5e4f5fb877 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -75,6 +75,7 @@
> #include <linux/of.h>
> #include <linux/of_dma.h>
> #include <linux/pm_runtime.h>
> +#include <linux/reset.h>
> #include <linux/seq_file.h>
> #include <linux/slab.h>
> #include <linux/amba/pl080.h>
> @@ -2695,6 +2696,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
> struct pl08x_driver_data *pl08x;
> struct vendor_data *vd = id->data;
> struct device_node *np = adev->dev.of_node;
> + struct reset_control *rst;
> u32 tsfr_size;
> int ret = 0;
> int i;
> @@ -2725,6 +2727,13 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
> goto out_no_ioremap;
> }
>
> + /* Release the reset before reading registers */
> + rst = devm_reset_control_get_optional_shared_deasserted(&adev->dev, NULL);
> + if (IS_ERR(rst)) {
> + ret = PTR_ERR(rst);
> + goto out_no_platdata;
> + }
> +
> if (vd->ftdmac020) {
> u32 val;
>
> --
> 2.53.0
>
next prev parent reply other threads:[~2026-11-16 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 7:25 [PATCH v2 0/2] dmaengine: pl08x: Support the Hi3798MV100 PL080 variant David Yang
2026-11-06 7:25 ` [PATCH v2 1/2] dmaengine: pl08x: Release the reset before reading registers David Yang
2026-11-06 12:32 ` Philipp Zabel
2026-11-16 20:24 ` Frank Li [this message]
2026-11-06 7:25 ` [PATCH v2 2/2] dmaengine: pl08x: Use the channel count from the device tree David Yang
2026-11-16 20:27 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avtmY1WaVWI_lxT_@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox