DMA Engine development
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: David Yang <mmyangfl@gmail.com>
Cc: dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
	Frank Li <Frank.Li@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dmaengine: pl08x: Use the channel count from the device tree
Date: Mon, 16 Nov 2026 14:27:15 -0600	[thread overview]
Message-ID: <avtnI3Xn9xVp6aVX@SMW015318> (raw)
In-Reply-To: <20261106072602.77560-3-mmyangfl@gmail.com>

On Fri, Nov 06, 2026 at 03:25:59PM +0800, David Yang wrote:
> [You don't often get email from mmyangfl@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> The Hi3798MV100 DMAC is a plain PL080 except for the channel count: 4
> instead of 8. The part ID does not say, and the driver takes the count
> from the matched vendor_data entry. The entry is shared between
> instances; the adjustment lands in a private copy. dma-common.yaml
> already defines dma-channels for a controller node. Honor it.
>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/amba-pl08x.c | 25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 9f5e4f5fb877..27c61a7f2082 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -282,7 +282,7 @@ struct pl08x_driver_data {
>         bool has_slave;
>         void __iomem *base;
>         struct amba_device *adev;
> -       const struct vendor_data *vd;
> +       struct vendor_data *vd;
>         struct pl08x_platform_data *pd;
>         struct pl08x_phy_chan *phy_chans;
>         struct dma_pool *pool;
> @@ -2698,6 +2698,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
>         struct device_node *np = adev->dev.of_node;
>         struct reset_control *rst;
>         u32 tsfr_size;
> +       u32 channels;
>         int ret = 0;
>         int i;
>
> @@ -2719,7 +2720,6 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
>
>         /* Assign useful pointers to the driver state */
>         pl08x->adev = adev;
> -       pl08x->vd = vd;
>
>         pl08x->base = ioremap(adev->res.start, resource_size(&adev->res));
>         if (!pl08x->base) {
> @@ -2727,6 +2727,17 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
>                 goto out_no_ioremap;
>         }
>
> +       /*
> +        * vd points into the shared id table; give the instance its own
> +        * copy before anything below starts adjusting it.
> +        */
> +       pl08x->vd = devm_kmemdup(&adev->dev, vd, sizeof(*vd), GFP_KERNEL);
> +       if (!pl08x->vd) {
> +               ret = -ENOMEM;
> +               goto out_no_platdata;
> +       }
> +       vd = pl08x->vd;
> +
>         /* Release the reset before reading registers */
>         rst = devm_reset_control_get_optional_shared_deasserted(&adev->dev, NULL);
>         if (IS_ERR(rst)) {
> @@ -2756,6 +2767,16 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
>                 vd->dualmaster = !!(val & BIT(9));
>         }
>
> +       /* Read the channel number from the node if specified */
> +       if (!of_property_read_u32(np, "dma-channels", &channels) && channels) {
> +               if (channels > vd->channels)
> +                       dev_warn(&adev->dev,
> +                                "using %u channels, instead of %u from the node\n",
> +                                vd->channels, channels);
> +               else
> +                       vd->channels = channels;
> +       }
> +
>         /* Initialize memcpy engine */
>         dma_cap_set(DMA_MEMCPY, pl08x->memcpy.cap_mask);
>         pl08x->memcpy.dev = &adev->dev;
> --
> 2.53.0
>

      reply	other threads:[~2026-11-16 20:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  7:25 [PATCH v2 0/2] dmaengine: pl08x: Support the Hi3798MV100 PL080 variant David Yang
2026-11-06  7:25 ` [PATCH v2 1/2] dmaengine: pl08x: Release the reset before reading registers David Yang
2026-11-06 12:32   ` Philipp Zabel
2026-11-16 20:24   ` Frank Li
2026-11-06  7:25 ` [PATCH v2 2/2] dmaengine: pl08x: Use the channel count from the device tree David Yang
2026-11-16 20:27   ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avtnI3Xn9xVp6aVX@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmyangfl@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox