[PATCH -next] dmaengine: ptdma: Fix static checker warnings

[PATCH -next] dmaengine: ptdma: Fix static checker warnings

[Basavaraj Natikar]

An unnecessary extra check leads to the following static code checker
warning:

    drivers/dma/amd/ptdma/ptdma-dmaengine.c: pt_cmd_callback_work()
    warn: variable dereferenced before check 'desc'

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/bfa0a979-ce9f-422d-92c3-34921155d048@stanley.mountain/
Fixes: 656543989457 ("dmaengine: ptdma: Utilize the AE4DMA engine's multi-queue functionality")
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
---
 drivers/dma/amd/ptdma/ptdma-dmaengine.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
index 715ac3ae067b..d1d38ed811c2 100644
--- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
+++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
@@ -355,16 +355,14 @@ static void pt_cmd_callback_work(void *data, int err)
 		desc->status = DMA_ERROR;
 
 	spin_lock_irqsave(&chan->vc.lock, flags);
-	if (desc) {
-		if (desc->status != DMA_COMPLETE) {
-			if (desc->status != DMA_ERROR)
-				desc->status = DMA_COMPLETE;
+	if (desc->status != DMA_COMPLETE) {
+		if (desc->status != DMA_ERROR)
+			desc->status = DMA_COMPLETE;
 
-			dma_cookie_complete(tx_desc);
-			dma_descriptor_unmap(tx_desc);
-		} else {
-			tx_desc = NULL;
-		}
+		dma_cookie_complete(tx_desc);
+		dma_descriptor_unmap(tx_desc);
+	} else {
+		tx_desc = NULL;
 	}
 	spin_unlock_irqrestore(&chan->vc.lock, flags);
 
-- 
2.34.1

Re: [PATCH -next] dmaengine: ptdma: Fix static checker warnings

[Basavaraj Natikar]

Hi Vinod,

Just a gentle reminder regarding my previous message.
Looking forward to your response.

Thanks,
—
Basavaraj

On 3/12/2025 5:40 PM, Basavaraj Natikar wrote:
> An unnecessary extra check leads to the following static code checker
> warning:
>
>      drivers/dma/amd/ptdma/ptdma-dmaengine.c: pt_cmd_callback_work()
>      warn: variable dereferenced before check 'desc'
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/all/bfa0a979-ce9f-422d-92c3-34921155d048@stanley.mountain/
> Fixes: 656543989457 ("dmaengine: ptdma: Utilize the AE4DMA engine's multi-queue functionality")
> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
> ---
>   drivers/dma/amd/ptdma/ptdma-dmaengine.c | 16 +++++++---------
>   1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> index 715ac3ae067b..d1d38ed811c2 100644
> --- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> +++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> @@ -355,16 +355,14 @@ static void pt_cmd_callback_work(void *data, int err)
>   		desc->status = DMA_ERROR;
>   
>   	spin_lock_irqsave(&chan->vc.lock, flags);
> -	if (desc) {
> -		if (desc->status != DMA_COMPLETE) {
> -			if (desc->status != DMA_ERROR)
> -				desc->status = DMA_COMPLETE;
> +	if (desc->status != DMA_COMPLETE) {
> +		if (desc->status != DMA_ERROR)
> +			desc->status = DMA_COMPLETE;
>   
> -			dma_cookie_complete(tx_desc);
> -			dma_descriptor_unmap(tx_desc);
> -		} else {
> -			tx_desc = NULL;
> -		}
> +		dma_cookie_complete(tx_desc);
> +		dma_descriptor_unmap(tx_desc);
> +	} else {
> +		tx_desc = NULL;
>   	}
>   	spin_unlock_irqrestore(&chan->vc.lock, flags);
>   

Re: [PATCH -next] dmaengine: ptdma: Fix static checker warnings

[Vinod Koul]

Hi,

On 12-03-25, 17:40, Basavaraj Natikar wrote:

Patch title should mention the changes and not cause, please revise
title

> An unnecessary extra check leads to the following static code checker
> warning:
> 
>     drivers/dma/amd/ptdma/ptdma-dmaengine.c: pt_cmd_callback_work()
>     warn: variable dereferenced before check 'desc'

Describe the fix please

> 
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/all/bfa0a979-ce9f-422d-92c3-34921155d048@stanley.mountain/
> Fixes: 656543989457 ("dmaengine: ptdma: Utilize the AE4DMA engine's multi-queue functionality")
> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
> ---
>  drivers/dma/amd/ptdma/ptdma-dmaengine.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> index 715ac3ae067b..d1d38ed811c2 100644
> --- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> +++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> @@ -355,16 +355,14 @@ static void pt_cmd_callback_work(void *data, int err)
>  		desc->status = DMA_ERROR;
>  
>  	spin_lock_irqsave(&chan->vc.lock, flags);
> -	if (desc) {
> -		if (desc->status != DMA_COMPLETE) {
> -			if (desc->status != DMA_ERROR)
> -				desc->status = DMA_COMPLETE;
> +	if (desc->status != DMA_COMPLETE) {
> +		if (desc->status != DMA_ERROR)
> +			desc->status = DMA_COMPLETE;
>  
> -			dma_cookie_complete(tx_desc);
> -			dma_descriptor_unmap(tx_desc);
> -		} else {
> -			tx_desc = NULL;
> -		}
> +		dma_cookie_complete(tx_desc);
> +		dma_descriptor_unmap(tx_desc);
> +	} else {
> +		tx_desc = NULL;
>  	}
>  	spin_unlock_irqrestore(&chan->vc.lock, flags);
>  
> -- 
> 2.34.1

-- 
~Vinod