DMA Engine development
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: Dave Jiang <dave.jiang@intel.com>, vkoul@kernel.org
Cc: dmaengine@vger.kernel.org
Subject: dmaengine: ioatdma: set the completion address register after channel reset
Date: Mon, 11 Jun 2018 15:37:25 -0400	[thread overview]
Message-ID: <dabe9547-cc14-cd42-f26c-e8daf633d7a6@codeaurora.org> (raw)

On 6/11/2018 3:30 PM, Dave Jiang wrote:
> +	/* set the completion address register again */
> +	writel(((u64)ioat_chan->completion_dma) & 0x00000000FFFFFFFF,
> +	       ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_LOW);
> +	writel(((u64)ioat_chan->completion_dma) >> 32,
> +	       ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_HIGH);

You could have used lower_32_bits() and upper_32_bits() macros here.

             reply	other threads:[~2018-06-11 19:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 19:37 Sinan Kaya [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-06-11 19:38 dmaengine: ioatdma: set the completion address register after channel reset Dave Jiang
2018-06-11 19:30 Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dabe9547-cc14-cd42-f26c-e8daf633d7a6@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox