Re: [PATCH 3/5] dmaengine: lgm-dma: split legacy DMA and HDMA functions

[Krzysztof Kozlowski <krzk@kernel.org>]

On 30/07/2025 04:45, Zhu Yixin wrote:
> Move legacy DMA functions into lgm-cdma.c.
> Move HDMA functions into lgm-hdma.c
> Keep the driver flow and general functions in lgm-dma.c
> 
> Signed-off-by: Zhu Yixin <yzhu@maxlinear.com>
> ---
>  .../devicetree/bindings/dma/intel,ldma.yaml   |   7 +-
>  drivers/dma/lgm/Makefile                      |   2 +-
>  drivers/dma/lgm/lgm-cdma.c                    | 492 ++++++++++
>  drivers/dma/lgm/lgm-dma.c                     | 839 ++----------------
>  drivers/dma/lgm/lgm-dma.h                     | 278 ++++++
>  drivers/dma/lgm/lgm-hdma.c                    | 130 +++
>  6 files changed, 961 insertions(+), 787 deletions(-)
>  create mode 100644 drivers/dma/lgm/lgm-cdma.c
>  create mode 100644 drivers/dma/lgm/lgm-dma.h
>  create mode 100644 drivers/dma/lgm/lgm-hdma.c
> 
> diff --git a/Documentation/devicetree/bindings/dma/intel,ldma.yaml b/Documentation/devicetree/bindings/dma/intel,ldma.yaml
> index 59f928297613..f91d849edc4c 100644
> --- a/Documentation/devicetree/bindings/dma/intel,ldma.yaml
> +++ b/Documentation/devicetree/bindings/dma/intel,ldma.yaml
> @@ -15,7 +15,8 @@ allOf:
>  properties:
>    compatible:
>      enum:
> -      - intel,lgm-ldma
> +      - intel,lgm-cdma
> +      - intel,lgm-hdma

NAK, stop random changes to compatibles.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>


Best regards,
Krzysztof