[PATCH v2 1/1] dmaengine: ppc4xx: adma: remove unused async_tx.h include

[PATCH v2 1/1] dmaengine: ppc4xx: adma: remove unused async_tx.h include

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

The async_tx.h header is not directly used in adma.c; all required
types and functions come from dmaengine.h which is already included.
Remove the redundant include.

Reduce async_tx.h user to prepare deprecate aysnc_tx framework.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
v2: change subject tags to dmaengine
---
 drivers/dma/ppc4xx/adma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
index bcc54d584e2bf..05041b99581a1 100644
--- a/drivers/dma/ppc4xx/adma.c
+++ b/drivers/dma/ppc4xx/adma.c
@@ -17,7 +17,6 @@
 
 #include <linux/init.h>
 #include <linux/module.h>
-#include <linux/async_tx.h>
 #include <linux/delay.h>
 #include <linux/dma-mapping.h>
 #include <linux/spinlock.h>
-- 
2.43.0

Re: [PATCH v2 1/1] dmaengine: ppc4xx: adma: remove unused async_tx.h include

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dmaengine: missing prototype for ppc440spe_async_tx_find_best_channel()
--

commit 7df6c7a27c8059b2cc2b7731da8108aa6dffb69a
Author: Frank Li <Frank.Li@nxp.com>

dmaengine: ppc4xx: adma: remove unused async_tx.h include

This commit removes the async_tx.h include from adma.c to prepare for
deprecating the async_tx framework. The commit message states the include
is no longer needed and its functions come from dmaengine.h.

> diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
> index bcc54d584e2bf..05041b99581a1 100644
> --- a/drivers/dma/ppc4xx/adma.c
> +++ b/drivers/dma/ppc4xx/adma.c
> @@ -17,7 +17,6 @@
>  
>  #include <linux/init.h>
>  #include <linux/module.h>
> -#include <linux/async_tx.h>

[Severity: Low]
Does removing this include cause a missing prototype regression for
ppc440spe_async_tx_find_best_channel()?

The prototype for this globally exported function is defined in
arch/powerpc/include/asm/async_tx.h, which is included via
linux/async_tx.h:

include/linux/async_tx.h:
#ifdef CONFIG_ARCH_HAS_ASYNC_TX_FIND_CHANNEL
#include <asm/async_tx.h>
#else

Removing linux/async_tx.h leaves the function without a visible prototype
in adma.c, causing a build warning.

>  #include <linux/delay.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/spinlock.h>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015155616.3068503-1-Frank.Li@oss.nxp.com?part=1

Re: [PATCH v2 1/1] dmaengine: ppc4xx: adma: remove unused async_tx.h include

[Frank Li]

On Thu, Oct 15, 2026 at 04:03:32PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dmaengine: missing prototype for ppc440spe_async_tx_find_best_channel()
> --
>
> commit 7df6c7a27c8059b2cc2b7731da8108aa6dffb69a
> Author: Frank Li <Frank.Li@nxp.com>
>
> dmaengine: ppc4xx: adma: remove unused async_tx.h include
>
> This commit removes the async_tx.h include from adma.c to prepare for
> deprecating the async_tx framework. The commit message states the include
> is no longer needed and its functions come from dmaengine.h.
>
> > diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
> > index bcc54d584e2bf..05041b99581a1 100644
> > --- a/drivers/dma/ppc4xx/adma.c
> > +++ b/drivers/dma/ppc4xx/adma.c
> > @@ -17,7 +17,6 @@
> >
> >  #include <linux/init.h>
> >  #include <linux/module.h>
> > -#include <linux/async_tx.h>
>
> [Severity: Low]
> Does removing this include cause a missing prototype regression for
> ppc440spe_async_tx_find_best_channel()?
>
> The prototype for this globally exported function is defined in
> arch/powerpc/include/asm/async_tx.h, which is included via

This is existing problem. warning is existing even without this patch.

Frank

> linux/async_tx.h:
>
> include/linux/async_tx.h:
> #ifdef CONFIG_ARCH_HAS_ASYNC_TX_FIND_CHANNEL
> #include <asm/async_tx.h>
> #else
>
> Removing linux/async_tx.h leaves the function without a visible prototype
> in adma.c, causing a build warning.
>
> >  #include <linux/delay.h>
> >  #include <linux/dma-mapping.h>
> >  #include <linux/spinlock.h>
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20261015155616.3068503-1-Frank.Li@oss.nxp.com?part=1