From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Ouyang Changchun
<changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 0/3] Vhost app removes dependency of REFCNT
Date: Fri, 24 Oct 2014 11:47:46 +0200 [thread overview]
Message-ID: <11605757.Du0pTjUQ40@xps13> (raw)
In-Reply-To: <1414138209-24431-1-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-24 16:10, Ouyang Changchun:
> To remove the dependency of RTE_MBUF_REFCNT for vhost zero copy,
> the mbuf need introduce EXTERNAL_MBUF(in ol_flags) to indicate it
> attaches to an external buffer, say, from guest space. And don't
> free the external buffer when freeing the mbuf itself in host, in
> addition, RX function in PMD need make sure not overwrite this flag
> when filling ol_flags from descriptors to mbuf.
So you are replacing refcnt by something else which requires special
handling in drivers.
I feel this is not the right design.
Why do you want to remove refcnt dependency?
--
Thomas
next prev parent reply other threads:[~2014-10-24 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 8:10 [PATCH 0/3] Vhost app removes dependency of REFCNT Ouyang Changchun
[not found] ` <1414138209-24431-1-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-24 8:10 ` [PATCH 1/3] mbuf: Use EXTERNAL_MBUF to indicate external buffer Ouyang Changchun
2014-10-24 8:10 ` [PATCH 2/3] pmd: RX function need keep EXTERNAL_MBUF flag Ouyang Changchun
[not found] ` <1414138209-24431-3-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-24 10:46 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772582139EBAF-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-24 12:34 ` Bruce Richardson
2014-10-24 15:43 ` Bruce Richardson
2014-10-24 15:58 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772582139ECF1-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-25 2:08 ` Ouyang, Changchun
2014-10-24 8:10 ` [PATCH 3/3] vhost: Removes dependency on REFCNT for zero copy Ouyang Changchun
2014-10-24 9:47 ` Thomas Monjalon [this message]
2014-10-24 10:47 ` [PATCH 0/3] Vhost app removes dependency of REFCNT Bruce Richardson
2014-10-25 1:01 ` Ouyang, Changchun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11605757.Du0pTjUQ40@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox