[dpdk-dev] [PATCH] net: announce changes in TCP header

[dpdk-dev] [PATCH] net: announce changes in TCP header

[Gregory Etelson]

Announce change to add a union that will provide byte and bitfield
access to TCP flags.

Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d9c0e65921..a78a68108c 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -158,3 +158,6 @@ Deprecation Notices
 * security: The functions ``rte_security_set_pkt_metadata`` and
   ``rte_security_get_userdata`` will be made inline functions and additional
   flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
+
+* net: structure ``rte_tcp_hdr`` will have a union that will provide
+  byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.
-- 
2.32.0

Re: [dpdk-dev] [PATCH] net: announce changes in TCP header

[Slava Ovsiienko]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Gregory Etelson
> Sent: Monday, August 2, 2021 13:42
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Ray Kinsella <mdr@ashroe.eu>
> Subject: [dpdk-dev] [PATCH] net: announce changes in TCP header
> 
> Announce change to add a union that will provide byte and bitfield access to
> TCP flags.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Re: [dpdk-dev] [PATCH] net: announce changes in TCP header

[Thomas Monjalon]

Nobody rejected this change but there is not enough ack
to make it an accepted announce of change.

02/08/2021 12:42, Gregory Etelson:
> Announce change to add a union that will provide byte and bitfield
> access to TCP flags.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
> +* net: structure ``rte_tcp_hdr`` will have a union that will provide
> +  byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.

Re: [dpdk-dev] [PATCH] net: announce changes in TCP header

[Andrew Rybchenko]

The patch lacks motivation. Why is the change required? Why is it useful?

On August 5, 2021 18:28:31 Thomas Monjalon <thomas@monjalon.net> wrote:

> Nobody rejected this change but there is not enough ack
> to make it an accepted announce of change.
>
> 02/08/2021 12:42, Gregory Etelson:
>> Announce change to add a union that will provide byte and bitfield
>> access to TCP flags.
>>
>> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
>> ---
>> +* net: structure ``rte_tcp_hdr`` will have a union that will provide
>> +  byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.

Re: [dpdk-dev] [PATCH] net: announce changes in TCP header

[Gregory Etelson]

Hello,

The TCP flags bitfield patch complements similar changes
proposed to IPv4 header in  net: announce changes in IPv4 header - Patchwork (dpdk.org)<https://patchwork.dpdk.org/project/dpdk/patch/20210802103834.14263-1-getelson@nvidia.com/>

Regards,
Gregory

From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Sent: Friday, August 6, 2021 12:03
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org; Matan Azrad <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>; Ray Kinsella <mdr@ashroe.eu>; ajit.khaparde@broadcom.com; jerinj@marvell.com; akhil.goyal@nxp.com; cristian.dumitrescu@intel.com; ferruh.yigit@intel.com; konstantin.ananyev@intel.com; olivier.matz@6wind.com; maxime.coquelin@redhat.com; david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] net: announce changes in TCP header

External email: Use caution opening links or attachments

The patch lacks motivation. Why is the change required? Why is it useful?

On August 5, 2021 18:28:31 Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>> wrote:

Nobody rejected this change but there is not enough ack
to make it an accepted announce of change.

02/08/2021 12:42, Gregory Etelson:
Announce change to add a union that will provide byte and bitfield
access to TCP flags.

Signed-off-by: Gregory Etelson <getelson@nvidia.com<mailto:getelson@nvidia.com>>
---
+* net: structure ``rte_tcp_hdr`` will have a union that will provide
+  byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.

Re: [dpdk-dev] [PATCH] net: announce changes in TCP header

[Stephen Hemminger]

On Fri, 6 Aug 2021 13:56:56 +0000
Gregory Etelson <getelson@nvidia.com> wrote:

> Hello,
> 
> The TCP flags bitfield patch complements similar changes
> proposed to IPv4 header in  net: announce changes in IPv4 header - Patchwork (dpdk.org)<https://patchwork.dpdk.org/project/dpdk/patch/20210802103834.14263-1-getelson@nvidia.com/>
> 
> Regards,
> Gregory

This version of patch is being dropped because it didn't have sufficient number
of ack's for a new feature over a several year timeframe. If it is really useful
then resubmit along with an example of where it could be used in DPDK.