From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
Jack Bond-Preston <jack.bond-preston@foss.arm.com>,
Gavin Hu <gahu@nvidia.com>,
"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH] eal: silence -Wconstant-logical-operand in RTE_IS_POWER_OF_2
Date: Mon, 18 May 2026 10:10:22 -0700 [thread overview]
Message-ID: <20260518101022.7d665d83@phoenix.local> (raw)
In-Reply-To: <agtEqEv2fB7R7_Aa@bricha3-mobl1.ger.corp.intel.com>
On Mon, 18 May 2026 17:56:08 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> I'd also suggest changing the second part of the && to match, changing the
> "!" for explicit "== 0":
>
> #define RTE_IS_POWER_OF_2(n) ((n) != 0 && (((n) - 1) & (n)) == 0)
Was heading for the smallest possible part
next prev parent reply other threads:[~2026-05-18 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 16:33 [PATCH] eal: silence -Wconstant-logical-operand in RTE_IS_POWER_OF_2 Stephen Hemminger
2026-05-18 16:56 ` Bruce Richardson
2026-05-18 17:10 ` Stephen Hemminger [this message]
2026-05-19 9:26 ` Jack Bond-Preston
2026-05-19 13:49 ` [PATCH v2] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518101022.7d665d83@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gahu@nvidia.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jack.bond-preston@foss.arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox