* [V1 0/1] Add VXLAN TSO function
@ 2026-05-20 6:58 Feifei Wang
2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang
0 siblings, 1 reply; 3+ messages in thread
From: Feifei Wang @ 2026-05-20 6:58 UTC (permalink / raw)
To: dev
V0: The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function
V1: Add sign-off in the commit message
Feifei Wang (1):
net/hinic3: Add VXLAN TSO function
drivers/net/hinic3/hinic3_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.47.0.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [V1 1/1] net/hinic3: Add VXLAN TSO function
2026-05-20 6:58 [V1 0/1] Add VXLAN TSO function Feifei Wang
@ 2026-05-20 6:58 ` Feifei Wang
2026-05-20 15:06 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Feifei Wang @ 2026-05-20 6:58 UTC (permalink / raw)
To: dev; +Cc: Feifei Wang
The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function
Signed-off-by: Feifei Wang <wangfeifei40@huawei.com>
---
drivers/net/hinic3/hinic3_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hinic3/hinic3_ethdev.c b/drivers/net/hinic3/hinic3_ethdev.c
index f4eb788..fbadb1e 100644
--- a/drivers/net/hinic3/hinic3_ethdev.c
+++ b/drivers/net/hinic3/hinic3_ethdev.c
@@ -696,7 +696,7 @@ hinic3_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)
RTE_ETH_TX_OFFLOAD_VLAN_INSERT | RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
RTE_ETH_TX_OFFLOAD_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
- RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
+ RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_MULTI_SEGS;
if (nic_dev->feature_cap & NIC_F_HTN_CMDQ)
hinic3_dev_tnl_tso_support(info, nic_dev);
--
2.47.0.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [V1 1/1] net/hinic3: Add VXLAN TSO function
2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang
@ 2026-05-20 15:06 ` Stephen Hemminger
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2026-05-20 15:06 UTC (permalink / raw)
To: Feifei Wang; +Cc: dev, Feifei Wang
On Wed, 20 May 2026 14:58:15 +0800
Feifei Wang <wff_light@vip.163.com> wrote:
> The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the VXLAN TSO function
>
> Signed-off-by: Feifei Wang <wangfeifei40@huawei.com>
> ---
You need to do more than just advertise the capability to get the driver
to actually work right.
AI explanation:
Error: VXLAN TSO is advertised unconditionally but the underlying hardware
feature is not. The patch adds RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO to the
unconditional tx_offload_capa assignment in hinic3_dev_infos_get(), but
the Tx path in drivers/net/hinic3/hinic3_tx.c:306-313 rejects every VXLAN
tunnel mbuf when the hardware does not have NIC_F_VXLAN_OFFLOAD:
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-20 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-20 6:58 [V1 0/1] Add VXLAN TSO function Feifei Wang
2026-05-20 6:58 ` [V1 1/1] net/hinic3: " Feifei Wang
2026-05-20 15:06 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox