From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "fengchengwen" <fengchengwen@huawei.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
<thomas@monjalon.net>, <dev@dpdk.org>,
<andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v2 2/2] ethdev: add telemetry endpoint for list names
Date: Thu, 21 May 2026 07:37:16 -0700 [thread overview]
Message-ID: <20260521073716.3a788175@phoenix.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35F6588F@smartserver.smartshare.dk>
On Thu, 21 May 2026 14:40:47 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> > From: fengchengwen [mailto:fengchengwen@huawei.com]
> > Sent: Thursday, 21 May 2026 14.25
> >
> > Thanks for the feedback.
> >
> > I intend to keep the current dict format. This concise ID-name mapping
> > is quite
> > helpful and easy to read especially when there are massive ports, which
> > is exactly
> > the main purpose why I submitted this patch.
> >
> > In my opinion, adopting OData-style query would require architecture-
> > level
> > refactoring of telemetry framework, which is way too heavy for this
> > simple requirement.
>
> Agree.
> Refactoring the telemetry framework is different task, not related to this patch.
>
> > For complex query demands, we can implement them by extending the
> > upper-layer Python
> > telemetry script instead.
> >
> > So I suggest we keep this simple form here.
>
> If it is generally acceptable for DPDK telemetry that a request for a list does not return a list type, but returns an object type with "index": "value" fields instead, then
> Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
It is necessary since port list may have holes due to hotplug or the ownership API.
It would be good to have a more complete query function that returns more about each ethdev.
I wouldn't worry about the size of the response. This is JSON and it is meant to be read by scripts not directly by humans.
next prev parent reply other threads:[~2026-05-21 14:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 3:56 [PATCH 0/2] enhance telemetry list endpoint with device name Chengwen Feng
2026-05-20 3:56 ` [PATCH 1/2] dmadev: include device name in telemetry list output Chengwen Feng
2026-05-20 15:03 ` Stephen Hemminger
2026-05-20 3:56 ` [PATCH 2/2] ethdev: " Chengwen Feng
2026-05-20 5:40 ` [PATCH 0/2] enhance telemetry list endpoint with device name Morten Brørup
2026-05-20 7:31 ` fengchengwen
2026-05-20 7:49 ` Bruce Richardson
2026-05-20 14:54 ` Stephen Hemminger
2026-05-20 9:38 ` [PATCH v2 0/2] Add list names telemetry endpoint Chengwen Feng
2026-05-20 9:38 ` [PATCH v2 1/2] dmadev: add telemetry endpoint for list names Chengwen Feng
2026-05-20 9:38 ` [PATCH v2 2/2] ethdev: " Chengwen Feng
2026-05-20 13:29 ` Morten Brørup
2026-05-20 14:58 ` Bruce Richardson
2026-05-21 12:24 ` fengchengwen
2026-05-21 12:40 ` Morten Brørup
2026-05-21 14:37 ` Stephen Hemminger [this message]
2026-05-21 15:21 ` Bruce Richardson
2026-05-21 15:44 ` Bruce Richardson
2026-05-22 0:42 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521073716.3a788175@phoenix.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox