From: "Morten Brørup" <mb@smartsharesystems.com>
To: dev@dpdk.org, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Bruce Richardson <bruce.richardson@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Praveen Shetty <praveen.shetty@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>
Subject: [PATCH v7] mempool/dpaa2: update for new mempool cache algorithm
Date: Mon, 1 Jun 2026 18:36:21 +0000 [thread overview]
Message-ID: <20260601183621.252920-3-mb@smartsharesystems.com> (raw)
In-Reply-To: <20260601183621.252920-1-mb@smartsharesystems.com>
As a consequence of the improved mempool cache algorithm, the mempool
driver was updated to not modify the mempool cache's flushthresh field,
which is now obsolete, and modifying it has no effect.
Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
---
v7:
* Rebased.
v6:
* Moved driver changes out as separate patches, for easier review. (Bruce)
---
Depends-on: patch-164745 ("mempool: improve cache behaviour and performance")
---
drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
index 02b6741853..ee001d8ce0 100644
--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
@@ -54,8 +54,6 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp)
struct dpaa2_bp_info *bp_info;
struct dpbp_attr dpbp_attr;
uint32_t bpid;
- unsigned int lcore_id;
- struct rte_mempool_cache *cache;
int ret;
avail_dpbp = dpaa2_alloc_dpbp_dev();
@@ -152,18 +150,6 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp)
DPAA2_MEMPOOL_DEBUG("BP List created for bpid =%d", dpbp_attr.bpid);
h_bp_list = bp_list;
- /* Update per core mempool cache threshold to optimal value which is
- * number of buffers that can be released to HW buffer pool in
- * a single API call.
- */
- for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
- cache = &mp->local_cache[lcore_id];
- DPAA2_MEMPOOL_DEBUG("lCore %d: cache->flushthresh %d -> %d",
- lcore_id, cache->flushthresh,
- (uint32_t)(cache->size + DPAA2_MBUF_MAX_ACQ_REL));
- if (cache->flushthresh)
- cache->flushthresh = cache->size + DPAA2_MBUF_MAX_ACQ_REL;
- }
return 0;
err4:
--
2.43.0
next prev parent reply other threads:[~2026-06-01 18:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 14:13 [PATCH] mempool: improve cache behaviour and performance Morten Brørup
2026-04-08 15:41 ` Stephen Hemminger
2026-04-09 10:25 ` [PATCH v2] " Morten Brørup
2026-04-09 11:05 ` [PATCH v3] " Morten Brørup
2026-04-15 13:40 ` Morten Brørup
2026-04-18 11:15 ` [PATCH v4] " Morten Brørup
2026-04-19 9:55 ` [PATCH v5] " Morten Brørup
2026-04-22 12:27 ` Morten Brørup
2026-04-27 15:21 ` Morten Brørup
2026-04-28 7:44 ` Andrew Rybchenko
2026-05-22 16:11 ` Bruce Richardson
2026-05-26 8:41 ` Morten Brørup
2026-05-26 9:39 ` Bruce Richardson
2026-05-26 10:37 ` Morten Brørup
2026-05-26 17:45 ` Morten Brørup
2026-05-27 8:48 ` Bruce Richardson
2026-05-27 9:22 ` Morten Brørup
2026-05-22 16:12 ` Bruce Richardson
2026-05-26 8:57 ` Morten Brørup
2026-05-26 14:00 ` [PATCH v6] " Morten Brørup
2026-05-26 16:00 ` Morten Brørup
2026-06-01 13:36 ` Thomas Monjalon
2026-06-01 13:51 ` Morten Brørup
2026-06-01 14:19 ` Thomas Monjalon
2026-06-01 14:27 ` Morten Brørup
2026-05-29 8:53 ` fengchengwen
2026-05-29 11:43 ` Morten Brørup
2026-05-27 11:36 ` [PATCH v6] net/idpf: update for new mempool cache algorithm Morten Brørup
2026-05-27 11:36 ` [PATCH v6] mempool/dpaa: " Morten Brørup
2026-05-27 11:36 ` [PATCH v6] mempool/dpaa2: " Morten Brørup
2026-06-01 16:40 ` [PATCH v7] mempool: improve cache behaviour and performance Morten Brørup
2026-06-03 15:44 ` Thomas Monjalon
2026-06-01 18:36 ` [PATCH v7] net/idpf: update for new mempool cache algorithm Morten Brørup
2026-06-01 18:36 ` [PATCH v7] mempool/dpaa: " Morten Brørup
2026-06-02 6:51 ` Morten Brørup
2026-06-01 18:36 ` Morten Brørup [this message]
2026-06-02 6:53 ` [PATCH v7] mempool/dpaa2: " Morten Brørup
2026-06-02 6:45 ` [PATCH v7] net/idpf: " Morten Brørup
2026-06-10 11:21 ` Morten Brørup
2026-06-10 11:31 ` Bruce Richardson
2026-06-10 12:17 ` Thomas Monjalon
2026-06-10 12:34 ` Bruce Richardson
2026-06-10 11:31 ` Morten Brørup
2026-06-04 11:48 ` [PATCH v8] mempool: improve cache behaviour and performance Morten Brørup
2026-06-04 13:57 ` Morten Brørup
2026-06-10 11:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601183621.252920-3-mb@smartsharesystems.com \
--to=mb@smartsharesystems.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jingjing.wu@intel.com \
--cc=praveen.shetty@intel.com \
--cc=sachin.saxena@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox