* [PATCH] app/testpmd: include IP fields in UDP RSS option
@ 2026-06-16 9:39 Maxime Leroy
2026-06-17 21:12 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Maxime Leroy @ 2026-06-16 9:39 UTC (permalink / raw)
To: dev
Cc: Maxime Leroy, stable, Aman Singh, Heqing Zhu, Jijiang Liu,
Helin Zhang, Cunming Liang, Jing Chen
The --rss-udp option is documented as enabling IPv4/IPv6 + UDP RSS, but it
currently sets the RSS hash functions to RTE_ETH_RSS_UDP only.
On PMDs that translate this directly to L4 port extracts, this can build a
L4-only RSS key. Add RTE_ETH_RSS_IP when --rss-udp is selected so the
configured key matches the documented IPv4/IPv6 + UDP behavior.
Make --rss-ip additive as well, so combining --rss-ip and --rss-udp is
order-independent.
Fixes: 8a387fa85f02 ("ethdev: more RSS flags")
Cc: stable@dpdk.org
Signed-off-by: Maxime Leroy <maxime@leroys.fr>
---
app/test-pmd/parameters.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 337d8fc8ac..0032ea4e25 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -1286,10 +1286,10 @@ launch_args_parse(int argc, char** argv)
set_pkt_forwarding_mode(optarg);
break;
case TESTPMD_OPT_RSS_IP_NUM:
- rss_hf = RTE_ETH_RSS_IP;
+ rss_hf |= RTE_ETH_RSS_IP;
break;
case TESTPMD_OPT_RSS_UDP_NUM:
- rss_hf = RTE_ETH_RSS_UDP;
+ rss_hf |= RTE_ETH_RSS_IP | RTE_ETH_RSS_UDP;
break;
case TESTPMD_OPT_RSS_LEVEL_INNER_NUM:
rss_hf |= RTE_ETH_RSS_LEVEL_INNERMOST;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] app/testpmd: include IP fields in UDP RSS option
2026-06-16 9:39 [PATCH] app/testpmd: include IP fields in UDP RSS option Maxime Leroy
@ 2026-06-17 21:12 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2026-06-17 21:12 UTC (permalink / raw)
To: Maxime Leroy
Cc: dev, stable, Aman Singh, Heqing Zhu, Jijiang Liu, Helin Zhang,
Cunming Liang, Jing Chen
On Tue, 16 Jun 2026 11:39:12 +0200
Maxime Leroy <maxime@leroys.fr> wrote:
> The --rss-udp option is documented as enabling IPv4/IPv6 + UDP RSS, but it
> currently sets the RSS hash functions to RTE_ETH_RSS_UDP only.
>
> On PMDs that translate this directly to L4 port extracts, this can build a
> L4-only RSS key. Add RTE_ETH_RSS_IP when --rss-udp is selected so the
> configured key matches the documented IPv4/IPv6 + UDP behavior.
>
> Make --rss-ip additive as well, so combining --rss-ip and --rss-udp is
> order-independent.
>
> Fixes: 8a387fa85f02 ("ethdev: more RSS flags")
> Cc: stable@dpdk.org
> Signed-off-by: Maxime Leroy <maxime@leroys.fr>
> ---
Applied to next-net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-17 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-16 9:39 [PATCH] app/testpmd: include IP fields in UDP RSS option Maxime Leroy
2026-06-17 21:12 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox