From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "Thomas Monjalon" <thomas@monjalon.net>,
"Huisong Li" <lihuisong@huawei.com>,
<andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org>,
<zhanjie9@hisilicon.com>
Subject: Re: [PATCH v1 0/5] prefix lcore role enum values
Date: Fri, 19 Jun 2026 08:39:34 -0700 [thread overview]
Message-ID: <20260619083934.510bd2d4@phoenix.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35F65929@smartserver.smartshare.dk>
On Fri, 19 Jun 2026 09:54:51 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> > > The problem with this patch it causes build failures now with abi
> > diff.
> >
> > It is probably a bug of an old version of abidiff.
> > I recommend updating.
>
> With the #define's the ABI has not changed. It's probably too indirect for abidiff to understand.
> If we absolutely want to please abidiff, we could keep the existing enums and #define RTE_LCORE_ROLE_RTE ROLE_RTE for now.
> But I'm in favor of what was done already.
The build failures on github, not in my local builds.
https://github.com/ovsrobot/dpdk/actions/runs/27789889172/job/82235965090
It makes looking at patchwork dashboard difficult, all patches show up with red mark
next prev parent reply other threads:[~2026-06-19 15:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 10:28 [PATCH v1 0/5] prefix lcore role enum values Huisong Li
2026-06-17 10:28 ` [PATCH v1 1/5] eal: " Huisong Li
2026-06-17 10:28 ` [PATCH v1 2/5] eal: use new lcore role enum names Huisong Li
2026-06-17 10:28 ` [PATCH v1 3/5] graph: " Huisong Li
2026-06-17 10:28 ` [PATCH v1 4/5] net/softnic: " Huisong Li
2026-06-17 10:28 ` [PATCH v1 5/5] test: " Huisong Li
2026-06-17 11:48 ` [PATCH v1 0/5] prefix lcore role enum values Morten Brørup
2026-06-18 16:19 ` Thomas Monjalon
2026-06-18 18:52 ` Morten Brørup
2026-06-19 2:03 ` Stephen Hemminger
2026-06-19 7:28 ` Thomas Monjalon
2026-06-19 7:54 ` Morten Brørup
2026-06-19 15:39 ` Stephen Hemminger [this message]
2026-06-19 20:11 ` Morten Brørup
2026-06-20 16:42 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619083934.510bd2d4@phoenix.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=lihuisong@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox