From: Stephen Hemminger <stephen@networkplumber.org>
To: Dawid Wesierski <dawid.wesierski@intel.com>
Cc: dev@dpdk.org, marek.kasiewicz@intel.com, thomas@monjalon.net,
mb@smartsharesystems.com
Subject: Re: [v5] pcapng: add user-supplied timestamp support
Date: Fri, 26 Jun 2026 08:04:00 -0700 [thread overview]
Message-ID: <20260626080400.42180308@phoenix.local> (raw)
In-Reply-To: <20260626102213.776257-1-dawid.wesierski@intel.com>
On Fri, 26 Jun 2026 06:22:04 -0400
Dawid Wesierski <dawid.wesierski@intel.com> wrote:
> Thanks again for the review,
>
> For v6 I have added the input validation we ccheck if the timestamp
> PCAPNG_TSC_FLAG is not set on caller-provided input.
>
> Regarding API versioning my concern is around source-level compatibility.
> Any application that calls rte_pcapng_copy() would need to be updated to
> pass the additional timestamp argument right?
>
> Is breaking source-level compatibility for existing callers of
> rte_pcapng_copy() acceptable here?
DPDK does not guarantee API compatibility across releases; only ABI.
As long as there is a release note this is fine.
At this point, might have to wait for 26.11 release anyway.
Also, this is not an API that is commonly used by applications.
prev parent reply other threads:[~2026-06-26 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 14:38 [PATCH v3 1/1] pcapng: add user-supplied timestamp support Dawid Wesierski
2026-06-18 15:22 ` Stephen Hemminger
2026-06-18 16:45 ` Morten Brørup
2026-06-18 18:51 ` Stephen Hemminger
2026-06-23 14:10 ` [PATCH v4] " Dawid Wesierski
2026-06-23 13:53 ` Stephen Hemminger
2026-06-24 21:57 ` [PATCH v5] " Dawid Wesierski
2026-06-24 22:07 ` Stephen Hemminger
2026-06-24 22:17 ` Stephen Hemminger
2026-06-26 10:22 ` [v5] " Dawid Wesierski
2026-06-26 15:04 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260626080400.42180308@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dawid.wesierski@intel.com \
--cc=dev@dpdk.org \
--cc=marek.kasiewicz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox