[PATCH] net/bonding: fix the log MAC address restore failure

[PATCH] net/bonding: fix the log MAC address restore failure

[Evgeny Sokolov]

Log an error when rte_eth_dev_default_mac_addr_set() fails while
restoring the default MAC address of a member device removed from a
bonding device.
This improves visibility of failures without changing the existing
behavior.

Fixes: aa7791ba8de0 ("net/bonding: fix setting slave MAC addresses")
Cc: chas3@att.com

Signed-off-by: Evgeny Sokolov <Evgeny.Sokolov@infotecs.ru>
Cc: stable@dpdk.org
---
 .mailmap                               | 1 +
 drivers/net/bonding/rte_eth_bond_api.c | 8 ++++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/.mailmap b/.mailmap
index 8e1153ce58..ddbaaf744f 100644
--- a/.mailmap
+++ b/.mailmap
@@ -461,6 +461,7 @@ Evan Swanson <evan.swanson@intel.com>
 Evgeny Efimov <evgeny.efimov@intel.com>
 Evgeny Im <evgeny.im@oktetlabs.com>
 Evgeny Schemeilin <evgenys@amazon.com>
+Evgeny Sokolov <Evgeny.Sokolov@infotecs.ru>
 Fabio Pricoco <fabio.pricoco@intel.com>
 Fady Bader <fady@mellanox.com>
 Faicker Mo <faicker.mo@ucloud.cn>
diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
index 9e5df67c18..da2b538b3c 100644
--- a/drivers/net/bonding/rte_eth_bond_api.c
+++ b/drivers/net/bonding/rte_eth_bond_api.c
@@ -706,8 +706,12 @@ __eth_bond_member_remove_lock_free(uint16_t bonding_port_id,
 			&rte_eth_devices[bonding_port_id].data->port_id);
 
 	/* Restore original MAC address of member device */
-	rte_eth_dev_default_mac_addr_set(member_port_id,
-			&internals->members[member_idx].persisted_mac_addr);
+	if (rte_eth_dev_default_mac_addr_set(member_port_id,
+			&internals->members[member_idx].persisted_mac_addr)) {
+		RTE_BOND_LOG(ERR,
+				"Failed to restore MAC address on member port %u",
+				member_port_id);
+	}
 
 	/* remove additional MAC addresses from the member */
 	member_remove_mac_addresses(bonding_eth_dev, member_port_id);
-- 
2.47.3

RE: [PATCH] net/bonding: fix the log MAC address restore failure

[Sokolov Evgeny]

Kindly reminder
Sorry, But nobody has reviewed my patch
Could you please review this?

-----Original Message-----
From: Sokolov Evgeny <Evgeny.Sokolov@infotecs.ru> 
Sent: Monday, June 29, 2026 4:59 PM
To: Thomas Monjalon <thomas@monjalon.net>; Chas Williams <3chas3@gmail.com>; Min Hu (Connor) <humin29@huawei.com>; Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org; stable@dpdk.org; chas3@att.com; Sokolov Evgeny <Evgeny.Sokolov@infotecs.ru>
Subject: [PATCH] net/bonding: fix the log MAC address restore failure

Log an error when rte_eth_dev_default_mac_addr_set() fails while restoring the default MAC address of a member device removed from a bonding device.
This improves visibility of failures without changing the existing behavior.

Fixes: aa7791ba8de0 ("net/bonding: fix setting slave MAC addresses")
Cc: chas3@att.com

Signed-off-by: Evgeny Sokolov <Evgeny.Sokolov@infotecs.ru>
Cc: stable@dpdk.org
---
 .mailmap                               | 1 +
 drivers/net/bonding/rte_eth_bond_api.c | 8 ++++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/.mailmap b/.mailmap
index 8e1153ce58..ddbaaf744f 100644
--- a/.mailmap
+++ b/.mailmap
@@ -461,6 +461,7 @@ Evan Swanson <evan.swanson@intel.com>  Evgeny Efimov <evgeny.efimov@intel.com>  Evgeny Im <evgeny.im@oktetlabs.com>  Evgeny Schemeilin <evgenys@amazon.com>
+Evgeny Sokolov <Evgeny.Sokolov@infotecs.ru>
 Fabio Pricoco <fabio.pricoco@intel.com>  Fady Bader <fady@mellanox.com>  Faicker Mo <faicker.mo@ucloud.cn> diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
index 9e5df67c18..da2b538b3c 100644
--- a/drivers/net/bonding/rte_eth_bond_api.c
+++ b/drivers/net/bonding/rte_eth_bond_api.c
@@ -706,8 +706,12 @@ __eth_bond_member_remove_lock_free(uint16_t bonding_port_id,
 			&rte_eth_devices[bonding_port_id].data->port_id);
 
 	/* Restore original MAC address of member device */
-	rte_eth_dev_default_mac_addr_set(member_port_id,
-			&internals->members[member_idx].persisted_mac_addr);
+	if (rte_eth_dev_default_mac_addr_set(member_port_id,
+			&internals->members[member_idx].persisted_mac_addr)) {
+		RTE_BOND_LOG(ERR,
+				"Failed to restore MAC address on member port %u",
+				member_port_id);
+	}
 
 	/* remove additional MAC addresses from the member */
 	member_remove_mac_addresses(bonding_eth_dev, member_port_id);
--
2.47.3

Re: [PATCH] net/bonding: fix the log MAC address restore failure

[Stephen Hemminger]

On Mon, 29 Jun 2026 13:58:40 +0000
Evgeny Sokolov <Evgeny.Sokolov@infotecs.ru> wrote:

> Log an error when rte_eth_dev_default_mac_addr_set() fails while
> restoring the default MAC address of a member device removed from a
> bonding device.
> This improves visibility of failures without changing the existing
> behavior.
> 
> Fixes: aa7791ba8de0 ("net/bonding: fix setting slave MAC addresses")
> Cc: chas3@att.com
> 
> Signed-off-by: Evgeny Sokolov <Evgeny.Sokolov@infotecs.ru>
> Cc: stable@dpdk.org
> ---

This patch is technically correct, and I have no issues with the code itself.

However, the submitter's mail domain (infotecs.ru) belongs to JSC
InfoTeCS, which is on the EU consolidated sanctions list. Whether a
contribution from a sanctioned entity can be accepted is a legal
question, and not one a maintainer has the authority to decide.

Holding off on merging this patch until there is direction from LF
legal and/or the DPDK governing board.