* [PATCH] net/mlx5: fix uint16 underflow on Rx queue error path
@ 2026-07-30 13:56 Maayan Kashani
0 siblings, 0 replies; only message in thread
From: Maayan Kashani @ 2026-07-30 13:56 UTC (permalink / raw)
To: dev
Cc: mkashani, rasland, stable, Dariusz Sosnowski,
Viacheslav Ovsiienko, Bing Zhao, Ori Kam, Suanming Mou,
Matan Azrad, Thomas Monjalon, Gregory Etelson
Avoid post-decrementing the segment index when it is zero in the
error cleanup path of mlx5_rxq_mempool_register().
Coverity issue: 503770
Fixes: 8d1cb02da5b7 ("net/mlx5: support selective Rx")
Cc: stable@dpdk.org
Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
---
drivers/net/mlx5/mlx5_trigger.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index c2804c58974..b6ce0133c93 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -187,10 +187,13 @@ mlx5_rxq_mempool_register(struct mlx5_rxq_ctrl *rxq_ctrl)
return 0;
error:
- while (s-- > 0) {
+ while (s > 0) {
+ s--;
seg = &rxq_ctrl->rxq.rxseg[s];
- mlx5_free(seg->null_mbuf);
- seg->null_mbuf = NULL;
+ if (!seg->mp) {
+ mlx5_free(seg->null_mbuf);
+ seg->null_mbuf = NULL;
+ }
}
return ret;
}
--
2.21.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-07-30 13:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-30 13:56 [PATCH] net/mlx5: fix uint16 underflow on Rx queue error path Maayan Kashani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox